~vcs-imports/xserver-xorg-video-intel/master : changes

~vcs-imports/xserver-xorg-video-intel/master » Changes from revision 8611

From Revision 8611 to 8592

Rev	Summary	Authors	Date
8611	sna: Shut up enum warns sna: Shut up enum warns The libdrm enum usage is a mess, and modern gcc is unhappy about the implicit conversions: ../src/sna/sna_present.c:229:26: warning: implicit conversion from ‘enum <anonymous>’ to ‘enum drm_vblank_seq_type’ [-Wenum-conversion] Just cast to an integer type to silence the warns. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>	Ville Syrjälä	1 year ago
8610	sna: Don't redefine NV12 stuff if already defined sna: Don't redefine NV12 stuff if already defined Modern server headers already define NV12 for us. Avoid the redefine. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>	Ville Syrjälä	1 year ago
8609	sna: Eliminate sna_mode_wants_tear_free() sna: Eliminate sna_mode_wants_tear_free() The modparam checks performed by sna_mode_wants_tear_free() don't generally work when the server is running as a regular user. Hence we can't rely on them to indicate whether FBC/PSR/etc is enabled. Also the "Panel Self-Refresh" connector property doesn't actually exist so we can nuke that part as well. Let's just nuke the whole thing and assume we want dirtyfb always when tearfree is not enabled. I'll anyway want to enable FBC by default across the board soonish so the check wouldn't really buy us much (would just exclude i830 and a few old desktop chipsets which don't have FBC hardware). Additionally if we don't have working dirtyfb we really should enable tearfree by default because otherwise we're going to get horrible lag due to missing frontbuffer flushes. Without WC mmaps we could in theory rely on the hw gtt tracking except the kernel no longer differentiates between GTT/WC/CPU access in its software frontbuffer tracking code so it'll just deactivate FBC even for a GTT mmap and potentially never re-enable it due to the missing frontbuffer flush from dirtyfb. So dirtyfb is always needed. v2: Rebase due to ppgtt->tear free logic Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>	Ville Syrjälä	1 year ago
8608	sna: Dump fences also on -ENOBUFS sna: Dump fences also on -ENOBUFS Since kernel commit 78d2ad7eb4e1 ("drm/i915/gt: Fix -EDEADLK handling regression") running out of fences will result in -ENOBUFS instead of -EDEADLK (the latter having been stolen by ww mutextes for their internal use). Adjust the fence dumping to expect either errno value. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>	Ville Syrjälä	1 year ago
8607	sna: Don't emit sse2 code where not wanted sna: Don't emit sse2 code where not wanted Fix the s/push_options/pop_options/ pragma so that we don't emit sse2 in the codepaths that run on non-sse2 machines as well. Seems gcc has become much more aggressive in its sse2 usage recently and I'm now hitting sse2 instructions in choose_memcpy_tiled_x() on my non-sse2 P3 machine. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>	Ville Syrjälä	1 year ago
8606	sna: Allow DRI3 on gen2/3 sna: Allow DRI3 on gen2/3 Once we have DRI3 in Mesa i915 driver we can allow DRI3 on gen2/3. But due to the supposed missing DRI2 fallback with older Mesa let's only do that if the user explicitly requests it. Note that when I tried this with modern Mesa that lacks i915 DRI3 support things seemed to fall back to DRI2 just fine, but better safe than sorry I guess. Cc: Chris Wilson <chris@chris-wilson.co.uk> References: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9734 Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>	Ville Syrjälä	1 year ago
8605	sna: Fix async flips sna: Fix async flips We need to wait for flip events even when doing async flips, otherwise the kernel will just hand us -EBUSY if we try to flip too fast. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>	Ville Syrjälä	1 year ago
8604	sna: Always validate userptr upon creation sna: Always validate userptr upon creation Since not all memory ranges can be mapped by userptr, in particular those passed by XShmAttachFD, we need to validate the userptr before use. We would ideally want to continue to lazily populate the pages as often the userptr is created but never used, but preventing an EFAULT later is more important. In https://patchwork.freedesktop.org/series/33449/ we provided a more efficient method for probing the userptr on construction while preserving the lazy population of gup-pages. For now, always follow userptr with set-domain. Reported-by: Jinoh Kang <jinoh.kang.kr@gmail.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>	Chris Wilson	3 years ago
8603	sna/gen7: Avoid clear-residuals overhead on all gen7 sna/gen7: Avoid clear-residuals overhead on all gen7 Since not just Haswell will enjoy clear-residuals, be very careful before using a potential context switch from DRI clients. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>	Chris Wilson	3 years ago
8602	sna: Enable TearFree by default on recent HW sna: Enable TearFree by default on recent HW When there is ample memory bandwidth and we are not fighting for global resources, enable TearFree by default. Avoiding tearing is much more pleasant (for direct rendering where the source itself is not being synchronized to vblank) at negligible power cost; just doubles the memory footprint of scanout. References: https://gitlab.freedesktop.org/drm/intel/-/issues/2799 References: https://gitlab.freedesktop.org/drm/intel/-/issues/2763 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>	Chris Wilson	3 years ago
8601	sna: Defer fbGetWindowPixmap() for sna_composite sna: Defer fbGetWindowPixmap() for sna_composite Mike Lothian ran into a surprising situation where compScreenUpdate was calling CompositePicture without a pixmap attached to the destination Window, and so we found ourselves chasing a NULL PixmapPtr. #1 to_sna_from_pixmap (pixmap=0x0) at sna.h:521 #2 sna_composite (op=<optimized out>, src=0x55b3346c1420, mask=0x0, dst=0x55b3346c1d50, src_x=<optimized out>, src_y=<optimized out>, mask_x=0, mask_y=0, dst_x=0, dst_y=0, width=3840, height=2160) at sna_composite.c:652 #3 0x000055b33202c208 in damageComposite (op=<optimized out>, pSrc=0x55b3346c1420, pMask=0x0, pDst=0x55b3346c1d50, xSrc=<optimized out>, ySrc=<optimized out>, xMask=0, yMask=0, xDst=0, yDst=0, width=3840, height=2160) at damage.c:513 #4 0x000055b33201820c in CompositePicture (op=<optimized out>, op@entry=1 '\001', pSrc=pSrc@entry=0x55b3346c1420, pMask=pMask@entry=0x0, pDst=pDst@entry=0x55b3346c1d50, xSrc=xSrc@entry=0, ySrc=ySrc@entry=0, xMask=0, yMask=0, xDst=0, yDst=0, width=3840, height=2160) at picture.c:1547 #5 0x000055b331fc85d3 in compWindowUpdateAutomatic ( pWin=pWin@entry=0x55b3343a6bc0) at compwindow.c:705 #6 0x000055b331fca029 in compPaintWindowToParent (pWin=pWin@entry=0x55b3343a6bc0) at compwindow.c:729 #7 0x000055b331fc9fbb in compPaintChildrenToWindow (pWin=0x55b333e77b50) at compwindow.c:744 #8 0x000055b331fca59f in compScreenUpdate (pClient=<optimized out>, closure=<optimized out>) at compalloc.c:57 #9 0x000055b331f3abf4 in ProcessWorkQueue () at dixutils.c:536 #10 0x000055b3320aaa51 in WaitForSomething (are_ready=<optimized out>) at WaitFor.c:192 #11 0x000055b331f361a9 in Dispatch () at dispatch.c:421 #12 0x000055b331f39cec in dix_main (argc=13, argv=0x7ffcf273f538, envp=<optimized out>) at main.c:276 #13 0x000055b331f247de in main (argc=<optimized out>, argv=<optimized out>, envp=<optimized out>) at stubmain.c:34 Fortuitously, that drawable was also fully clipped so that it took an early exit and so we can hide the segfault by delaying querying the pixmap until after the clip check. The ongoing mystery is how we ended up in that state in the first place. Closes: https://gitlab.freedesktop.org/xorg/driver/xf86-video-intel/-/issues/204 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>	Chris Wilson	3 years ago
8600	More ABI changes for ABI_VIDEODRV_VERSION 25.2 More ABI changes for ABI_VIDEODRV_VERSION 25.2 Descending down into the naming changes, onto the next struct in the chain. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>	Chris Wilson	3 years ago
8599	Track ABI changes for ABI_VIDEODRV_VERSION 25.2 Track ABI changes for ABI_VIDEODRV_VERSION 25.2 Several structs had fields renamed, and so we must update our usage. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>	Chris Wilson	3 years ago
8598	sna/gen7: Prefer blitter for plain copies on Haswell sna/gen7: Prefer blitter for plain copies on Haswell Since the clear-residuals security fix on gen7, context switches are very slow. If X is being used with DRI clients, those clients will typically be using the 3D engine for themselves and every frame presented will then be copied by X, causing at least a couple of context switches per frame. That greatly diminishes throughput, but if we prefer to use the blitter engine for X, we can mostly keep off the render engine avoiding the context thrash. Reported-by: Rafael Ristovski <rafael.ristovski@gmail.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>	Chris Wilson	3 years ago
8597	sna/video/overlay: Declare support for depth 8 and 30 sna/video/overlay: Declare support for depth 8 and 30 Add 8 and 30 to the list of supported screen depths. The colorkey massaging will be handled by the kernel so we don't have to worry about it unlike with the sprite colorkey uapi. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>	Ville Syrjälä	3 years ago
8596	sna: Avoid selecting gen9 backend for future gen sna: Avoid selecting gen9 backend for future gen Cannonlake, then Icelake introduce new instruction formats and state command, and require a new render backend to be written. Avoid selecting the gen9 backend as this will hang! Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1864 Fixes: 3d5a1238af6a ("sna: Restore blt fallback backend") Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>	Chris Wilson	3 years ago
8595	sna/dri2: Prevent copying stale buffers sna/dri2: Prevent copying stale buffers The back buffer of window/pixmap is invalidated by DRI2ScheduleSwap, and is not available until the client calls DRI2GetBuffers. If they try to use their old handles, they will only get stale data. Similarly if they ask us to DRI2CopyRegion before the GetBuffers has reallocated a new back buffer, that back buffer is stale. Since the back buffer is out-of-date [likely containing data from a couple of swaps ago], we should ignore the copy to avoid glitching [by hopefully having a less noticeable glitch!] It's not entirely clear what the client intended at this point... Closes: https://gitlab.freedesktop.org/xorg/driver/xf86-video-intel/-/issues/195 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>	Chris Wilson	3 years ago
8594	Add description for PCI-ID 0x3E98 Add description for PCI-ID 0x3E98 Closes: https://gitlab.freedesktop.org/xorg/driver/xf86-video-intel/-/issues/162 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>	Chris Wilson	4 years ago
8593	Sync i915_pciids upto 8717c6b7414f Sync i915_pciids upto 8717c6b7414f Import the kernel's i915_pciids.h, up to: commit 8717c6b7414ffb890672276dccc284c23078ac0e Author: Lee Shawn C <shawn.c.lee@intel.com> Date: Tue Dec 10 23:04:15 2019 +0800 drm/i915/cml: Separate U series pci id from origianl list. Signed-off-by: Liwei Song <liwei.song@windriver.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>	Liwei Song	4 years ago
8592	sna: Forcibly relinquish the GPU bo cache of a SHM pixmap on... sna: Forcibly relinquish the GPU bo cache of a SHM pixmap on flushing Before we indicate return control of the SHM Pixmap to the client (that is prior to the next XReply), we ensure that the original SHM buffer is uptodate with any changes made on the GPU. We must flush the GPU writes back to the CPU and so not allow ourselves to keep the dirty cache of the GPU bo. Closes: https://gitlab.freedesktop.org/xorg/driver/xf86-video-intel/-/issues/189 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Alexei Podtelezhnikov <apodtele@gmail.com> Tested-by: Alexei Podtelezhnikov <apodtele@gmail.com>	Chris Wilson	4 years ago

Older »