~wallyworld/juju-core/fast-lxc-everywhere : changes

~wallyworld/juju-core/fast-lxc-everywhere » Changes to .lbox.check from revision 2698

From Revision 2698

Rev	Summary	Authors	Date
1869	[r=rogpeppe] environs/storage, state/statecmd: reenable test... [r=rogpeppe] environs/storage, state/statecmd: reenable tests Also add a script to .lbox.check to make sure this doesn't happen again. https://codereview.appspot.com/13321052/	Roger Peppe	10 years ago
1820	[r=axwalk] Remove Logf from .lbox.check [r=axwalk] Remove Logf from .lbox.check There are two Logfs: one from loggo, and one from gocheck. They have different positions for their format parameter. https://codereview.appspot.com/13532047/	Andrew Wilkins	10 years ago
1812	[r=rogpeppe] lbox check always vets [r=rogpeppe] lbox check always vets Since we're now using go1.1, we can always use go vet. Also fix a couple of errors that this caught. Also fix the dependencies.tsv file, which hadn't been updated for a recent gwacl change. https://codereview.appspot.com/13648048/	Roger Peppe	10 years ago
1282	[r=jameinel],[bug=1190560] Ignore Emacs auto-save files in l... [r=jameinel],[bug=1190560] Ignore Emacs auto-save files in lbox pre-checks Emacs auto-save files are named '.#...', so if you have a storage.go file open, Emacs will keep a '.#storage.go' file around for auto-saving. However, the way we pass arguments to gofmt means that '.#' will not be properly escaped and gofmt will not be able to open the file, thus stopping an lbox propose. This change removes any filenames beginning with '.#' with a simple grep. https://codereview.appspot.com/10244044/	Danilo Šegan	10 years ago
1124	state: factor out allWatcher state: factor out allWatcher As suggested by dimiter. The functionality is more general than just watching everything, so names are changed accordingly. There are no significant logic changes in this branch. R=dimitern, TheMue CC= https://codereview.appspot.com/8458044	Roger Peppe	11 years ago
1111	.lbox: add a go build check to .lbox.check .lbox: add a go build check to .lbox.check R=fwereade CC= https://codereview.appspot.com/8366046	Dave Cheney	11 years ago
841	all: fix fmt mistakes all: fix fmt mistakes Also add a trailing "f" to some functions to make them amenable to go vet checking. R=niemeyer CC= https://codereview.appspot.com/7137048	Roger Peppe	11 years ago
717	Add CONTRIBUTING Add CONTRIBUTING R=fwereade, niemeyer, aram CC= https://codereview.appspot.com/6817113	Dave Cheney	11 years ago
538	.lbox: go vet on propose .lbox: go vet on propose Now lbox has the ability to do precommit hooks, we should do more of them. I've added a selective vet of the tree, with a few caviets. 1. 1.0.x vet sucks, so we skip the check unless you're using trunk 2. there is no way to identify go 1.1 version of vet, so we use 'devel' as the signal. Once go 1.1 is released, i'll update this check. R=niemeyer CC= https://codereview.appspot.com/6547044	Dave Cheney	11 years ago
495	build: add .lbox.check build: add .lbox.check This will check for formatting issues, both at proposal time and at submit time (on the merged branch). It requires an up-to-date lbox to work. R= CC= https://codereview.appspot.com/6503109	Gustavo Niemeyer	11 years ago