← Back to branch summary

~widelands-dev/widelands/bug-1654989-fuzzy-terrain-images

~widelands-dev/widelands/bug-1654989-fuzzy-terrain-images

« back to all changes in this revision

Viewing changes to cmake/codecheck/rules/contrived_access_to_last_element

Committer: qcs
Date: 2010-02-05 01:13:20 UTC
Revision ID: git-v1:136d6c48811c97ec1f98301726134b0de66f868c

Manual merge of cmake-migration branch to trunk

git-svn-id: https://widelands.svn.sourceforge.net/svnroot/widelands/trunk@5030 37b2a8de-5219-0410-9f54-a31bc463ab9c

files added:
CMakeLists.txt

cmake

cmake/Modules

cmake/Modules/FindSDL.cmake

cmake/Modules/FindSDL_gfx.cmake

cmake/Modules/Findintl.cmake

cmake/codecheck

cmake/codecheck/CodeCheck.py

cmake/codecheck/SConscript

cmake/codecheck/__init__.py

cmake/codecheck/rules

cmake/codecheck/rules/SDL_integer_types_in_non_SDL_dependent_code

cmake/codecheck/rules/assert0

cmake/codecheck/rules/const_qualifier_for_parameter_passed_by_value

cmake/codecheck/rules/const_std_string_by_value

cmake/codecheck/rules/const_without_effect_in_cast

cmake/codecheck/rules/contrived_access_to_last_element

cmake/codecheck/rules/contrived_dereference_and_member_selection

cmake/codecheck/rules/contrived_std_string_find

cmake/codecheck/rules/contrived_std_string_find_first_last_of

cmake/codecheck/rules/deprecated_c_header

cmake/codecheck/rules/explicit_compare_with_boolean_constant

cmake/codecheck/rules/explicit_this_dereference_and_component_selection

cmake/codecheck/rules/function_returning_constant_value

cmake/codecheck/rules/garbage_after_include

cmake/codecheck/rules/illegal_character_after_closing_brace

cmake/codecheck/rules/illegal_character_after_semicolon

cmake/codecheck/rules/illegal_character_before_opening_brace

cmake/codecheck/rules/illegal_space_after_opening_brace

cmake/codecheck/rules/illegal_space_after_opening_bracket

cmake/codecheck/rules/illegal_space_after_opening_parenthesis

cmake/codecheck/rules/illegal_space_before

cmake/codecheck/rules/illegal_token_after_closing_parenthesis_opened_on_earlier_line

cmake/codecheck/rules/leading_whitespace_check

cmake/codecheck/rules/line_starting_with_space_followed_by_control_structure

cmake/codecheck/rules/local_inlude_with_dir

cmake/codecheck/rules/long_line

cmake/codecheck/rules/loop_with_numerical_constant_condition

cmake/codecheck/rules/missing_newline_at_eof

cmake/codecheck/rules/missing_padding

cmake/codecheck/rules/missing_space_after_access_type_symbol

cmake/codecheck/rules/missing_space_after_comma

cmake/codecheck/rules/missing_space_after_control_structure_keyword

cmake/codecheck/rules/misused_tab

cmake/codecheck/rules/multiline_single-statement-controlling_control-statement_not_wrapped_before_controlled_statement

cmake/codecheck/rules/old-style_cast

cmake/codecheck/rules/parenthesis_not_closed_before_end_of_line

cmake/codecheck/rules/snprintf_with_literal_length

cmake/codecheck/rules/space_as_indentation

cmake/codecheck/rules/std_string_replace_replaces_single_character

cmake/codecheck/rules/std_string_substr_compare

cmake/codecheck/rules/testing_not_size

cmake/codecheck/rules/trailing_whitespace

cmake/codecheck/rules/upcast_without_macro

cmake/codecheck/rules/using_macro_TRUE_FALSE

cmake/codecheck/rules/void_parameter_list

cmake/codecheck/run_tests.py

doc/Doxyfile.in

pics/CMakeLists.txt

src/CMakeLists.txt

src/ai/CMakeLists.txt

src/build_info.cc.cmake

src/config.h.cmake

src/economy/CMakeLists.txt

src/editor/CMakeLists.txt

src/editor/tools/CMakeLists.txt

src/editor/ui_menus/CMakeLists.txt

src/events/CMakeLists.txt

src/game_io/CMakeLists.txt

src/graphic/CMakeLists.txt

src/io/CMakeLists.txt

src/io/filesystem/CMakeLists.txt

src/logic/CMakeLists.txt

src/map_io/CMakeLists.txt

src/network/CMakeLists.txt

src/network/game_server/CMakeLists.txt

src/profile/CMakeLists.txt

src/scripting/CMakeLists.txt

src/sound/CMakeLists.txt

src/trigger/CMakeLists.txt

src/ui_basic/CMakeLists.txt

src/ui_fsmenu/CMakeLists.txt

src/wui/CMakeLists.txt

Show diffs side-by-side

added added

removed removed

cmake/codecheck/rules/contrived_access_to_last_element

1

#!/usr/bin/python

2

3

4

"""

5

This catches clumsy expressions like

6

some_container[some_container.size() - 1]

7

which should be written as

8

*some_container.rbegin()

9

"""

10

11

error_msg = "Simplify \"some_container[some_container.size() - 1];\" to \"*some_container.rbegin();\"."

12

13

regexp = r"""(.*) *\[ *\\1 *\. *size *\( *\) *- *1 *\]"""

14

15

forbidden = [

16

"some_container[some_container.size() - 1];"

17

]

18

19

allowed = [

20

"*some_container.rbegin();"

21

]

Older »