← Back to branch summary

~widelands-dev/widelands/bug-1803602-reveal-frisian-campaign

~widelands-dev/widelands/bug-1803602-reveal-frisian-campaign

« back to all changes in this revision

Viewing changes to cmake/codecheck/rules/loop_with_numerical_constant_condition

Committer: qcs
Date: 2010-02-05 01:13:20 UTC
Revision ID: git-v1:136d6c48811c97ec1f98301726134b0de66f868c

Manual merge of cmake-migration branch to trunk

git-svn-id: https://widelands.svn.sourceforge.net/svnroot/widelands/trunk@5030 37b2a8de-5219-0410-9f54-a31bc463ab9c

files added:
CMakeLists.txt

cmake

cmake/Modules

cmake/Modules/FindSDL.cmake

cmake/Modules/FindSDL_gfx.cmake

cmake/Modules/Findintl.cmake

cmake/codecheck

cmake/codecheck/CodeCheck.py

cmake/codecheck/SConscript

cmake/codecheck/__init__.py

cmake/codecheck/rules

cmake/codecheck/rules/SDL_integer_types_in_non_SDL_dependent_code

cmake/codecheck/rules/assert0

cmake/codecheck/rules/const_qualifier_for_parameter_passed_by_value

cmake/codecheck/rules/const_std_string_by_value

cmake/codecheck/rules/const_without_effect_in_cast

cmake/codecheck/rules/contrived_access_to_last_element

cmake/codecheck/rules/contrived_dereference_and_member_selection

cmake/codecheck/rules/contrived_std_string_find

cmake/codecheck/rules/contrived_std_string_find_first_last_of

cmake/codecheck/rules/deprecated_c_header

cmake/codecheck/rules/explicit_compare_with_boolean_constant

cmake/codecheck/rules/explicit_this_dereference_and_component_selection

cmake/codecheck/rules/function_returning_constant_value

cmake/codecheck/rules/garbage_after_include

cmake/codecheck/rules/illegal_character_after_closing_brace

cmake/codecheck/rules/illegal_character_after_semicolon

cmake/codecheck/rules/illegal_character_before_opening_brace

cmake/codecheck/rules/illegal_space_after_opening_brace

cmake/codecheck/rules/illegal_space_after_opening_bracket

cmake/codecheck/rules/illegal_space_after_opening_parenthesis

cmake/codecheck/rules/illegal_space_before

cmake/codecheck/rules/illegal_token_after_closing_parenthesis_opened_on_earlier_line

cmake/codecheck/rules/leading_whitespace_check

cmake/codecheck/rules/line_starting_with_space_followed_by_control_structure

cmake/codecheck/rules/local_inlude_with_dir

cmake/codecheck/rules/long_line

cmake/codecheck/rules/loop_with_numerical_constant_condition

cmake/codecheck/rules/missing_newline_at_eof

cmake/codecheck/rules/missing_padding

cmake/codecheck/rules/missing_space_after_access_type_symbol

cmake/codecheck/rules/missing_space_after_comma

cmake/codecheck/rules/missing_space_after_control_structure_keyword

cmake/codecheck/rules/misused_tab

cmake/codecheck/rules/multiline_single-statement-controlling_control-statement_not_wrapped_before_controlled_statement

cmake/codecheck/rules/old-style_cast

cmake/codecheck/rules/parenthesis_not_closed_before_end_of_line

cmake/codecheck/rules/snprintf_with_literal_length

cmake/codecheck/rules/space_as_indentation

cmake/codecheck/rules/std_string_replace_replaces_single_character

cmake/codecheck/rules/std_string_substr_compare

cmake/codecheck/rules/testing_not_size

cmake/codecheck/rules/trailing_whitespace

cmake/codecheck/rules/upcast_without_macro

cmake/codecheck/rules/using_macro_TRUE_FALSE

cmake/codecheck/rules/void_parameter_list

cmake/codecheck/run_tests.py

doc/Doxyfile.in

pics/CMakeLists.txt

src/CMakeLists.txt

src/ai/CMakeLists.txt

src/build_info.cc.cmake

src/config.h.cmake

src/economy/CMakeLists.txt

src/editor/CMakeLists.txt

src/editor/tools/CMakeLists.txt

src/editor/ui_menus/CMakeLists.txt

src/events/CMakeLists.txt

src/game_io/CMakeLists.txt

src/graphic/CMakeLists.txt

src/io/CMakeLists.txt

src/io/filesystem/CMakeLists.txt

src/logic/CMakeLists.txt

src/map_io/CMakeLists.txt

src/network/CMakeLists.txt

src/network/game_server/CMakeLists.txt

src/profile/CMakeLists.txt

src/scripting/CMakeLists.txt

src/sound/CMakeLists.txt

src/trigger/CMakeLists.txt

src/ui_basic/CMakeLists.txt

src/ui_fsmenu/CMakeLists.txt

src/wui/CMakeLists.txt

Show diffs side-by-side

added added

removed removed

cmake/codecheck/rules/loop_with_numerical_constant_condition

1

#!/usr/bin/python

2

3

4

"""

5

This catches a numerical constant used as a loop condition. Instead of while

6

(true) or while (1), one should write for (;;). But it avoids catching some

7

cases that are used in macro definitions (see

8

[http://vivekkutal.blogspot.com/2006/03/do-while0.html]):

9

#define macro(...) do {...} while (false)

10

"""

11

12

error_msg="Do not use numerical constants in loop condition!"

13

14

regexp =r"""(^.?|[^}].|.[^ ])while *\((true|false|(0x[[:xdigit:]]+|[[:digit:]]+)[Uu]?(L|l|LL|ll)?|[[:digit:]]*\.[[:digit:]]+[Ll]?)\)"""

15

16

forbidden = [

17

'while (false)',

18

'while (true)',

19

'while (0)',

20

'while (1)',

21

'while (00)',

22

'while (0U)',

23

'while (0u)',

24

'while (0UL)',

25

'while (0uL)',

26

'while (0Ul)',

27

'while (0ul)',

28

'while (0ULL)',

29

'while (0uLL)',

30

'while (0Ull)',

31

'while (0ull)',

32

'while (01)',

33

'while (1U)',

34

'while (1u)',

35

'while (1UL)',

36

'while (1uL)',

37

'while (1Ul)',

38

'while (1ul)',

39

'while (1ULL)',

40

'while (1uLL)',

41

'while (1Ull)',

42

'while (1ull)',

43

'while (01.1)',

44

'while (.1)',

45

'while (.1L)',

46

'while (.1l)',

47

'while (.0)',

48

'while (.0L)',

49

'while (.0l)',

50

'while (1.01)',

51

'while (1.01L)',

52

'while (1.01l)',

53

'while (0xf)',

54

'while (0x9d)',

55

' while (0x9d)',

56

' while (0x9d)',

57

]

58

59

allowed = [

60

'for (;;)',

61

'while (a)',

62

'while (1 + b)',

63

'} while (false)',

64

]

Older »