1
2008-02-15 Werner Koch <wk@g10code.com>
5
2008-02-14 Werner Koch <wk@g10code.com>
7
* configure.ac: Check for -Wno-pointer-sign.
9
* pinentry/pinentry.c (cmd_getinfo): New.
10
(register_commands): Register it.
12
2008-01-02 Marcus Brinkmann <marcus@g10code.de>
14
* configure.ac: Use PKG_CONFIG instead of PKGCONFIG and
15
pkg-config. Use AC_PATH_PROG instead of AC_CHECK_PROG.
17
* Makefile.am (install-exec-local): Add exe extension to link.
19
2007-11-29 Marcus Brinkmann <marcus@g10code.de>
23
2007-11-19 Werner Koch <wk@g10code.com>
25
* doc/pinentry.texi (Protocol): Typo fixes by Bernhard Herzog.
26
Describe SETQUALITYBAR_TT.
28
2007-11-19 Bernhard Herzog <bernhard.herzog@intevation.de> (wk)
30
* qt/pinentrydialog.cpp (PinEntryDialog): Fixed crash
32
2007-11-19 Werner Koch <wk@g10code.com>
34
* gtk+-2/pinentry-gtk-2.c (create_window): Use again map-event and
35
unmap-event as this works on my setup far more reliable than
36
expose-event/no-expose-event.
38
* gtk+-2/gtksecentry.c (get_cursor_time): s/time/blinktime/ t
39
avoid shadowing warning.
41
* pinentry/pinentry.h (struct pinentry): Change QUALITY_BAR to a
43
(struct pinentry): Add QUALITY_BAR_TT.
44
* pinentry/pinentry.c (cmd_setqualitybar): Allow to set a label text.
45
(cmd_setqualitybar_tt): New.
46
* gtk+-2/pinentry-gtk-2.c (create_window): Take label and tooltip
48
* qt/pinentrydialog.h (setQualityBar, setQualityBarTT)
49
(_quality_bar_label): New.
50
* qt/pinentrydialog.cpp (setQualityBar, setQualityBarTT): New.
51
(PinEntryDialog): Remove setting of tooltip.
53
* qt/main.cpp (qt_cmd_handler): Propagate quality bar label and tootip.
55
2007-11-19 Bernhard Herzog <bernhard.herzog@intevation.de> (wk)
57
* qt/pinentrydialog.cpp (PinEntryDialog): Move the quality bar
58
below the text entry and align them properly. Show a tooltip.
59
* gtk+-2/pinentry-gtk-2.c (create_window): Ditto. Don't let it
61
(QUALITYBAR_EMPTY_TEXT): New.
63
2007-09-18 Werner Koch <wk@g10code.com>
65
* qt/secqlineedit.h (SecQLineEdit): New signal textModified.
66
* qt/secqlineedit.cpp (finishChange): Emit it.
67
* qt/pinentrydialog.cpp (setPinentryInfo): New.
68
(PinEntryDialog): Add arg ENABLE_QUALITY_BAR.
69
* qt/pinentrydialog.h (setPinentryInfo): New.
70
(PinEntryDialog): Add arg ENABLE_QUALITY_BAR.
72
* pinentry/pinentry.h (struct pinentry): Add member QUALITY_BAR
74
* pinentry/pinentry.c (cmd_setqualitybar): New.
75
(copy_and_escape): New.
76
(pinentry_inq_quality): New.
78
2007-07-09 Werner Koch <wk@g10code.com>
80
* doc/pinentry.texi: Fixed direntry syntax.
82
* configure.ac: Add --without-libcap. From the Gentoo patch archive.
84
* gtk+-2/pinentry-gtk-2.c (create_window): Use expose-event
85
instead of map-event. From Alon Bar-Lev.
87
2007-07-06 Werner Koch <wk@g10code.com>
91
* config.sub, config.guess: Updated from current Savannah CVS.
93
2007-06-27 Werner Koch <wk@g10code.com>
95
* w32/main.c: Revamped the SetFocus stuff. It is all not that easy.
97
2007-06-26 Werner Koch <wk@g10code.com>
99
* w32/Makefile.am (pinentry_w32_LDFLAGS): Add -mconsole again.
101
* w32/main.c (dlg_proc): Set focus.
102
(resize_button): New. No code yet.
103
(dlg_proc): Call it for the buttons.
104
(w32_cmd_handler): Restore old foreground window.
106
2007-06-20 Werner Koch <wk@g10code.com>
108
* w32/Makefile.am (pinentry_w32_LDFLAGS): Remove -mconsole.
110
* w32/main.c (wchar_to_utf8): New.
111
(ok_button_clicked): Use it.
112
(utf8_to_wchar): New.
113
(set_dlg_item_text): New.
114
(dlg_proc): Use new function so that we are able to correctly
116
(main): Load LockSetForegroundWindow.
117
(dlg_proc): Call LockSetForegroundWindow via its fnc ptr.
118
(center_window): New. Taken from GPGol.
120
(w32_cmd_handler): Revamped the confirm mode.
122
2007-06-18 Werner Koch <wk@g10code.com>
124
* w32/main.c (dlg_proc): Call LockSetForegroundWindow.
126
* Makefile.am (signed-dist, %.sig): Remove.
128
* autogen.sh: Modernized.
130
2007-05-10 Marcus Brinkmann <marcus@g10code.de>
132
* pinentry/pinentry.h (pinentry_color_t): New type.
133
(struct pinentry): New members COLOR_FG, COLOR_FG_BRIGHT,
135
* pinentry/pinentry.c (pinentry_parse_opts): Support new option --colors.
136
(parse_color): New function.
137
* pinentry/pinentry-curses.c (USE_COLORS): New macro.
138
(pinentry_color): New static variable.
139
(dialog_create): Redo color management.
141
* pinentry/pinentry-curses.c (dialog_create): Re-add calculation
142
of cancel button position. Adjust calculation of OK button
143
position if it is the only one used.
145
2007-04-13 Marcus Brinkmann <marcus@g10code.de>
147
* qt/secqlineedit.h (SecQLineEdit::contextMenuEvent,
148
SecQLineEdit::createPopupMenu): Remove prototype.
149
* qt/secqlineedit.cpp (SecQLineEdit::contextMenuEvent,
150
SecQLineEdit::createPopupMenu): Remove implementation.
151
Submitted by Tobias Koenig <tokoe@kde.org>.
153
2007-02-14 Werner Koch <wk@g10code.com>
155
* pinentry/pinentry.h (struct pinentry): Add TOUCH_FILE.
156
* pinentry/pinentry.c (option_handler): New option "touch-file".
157
(pinentry_have_display): Ignore an empty DISPLAY.
158
* pinentry/pinentry-curses.c (do_touch_file): New.
159
(curses_cmd_handler): Call it.
160
* configure.ac: Check for utime.h.
162
2007-01-24 Werner Koch <wk@g10code.com>
164
* pinentry/pinentry.c (cmd_message): New.
165
(cmd_confirm): New command option --one-button.
166
(cmd_getpin): Zeroise ONE_BUTTON.
167
* pinentry/pinentry.h (struct pinentry): Add field ONE_BUTTON.
168
* gtk/pinentry-gtk.c (create_window): Take care of new option.
169
* gtk+-2/pinentry-gtk-2.c (create_window): Ditto.
170
* pinentry/pinentry-curses.c (dialog_create): Ditto.
171
(dialog_create, dialog_switch_pos): Allow CANCEL to be optional.
173
2006-07-29 Marcus Brinkmann <marcus@g10code.de>
175
* secmem/secmem.c (init_pool): Close FD after establishing the
178
2005-09-28 Marcus Brinkmann <marcus@g10code.de>
180
* configure.ac (PINENTRY_GTK): Error out if iconv is not found but
183
* config.rpath: New file from gettext. Needed by iconv.m4.
185
2005-07-11 Marcus Brinkmann <marcus@g10code.de>
187
* pinentry/pinentry-curses.c (dialog_switch_pos): Set the cursor
188
state to invisible before moving around. Move the cursor to the
189
beginning of the dialog buttons for accessibility.
191
2005-06-16 Marcus Brinkmann <marcus@g10code.de>
193
* pinentry/pinentry-curses.c (dialog_run): Only convert pin if a
196
2005-01-27 Werner Koch <wk@g10code.com>
200
* gtk+-2/Makefile.am: Removed padlock-keyhole.xpm.
202
* configure.ac: Use AC_GNU_SOURCE instead of the custom define.
203
Prefer gtk2 pinentry over qt.
205
2005-01-21 Marcus Brinkmann <marcus@g10code.de>
207
* doc/pinentry.texi: Fix spelling errors.
208
Submitted by Ville Skytt�.
210
2004-12-23 Werner Koch <wk@g10code.com>
212
* w32/pinentry-w32.rc: Remove the default texts for description,
213
prompt and error. Make it system modal. Enlarge the description
216
2004-12-22 Timo Schulz <twoaday@g10code.com>
218
* w32/main.c: Remove all helper functions and use a callback
219
to set the dialog items directly.
220
(dlg_proc): Set 'result' to -1 to indicate cancel.
221
(ok_button_clicked): Adjusted. Set 'result' to the len of
222
the PIN to indicate success.
224
2004-12-22 Werner Koch <wk@g10code.com>
226
* w32/main.c: Simplified.
227
* w32/dialog.h, w32/dialog.c, w32/controller.h, w32/controller.c:
230
* w32/resource.h, w32/pinentry-w32.rc, w32/main.c, w32/dialog.h
231
* w32/dialog.c, w32/controller.h, w32/controller.c
232
* w32/Makefile.am: New. Based on Timo's work.
234
Update to automake 1.9.
236
* autogen.sh (configure_ac): Add --build-w32 option.
237
* Makefile.am: Support for the W32 pinentry.
238
* configure.ac: Ditto. Reformatted some error messages.
239
Define the usual conditionals for W32.
240
Check for a couple of more usually required headers.
242
* pinentry/pinentry.h (sleep) [W32]: New.
244
* pinentry/pinentry.c: Include langinfo.h only if available.
245
(pinentry_loop) [DOSISH]: Don't do uid check.
247
* secmem/util.c [DOSISH]: Disable UID stuff.
249
2004-09-27 Marcus Brinkmann <marcus@g10code.de>
251
* acinclude.m4 (IU_LIB_NCURSES, IU_LIB_CURSES, IU_LIB_TERMCAP):
252
Moved to m4/curses.m4.
253
(AM_ICONV): Moved to m4/iconv.m4.
254
(AM_PATH_GLIB): Moved to m4/glib.m4.
255
(QT_FIND_FILE, QT_PATH_MOC, QT_PATH_X, QT_PRINT_PROGRAM,
256
QT_CHECK_VERSION, QT_PATH_1_3, QT_PATH, QT_CHECK_COMPILER_FLAG,
257
QT_REMOVE_FORBIDDEN, QT_VALIDIFY_CXXFLAGS, QT_CHECK_COMPILERS,
258
QT_CHECK_RPATH, QT_CHECK_LIBPTHREAD, QT_CHECK_PTHREAD_OPTION,
259
QT_CHECK_THREADING): Move to m4/qt.m4.
261
2004-09-21 Marcus Brinkmann <marcus@g10code.de>
263
* qt/Makefile.am (pinentry_qt_LDFLAGS): Add $(QT_RPATH).
264
Requested by Leo Savernik <l.savernik@aon.at>.
266
2004-09-02 Marcus Brinkmann <marcus@g10code.de>
268
* gtk+-2/padlock-keyhole.xpm: File removed.
269
* gtk+-2/pinentry-gtk-2.c (create_window): Use stock icon.
270
* gtk+-2/gtksecentry.h, gtk+-2/gtksecentry.c: Fix copyright notice.
272
Submitted by Albrecht Dress albrecht.dress@arcor.de.
274
2004-08-17 Marcus Brinkmann <marcus@g10code.de>
276
* configure.ac: Invoke AC_PROG_LN_S.
277
(PINENTRY_DEFAULT): New variable. Substitute it. Fail if no
278
default can be determined.
279
* Makefile.am (install-exec-local): Install pinentry default link.
281
* configure.ac: Check for Gtk+-2.
282
* gtk+-2: New directory with gtk+-2 pinentry.
283
* gtk+-2/Makefile.am, gtk+-2/gtksecentry.h, gtk+-2/gtksecentry.c,
284
gtk+-2/pinentry-gtk-2.c, gtk+-2/padlock-keyhole.xpm: New files.
285
* Makefile.am (pinentry_gtk_2): New variable.
286
(SUBDIRS): Add pinentry_gtk_2.
288
Submitted by Albrecht Dress albrecht.dress@arcor.de.
290
2004-08-04 Werner Koch <wk@g10code.de>
292
* pinentry/pinentry.c (usage): Print help to stdout.
294
2004-07-30 Moritz Schulte <moritz@g10code.com>
296
* qt/Makefile.am (ncurses_include): Removed
297
-I$(top_srcdir)/pinentry ...
298
(AM_CPPFLAGS): ... added: -I$(top_srcdir)/pinentry. Thanks to
301
* pinentry/pinentry.c (pinentry_utf8_to_local): Declare INPUT
303
(pinentry_local_to_utf8): Likewise.
304
(pinentry_utf8_to_local, pinentry_local_to_utf8): Compile only, if
305
either Curses or GTK+ support is enabled.
306
* configure.ac: Do also check for libiconv when the GTK+ version
307
of pinentry is to be build. Define PINENTRY_CURSES, PINENTRY_GTK,
308
PINENTRY_QT depending on which versions of pinentry should be
311
2004-05-21 Marcus Brinkmann <marcus@g10code.de>
313
* acinclude.m4 (QT_CHECK_DIRECT): Removed.
314
(QT_PATH_1_3): Do never invoke QT_CHECK_DIRECT.
316
2004-04-21 Werner Koch <wk@gnupg.org>
320
2004-04-20 Werner Koch <wk@gnupg.org>
322
* secmem/secmem.c [!ORIGINAL_GPG_VERSION]: Include util.h for some
324
(secmem_free, secmem_term): Use wipememory2 instead of memset.
326
* autogen.sh (configure_ac): Fixed version check (s/==/=/).
328
2004-04-02 Thomas Schwinge <schwinge@nic-nac-project.de>
330
* autogen.sh: Added ACLOCAL_FLAGS.
332
2004-02-23 Marcus Brinkmann <marcus@g10code.de>
334
* qt/main.cpp: Include "pinentry.h", not <pinentry.h>.
336
2004-01-30 Werner Koch <wk@gnupg.org>
338
* configure.ac (fopencookie): Remove that test.
340
2004-01-28 Moritz Schulte <mo@g10code.com>
343
(gtk_secure_entry_key_press): Treat GDK_KP_Enter just like
346
2004-01-18 Marcus Brinkmann <marcus@g10code.de>
348
* qt/secqstring.cpp: Do not include "private/qunicodetables_p.h".
349
(isRightToLeft): De-optimize direction query.
351
* qt/secqinternal_p.h, qt/secqinternal.cpp: New files.
352
* qt/Makefile.am (pinentry_qt_SOURCES): Add secqinternal_p.h
353
and secqinternal.cpp.
354
(EXTRA_DIST): Add README.SecQ.
355
* qt/secqlineedit.cpp: Include "secqinternal_p.h".
356
(drawContents): Use SecQSharedDoubleBuffer.
358
2004-01-02 Werner Koch <wk@gnupg.org>
360
* configure.ac: Early check for a c++ compiler.
362
2003-12-23 Werner Koch <wk@gnupg.org>
366
Added Manifest files to all directories.
368
2003-12-22 Werner Koch <wk@gnupg.org>
370
* qt/main.cpp: Include errno.h.
371
(main): Translate the --display option to -display, so that the Qt
372
init code can grasp it.
374
* doc/ChangeLog: Removed and merged with this file.
375
* doc/pinentry.texi: Cleaned up.
376
* doc/fdl.texi: Removed.
378
* pinentry/pinentry.h (struct pinentry): Added LOCALE_ERR.
379
* gtk/pinentry-gtk.c (button_clicked): Set the LOCAE_ERR flag.
380
* pinentry/pinentry-curses.c (dialog_run): Ditto.
381
* pinentry/pinentry.c (cmd_getpin, cmd_confirm): Check this flag.
382
(pinentry_local_to_utf8): Release the correct buffer in the error
383
case. Print diagnostics.
384
(pinentry_utf8_to_local): Print diagnostics.
385
(pinentry_parse_opts): Make short options work.
386
(pinentry_utf8_to_local): Pass nl_langinfo to iconv_open.
388
* gtk/pinentry-gtk.c (button_clicked): Use the right value as
389
input for the conversion.
391
* pinentry/pinentry.c: New variable THIS_PGMNAME.
392
(pinentry_init): Add arg PGMNAME and store it. Use it at all
393
marked placed instead of the constant "pinentry".
394
(usage): Use it here too.
395
* curses/pinentry-curses.c (main): Call pinentry_init with our name.
396
* qt/main.cpp (main): Ditto.
397
* gtk/pinentry-gtk.c (main): Ditto.
399
* configure.ac: Check for mmap.
401
* secmem/util.h (wipememory2,wipememory,wipe): New.
402
* secmem/util.c (wipe): Removed.
403
* secmem/util.c (lower_privs, raise_privs): Commented out.
405
* pinentry/pinentry.c (pinentry_loop): Add paranoia check for
408
* secmem/secmem.c (lock_pool): Cleanup syntax of cpp directives.
410
* gtk/pinentry-gtk.c (main): Print package name in the version line.
411
* curses/pinentry-curses.c (main): Ditto.
412
* qt/main.cpp (main): Ditto. Fixed typo.
414
* gtk/pinentry-gtk.c: Include memory.h.
416
2003-12-20 Marcus Brinkmann <marcus@g10code.de>
418
* pinentry/pinentry.h (struct pinentry): New member PARENT_WID.
419
* pinentry/pinentry.c (pinentry): Add new member here.
420
(usage): Add --parent-wid.
421
(pinentry_parse_opts): Add case for "parent-wid".
422
(option_handler): Same here.
424
2003-12-19 Marcus Brinkmann <marcus@g10code.de>
426
* pinentry/pinentry.c (cmd_setcancel): Use strcpy_escaped.
427
(cmd_setok): Likewise.
428
(cmd_setprompt): Likewise.
429
(pinentry_utf8_to_local): Don't use
430
nl_langinfo, but just lc_ctype directly.
431
* pinentry/pinentry.c (cmd_getpin): Do not convert passphrase to
433
* gtk/pinentry-gtk.c (button_clicked): Convert passphrase to UTF8
435
* pinentry/pinentry-curses.c (dialog_run): Likewise.
437
2003-12-14 Marcus Brinkmann <marcus@g10code.de>
439
* pinentry/pinentry.c (pinentry_init): Register secmem_term as
440
atexit function. Set assuan malloc hooks to secmem.
441
(pinentry_parse_opts): Add break statement to silence gcc warning.
442
* pinentry/pinentry.c (cmd_getpin): If canceled, release and clear
443
PINENTRY->pin nevertheless.
445
* acinclude.m4 (qt_incdirs): Add /usr/include/qt3.
446
* qt/Makefile.am (pinentry_qt_SOURCES): Remove cppmemory.h,
447
cppmemory.cpp, pinentrycontroller.h, pinentrycontroller.cpp.
448
(nodist_pinentry_qt_SOURCES): Remove pinentrycontroller.moc.cpp.
449
(libcurses): Move ../pinentry/libpinentry.a from here to ...
450
(pinentry_qt_LDADD): ... here. Change order a bit to make it
452
* qt/cppmemory.h, qt/cppmemory.cpp, qt/pinentrycontroller.h,
453
qt/pinentrycontroller.cpp: Files removed.
454
* qt/secqstring.h, qt/secqstring.cpp, secqlineedit.h,
455
secqlineedit.cpp: New files.
456
* qt/Makefile.am (pinentry_qt_SOURCES): Add secqstring.h,
457
secqstring.cpp, secqlineedit.h, and secqlineedit.cpp.
458
(nodist_pinentry_qt_SOURCES): Add secqlineedit.moc.cpp.
459
* qt/main.cpp: Do not include "memory.h" or "secmem-util.h", nor
460
<new> or "pinentrycontroller.h". Include <qapplication.h>,
461
<qmessagebox.h>, <qwidget.h> and "secqstring.h". Always include
463
[USE_KDE]: Remove all instances.
464
(curses_main): Function removed.
465
(my_new_handler): Likewise.
467
(qt_cmd_handler): New function.
468
(pinentry_cmd_handler): Define always (to qt_cmd_handler).
470
* qt/pinentrydialog.cpp: Do not include <qlineedit.h>, but
472
(PinEntryDialog::PinEntryDialog): Make _edit a SecQLineEdit
473
object. Connect accepted SIGNAL to accept SLOT, and rejected
474
SIGNAL to reject SLOT.
475
(PinEntryDialog::setText): Make argument SecQString rather than
477
(PinEntryDialog::text): Likewise for return value.
478
* qt/pinentrydialog.h: Declare SecQString and SecQLineEdit classes.
479
(class PinEntryDialog): Disable property text (for now). Adjust
480
argument of setText and return value of text, as well as type of
483
2003-12-09 Werner Koch <wk@gnupg.org>
486
* Makefile.am (EXTRA_DIST): Add README.CVS
487
(ACLOCAL_AMFLAGS): New.
488
* configure.ac: Added min_automake_versions.
489
* autogen.sh: Revamped.
491
2003-04-23 Steffen Hansen <steffen@klaralvdalens-datakonsult.se>
493
* configure.ac: Version 0.6.10-cvs
495
2003-04-23 Steffen Hansen <steffen@klaralvdalens-datakonsult.se>
497
* configure.ac: Version 0.6.9
498
* qt/Makefile.am: Added moc files to DISTCLEANFILES
499
* qt/pinentrycontroller.cpp: Dont spew assuan debug stuff out on stderr.
501
2003-03-26 Steffen Hansen <steffen@klaralvdalens-datakonsult.se>
503
* qt/cppmemory.cpp, qt/main.cpp: Only override array allocation
504
operators. This should take care of the reported memory-problems
505
and even make pinentry-qt use a bit less memory.
507
2003-02-15 Steffen Hansen <steffen@klaralvdalens-datakonsult.se>
509
* qt/pinentrydialog.h, qt/pinentrydialog.cpp: Added icons
510
for error/non-error messages.
512
2003-02-07 Marcus Brinkmann <marcus@g10code.de>
516
2003-02-04 Steffen Hansen <steffen@klaralvdalens-datakonsult.se>
518
* qt/main.cpp: Work around '--display' option. This fixes
519
the pinentry-qt problem reported by several people lately.
521
2003-01-24 Werner Koch <wk@gnupg.org>
523
* autogen.sh: Print a hint to use maintainer mode.
525
2002-12-24 Marcus Brinkmann <marcus@g10code.de>
527
* pinentry/pinentry-curses.c (collect_line): New function.
528
(COPY_OUT, MAKE_BUTTON): New macros.
529
(dialog_create): Rewrite the initializing code and the description
530
calculation routine with word wrapping.
532
2002-11-20 Werner Koch <wk@gnupg.org>
536
* pinentry/pinentry-curses.c (dialog_create): Better truncate
537
lines than to go into an infinite loop. We need to implement word
539
(dialog_run): Add DIALOG_POS_NONE to switch so prevent a warning.
541
2002-11-12 Werner Koch <wk@gnupg.org>
543
* config.sub, config.guess: Updated from ftp.gnu.org/gnu/config
544
to version 2002-11-08.
546
2002-11-09 Werner Koch <wk@gnupg.org>
550
2002-11-08 Werner Koch <wk@gnupg.org>
552
* pinentry/pinentry-curses.c (convert_utf8_string): Renamed to
553
* pinentry/pinentry.c (pinentry_utf8_to_local): this. Changed
555
(pinentry_local_to_utf8): New.
556
(cmd_getpin): Convert result back to UTF-8.
557
* gtk/pinentry-gtk.c (create_utf8_label): New.
558
(create_window): Use it here to set the prompts.
560
2002-11-06 Werner Koch <wk@gnupg.org>
562
* pinentry/pinentry-curses.c (dialog_run): Fixed retrun value tests
565
2002-11-05 Werner Koch <wk@gnupg.org>
567
* secmem/util.c (init_uids): Make it a prototype.
569
* gtk/pinentry-gtk.c (enter_callback): Changed argument name to
570
avoid shadowing warning.
571
(create_window): Removed unused variable I.
572
(ok): Not used, commented.
574
* pinentry/pinentry.c: Include headers for getpid and sleep
577
* secmem/util.h: Correctly declare functions taking no args.
579
* gtk/pinentry-gtk.c: Move gtk headers to the top to avoid
580
compiler warnings about shadowing index etc.
582
* curses/pinentry-curses.c: Include stdio.h for the printf prototype.
584
* pinentry/pinentry-curses.c (dialog_switch_pos): Return a value.
586
* pinentry/pinentry.c (pinentry_have_display): New.
587
(pinentry_setbufferlen): Must return a value. Fixed documentation.
588
(usage): Print a question mark as a substitue for the program name.
590
* gtk/pinentry-gtk.c (main): use it here instead of getenv().
591
* qt/main.cpp (main): Ditto.
593
2002-10-11 Werner Koch <wk@gnupg.org>
595
* configure.ac, Makefile.am: Added doc/ and tests for makeinfo
597
* doc/pinentry.texi, doc/Makefile.am: New.
598
* doc/gpl.texi, doc/fdl.texi: Added these standard files.
600
2002-09-30 Werner Koch <wk@gnupg.org>
604
* qt/pinentrycontroller.cpp (optionHandler): Make sure that a
606
* configure.ac: Use -Wall also for C++.
608
2002-08-19 Steffen Hansen <steffen@hrhansen.dk>
612
2002-08-11 Steffen Hansen <steffen@hrhansen.dk>
614
* Adapted pinentry-qt to new CONFIRM spec.
616
2002-06-26 Werner Koch <wk@gnupg.org>
620
2002-05-24 Werner Koch <wk@gnupg.org>
622
* AUTHORS: Added Marcus
623
* README: Fixed spelling of Quintuple-Agent.
625
2002-05-13 Marcus Brinkmann <marcus@g10code.de>
629
* configure.ac: Set version number to 0.6.2.
630
* NEWS: Add information for 0.6.2.
631
* README: Update for release.
633
2002-05-09 Marcus Brinkmann <marcus@g10code.de>
635
* configure.ac: Add option --enable-fallback-curses and bind it to
636
the ncurses check. Add automake conditional
637
BUILD_LIBPINENTRY_CURSES and FALLBACK_CURSES. Add preprocessor
638
symbol FALLBACK_CURSES.
640
* curses/Makefile.am (AM_CPPFLAGS): Add $(NCURSES_INCLUDE).
641
(LDADD): Add ../pinentry/libpinentry-curses.a.
642
* curses/pinentry-curses.c: Include "pinentry-curses.h".
643
Moved most of the meat to ...
644
* pinentry/pinentry-curses.c: ... here. New file. Make all
645
functions and global variables static.
646
(dialog_cmd_handler): Rename to ...
647
(curses_cmd_handler): ... this.
648
* pinentry/pinentry-curses.h: New file.
649
* pinentry/Makefile.am (noinst_LIBRARIES)
650
[BUILD_LIBPINENTRY_CURSES]: Add libpinentry-curses.a.
651
(libpinentry_curses_a_SOURCES): New target.
653
* gtk/Makefile.am (INCLUDES): Moved all to ...
654
(AM_CPPFLAGS): ... here.
655
[CURSES_FALLBACK]: Define ncurses_include and libcurses.
656
(AM_CPPFLAGS): Add $(ncurses_include).
657
(LDADD): Add $(libcurses).
658
* gtk/pinentry-gtk.c: Rename TIMEOUT to TIME_OUT to avoid conflict
660
[CURSES_FALLBACK]: Include "pinentry-curses.h".
661
(button_clicked): Likewise.
662
(create_window): Likewise.
663
(cmd_handler): Renamed to ...
664
(gtk_cmd_handler): ... this.
665
(pinentry_cmd_handler): Set to gtk_cmd_handler.
666
(main) [CURSES_FALLBACK]: Initialize GTK+ only if environment
667
variable DISPLAY is set, otherwise fall back to curses dialog.
669
* pinentry/pinentry.h: Protect against multiple inclusion.
671
2002-05-09 Marcus Brinkmann <marcus@g10code.de>
673
* curses/pinentry-curses.c (dialog_create): Allow multi-line error
676
* pinentry/pinentry.c (cmd_seterror): Call strcpy_escaped, rather
677
than strcpy, to allow percent-escaping the error text.
679
2002-04-25 Steffen Hansen <steffen@hrhansen.dk>
681
* pinentry-qt: Use ok and cancel value if
684
2002-04-25 Marcus Brinkmann <marcus@g10code.de>
686
* gtk/pinentry-gtk.c (create_window): Use ok and cancel value if
689
2002-04-25 Marcus Brinkmann <marcus@g10code.de>
691
* qt/pinentrycontroller.h: New members _ok and _cancel.
692
* qt/pinentrycontroller.cpp (registerCommands): Add SETOK and SETCANCEL.
693
(assuanOk): New method.
694
(assuanCancel): Likewise.
696
2002-04-25 Marcus Brinkmann <marcus@g10code.de>
698
* curses/pinentry-curses.c (dialog_create): Grok the new ok and
699
cancel members to set the pbutton texts, rather than parsing the
700
prompt in the confirm case.
702
* pinentry/pinentry.h (struct pinentry): Add new members ok and cancel.
703
* pinentry/pinentry.c (register_commands): Add new commands SETOK
704
and SETCANCEL to set button texts.
705
(struct pinentry pinentry): Add initializers for new members.
706
(cmd_setok): New function.
707
(cmd_setcancel): Likewise.
709
2002-04-24 Marcus Brinkmann <marcus@g10code.de>
711
* curses/pinentry-curses.c (dialog_create): Add '<' and '>' around
712
the user provided button texts. Replace sizeof by strlen to fix
713
size calculation of ok and cancel button.
715
2002-04-23 Marcus Brinkmann <marcus@g10code.de>
717
* pinentry/pinentry.h (struct pinentry): New variables lc_ctype
719
* pinentry/pinentry.c (usage): New options --lc-ctype and
721
(pinentry_parse_opts): Likewise.
722
(option_handler): Likewise.
723
(struct pinentry pinentry): New initializers for new members.
725
* curses/pinentry-curses.c (convert_utf8_string): New function.
726
(struct dialog): New members ok and cancel.
727
(dialog_create): New variables ERR, DESCRIPTION, ERROR, PROMPT,
728
OK, and CANCEL. Initialize them with the localised versions of
729
the pinentry strings. If in confirm mode, split up the prompt at
730
'|' and use the values as button texts. Use localised strings.
731
(dialog_switch_pos): Use localised strings.
732
(dialog_run): Free dialog strings.
734
* acinclude.m4 (AM_ICONV): New check from gettext.
735
* configure.ac: Run AM_ICONV if curses pinentry is build.
736
Don't check for inttypes.h, don't check size of unsigned int or
738
(LIBCAP): Move check to interface independent part.
740
2002-04-21 Steffen Hansen <steffen@hrhansen.dk>
742
* Removed X11 dependency and use Qt for grabbing the keyboard.
743
* Clear the lineedit before asking the user for the PIN.
745
2002-04-12 Steffen Hansen <steffen@hrhansen.dk>
747
* Enable pinentry-qt if Qt is found
749
2002-04-06 Marcus Brinkmann <marcus@g10code.de>
752
* qt/Makefile.am, qt/cppmemory.cpp, qt/main.cpp,
753
pinentrycontroller.cpp, qt/pinentrycontroller.h,
754
qt/pinentrydialog.cpp, qt/pinentrydialog.h: New file, copied from
756
* kde: Directory removed.
757
* kde/Makefile.am, kde/cppmemory.cpp, kde/main.cpp,
758
kde/pinentry.desktop, kde/pinentrycontroller.cpp,
759
kde/pinentrycontroller.h, kde/pinentrydialog.cpp,
760
kde/pinentrydialog.h: Files removed.
761
* acinclude.m4: Removed the KE checks and completely overhauled
762
the Qt checks, putting all Qt checks in their own namespace QT_,
763
and make it declare QT_-prefixed variables for linking and
765
* configure.ac: Use the new Qt checks instead the KDE checks.
766
Replace "kde" with "qt" everywhere.
767
* Makefile.am: Replace "kde" with "qt" everywhere.
769
2002-04-06 Marcus Brinkmann <marcus@g10code.de>
771
* acinclude.m4: Reworked the Qt and KDE checks, cutting out a lot
772
of dead and not-so-dead wood. Gave all KDE checks proper names.
773
* configure.ac: Use the new names for the KDE checks.
775
2002-04-06 Marcus Brinkmann <marcus@g10code.de>
777
* kde/Makefile.am (EXTRA_DIST): Remove variable.
778
(install-data-local): Remove target.
779
(uninstall-local): Likewise.
781
2002-04-05 Marcus Brinkmann <marcus@g10code.de>
785
* configure.ac: Set version number to 0.6.
786
* NEWS: Add information for 0.6.0.
787
* secmem/Makefile.am (libsecmem_a_SOURCES): Replace secmem.h with memory.
788
* kde/Makefile.am (pinentry_kde_SOURCES): Move
789
pinentrydialog.moc.cpp and pinentrycontroller.moc.cpp to ...
790
(nodist_pinentry_kde_SOURCES): ... this new target.
792
2002-04-05 Marcus Brinkmann <marcus@g10code.de>
794
* acinclude.m4: A lot of new checks more or less straight from KDE's
795
admin/acinclude.m4.in.
796
* configure.ac (AC_CANONICAL_HOST): Call that macro.
797
(AC_CHECK_COMPILERS, AC_PATH_KDE): Call those macros if KDE
799
* kde/Makefile.am (CXXFLAGS, XXX_PREFIX, XXX_KDE_DEFINES, LIB_QT,
800
LIB_KDECORE, LIB_KDEUI, KDE_RPATH, MOC, kde_appsdir): Variables removed.
801
(AM_CPPFLAGS): Replace XXX_KDE_DEFINES by all_includes.
802
(pinentry_kde_LDFLAGS): Add all_libraries.
803
* README: Document that automatic check is not possible for KDE.
805
2002-04-05 Marcus Brinkmann <marcus@g10code.de>
807
* curses/pinentry-curses.c (dialog_run): Add handling for TAB key.
808
(dialog_create): New variable description_x. Calculate dimension
809
of multi-line description correctly.
811
2002-04-04 Marcus Brinkmann <marcus@g10code.de>
813
* pinentry/pinentry.h (struct pinentry): New members DISPLAY,
815
* pinentry/pinentry.c (pinentry): Likewise.
816
* pinentry/pinentry.c: Include <string.h>.
817
(usage): Add new options --display,
818
--ttyname and --ttytype.
819
(option_handler): Likewise.
820
(pinentry_parse_opts): Likewise.
822
* curses/pinentry-curses.c (dialog_cmd_handler): Use
823
PINENTRY->ttyname and PINENTRY->ttytype.
825
2002-03-30 Marcus Brinkmann <marcus@g10code.de>
827
* acinclude.m4: Add AM_PATH_GLIB and AM_PATH_GTK.
829
2002-03-29 Marcus Brinkmann <marcus@g10code.de>
831
* configure.ac: Choose a more appropriate AC_CONFIG_SRCDIR.
833
2002-03-29 Marcus Brinkmann <marcus@g10code.de>
835
* kde/Makefile.am (pinentry_kde_LDADD): Link with $(LIBCAP).
836
* gtk/Makefile.am (install-exec-local): Moved to ...
837
* Makefile.am (install-exec-local): ... here.
839
2002-03-29 Marcus Brinkmann <marcus@g10code.de>
841
* kde/Makefile.am (kde_appsdir): New variable.
842
* kde/Makefile.am (install-data-local): Use DESTDIR.
843
(uninstall-local): Likewise.
845
2002-03-29 Marcus Brinkmann <marcus@g10code.de>
847
Merge of the gpinentry and curses pinentry program into the
848
pinentry distribution. For this, the structure of the repository
849
has been thoroughly overhauled. Some of the changes:
850
* secmem: New directory with secure memory allocation code.
851
* pinentry: New directory with pinentry support library.
852
* curses: New directory with curses frontend.
853
* gtk: New directory with GTK+ frontend.
854
* kde: New directory with only the core of the old kpinentry program.
855
* admin: Directory removed.
856
* po: Directory removed.
857
* kpinentry: Directory removed.
858
* doc: Directory removed.
859
* jnlib: Directory removed.x
861
The changes in more detail:
862
* AUTHORS: Add authors of other pinentry frontends.
863
* ChangeLog: Add the one from gpinentry.
864
* Makefile.am: Completely rewritten.
865
* README: Add content.
867
* NEWS: New file from gpinentry.
868
* THANKS: New file from gpinentry.
869
* acinclude.m4: New file.
870
* configure.ac: New file which configures for all frontends.
871
* curses/Makefile.am, curses/pinentry-curses.c: New files for
873
* gtk/Makefile.am, gtk/gtksecentry.c, gtk/gtksecentry.h,
874
gtk/pinentry-gtk.c: New files, modified from gpinentry, for GTK+
876
* kde/Makefile.am, kde/cppmemory.cpp, kde/main.cpp,
877
kde/pinentry.desktop, kde/pinentrycontroller.cpp,
878
kde/pinentrycontroller.h, kde/pinentrydialog.cpp,
879
kde/pinentrydialog.h: New files, modified from kpinentry, for KDE
881
* pinentry/Makefile.am, pinentry/pinentry.c, pinentry/pinentry.h:
882
New files containing pinentry support library, partly factored out
884
* secmem/Makefile.am, secmem/memory.h, secmem/secmem-util.h,
885
secmem/secmem.c, secmem/util.c, secmem/util.h: New files
886
containing secure memory allocation code common to all pinentry
888
* Makefile.dist, acconfig.h, configure.files, configure.in.in:
889
Files removed in favor of new configure.ac.
890
* pinentry.lsm: Removed file never used.
891
* stamp-h.in: Removed generated file.
892
* admin/ChangeLog, admin/Makefile.common, admin/acinclude.m4.in,
893
admin/am_edit, admin/am_edit.py, admin/conf.change.pl,
894
admin/config.guess, admin/config.pl, admin/config.sub,
895
admin/configure.in.min, admin/debianrules, admin/depcomp,
896
admin/install-sh, admin/libtool.m4.in, admin/ltcf-c.sh,
897
admin/ltcf-cxx.sh, admin/ltcf-gcj.sh, admin/ltconfig,
898
admin/ltmain.sh, admin/missing, admin/mkinstalldirs, admin/ylwrap:
899
Removed KDE build suite in favor of configure.ac.
900
* doc/Makefile.am, doc/en/Makefile.am, doc/en/index.docbook:
901
Removed files never used.
902
* jnlib/ChangeLog, jnlib/Makefile.am, jnlib/argparse.c,
903
jnlib/argparse.h jnlib/dotlock.c, jnlib/dotlock.h,
904
jnlib/libjnlib-config.h, jnlib/logging.c, jnlib/logging.h,
905
jnlib/mischelp.h, jnlib/stringhelp.c, jnlib/stringhelp.h,
906
jnlib/strlist.c, jnlib/strlist.h, jnlib/types.h, jnlib/xmalloc.c,
907
jnlib/xmalloc.h: Removed files no longer used.
908
* kpinentry/Makefile.am, kpinentry/cppmemory.cpp,
909
kpinentry/cppmemory.h, kpinentry/i18n.h, kpinentry/main.cpp,
910
kpinentry/memory.h, kpinentry/pinentry.desktop,
911
kpinentry/pinentrycontroller.cpp, kpinentry/pinentrycontroller.h,
912
kpinentry/pinentrydialog.cpp, kpinentry/pinentrydialog.h,
913
kpinentry/secmem.cpp, kpinentry/util.cpp, kpinentry/util.h:
914
Removed files in favor of new files in kde/.
915
* po/Makefile.am, po/pinentry.pot: Removed files never used.
917
* autogen.sh: New file.
919
2002-03-04 Werner Koch <wk@gnupg.org>
921
* gpinentry.c (enter_callback): New
922
(create_window): Connect it to the entry field.
924
2002-02-18 Werner Koch <wk@gnupg.org>
928
* gpinentry.c (create_window): Add CONFIRM_MODE.
929
(cmd_confirm): Implemented.
931
* assuan/: Updated from NewPG.
933
2002-01-20 Werner Koch <wk@gnupg.org>
935
* gpinentry.c (option_handler): New to allow changing of the grab
937
(grab_keyboard): Shortcut this when global grab is not set.
939
2002-01-04 Werner Koch <wk@gnupg.org>
943
* configure.ac: Bumbed version
945
* util.h (xtoi_1, xtoi_2): New.
946
* gpinentry.c (strcpy_escaped): New
947
(cmd_setdesc, cmd_seterror): Use it here to allo multiline texts.
949
* gpinentry: Removed debugging outbut
950
(create_window): Tweaked layout.
952
2001-12-07 Werner Koch <wk@gnupg.org>
954
New package gpinentry based on quintuple-agent.
956
Removed all stuff except for the basic configuration stuff and
957
what is needed to build gpinentry. Also removed i18n support.
958
* gpinentry.c: Renamed from secret-query.c
960
2001-02-12 Robert Bihlmeyer <robbe@orcus.priv.at>
962
* 1.0.0 released. Woo-hoo!
964
* configure.in, NEWS: Bumped version.
966
2001-02-04 Robert Bihlmeyer <robbe@orcus.priv.at>
968
* agent.c (make_tmpdir): Honor $TMPDIR.
970
(agent): Would exit on every minor problem. Now, we just close the
971
offending connection.
972
Ignore SIGPIPE, so that EPIPE will close connection.
974
2001-01-11 Robert Bihlmeyer <robbe@orcus.priv.at>
976
* secmem.c: Move one include statement so that the thing compiles.
978
* secret-query.c (main): Minor source cosmetics.
980
2000-11-16 Robert Bihlmeyer <robbe@orcus.priv.at>
982
* gtksecentry.c (gtk_secure_entry_insert_text): Secured a couple
983
of memory (de)allocations that were missed. Thanks to John Steele
984
<jhs28@eng.cam.ac.uk> for spotting these.
986
2000-11-10 Robert Bihlmeyer <robbe@orcus.priv.at>
988
* Thoughts: Removed in favor of new TODO.
990
* README: Remove content and refer to doc/manual.info instead.
992
* agent.c (do_get): Would burn badly on a premature exit of the
993
query program (which would occur routinely if you selected /cancel/).
995
2000-10-25 Robert Bihlmeyer <robbe@orcus.priv.at>
997
* memory.h: Include sys/types.h for size_t.
999
2000-10-08 Robert Bihlmeyer <robbe@orcus.priv.at>
1001
* README: Removed apology about missing documentation.
1002
Updated paragraph about Linux capability patch.
1005
2000-10-03 Robert Bihlmeyer <robbe@orcus.priv.at>
1009
* Makefile.am (EXTRA_DIST): Distribute BUGS (the file, that is).
1011
* configure.in, NEWS: Bumped version.
1013
* Makefile.am, configure.in: Add debian subdir.
1015
* README: Recommend GTK+.
1016
Update list of checked platforms.
1018
2000-10-02 Robert Bihlmeyer <robbe@orcus.priv.at>
1020
* secret-query.c (ok): Simplify.
1021
Put empty line between headers and secret.
1022
(usage): Document '--help' and '--version'.
1024
* agent.c (do_get): Use enhanced secret-query output to fill in
1027
2000-10-01 Robert Bihlmeyer <robbe@orcus.priv.at>
1029
* secret-query.c (main): Clarify error.
1031
* client.c (query_options): New global variable.
1032
(main): New option '--query-options' to pass options to the query
1036
* agent.c (main): New option '--query-options' to pass options to
1038
(do_get): Use 'query_options'.
1040
* acconfig.h, configure.in: Add QUERY_PROGRAM definition.
1041
* client.c: Remove here.
1042
* agent.c (do_get): Use it here, too.
1044
* secret-query.c (main): New option '--no-global-grab' introduced,
1045
that prevents keyboard grabbing unless the window has focus.
1047
2000-09-11 Robert Bihlmeyer <robbe@orcus.priv.at>
1049
* secret-query.c (usage): Add two missing pieces of "\n\".
1051
* agent.c (main): --nofork is now the default, and the option is
1052
deprecated. New option --fork added to turn forking on again.
1053
Close stdout (and stderr unless debugging) even when not forking,
1054
so that normal usage inside eval is still possible.
1055
(agent): Exit gracefully on HUP, so that logging out now kills the
1058
* README (Contact Information): Old URL - duh!
1059
(Using Secret Agent): We no longer fork per default.
1061
* Makefile.am (lib/libutil.a): New target, allows targets that not
1062
automatically recurse (but still depend on libutil.a) to succeed.
1064
2000-07-20 Robert Bihlmeyer <robbe@orcus.priv.at>
1066
* secret-query.c (usage): New function.
1067
(main): Parse options: debug, enhanced, help, version.
1068
Turn on locale support.
1069
If enhanced, insert widgets to ask for timeout and insurance.
1070
(ok): If enhanced, print more information on exit.
1071
(grab_keyboard): Die if grab was unsuccessful.
1073
2000-05-31 Robert Bihlmeyer <robbe@orcus.priv.at>
1077
* configure.in, NEWS: Bumped version.
1079
* Makefile.am (SUBDIRS): Include doc.
1081
* configure.in, acconfig.h: Check for ssize_t.
1082
Check for vsnprintf(), strdup().
1083
Generate doc/Makefile.
1085
* apgp.c, agpg.c, agentlib.c, util.c: Include more stuff.
1087
* agent.c (do_get): Use asprintf() instead of snprintf() so we
1088
don't need to roll our own for yet another function.
1091
* acinclude.m4: gettext macros copied from automake and fixed.
1093
2000-05-30 Robert Bihlmeyer <robbe@orcus.priv.at>
1095
* configure.in, Makefile.am: Properly include doc subdir.
1097
2000-05-29 Robert Bihlmeyer <robbe@orcus.priv.at>
1099
* configure.in, acconfig.h: Add test for XMESSAGE path.
1101
* client.c (main): Decode command from string to integer code
1102
first, then evaluate that in ifs.
1104
* secret-ask.c: New file, external ask-for-confirmation utility.
1106
* configure.in, Makefile.am: Add secret-ask to programs being
1107
built when GTK is available. Rename QUERY to more descriptive
1110
* agent.c (do_get): If GTK is available, try executing secret-ask
1112
Only put the comment into the insure-question if there is a
1114
(main): --csh was missing from usage message.
1116
2000-04-23 Robert Bihlmeyer <robbe@orcus.priv.at>
1118
* secret-query.c (constrain_size): Lower window max_width to
1119
accomodate bugs in GTK and Scwm.
1121
* agent.c (main): Set x_enabled if X appears to be available.
1122
Use it to selectively make FLAGS_INSURE supported.
1123
(do_get): Use it instead of testing at every call.
1124
(do_put): Requests containing unsupported flags fail.
1125
(forget_old_stuff): Would not set next_deadline correctly.
1126
(do_get): Implement FLAGS_INSURE.
1128
* client.c (main): "list" format changed so that comment is to the
1129
far right. Display the deadline as proper date/time, too.
1131
1999-11-11 Robert Bihlmeyer <robbe@orcus.priv.at>
1133
* agent.c (next_deadline): New global variable, holds time when
1134
next secret has to be killed.
1135
(store): Keep it up-to-date.
1136
(forget_old_stuff): New function, reaps secrets ready to kill,
1137
keeps next_deadline updated.
1138
(agent): Use it on all secrets, whenever a deadline is active.
1140
1999-11-08 Robert Bihlmeyer <robbe@orcus.priv.at>
1142
* agent.h (request_put): Add flags, deadline. Increase REQUEST_MAGIC.
1143
(reply_get): Ditto, and increase REPLY_MAGIC.
1144
* agent.c (store): Store flags, deadline in reply.
1145
(do_put): Hand flags, deadline from request on to store().
1146
(do_get): Store on-demand queried secrets without deadline or
1147
special flags, for now.
1148
(agent): Do not ignore obsolete clients, return an error reply.
1149
* agentlib.c (agent_put): Add flags, deadline arguments, and copy
1150
them into the request.
1151
* agentlib.h (agent_put): Update prototype.
1152
* * client.c (main): Added --time-to-live (-t) and --insure (-i)
1153
options, influencing PUT's deadline and flags, respectively.
1154
(main): Change list format to include new attributes.
1156
1999-11-05 Robert Bihlmeyer <robbe@orcus.priv.at>
1158
* configure.in: <getopt.h> check had redundant definition.
1159
* acconfig.h: Remove here, too.
1161
* configure.in: Check for <inttypes.h>. If not found, check for
1162
unsigned {int, long} sizes.
1163
* agent.h: Either include <inttypes.h>, or try to define uint32_t
1165
Need to include "config.h".
1167
1999-11-04 Robert Bihlmeyer <robbe@orcus.priv.at>
1169
* Makefile.am (signed-dist): New rule, generates sig for dist.
1170
(%.sig): New rule, for detached signatures in general.
1172
* configure.in: Check for ulong.
1173
* acconfig.h: Document it.
1174
* secmem.c: Unconditionally defining it is no longer necessary
1175
here. But do include <sys/types.h> in all cases.
1179
* secmem.c: ulong is not defined on all systems.
1181
* agent.h: <inttypes.h> should define `uint32_t' as per Unix98, so
1184
1999-11-02 Robert Bihlmeyer <robbe@orcus.priv.at>
1186
* agent.h: Augmented requests and replies with magic numbers.
1187
Data structures heavily commented.
1188
All structures and enums typedef'd.
1190
(store): Set magic number in stored reply.
1191
(do_put): Set magic number in reply.
1194
(agent): Check magic number in request.
1195
* agentlib.c: Adapted.
1196
(send_request): Set magic number in request. Check it in reply.
1197
* agentlib.h: Adapted.
1200
* client.c: Adapted.
1202
1999-10-31 Robert Bihlmeyer <robbe@orcus.priv.at>
1204
* secmem.c: Instead of defining ulong directly, include
1207
* secret-query.c (constrain_size): New function, puts constrains
1208
on size of toplevel window.
1209
(grab_keyboard): Removed protection against multiple calls.
1210
(ungrab_keyboard): New function, cancelling a keyboard grab.
1211
(main): Hang `grab_keyboard' onto map-event which makes it
1212
actually work, hang `ungrab_keyboard' onto unmap-event.
1213
Hang `constrain_size' onto size-request.
1215
* secmem.c: ulong was undefined on some systems.
1217
1999-10-19 Robert Bihlmeyer <robbe@orcus.priv.at>
1219
* Makefile.am (install-exec-local): Ignore setcap errors.
1221
* apgp.c: New program, based on agpg.c, but for pgp2.6.
1222
* Makefile.am (bin_PROGRAMS, apgp_SOURCES): Added it.
1224
* agpg.c (GPG): New constant.
1225
(find_id, main): Use it throughout.
1226
(find_id): Forgot to pclose on success.
1228
* secret-query.c (main): Don't expand anything.
1229
Use a button box for the buttons.
1230
Prompt label can be overridden from the commandline.
1231
* agent.c (do_get): Make spawned secret-query show the id.
1232
* client.c (xgetpass): Pass prompt to secret-query.
1233
(main): Include id in xgetpass prompt.
1235
1999-10-14 Robert Bihlmeyer <robbe@orcus.priv.at>
1237
* configure.in: setcap must be searched outside the usual user
1239
* Makefile.am (install-exec-local): Set cap_ipc_lock permitted on
1240
installed binaries, if possible.
1242
* agent.c (xdup2): New function, dup2 with error handling.
1243
(move_fd): New function, moves fds.
1244
(store): New function, abstracted out from do_put.
1246
(do_get): If secret was not found, and DISPLAY is set, try to
1247
query the user about it. If successful, store it.
1248
(main): Route standard file descriptors to /dev/null rather than
1249
just closing them. The latter would confuse children.
1251
1999-10-13 Robert Bihlmeyer <robbe@orcus.priv.at>
1253
* gtksecentry.c, gtksecentry.h: New files, being slightly modified
1254
versions of GTK+'s gtkentry.[ch], spiffed up to use secure memory.
1255
* secret-query.c (ok, unselect, main): Replace GtkEntry with
1257
(main): Initialize secure memory.
1258
* Makefile.am (secret_query_SOURCES): Added gtksecentry.[ch].
1260
* README (Security): New chapter.
1262
* configure.in, acconfig.h: Check for POSIX capabilities, and the
1264
* Makefile.am: Link LIBCAP to those binaries using secmem.c.
1266
* util.h: Include <sys/types.h> for size_t.
1268
1999-09-21 Robert Bihlmeyer <robbe@orcus.priv.at>
1270
* secmem.c: Synced with gnupg-1.0 (top new feature: capabilities).
1271
(log_fatal): New function, logs to stderr, and dies.
1273
1999-09-08 Robert Bihlmeyer <robbe@orcus.priv.at>
1275
* secmem.c (log_info): New function, logs to stderr.
1277
* agent.c (agent): select() expects the number of fds, not the
1278
highest fd. So remember that number.
1280
* agent.c (agent): Don't use FD_SETSIZE, which is not defined on
1281
all systems. Remember the number of the highest descriptor
1284
* configure.in: Replace getline() instead of getdelim() because
1285
this is the function we really need. Still check for getdelim(),
1286
though - there are systems out there where this is provided, but
1289
1999-09-01 Robert Bihlmeyer <robbe@orcus.priv.at>
1293
* configure.in: Bump version.
1297
1999-08-31 Robert Bihlmeyer <robbe@orcus.priv.at>
1299
* util.c (init_uids, lower_privs, raise_privs, drop_privs): New
1300
functions, for setuid binaries, extracted from agent.c.
1301
* util.h: Add prototypes for them.
1302
* agpg.c (main): Use them.
1303
* client.c (main): Ditto.
1304
* agent.c (main): Ditto. Removed code that did the same.
1305
Unconditionally include "asprintf.h" (it protects itself now).
1307
1999-08-25 Robert Bihlmeyer <robbe@orcus.priv.at>
1309
* Makefile.am (SUBDIRS): Process . before test so that "make
1310
check" always builds all in . first.
1312
1999-08-21 Robert Bihlmeyer <robbe@orcus.priv.at>
1314
* secret-query.c: Include "config.h".
1316
* agent.h (reply_list_entry, reply_list): New reply structures.
1317
* agent.c (send_list_entry): New function.
1318
(do_list): First send number of entries, then each entry via
1320
* agentlib.c (agent_list): Read entries returned by LIST request.
1321
* client.c (main): Output all entries returned by agent_list().
1323
* agentlib.c (agent_put): Don't construct PUT request in insecure
1326
1999-08-20 Robert Bihlmeyer <robbe@orcus.priv.at>
1328
* NEWS: Bump patchlevel.
1330
* configure.in: Bump patchlevel.
1331
Check for missing setenv().
1333
1999-08-09 Robert Bihlmeyer <robbe@orcus.priv.at>
1335
* configure.in: Check for strsignal().
1337
* client-test: Obsoleted by test/client.
1339
* Makefile.am (SUBDIRS): New subdirectory.
1340
* configure.in (AC_OUTPUT): Add here, too.
1344
* README: Explain why secret-client will not output secrets to a
1345
tty, and mention the cat-trick.
1347
* agent.c (main): If seteuid is not available, don't use it and
1348
issue a warning if running setuid.
1350
* configure.in: Run together two REPLACE_FUNCS.
1353
* client-test: Mask out insecure memory warnings.
1355
* agentlib.c (send_request): Let the calling functions reserve
1356
space for the reply, but offer a simple way for simple requests.
1357
(agent_get): Allocate secure memory.
1359
* agent.c (main): Moved secmem_init() after the fork, since that
1360
seemingly munlock's all pages.
1361
Drop priviledges just in case somebody wants to install this
1365
* agpg.c (find_id): Would reorder arguments.
1366
Initialize opt_version.
1367
(main): Initialize secure memory.
1369
* Makefile.am (agpg_SOURCES): Link with secure memory module.
1371
* client.c (usage): Fixed another program name reference.
1373
1999-08-06 Robert Bihlmeyer <robbe@orcus.priv.at>
1375
* configure.in: Conditionally define HAVE_GTK.
1376
* acconfig.h: Add here too.
1378
* client.c (xgetpass): Use "secret-query" only if it was built.
1379
(main): Don't output secret (GET command) to ttys.
1381
* agpg.c (find_id): Also print own version if "--version" is given.
1382
(main): Check agent_init() errors.
1383
Print error if exec fails.
1385
* agent.c (main): Added an option to produce csh-compatible
1388
* agent.c, client.c: Forgot the terminating NULL in long options.
1389
Fixed the program names in usage and version output.
1391
* agent.c (create_socket): AF_UNIX and PF_UNIX are Unix98, so
1392
that's what we use. AF_LOCAL, PF_LOCAL removed.
1393
* agentlib.c (agent_init): Ditto.
1395
1999-08-05 Robert Bihlmeyer <robbe@orcus.priv.at>
1399
* configure.in: Bumped version.
1400
Check for missing getdelim.
1402
* cgpg: Removed, obsoleted by agpg.
1403
* Makefile.am: Here, too.
1405
* agpg.c (find_id): New function.
1408
* Makefile.am (INCLUDES): Put GTK_FLAGS and GLIB_FLAGS here. It
1409
is the easiest way for sources needing it, and it won't hurt those
1411
(agent.o): Explicit command removed accordingly.
1413
1999-08-04 Robert Bihlmeyer <robbe@orcus.priv.at>
1415
* configure.in: Need double quoting in nested AC_MSG_WARN.
1417
* client.c (xgetpass): If no tty is available, but a DISPLAY is,
1418
fork off "secure-query" to read the secret.
1419
Put the fgets into a loop that keeps reading until all of the
1422
* client-test: Unset DISPLAY, so that "secret-query" is never used.
1424
1999-08-03 Robert Bihlmeyer <robbe@orcus.priv.at>
1426
* agpg.c: New file, first cut at a C version of the gpg wrapper,
1427
written in a hurry (20 keys waiting to be signed, and a growling
1429
* Makefile.am: Add it to built programs.
1430
(LDADD): New default.
1431
(secret_client_LDADD): Removed, since it was identical to default.
1433
1999-08-01 Robert Bihlmeyer <robbe@orcus.priv.at>
1435
* secret-query.c: New program, queries the user for a password.
1436
* Makefile.am (bin_PROGRAMS): Added it.
1437
* configure.in: Check for GTK+, build "secret-query" only when
1440
* cgpg: Extra argument for ID is no longer necessary. cgpg will
1441
scan the gpg args for switches that affect user-id, and determine
1442
the right key itself. Per convention, the key-id is used by "GET".
1444
* configure.in: The project name is now "secret-agent".
1446
* Makefile.am: "agent" & "client" renamed to "secret-agent" &
1447
"secret-client", respectively.
1448
* client-test: Adapt to new names.
1450
* Thoughts: Removed discussion of other names.
1451
Added indication of which things already work.
1453
* agent.c (make_tmpdir): Removed occurance of "gpg-agent."
1455
* README: First proper version.
1457
* client-test: Context diffs are more portable then unified diffs.
1459
* agent.c, agent.h, agentlib.c, agentlib.h, client.c, memory.h,
1460
util.c, util.h: Banner updated to new name.
1462
1999-07-29 Robert Bihlmeyer <robbe@orcus.priv.at>
1464
* configure.in: Check for missing asprintf.
1465
Check if -lsocket is needed.
1467
* secmem.c (secmem_dump_stats): Replace usage of ulong.
1469
* Makefile.am (INCLUDES): Add the lib subdirectory to include search.
1471
* agent.c: Forgot to include <string.h>.
1472
Include RYO asprintf header if this function is missing.
1473
For the sake of compatibility, provide a definition for AF_LOCAL,
1474
PF_LOCAL, if missing.
1475
* agentlib.c: Ditto.
1477
1999-07-28 Robert Bihlmeyer <robbe@orcus.priv.at>
1479
* Makefile.am (client_SOURCES): Add "secmem.c", "memory.h".
1481
* client.c (xgetpass): Use secmem_malloc() instead of RYO.
1482
(main): Init and shutdown secmem.
1484
1999-07-27 Robert Bihlmeyer <robbe@orcus.priv.at>
1486
* Makefile.am (agent_SOURCES): Add "secmem.c", "i18n.h", "memory.h".
1487
(client_SOURCES): Add "i18n.h".
1489
* client.c (main): Exit on agent_init() failure.
1491
* agent.c (main): Init secmem.
1492
Make --debug switch cumulative.
1493
(cleanup): Shutdown secmem.
1494
(do_put): Use secmem for storage of secrets.
1495
(do_delete): Use secmem_free(). Since this wipes the memory on its
1496
own, wipe() is superflous now.
1497
(agent): Use secmem for inbound requests.
1498
(delete_secret): New function, takes part of do_delete's
1500
(do_put): Use it to remove old versions stored under the same id.
1501
(do_delete): Use it to delete secrets.
1503
* memory.h: New file.
1505
* secmem.c: New file, snarfed from GnuPG and modified slightly.
1507
* acinclude.m4: New file.
1508
* configure.in: (ALL_LINGUAS): Expanded list of available
1509
languages. Most of them only have a few translations from gpg,
1511
getopt_long test was commented out for debugging,
1512
and left such. Fixed.
1514
* acconfig.h: Comment HAVE_BROKEN_MLOCK.
1516
* cgpg: A space was missing.
1518
* i18n.h: New file, centralizing the gettext macro defs.
1520
* agent.c (BLIND): New macro, that blinds out a secret if debug
1526
* agentlib.c: Include i18n.h
1528
* client.c (usage): New function.
1529
Usage-message made gettext-friendly.
1530
(xgetpass): Use perror() instead of fprintf().
1532
Make comment an optional argument of PUT.
1535
1999-07-26 Robert Bihlmeyer <robbe@orcus.priv.at>
1537
* Makefile.am (client_LDADD): Add lib/libutil.a for portability.
1538
(agent_LDADD): Ditto.
1539
(SUBDIRS): Add lib directory.
1540
(bin_SCRIPTS): New with cgpg, so it gets installed, too.
1542
* configure.in: Add lib/Makefile to output.
1544
1999-07-24 Robert Bihlmeyer <robbe@orcus.priv.at>
1547
* Makefile.am (EXTRA_DIST): Added it.
1549
* agent.c: Moved inclusion of config.h before inclusion of
1550
libintl.h since the latter needs HAVE_LC_MESSAGE.
1552
* clientlib.c: Ditto.
1554
* client-test: Update for new client semantics.
1556
* client.c (check_status): Use debugmsg(). Do nothing if not
1558
(xgetpass): New function, getpass replacement that uses mlock'ed
1560
(main): PUT now asks for the secret rather then getting it from
1562
GET prints only the secret to stdout.
1564
* configure.in: Rearranged.
1565
Check for socklen_t.
1566
* acconfig.h: Added a definition for it.
1568
* client.c: Include packaged getopt.h if the system doesn't provide
1571
(create_socket): Replace AF_FILE, PF_FILE with AF_LOCAL, PF_LOCAL
1573
* agentlib.c (agent_init): Ditto.
1574
Explicitly cast addr to a sockaddr pointer.
1576
* Makefile.am (client_LDADD): Added @INTLLIBS@.
1577
(agent_LDADD): Ditto.
1579
1999-07-19 Robert Bihlmeyer <robbe@orcus.priv.at>
1581
* configure.in: Check for getopt.h and getopt_long.
1582
* acconfig.h (HAVE_GETOPT_H): New define.
1583
* lib/getopt.c, lib/getopt1.c, lib/getopt.h: Added.
1585
1999-07-18 Robert Bihlmeyer <robbe@orcus.priv.at>
1591
* Makefile.am (agent.o): Mentioning the source explicitly does not
1592
work for srcdir!=builddir.
1594
* client.c (main): Function arguments are not always evaluated in
1595
order, so drop the neat ++optind in favor of optind+1, optind+2,
1598
* configure.in: Upped version.
1600
1999-06-28 Robert Bihlmeyer <robbe@orcus.priv.at>
1602
* util.h: Added multi-inclusion guard.
1604
* agent.c Include "util.h".
1605
(main): Forgot to exit at end.
1606
(do_delete): Assume that value is a string and wipe it accordingly.
1608
* configure.in (--enable-debug): New switch.
1610
* agent.h (status_t): Added STATUS_COMM_ERR code.
1611
Added multi-inclusion guard.
1613
* client.c (main): Abstracted out most functionality into a
1614
function library, namely:
1615
* agentlib.c: New file.
1616
* agentlib.h: New file.
1617
* Makefile.am (client_SOURCES): Added agentlib.c, agentlib.h.
1619
* Makefile.am (INCLUDES): GLIB_CFLAGS moved again, this time to
1622
1999-06-15 Robert Bihlmeyer <robbe@orcus.priv.at>
1626
* Makefile.am (agent_CFLAGS): Removed - did not work.
1627
(INCLUDES): Moved the GLIB stuff here.
1629
1999-06-14 Robert Bihlmeyer <robbe@orcus.priv.at>
1631
* configure.in (ALL_LINGUAS): Added `de'.
1633
* agent.c (do_get): Added more debugmsgs.
1634
(do_put): Wouldn't allocate enough for `value'.
1635
(main): New option "--nofork" prevents forking.
1636
Use macros for the std filedescriptor numbers.
1637
Only close stderr if not debugging.
1638
(main): Make Usage string gettext-friendly.
1640
* client-test (cleanup): New function.
1641
Call it on shell exit.
1642
(client): New function.
1643
Use it instead of calling client binary directly.
1644
diff client output with expected one in GET testcases.
1646
1999-06-13 Robert Bihlmeyer <robbe@orcus.priv.at>
1648
* agent.c (failed_reply): New constant.
1650
(do_put): The hash key was overwritten - strdup it.
1651
Construct a GET reply and save that in the hash.
1652
(do_get): Just send the preconstructed reply if the id is present,
1653
and failed_reply otherwise.
1654
(do_delete): Actually free the hashed stuff.
1656
* client.c: Exit with error if agent returned STATUS_FAIL.
1658
* Makefile.am (EXTRA_DIST): Added autogen.sh, Thoughts,
1660
(TESTS): Added client-test.
1661
(AUTOMAKE_OPTIONS): Added gnits.
1664
Copyright 2002, 2003 g10 Code GmbH
1666
This file is free software; as a special exception the author gives
1667
unlimited permission to copy and/or distribute it, with or without
1668
modifications, as long as this notice is preserved.
1670
This file is distributed in the hope that it will be useful, but
1671
WITHOUT ANY WARRANTY, to the extent permitted by law; without even the
1672
implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.