« back to all changes in this revision
Viewing changes to hooks/stop
- Committer: Xiaoming Wang
- Date: 2014-03-06 04:39:31 UTC
- Revision ID: xiaoming.wang@lexisnexis.com-20140306043931-r13hyork3347eadr
Again, thanks for taking time to review HPCC Charm. Based on the 5th review we made following changes:
1) add '-e' bash option for all the hook scripts
So if any statement return non-zero value the hook script will stop
execution.
2) Remove unused charm upgrade and hpcc-relation-changed hooks
The later will result "INFO" level message from 'juju charm proof'
as expected.
3) For reported HPCC roxie process fails to start, it is due to lacking
of network resource (/proc/sys/net/core/rmem_max. It is only happens
on some Juju local environment. We will open a bug against juju-core.
1) add '-e' bash option for all the hook scripts
So if any statement return non-zero value the hook script will stop
execution.
2) Remove unused charm upgrade and hpcc-relation-changed hooks
The later will result "INFO" level message from 'juju charm proof'
as expected.
3) For reported HPCC roxie process fails to start, it is due to lacking
of network resource (/proc/sys/net/core/rmem_max. It is only happens
on some Juju local environment. We will open a bug against juju-core.
added
removed
hooks/stop
