← Back to branch summary

~barry/mailman/events-and-web

« back to all changes in this revision

Viewing changes to src/mailman/runners/tests/test_lmtp.py

  • Committer: Barry Warsaw
  • Date: 2012-04-22 21:33:33 UTC
  • mfrom: (7150.1.11 transactions)
  • Revision ID: barry@list.org-20120422213333-3skjqsjktooesgsl
Several non-functional improvements to the code base.

Reduce the explicit use of the config.db global by introducing two new
helpers:
 - A new transaction() context manager which will commit the transaction on
   successful exit, otherwise it will abort the transaction
 - A new dbconnection decorator which calls the decorated method with the
   Storm store object as the first argument (after self).  This can be used
   instead of config.db.store.

By reducing the explicit use of this global, we have a better chance of
refactoring it away in the future.  Still TODO: runner.py and lmtp.py.

Be explicit about the `store` attribute on the IDatabase interface.

More consistent use of __future__ imports.

Remove an obsolete command line script.

Show diffs side-by-side

added added

removed removed

Lines of Context:
src/mailman/runners/tests/test_lmtp.py
31
31
from datetime import datetime
32
32
 
33
33
from mailman.app.lifecycle import create_list
34
 
from mailman.config import config
 
34
from mailman.database.transaction import transaction
35
35
from mailman.testing.helpers import get_lmtp_client, get_queue_messages
36
36
from mailman.testing.layers import LMTPLayer
37
37
 
43
43
    layer = LMTPLayer
44
44
 
45
45
    def setUp(self):
46
 
        self._mlist = create_list('test@example.com')
47
 
        config.db.commit()
 
46
        with transaction():
 
47
            self._mlist = create_list('test@example.com')
48
48
        self._lmtp = get_lmtp_client(quiet=True)
49
49
        self._lmtp.lhlo('remote.example.org')
50
50