- Committer: Colin Watson
- Date: 2019-07-11 10:58:51 UTC
- Revision ID: cjwatson@canonical.com-20190711105851-5f04oscpxcgi6q68
Fix behaviour of PASV with IPv4-mapped addresses.
When receiving a connection to an IPv6 endpoint using an IPv4-mapped
address (possible on some IPv6 stacks), PASV can work but needs to
return a properly-encoded IPv4 address. Including the leading "::ffff:"
in the response appears to confuse connection tracking in some
firewalls.
This is a backport from a commit in
https://github.com/twisted/twisted/pull/1149, with the only changes being
minor adjustments to symbol names and using six.ensure_text rather than the
private twisted.python.compat._coercedUnicode. As before, getting the tests
backported here was unreasonably difficult, but the Twisted PR has
reasonable coverage.
When receiving a connection to an IPv6 endpoint using an IPv4-mapped
address (possible on some IPv6 stacks), PASV can work but needs to
return a properly-encoded IPv4 address. Including the leading "::ffff:"
in the response appears to confuse connection tracking in some
firewalls.
This is a backport from a commit in
https://github.com/twisted/twisted/pull/1149, with the only changes being
minor adjustments to symbol names and using six.ensure_text rather than the
private twisted.python.compat._coercedUnicode. As before, getting the tests
backported here was unreasonably difficult, but the Twisted PR has
reasonable coverage.
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 .. |
|||||||
etc
|
6 | 9 years ago | Colin Watson | Refactor to avoid dependency on Launchpad's config |
|
||
|
src
|
1 | 9 years ago | Colin Watson | Initial commit, split out from Launchpad with popp |
|
||
.bzrignore |
25.1.1 | 8 years ago | Colin Watson | Convert from buildout to pip. | 88 bytes |
|
|
|
bootstrap-requirements.txt |
37.1.7 | 6 years ago | Colin Watson | Upgrade to Twisted 16.5.0. As well as the various | 44 bytes |
|
|
|
COPYING.txt |
1 | 9 years ago | Colin Watson | Initial commit, split out from Launchpad with popp | 33.7 KB |
|
|
|
Makefile |
36 | 7 years ago | Colin Watson | Pass --never-download to virtualenv. | 1.2 KB |
|
|
|
MANIFEST.in |
25.1.1 | 8 years ago | Colin Watson | Convert from buildout to pip. | 186 bytes |
|
|
|
README.txt |
1 | 9 years ago | Colin Watson | Initial commit, split out from Launchpad with popp | 704 bytes |
|
|
|
requirements.txt |
46 | 4 years ago | Colin Watson | Fix behaviour of PASV with IPv4-mapped addresses. | 1 KB |
|
|
setup.py |
46 | 4 years ago | Colin Watson | Fix behaviour of PASV with IPv4-mapped addresses. | 2.6 KB |
|
|