← Back to branch summary

~mhr3/unity/places-group-focus-overlay

~mhr3/unity/places-group-focus-overlay

« back to all changes in this revision

Viewing changes to dash/ResultView.cpp

Committer: Tarmac
Author(s): MC Return
Date: 2012-08-03 11:58:29 UTC
mfrom: (2528.1.22 unity)
Revision ID: tarmac-20120803115829-2isyblrrxygwiarj

Optimized performance and style following suggestions reported by cppcheck:

1. Reduced the scope of various variables.

2. Used prefix ++ operators for non-primitive types, because those can be more efficient than post-increment. Post-increment usually keeps a copy of the previous value, adds extra code and is slower.. Fixes: . Approved by Brandon Schaefer, Marco Trevisan (Treviño).

files modified:
UnityCore/HomeLens.cpp

dash/ResultView.cpp

dash/ResultViewGrid.cpp

launcher/Launcher.cpp

launcher/LauncherController.cpp

launcher/LauncherModel.cpp

panel/PanelIndicatorEntryView.cpp

panel/PanelMenuView.cpp

plugins/unity-mt-grab-handles/src/unity-mt-grab-handles.cpp

plugins/unitydialog/src/unitydialog.cpp

plugins/unityshell/src/nux-layout-accessible.cpp

plugins/unityshell/src/unity-launcher-accessible.cpp

plugins/unityshell/src/unity-switcher-accessible.cpp

plugins/unityshell/src/unityshell.cpp

unity-shared/BGHash.cpp

unity-shared/DashStyle.cpp

unity-shared/IconRenderer.cpp

unity-shared/PluginAdapterCompiz.cpp

Show diffs side-by-side

added added

removed removed

dash/ResultView.cpp

97

97

ResultList::iterator it;

98

98

std::string uri = result.uri;

99

99

100

for (it = results_.begin(); it != results_.end(); it++)

100

for (it = results_.begin(); it != results_.end(); ++it)

101

101

{

102

102

if (result.uri == (*it).uri)

103

103

{

Older »