← Back to branch summary

~mhr3/unity/places-group-focus-overlay

« back to all changes in this revision

Viewing changes to dash/ResultViewGrid.cpp

  • Committer: Tarmac
  • Author(s): MC Return
  • Date: 2012-08-03 11:58:29 UTC
  • mfrom: (2528.1.22 unity)
  • Revision ID: tarmac-20120803115829-2isyblrrxygwiarj
Optimized performance and style following suggestions reported by cppcheck:

1. Reduced the scope of various variables.

2. Used prefix ++ operators for non-primitive types, because those can be more efficient than post-increment. Post-increment usually keeps a copy of the previous value, adds extra code and is slower.. Fixes: . Approved by Brandon Schaefer, Marco Trevisan (Treviño).

Show diffs side-by-side

added added

removed removed

Lines of Context:
dash/ResultViewGrid.cpp
354
354
  total_rows = (expanded) ? total_rows : 1; // restrict to one row if not expanded
355
355
 
356
356
  // find the currently focused item
357
 
  for (it = results_.begin(); it != results_.end(); it++)
 
357
  for (it = results_.begin(); it != results_.end(); ++it)
358
358
  {
359
359
    std::string result_uri = (*it).uri;
360
360
    if (result_uri == focused_uri_)