← Back to branch summary

~osomon/oxide/camera-names-i18n

« back to all changes in this revision

Viewing changes to shared/browser/ssl/oxide_certificate_error_dispatcher.cc

  • Committer: Chris Coulson
  • Date: 2016-04-18 10:53:32 UTC
  • mfrom: (1378.1.44 unit-testing)
  • Revision ID: chris.coulson@canonical.com-20160418105332-h9b6vhimddqtt7vp
Expand testing capability - this adds 2 new test suites:
- API unit tests (qt/tests/unit). These are compiled unit tests for public APIs and are expected to be fairly limited in scope, and not require a full browser process.
- Internal unit tests. This will allow unit testing of internal classes that can be tested without requiring a full browser process.
I've not added many tests yet - future commits will expand on these.

There's still a hole in test capability - testing internal classes that require a full browser process. For these, I plan to add a test shell binary that will allow this.

Show diffs side-by-side

added added

removed removed

Lines of Context:
shared/browser/ssl/oxide_certificate_error_dispatcher.cc
182
182
  // (should dismiss the error via the cancel callback and go back to the last
183
183
  // committed page)
184
184
 
185
 
  // This gets owned by the |contents|
186
 
  new CertificateErrorPlaceholderPage(contents,
187
 
                                      request_url,
188
 
                                      proxy.get());
 
185
  proxy->AttachPlaceholderPage(contents, request_url);
189
186
}
190
187
 
191
188
} // namespace oxide