← Back to branch summary

~osomon/oxide/camera-names-i18n

« back to all changes in this revision

Viewing changes to shared/browser/ssl/oxide_certificate_error_placeholder_page.cc

  • Committer: Chris Coulson
  • Date: 2016-04-18 10:53:32 UTC
  • mfrom: (1378.1.44 unit-testing)
  • Revision ID: chris.coulson@canonical.com-20160418105332-h9b6vhimddqtt7vp
Expand testing capability - this adds 2 new test suites:
- API unit tests (qt/tests/unit). These are compiled unit tests for public APIs and are expected to be fairly limited in scope, and not require a full browser process.
- Internal unit tests. This will allow unit testing of internal classes that can be tested without requiring a full browser process.
I've not added many tests yet - future commits will expand on these.

There's still a hole in test capability - testing internal classes that require a full browser process. For these, I plan to add a test shell binary that will allow this.

Show diffs side-by-side

added added

removed removed

Lines of Context:
shared/browser/ssl/oxide_certificate_error_placeholder_page.cc
31
31
}
32
32
 
33
33
void CertificateErrorPlaceholderPage::OnDontProceed() {
 
34
  weak_ptr_factory_.InvalidateWeakPtrs();
34
35
  error_->Cancel();
35
36
}
36
37
 
42
43
                                                      true,
43
44
                                                      request_url,
44
45
                                                      this)),
45
 
      error_(error) {
46
 
  error_->SetPlaceholderPage(this);
 
46
      error_(error),
 
47
      weak_ptr_factory_(this) {}
 
48
 
 
49
void CertificateErrorPlaceholderPage::Show() {
47
50
  interstitial_->Show();
48
51
}
49
52