~smspillaz/folly/folly-git-master : changes

~smspillaz/folly/folly-git-master » Changes from revision 9855

From Revision 8714 to 8695

Rev	Summary	Authors	Date
8714	reclaimbale -> reclaimable reclaimbale -> reclaimable Summary: Found because I saw the error message Reviewed By: magedm Differential Revision: D23019298 fbshipit-source-id: 6744e9e6d0c21cf76db756f68b3e948a044e6888	Zach Zundel	3 years ago
8713	Fix TSAN-reported race in ShutdownSocketSet test Fix TSAN-reported race in ShutdownSocketSet test Summary: [Folly] Fix TSAN-reported race in `ShutdownSocketSet` test where the shutdown does not wait for the server. Reviewed By: yfeldblum Differential Revision: D23057822 fbshipit-source-id: 4b682e6e80cff503e85cb2b663f8399b69265a77	Dan Melnic	3 years ago
8712	fix folly::fibers GDB extension for GCC 9 fix folly::fibers GDB extension for GCC 9 Summary: The folly::fibers GDB extension, specifically the `info fibers` command, depended on a specific format of the std::unique_ptr pretty printer output. This pretty printer format changed between GCC 7 and GCC 9, with the latter omitting the target address. However, the new pretty printer does expose an iterator for the child target address that we can use instead. Differential Revision: D23063364 fbshipit-source-id: 6125edaba9abcfd0b7a9c0741a18854637c97804	Christopher Gist	3 years ago
8711	Eliminate lift_void_to_char Eliminate lift_void_to_char Summary: `std::allocator<void>::allocate` is not invocable as policy. Let folly allocators behave the same. Switch existing sites to parameterizing the allocators over `char` instead, since `std::allocator<char>::allocate` is invocable. Reviewed By: yfeldblum Differential Revision: D22986960 fbshipit-source-id: ca1ff3cb1785029b6b6f59ddc4046b1b105d8bd6	Mark Santaniello	3 years ago
8710	fix forwarding for hinted insert_or_assign fix forwarding for hinted insert_or_assign Summary: The hinted forms of insert_or_assign were forwarding with std::move rather than std::forward, which has the potential to elevate a non-const lvalue ref to an rvalue ref. (Note: this ignores all push blocking failures!) Reviewed By: yfeldblum Differential Revision: D21475865 fbshipit-source-id: e91e759762cf6f045c843cd7de1402953e6afb61	Nathan Bronson	3 years ago
8709	Back out "suggest race condition to users that trip F14's in... Back out "suggest race condition to users that trip F14's internal checks" Summary: Original commit changeset: 8d5e96feea4d Reviewed By: yfeldblum Differential Revision: D23046629 fbshipit-source-id: e24c4a0ba5f40a584646a602f618e881dbf0f344	Nathan Bronson	3 years ago
8708	Fix an issue in ElfCache that makes it async-signal-unsafe. Fix an issue in ElfCache that makes it async-signal-unsafe. Summary: basic_fbstring unfortunately just ignores the allocator. Switching it to use std::basic_string. This is necessary because ElfCache must be async-signal-safe, but basic_fbstring ignores the allocator and always uses standard malloc/free, which are not safe async-signal-safe. Reviewed By: yfeldblum Differential Revision: D23035304 fbshipit-source-id: 7b4e77a3764701366556a5fe5a352f952b052ed4	Robin Cheng	3 years ago
8707	Fix TSAN issues for //folly/io/async/test:async_test Fix TSAN issues for //folly/io/async/test:async_test Summary: These are all test setup issues: - EventBase needs to be destructed before objects that callbacks may refer to. - A socket should not be operated on by a thread that is different from the event base it is associated with (in this case, the socket was being closed on the RSA computation thread). Reviewed By: yfeldblum Differential Revision: D23043485 fbshipit-source-id: 733868317aef09e32e79169aedb84a988de3bb41	Robin Cheng	3 years ago
8706	Add blocking logging to fibers::Baton Add blocking logging to fibers::Baton Summary: Increase coverage of blocking operation logging. Reviewed By: yfeldblum Differential Revision: D22933413 fbshipit-source-id: e820927ddafa0bb5f2d50dbb1dceeeb2e89133b3	Pranav Thulasiram Bh...	3 years ago
8705	fix a bad comment in folly/Poly.h fix a bad comment in folly/Poly.h Summary: A doc comment in folly/Poly.h makes reference to a non-existent entity "`Decay`" and is missing namespace qualifiers, making the example confusing and wrong. Reviewed By: Alfus, yfeldblum Differential Revision: D23038865 fbshipit-source-id: 50f515b31919552e11ae18ff645ef71812d77bfb	Eric Niebler	3 years ago
8704	Simplify reentrant_allocator hierarchy Simplify reentrant_allocator hierarchy Summary: [Folly] Simplify `reentrant_allocator` hierarchy while preserving presence/absence rules of `allocate` and `dealllocate`. Apply same rules to `max_size` and `address`. Plus some assorted tweaks. Plus some comments. Reviewed By: luciang Differential Revision: D23016816 fbshipit-source-id: 601318ea112193afcffc93d6783dbd79168a164e	Yedidya Feldblum	3 years ago
8703	Add exception_wrapper::from_exception_ptr taking by && Add exception_wrapper::from_exception_ptr taking by && Summary: [Folly] Add `exception_wrapper::from_exception_ptr` taking by `&&`, permitting callers to move, since `std::exception_ptr` copy is expensive and `std::rethrow_exception` takes by value. Reviewed By: ericniebler, markisaa Differential Revision: D23016839 fbshipit-source-id: c07695fef0828a50426fe4e2b40fae9582c7ffd9	Yedidya Feldblum	3 years ago
8702	Fix a previously introduced bug in ElfTests related to PIE a... Fix a previously introduced bug in ElfTests related to PIE and addresses. Summary: This failed on mode/opt, because the `- sh_addr + sh_offset` was actually using the address and offset of the symbol table section, not the data section (where the kStringValue variable actually is). It still worked, because for mapped sections, the `offset - address` just happens to be the same for all sections, so it didn't matter what section we used; in debug mode, we use dynamic linking, so the symbol section is called .dynsym and is loaded in memory, but in opt mode, the symbol section is called .symtab and is not loaded, so sh_addr is zero, and that formula no longer works. The goal there was really just to subtract the binary base address encoded in the ELF file. ElfFile already provides this via getBaseAddress(), and that's also how we can identify whether the loaded ELF (in this case, the same as the current executable) is PIE; so switched both the calculation and the if condition to use this result. Reviewed By: yfeldblum Differential Revision: D23020998 fbshipit-source-id: f7e66bb554c62aa13d7d2fc1017cb31542507be9	Robin Cheng	3 years ago
8701	Avoid traversing the callbacks map twice when inserting a no... Avoid traversing the callbacks map twice when inserting a non-existing entry Summary: Avoid traversing the callbacks map twice when inserting a non-existing entry Reviewed By: kevin-vigor Differential Revision: D23030404 fbshipit-source-id: afbf7564f4039ffbd942f407429874fde795025d	Dan Melnic	3 years ago
8700	Fix Singleton TSAN issue (mutex used after being destroyed) Fix Singleton TSAN issue (mutex used after being destroyed) Summary: Fix Singleton TSAN issue (mutex used after being destroyed) Reviewed By: yfeldblum Differential Revision: D22925120 fbshipit-source-id: e25c113cdef7076c93a189281f5b9d842f576dd3	Dan Melnic	3 years ago
8699	Add missing header in WTCallback.h Add missing header in WTCallback.h Summary: Add definition to EventBase. Differential Revision: D23004586 fbshipit-source-id: 828767b3d9a43c33bcf047b9b06c08bfba8fde68	Xun Li	3 years ago
8698	better lag detector factory caching better lag detector factory caching Reviewed By: andriigrynenko Differential Revision: D23008623 fbshipit-source-id: db3e5a3dfe8dbbf1c9583b8e4924da31c2f5c174	Misha Shneerson	3 years ago
8697	Avoid std::string with reentrant_allocator in ElfCache Avoid std::string with reentrant_allocator in ElfCache Summary: The implementation of `std::basic_string` with the legacy ABI and with `_GLIBCXX_FULLY_DYNAMIC_STRING`, as appears by default on CentOS 7, incorrectly requires the provided allocator type to have a default constructor. The `Allocator` concept does not require this and many allocator types with runtime state shared between copies will not provide this. Switch to `folly::fbstring` in `ElfCache` to sidestep this problem. Fixes: https://github.com/facebook/folly/issues/1344. Reviewed By: yfeldblum Differential Revision: D22970418 fbshipit-source-id: 1e188d668991d25f53da5702b31f4a7a7ec7d7e8	Chad Austin	3 years ago
8696	fix buffer overrun fix buffer overrun Summary: (Note: this ignores all push blocking failures!) Reviewed By: andriigrynenko Differential Revision: D23005233 fbshipit-source-id: 4ea528505e06fec0af7841ccbd6d41eabe0de558	Misha Shneerson	3 years ago
8695	Make //folly/tracing/test:static_tracepoint_test work if com... Make //folly/tracing/test:static_tracepoint_test work if compiled as PIE. Summary: A tracepoint semaphore address is written to the notes section as either the absolute address (if binary is compiled as non-PIE) or the relative address (if binary is compiled as PIE) of the semaphore. In the former case, the test passes; in the latter case, the test as it was could not possibly pass because the binary is mapped to some random base address. This diff makes a guess: if the addresses are equal, then we're non-PIE; otherwise check if the address offset is valid - that offset is the address at which the binary is mapped, so it always begins with the ELF header, so we can check against that. If someone knows how to easily figure out that random address or to detect whether the binary is PIE (thereby disabling the test) that'd be great too. This fixes TSAN for the test, as TSAN binaries are built as PIE. Reviewed By: yfeldblum Differential Revision: D22752824 fbshipit-source-id: cd320f9fb8355a20f65e2385f0a1ab1c24ec0b81	Robin Cheng	3 years ago