~thopiekar/emgd/xserver-xorg-input-synaptics-github

~thopiekar/emgd/xserver-xorg-input-synaptics-github_community » Changes from revision 1311

From Revision 1303 to 1284

Rev	Summary	Authors	Date
1303	Fix stack smash in clickpad_guess_clickfingers() Fix stack smash in clickpad_guess_clickfingers() Apple Magic Trackpad can report 16 slots. In clickpad_guess_clickfingers() the array allocated on the stack contains only 10 slots. As (.num_mt_mask == .num_slots), the function writes out of the bounds of close_point. Use a size 32 bitmask instead and warn if we ever get past 32 touchpoints. This fixes: https://bugzilla.redhat.com/show_bug.cgi?id=952221 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reported-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Conflicts: src/synaptics.c	Peter Hutterer	11 years ago
1302	synaptics 1.6.3 synaptics 1.6.3 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>	Peter Hutterer	11 years ago
1301	conf: add example for AreaBottomEdge on clickpad buttons conf: add example for AreaBottomEdge on clickpad buttons Those that use clickpad buttons as buttons can see cursor jumps as the press on the touchpad - largely caused by the finger changing shape as the pressure changes and thus moving the hotspot. Simple fix is to define the clickpad soft button areas as dead areas, but this cannot be set as general option as it would break for those that use tapping. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 2159b5d26207c83efea6efca7fa5765df95a4219)	Peter Hutterer	11 years ago
1300	synaptics 1.6.2.901 synaptics 1.6.2.901 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>	Peter Hutterer	11 years ago
1299	Recognise the soft button area property before clickpad is e... Recognise the soft button area property before clickpad is enabled Otherwise the driver has no internal reference to the soft button area property and will ignore any setting. Also, if a client sets this property, we claim it as our own and disallow deletion. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 86460318ba5606ef41712b52e50bf7b2ba083226)	Peter Hutterer	11 years ago
1298	Free mtdev device as well as closing it Free mtdev device as well as closing it mtdev_close_delete() is to mtdev_new_open() as mtdev_close() is to mtdev_open(). So, since we're using mtdev_new_open(), we need to use mtdev_close_delete() instead of just mtdev_close() to actually free everything. Fixes an eventual failure to open the touchpad device after a lot of suspend/resume cycles. [whot: amended to mtdev_close_delete in evdev_query_touch] Signed-off-by: Daniel Stone <daniel@fooishbar.org> Reviewed-by: Dan Nicholson <dbn.lists@gmail.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit ce7565ea6683f594f1f2ab5769bf60b1337d70bd)	Daniel Stone	11 years ago
1297	Use LogMessageVerbSigSafe on ABI 18 Use LogMessageVerbSigSafe on ABI 18 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Chase Douglas <chase.douglas@canonical.com> (cherry picked from commit e28575b29b394b38f1d92b75353fc0fe82838b7c)	Peter Hutterer	11 years ago
1296	test: drop xf86CheckStrOption from fake symbols test: drop xf86CheckStrOption from fake symbols The tests don't need this symbol anymore. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 3cb14dcccf5574366d90e24f351e3ad04b35e35f) Conflicts: test/fake-symbols.c test/fake-symbols.h	Peter Hutterer	11 years ago
1295	Allow dead areas to update the button state Allow dead areas to update the button state On clickpads, a dead area helps prevent pointer movement when the buttons are pressed. Thus check for the button state before resetting the hw state in case we get a right-click in the soft button area. For clickfinger, the effect is that clickfinger events are now triggered if the finger rests in the dead area. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit a5ac54f60af96b9b862425ccd8b6c7afaa4937e4) Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Conflicts: src/synaptics.c	Peter Hutterer	11 years ago
1294	Reset num_active_touches on DeviceOff (#52496) Reset num_active_touches on DeviceOff (#52496) When disabling the device, reset num_active_touches to zero. Otherwise, num_active_touches stays at the value it was on DeviceOff(). Future touches add to that value until the index may go past priv->open_slots[]. That causes spurious memory corruption on touch ends. And as of 55fc42e7c9b4948cadd4f98ef7b6a3b12e268e3e we ignore pre-existing touches anyway. Test-case: - place num_touches fingers on the touchpad - xinput disable <device> - lift fingers - xinput enable <device> - place finger on device, num_active_touches is now (num_touches + 1) X.Org Bug 52496 <http://bugs.freedesktop.org/show_bug.cgi?id=52496> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Chase Douglas <chase.douglas@canonical.com> (cherry picked from commit a245d42f53096b1ae81e6702729f97ca508e5b5b) Conflicts: src/synaptics.c	Peter Hutterer	11 years ago
1293	synaptics 1.6.2 synaptics 1.6.2 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>	Peter Hutterer	11 years ago
1292	synaptics 1.6.1.901 synaptics 1.6.1.901 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>	Peter Hutterer	11 years ago
1291	Don't allow for scroll distances of 0 (#49965) Don't allow for scroll distances of 0 (#49965) It'll either hang the server or blow up with divisions by 0, whichever one comes first. X.Org Bug 49965 <http://bugs.freedesktop.org/show_bug.cgi?id=49965> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Chase Douglas <chase.douglas@canonical.com> (cherry picked from commit 6d47d334d8a876e7e094306c313246b87016b78a)	Peter Hutterer	11 years ago
1290	Reset hw->x/y to INT_MIN and skip HandleState until we have ... Reset hw->x/y to INT_MIN and skip HandleState until we have x/y events The driver assumes x/y is always valid but after coming from a resume we may get a few events with either ABS_X or ABS_Y (not both). Thus we process with hw->x == 0 and hw->y == somevalue, causing cursor jumps when calculating deltas whenver the real hw->x comes in. Fix this by resetting hw->x/y to INT_MIN and skip state processing until both axes are available. For clickpads, this means handling of data will be delayed until we get at least one motion on each axis. Button presses won't be recognised either until that happens. It requires some skill to not trigger motion on both axes, even more to press a button without doing so. For non-clickpads, handling of motion events will be delayed likewise. If a physical button is pressed immediately after resume we have to assume deltas of x/y. - If the next event is a new touch, it will have ABS_X/ABS_Y set anyway - If the finger was already down, a button event is generated, and the finger has generated ABS_X or ABS_Y only before the event, the next event containing the missing data will cause a jump. The fix for this is more invasive and this is quite a corner-case. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Chase Douglas <chase.douglas@canonical.com> (cherry picked from commit cd569377cda9b5a4ee00c0137db14f625c76c40f)	Peter Hutterer	11 years ago
1289	Reset open slots array on device disable Reset open slots array on device disable The open slots array is used for clickpad cumulative delta computation. If the array is not reset and becomes corrupted during the device disable/enable cycle, the cumulative deltas may be wrong. This manifests as jumpy cursor behavior on some clickpads after suspend/resume. Signed-off-by: Chase Douglas <chase.douglas@canonical.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 0054b144f3daf00e46a35b2f165befb209df94fc)	Chase Douglas	11 years ago
1288	Fix coasting for negative ScrollDelta Fix coasting for negative ScrollDelta Fix the coasting direction for when VertScrollDelta or HorizScrollDelta is negative. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=49966 Regression introduced in 0de4445ff8e75aab208faf6383e76045934c6720 Signed-off-by: Chun Yang <Chuck.Yang@gmail.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 53557a5cab1e253dc8f4393207954ae0fe76068f)	Chun Yang	11 years ago
1287	Ignore pre-existing touches Ignore pre-existing touches If a touch is physically active when the device is enabled, then all events for that touch must be ignored. In particular, we cannot close the touch or we will decrement touch count counters below zero. If these counters go below zero memory corruption can occur. Note that a device is disabled and enabled every time the user types on the keyboard if synclient is used to disable the trackpad while typing. This is a very common option. Signed-off-by: Chase Douglas <chase.douglas@canonical.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 55fc42e7c9b4948cadd4f98ef7b6a3b12e268e3e)	Chase Douglas	11 years ago
1286	Avoid out-of-bounds access by running num_active_touches < 0... Avoid out-of-bounds access by running num_active_touches < 0 (#49439) If a touch is active during driver init, the slot will be set to SLOTSTATE_CLOSE when it finishes. That could decrease num_active_touches to less than 0, causing out-of-bounds access. X.Org Bug 49439 <http://bugs.freedesktop.org/show_bug.cgi?id=49439> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Chase Douglas <chase.douglas@canonical.com> (cherry picked from commit 77d766b1d535dff9a27c7db343ede85d9f44850b)	Peter Hutterer	11 years ago
1285	synaptics 1.6.1 synaptics 1.6.1 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>	Peter Hutterer	11 years ago
1284	tools: coasting speed is not capped at 20, cap it at 255 tools: coasting speed is not capped at 20, cap it at 255 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> (cherry picked from commit 0352c67fa2a7224b5a3bf03a934b3c7af42b4f51)	Peter Hutterer	11 years ago

Older »