← Back to branch summary

~timo-jyrinki/compiz/metacity-key-migrations

~timo-jyrinki/compiz/metacity-key-migrations

« back to all changes in this revision

Viewing changes to gtk/window-decorator/events.c

Committer: Tarmac
Author(s): MC Return
Date: 2012-08-03 09:23:59 UTC
mfrom: (3294.4.166 compiz.fix1030473-part1)
Revision ID: tarmac-20120803092359-pe2e1cpe6u0toxt3

Fixed various problems described in bug 1030473.
Optimized performance and style following suggestions reported by cppcheck:

1. Reduced the scope of various variables.

2. Used prefix ++ operators for non-primitive types, because those can be more efficient than post-increment. Post-increment usually keeps a copy of the previous value, adds extra code and is slower.. Fixes: https://bugs.launchpad.net/bugs/1030473. Approved by Daniel van Vugt, Sam Spilsbury.

files modified:
cmake/src/compiz/compiz_discover_gtest_tests.cpp

compizconfig/libcompizconfig/src/bindings.c

compizconfig/libcompizconfig/src/compiz.cpp

gtk/window-decorator/events.c

kde/window-decorator-kde4/window.cpp

plugins/animation/src/animation.cpp

plugins/animation/src/extensionplugin.cpp

plugins/animationaddon/src/burn.cpp

plugins/annotate/src/annotate.cpp

plugins/ccp/src/ccp.cpp

plugins/clone/src/clone.cpp

plugins/colorfilter/src/parser.cpp

plugins/compiztoolbox/src/compiztoolbox.cpp

plugins/composite/src/screen.cpp

plugins/cubeaddon/src/cubeaddon.cpp

plugins/dbus/src/dbus.cpp

plugins/decor/src/clip-groups/tests/clip-groups/src/test-decor-clip-groups.cpp

plugins/decor/src/decor.cpp

plugins/extrawm/src/extrawm.cpp

plugins/ezoom/src/ezoom.cpp

plugins/firepaint/src/firepaint.cpp

plugins/grid/src/grid.cpp

plugins/group/src/group.cpp

plugins/group/src/init.cpp

plugins/group/src/paint.cpp

plugins/group/src/selection.cpp

plugins/group/src/tab.cpp

plugins/loginout/src/loginout.cpp

plugins/mousepoll/src/mousepoll.cpp

plugins/opengl/src/fragment.cpp

plugins/opengl/src/paint.cpp

plugins/place/src/place.cpp

plugins/place/src/screen-size-change/src/screen-size-change.cpp

plugins/resize/src/resize.cpp

plugins/ring/src/ring.cpp

plugins/scale/src/scale.cpp

plugins/session/src/session.cpp

plugins/shift/src/shift.cpp

plugins/snap/src/snap.cpp

plugins/staticswitcher/src/staticswitcher.cpp

plugins/switcher/src/switcher.cpp

plugins/td/src/3d.cpp

plugins/trailfocus/src/trailfocus.cpp

plugins/wall/src/offset_movement/src/offset-movement.cpp

plugins/wobbly/src/wobbly.cpp

src/event.cpp

src/match.cpp

src/plugin.cpp

src/screen.cpp

src/stackdebugger.cpp

src/timer/src/timeouthandler.cpp

src/timer/src/timer.cpp

src/timer/tests/callbacks/src/test-timer-callbacks.cpp

src/timer/tests/while-calling/src/test-timer-set-times-while-calling.cpp

Show diffs side-by-side

added added

removed removed

gtk/window-decorator/events.c

440

440

decor_event *gtkwd_event,

441

441

decor_event_type gtkwd_type)

442

442

{

443

static int last_button_num = 0;

444

443

static Window last_button_xwindow = None;

445

444

static Time last_button_time = 0;

446

static int last_button_x = 0;

447

static int last_button_y = 0;

448

445

449

446

decor_t *d = g_object_get_data (G_OBJECT (win), "decor");

450

447

460

457

461

458

if (gtkwd_event->button == 1)

462

459

{

460

static int last_button_num = 0;

461

static int last_button_x = 0;

462

static int last_button_y = 0;

463

463

if (gtkwd_event->button == last_button_num &&

464

464

gtkwd_event->window == last_button_xwindow &&

465

465

gtkwd_event->time < last_button_time + double_click_timeout &&

Older »