~timo-jyrinki/compiz/metacity-key-migrations

« back to all changes in this revision

Viewing changes to src/match.cpp

Fixed various problems described in bug 1030473.
Optimized performance and style following suggestions reported by cppcheck:

1. Reduced the scope of various variables.

2. Used prefix ++ operators for non-primitive types, because those can be more efficient than post-increment. Post-increment usually keeps a copy of the previous value, adds extra code and is slower.. Fixes: https://bugs.launchpad.net/bugs/1030473. Approved by Daniel van Vugt, Sam Spilsbury.

Show diffs side-by-side

added added

removed removed

Lines of Context:
236
236
                break;
237
237
        }
238
238
 
239
 
        it1++;
240
 
        it2++;
 
239
        ++it1;
 
240
        ++it2;
241
241
    }
242
242
 
243
243
    return true;