1
From 4acfab6a7b368d34295afdace678563e1c3fa058 Mon Sep 17 00:00:00 2001
2
From: Vishvananda Ishaya <vishvananda@gmail.com>
3
Date: Thu, 5 Apr 2012 17:00:25 -0700
4
Subject: [PATCH 2/5] Stop libvirt test from deleting instances dir
8
Change-Id: Id41ab20193a70246ad2e3e1cc18edf47059d312d
10
nova/tests/test_libvirt.py | 37 ++++++++++++-------------------------
11
1 files changed, 12 insertions(+), 25 deletions(-)
13
diff --git a/nova/tests/test_libvirt.py b/nova/tests/test_libvirt.py
14
index 6b0f668..4ce91cb 100644
15
--- a/nova/tests/test_libvirt.py
16
+++ b/nova/tests/test_libvirt.py
17
@@ -2148,25 +2148,8 @@ class LibvirtConnectionTestCase(test.TestCase):
18
"""Test for nova.virt.libvirt.connection.LibvirtConnection."""
20
super(LibvirtConnectionTestCase, self).setUp()
22
self.libvirtconnection = connection.LibvirtConnection(read_only=True)
24
- self.temp_path = os.path.join(flags.FLAGS.instances_path,
25
- 'instance-00000001/', '')
27
- os.makedirs(self.temp_path)
29
- print 'testcase init error'
33
- super(LibvirtConnectionTestCase, self).tearDown()
36
- shutil.rmtree(flags.FLAGS.instances_path)
40
def _create_instance(self, params=None):
41
"""Create a test instance"""
43
@@ -2374,11 +2357,15 @@ class LibvirtConnectionTestCase(test.TestCase):
44
self.stubs.Set(self.libvirtconnection, '_create_new_domain',
45
fake_create_new_domain)
47
- ins_ref = self._create_instance()
48
- libvirt_xml_path = os.path.join(flags.FLAGS.instances_path,
49
- ins_ref['name'], 'libvirt.xml')
50
- f = open(libvirt_xml_path, 'w')
53
- ref = self.libvirtconnection.finish_revert_migration(ins_ref, None)
54
- self.assertTrue(isinstance(ref, eventlet.event.Event))
55
+ with utils.tempdir() as tmpdir:
56
+ self.flags(instances_path=tmpdir)
57
+ ins_ref = self._create_instance()
58
+ os.mkdir(os.path.join(tmpdir, ins_ref['name']))
59
+ libvirt_xml_path = os.path.join(tmpdir,
62
+ f = open(libvirt_xml_path, 'w')
65
+ ref = self.libvirtconnection.finish_revert_migration(ins_ref, None)
66
+ self.assertTrue(isinstance(ref, eventlet.event.Event))