~axwalk/juju-core/api-uniter-machine : changes

~axwalk/juju-core/api-uniter-machine » Changes from revision 2793

From Revision 2778 to 2759

Rev	Summary	Authors	Date
2778	[r=axwalk],[bug=1322136] utils: clear $_proxy in tests [r=axwalk],[bug=1322136] utils: clear $_proxy in tests Clear $http_proxy, $HTTP_PROXY, $https_proxy, and $HTTPS_PROXY when running the tests. As of Go 1.3, net/http will use a sync.Once to get the proxy env var values; thus, we clear these variables at program initialisation. Fixes lp:1322136 https://codereview.appspot.com/98450046/	Andrew Wilkins	10 years ago
2777	[r=axwalk],[bug=1322037] worker/provisioner: make tests dete... [r=axwalk],[bug=1322037] worker/provisioner: make tests deterministic Fix TestProvisionerRetriesTransientErrors which was relying on non-deterministic behaviour of the provisioner. Wait for machine-1 and then machine-2 to be provisioned serially. Fixes lp:1322037 https://codereview.appspot.com/100730043/	Andrew Wilkins	10 years ago
2776	[r=dave-cheney] testing: make RunCommand variadic [r=dave-cheney] testing: make RunCommand variadic This change alters the testing.RunCommand helper to be variadic. In terms of LOC this is probably a net nil, but being variadic this removes the requirement to wrap arguments to this method in a []string{ ... }	Dave Cheney	10 years ago
2775	[r=frankban] Remove juju-core dependencies from filetesting. [r=frankban] Remove juju-core dependencies from filetesting.	Francesco Banconi	10 years ago
2774	[r=menno.smits] state: Preload Relations for status API resp... [r=menno.smits] state: Preload Relations for status API response Avoid unnecessary DB hits by loading Relations at the start of status response handing. Previously each relation was being loaded from the DB twice. This change involves some minor extensions to State structs to support new ways of querying and inspecting Relations. This change supports upcoming work to display better status information when relation hooks fail. https://codereview.appspot.com/97600044/ R=fwereade	Menno Smits	10 years ago
2773	[r=axwalk],[bug=1322132] provider/manual: use SameContents [r=axwalk],[bug=1322132] provider/manual: use SameContents Fixes lp:1322132 https://codereview.appspot.com/98440049/	Andrew Wilkins	10 years ago
2772	[r=fwereade],[bug=1192433] state: set departed on dying unit... [r=fwereade],[bug=1192433] state: set departed on dying units' relations This ended up including: * stopping using magic strings in cleanup * drawing a clear distinction between "joined" and "in scope" (which accounts for most of the lines of changes) ...but did not include: * fixing the name of the Uniter.JoinedRelations API, because I want to wait for API versioning https://codereview.appspot.com/94540043/	William Reade	10 years ago
2771	[r=axwalk] Output mongo log if TestEnsureAdminUser fails [r=axwalk] Output mongo log if TestEnsureAdminUser fails Hopefully this will provide some insight into why CI keeps failing on this test. https://codereview.appspot.com/97640046/	Andrew Wilkins	10 years ago
2770	[r=axwalk],[bug=1308852] worker: fix simpleworker Kill [r=axwalk],[bug=1308852] worker: fix simpleworker Kill gccgo does not like it when you close a channel twice. It's not a very nice thing anyway. Fixes lp:1308852 https://codereview.appspot.com/98480046/	Andrew Wilkins	10 years ago
2769	[r=axwalk],[bug=1308767] provider/common: instance.Addresses... [r=axwalk],[bug=1308767] provider/common: instance.Addresses() in StateInfo Previously we would just accumulate instances' DNS names in StateInfo. This breaks if the DNS name is not routable from where you are attempting to connect. Instead, we add all of the instance's addresses to StateInfo. Fixes lp:1308767 https://codereview.appspot.com/93500046/	Andrew Wilkins	10 years ago
2768	[r=menno.smits] cmd/juju: "juju user add" now takes --passwo... [r=menno.smits] cmd/juju: "juju user add" now takes --password As per requirements, changed the password option for the "user add" command from a positional argument to an option (--password). This is a better way of handling an optional argument anyway. Also fixed a number of problems with the tests (excessive copy and paste, misnamed test names etc). https://codereview.appspot.com/100620046/ R=dave-cheney	Menno Smits	10 years ago
2767	[r=dave-cheney],[bug=1322018] provider/maas: fix lp 1322018 [r=dave-cheney],[bug=1322018] provider/maas: fix lp 1322018	Dave Cheney	10 years ago
2766	[r=dave-cheney],[bug=1321492] provider/openstack: fix lp 132... [r=dave-cheney],[bug=1321492] provider/openstack: fix lp 1321492 Replace a bunch of calls to DeepEqual which should be doing set comparison.	Dave Cheney	10 years ago
2765	[r=axwalk],[bug=1303583] provider/azure: fix tests for go1.3... [r=axwalk],[bug=1303583] provider/azure: fix tests for go1.3/gccgo Fix a test to use SameContents instead of DeepEquals. Also, make StopInstances deterministic; it now stops instances in the order of IDs specified. One of the StopInstances tests was sending responses in the wrong order, and that has been rectified. Fixes lp:1303583 https://codereview.appspot.com/93520047/	Andrew Wilkins	10 years ago
2764	[r=waigani] Validate usernames [r=waigani] Validate usernames Move username regex validation into names.IsUser. Update codebase to ensure usernames are validated where need. https://codereview.appspot.com/92560043/ R=menno.smits, waigani	Jesse Meek	10 years ago
2763	[r=waigani],[bug=1307241] Fix 1307241. Isolate tests. [r=waigani],[bug=1307241] Fix 1307241. Isolate tests. Add the following mock functions to environs/tools/testing/testing.go: GetMockBundleTools GetMockBuildTools Make envtools.BundleTools mockable. Patch functions in tests where needed to ensure tests pass without dependencies on jujud.	Jesse Meek	10 years ago
2762	[r=cmars] Log supercommand name. [r=cmars] Log supercommand name. In SuperCommand.Run, log the supercommand's name instead of hard-coded 'juju'. https://codereview.appspot.com/92440046/	Casey Marshall	10 years ago
2761	[r=wallyworld] Fix store tests which use bzr [r=wallyworld] Fix store tests which use bzr The various test suites in store should embed FakeHomeSuite not BaseSuite https://codereview.appspot.com/100590048/	Ian Booth	10 years ago
2760	[r=axwalk],[bug=1321461] replicaset: clean up, extend timeou... [r=axwalk],[bug=1321461] replicaset: clean up, extend timeout Various cleanups, factoring out code, etc.; uncovered a bit of code that was leaking an *mgo.Session. I've extended the attempt strategy total for replset modifications to 2 minutes, since the mongo docs say that operations inducing a renegotiation of primary may incur downtime of >1m. I was able to reproduce the error initially on my machine by running the test in a loop; I have not reproduced it with these changes. Fixes lp:1321461 https://codereview.appspot.com/95550044/	Andrew Wilkins	10 years ago
2759	[r=dave-cheney],[bug=1321521] Fix lp 1321521 [r=dave-cheney],[bug=1321521] Fix lp 1321521 Constraints are an unordered set, use SameContents rather than DeepEqual.	Dave Cheney	10 years ago

Older »