← Back to branch summary

~apparmor-dev/apparmor/master

« back to all changes in this revision

Viewing changes to kernel-patches/4.6/0005-apparmor-exec-should-not-be-returning-ENOENT-when-it.patch

  • Committer: Steve Beattie
  • Date: 2019-02-19 09:38:13 UTC
  • Revision ID: sbeattie@ubuntu.com-20190219093813-ud526ee6hwn8nljz
The AppArmor project has been converted to git and is now hosted on
gitlab.

To get the converted repository, please do
  git clone https://gitlab.com/apparmor/apparmor

Show diffs side-by-side

added added

removed removed

Lines of Context:
kernel-patches/4.6/0005-apparmor-exec-should-not-be-returning-ENOENT-when-it.patch
1
 
From c1216728b7d644443eef31e4bd9d01b4a0a51d61 Mon Sep 17 00:00:00 2001
2
 
From: John Johansen <john.johansen@canonical.com>
3
 
Date: Fri, 25 Jul 2014 04:02:03 -0700
4
 
Subject: [PATCH 05/27] apparmor: exec should not be returning ENOENT when it
5
 
 denies
6
 
 
7
 
The current behavior is confusing as it causes exec failures to report
8
 
the executable is missing instead of identifying that apparmor
9
 
caused the failure.
10
 
 
11
 
Signed-off-by: John Johansen <john.johansen@canonical.com>
12
 
Acked-by: Seth Arnold <seth.arnold@canonical.com>
13
 
---
14
 
 security/apparmor/domain.c | 2 +-
15
 
 1 file changed, 1 insertion(+), 1 deletion(-)
16
 
 
17
 
diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c
18
 
index dc0027b..67a7418 100644
19
 
--- a/security/apparmor/domain.c
20
 
+++ b/security/apparmor/domain.c
21
 
@@ -433,7 +433,7 @@ int apparmor_bprm_set_creds(struct linux_binprm *bprm)
22
 
                                new_profile = aa_get_newest_profile(ns->unconfined);
23
 
                                info = "ux fallback";
24
 
                        } else {
25
 
-                               error = -ENOENT;
26
 
+                               error = -EACCES;
27
 
                                info = "profile not found";
28
 
                                /* remove MAY_EXEC to audit as failure */
29
 
                                perms.allow &= ~MAY_EXEC;
30
 
2.7.4
31