2
// ExpressionOfCompatibleTypeCastIssue.cs
5
// Ciprian Khlud <ciprian.mustiata@yahoo.com>
7
// Copyright (c) 2013 Ciprian Khlud <ciprian.mustiata@yahoo.com>
9
// Permission is hereby granted, free of charge, to any person obtaining a copy
10
// of this software and associated documentation files (the "Software"), to deal
11
// in the Software without restriction, including without limitation the rights
12
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
13
// copies of the Software, and to permit persons to whom the Software is
14
// furnished to do so, subject to the following conditions:
16
// The above copyright notice and this permission notice shall be included in
17
// all copies or substantial portions of the Software.
19
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
20
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
21
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
22
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
23
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
24
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
26
using System.Collections.Generic;
27
using ICSharpCode.NRefactory.CSharp.Resolver;
28
using ICSharpCode.NRefactory.Semantics;
29
using ICSharpCode.NRefactory.TypeSystem;
31
namespace ICSharpCode.NRefactory.CSharp.Refactoring
33
/* [IssueDescription("Type cast expression of compatible type",
34
Description = "Type cast expression of compatible type",
35
Category = IssueCategories.CodeQualityIssues,
36
Severity = Severity.Warning,
37
IssueMarker = IssueMarker.Underline)]*/
38
public class ExpressionOfCompatibleTypeCastIssue : ICodeIssueProvider
40
public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
42
return new GatherVisitor(context).GetIssues();
45
class GatherVisitor : GatherVisitorBase<CastExpressionOfIncompatibleTypeIssue>
47
readonly CSharpConversions conversion;
49
public GatherVisitor(BaseRefactoringContext ctx)
52
conversion = new CSharpConversions(ctx.Compilation);
55
public override void VisitAssignmentExpression(AssignmentExpression assignmentExpression)
57
var rightExpressionType = ctx.Resolve(assignmentExpression.Right).Type;
58
if (rightExpressionType.Kind == TypeKind.Class)
60
var leftExpressionType = ctx.Resolve(assignmentExpression.Left).Type;
61
VisitTypeCastExpression(assignmentExpression, leftExpressionType,
65
private AstType CreateShortType(AstNode node, IType fullType)
67
var builder = ctx.CreateTypeSytemAstBuilder(node);
68
return builder.ConvertType(fullType);
71
void VisitTypeCastExpression(AssignmentExpression expression, IType exprType, IType castToType)
73
if (exprType.Kind == TypeKind.Unknown || castToType.Kind == TypeKind.Unknown)
75
var foundConversion = conversion.ExplicitConversion(exprType, castToType);
76
if (foundConversion == Conversion.None)
78
if (!foundConversion.IsExplicit)
81
AddIssue(expression, string.Format(ctx.TranslateString("Cast to '{0}'"), castToType.Name),
83
var right = expression.Right.Clone();
84
var castRight = right.CastTo(CreateShortType(expression, castToType));
85
script.Replace(expression.Right, castRight);
b'\\ No newline at end of file'