← Back to branch summary

~ubuntu-branches/ubuntu/trusty/monodevelop/trusty-proposed

« back to all changes in this revision

Viewing changes to external/nrefactory/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/MethodOverloadHidesOptionalParameterIssue.cs

  • Committer: Package Import Robot
  • Author(s): Jo Shields
  • Date: 2013-05-12 09:46:03 UTC
  • mto: This revision was merged to the branch mainline in revision 29.
  • Revision ID: package-import@ubuntu.com-20130512094603-mad323bzcxvmcam0
Tags: upstream-4.0.5+dfsg
Import upstream version 4.0.5+dfsg

Show diffs side-by-side

added added

removed removed

Lines of Context:
external/nrefactory/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/MethodOverloadHidesOptionalParameterIssue.cs
 
1
// 
 
2
// MethodOverloadHidesOptionalParameterIssue.cs
 
3
// 
 
4
// Author:
 
5
//      Mansheng Yang <lightyang0@gmail.com>
 
6
// 
 
7
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
 
8
// 
 
9
// Permission is hereby granted, free of charge, to any person obtaining a copy
 
10
// of this software and associated documentation files (the "Software"), to deal
 
11
// in the Software without restriction, including without limitation the rights
 
12
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 
13
// copies of the Software, and to permit persons to whom the Software is
 
14
// furnished to do so, subject to the following conditions:
 
15
// 
 
16
// The above copyright notice and this permission notice shall be included in
 
17
// all copies or substantial portions of the Software.
 
18
// 
 
19
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 
20
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 
21
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 
22
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 
23
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 
24
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 
25
// THE SOFTWARE.
 
26
 
 
27
using System.Collections.Generic;
 
28
using System.Linq;
 
29
using ICSharpCode.NRefactory.Semantics;
 
30
using ICSharpCode.NRefactory.TypeSystem;
 
31
 
 
32
namespace ICSharpCode.NRefactory.CSharp.Refactoring
 
33
{
 
34
        [IssueDescription ("Method with optional parameter is hidden by overload",
 
35
                                           Description = "Method with optional parameter is hidden by overload",
 
36
                                           Category = IssueCategories.CodeQualityIssues,
 
37
                                           Severity = Severity.Warning,
 
38
                                           IssueMarker = IssueMarker.Underline,
 
39
                       ResharperDisableKeyword = "MethodOverloadWithOptionalParameter")]
 
40
        public class MethodOverloadHidesOptionalParameterIssue : ICodeIssueProvider
 
41
        {
 
42
                public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
 
43
                {
 
44
                        return new GatherVisitor (context).GetIssues ();
 
45
                }
 
46
 
 
47
                class GatherVisitor : GatherVisitorBase<MethodOverloadHidesOptionalParameterIssue>
 
48
                {
 
49
                        public GatherVisitor(BaseRefactoringContext ctx)
 
50
                                : base (ctx)
 
51
                        {
 
52
                        }
 
53
 
 
54
                        public override void VisitMethodDeclaration (MethodDeclaration methodDeclaration)
 
55
                        {
 
56
                                base.VisitMethodDeclaration (methodDeclaration);
 
57
 
 
58
                                var resolveResult = ctx.Resolve (methodDeclaration) as MemberResolveResult;
 
59
                                if (resolveResult == null)
 
60
                                        return;
 
61
                                var method = resolveResult.Member as IMethod;
 
62
                                if (method == null)
 
63
                                        return;
 
64
 
 
65
                                if (method.Parameters.Count == 0 || !method.Parameters.Last ().IsOptional)
 
66
                                        return;
 
67
 
 
68
                                var overloads = method.DeclaringType.GetMethods(m => m.Name == method.Name && m.TypeParameters.Count == method.TypeParameters.Count)
 
69
                                        .ToArray ();
 
70
 
 
71
                                var parameterNodes = methodDeclaration.Parameters.ToArray();
 
72
                                var parameters = new List<IParameter> ();
 
73
                                for (int i = 0; i < method.Parameters.Count; i++) {
 
74
                                        if (method.Parameters [i].IsOptional && 
 
75
                                                overloads.Any (m => ParameterListComparer.Instance.Equals (parameters, m.Parameters))) {
 
76
                                                AddIssue (parameterNodes [i].StartLocation, parameterNodes.Last ().EndLocation,
 
77
                                                        ctx.TranslateString ("Method with optional parameter is hidden by overload"));
 
78
                                                break;
 
79
                                        }
 
80
                                        parameters.Add (method.Parameters [i]);
 
81
                                }
 
82
                        }
 
83
                }
 
84
        }
 
85
}