← Back to branch summary

~ubuntu-branches/ubuntu/trusty/monodevelop/trusty-proposed

« back to all changes in this revision

Viewing changes to external/nrefactory/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/NegativeRelationalExpressionIssue.cs

  • Committer: Package Import Robot
  • Author(s): Jo Shields
  • Date: 2013-05-12 09:46:03 UTC
  • mto: This revision was merged to the branch mainline in revision 29.
  • Revision ID: package-import@ubuntu.com-20130512094603-mad323bzcxvmcam0
Tags: upstream-4.0.5+dfsg
Import upstream version 4.0.5+dfsg

Show diffs side-by-side

added added

removed removed

Lines of Context:
external/nrefactory/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/NegativeRelationalExpressionIssue.cs
 
1
// 
 
2
// NegativeRelationalExpressionIssue.cs
 
3
// 
 
4
// Author:
 
5
//      Mansheng Yang <lightyang0@gmail.com>
 
6
// 
 
7
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
 
8
// 
 
9
// Permission is hereby granted, free of charge, to any person obtaining a copy
 
10
// of this software and associated documentation files (the "Software"), to deal
 
11
// in the Software without restriction, including without limitation the rights
 
12
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 
13
// copies of the Software, and to permit persons to whom the Software is
 
14
// furnished to do so, subject to the following conditions:
 
15
// 
 
16
// The above copyright notice and this permission notice shall be included in
 
17
// all copies or substantial portions of the Software.
 
18
// 
 
19
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 
20
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 
21
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 
22
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 
23
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 
24
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 
25
// THE SOFTWARE.
 
26
 
 
27
using System.Collections.Generic;
 
28
using ICSharpCode.NRefactory.TypeSystem;
 
29
 
 
30
namespace ICSharpCode.NRefactory.CSharp.Refactoring
 
31
{
 
32
        [IssueDescription ("Simplify negative relational expression",
 
33
                                           Description = "Simplify negative relational expression",
 
34
                                           Category = IssueCategories.Improvements,
 
35
                                           Severity = Severity.Suggestion,
 
36
                                           IssueMarker = IssueMarker.Underline)]
 
37
        public class NegativeRelationalExpressionIssue : ICodeIssueProvider
 
38
        {
 
39
                public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
 
40
                {
 
41
                        return new GatherVisitor (context).GetIssues ();
 
42
                }
 
43
 
 
44
                class GatherVisitor : GatherVisitorBase<NegativeRelationalExpressionIssue>
 
45
                {
 
46
                        public GatherVisitor (BaseRefactoringContext ctx)
 
47
                                : base (ctx)
 
48
                        {
 
49
                        }
 
50
 
 
51
                        bool IsFloatingPoint (AstNode node)
 
52
                        {
 
53
                                var typeDef = ctx.Resolve (node).Type.GetDefinition ();
 
54
                                return typeDef != null &&
 
55
                                        (typeDef.KnownTypeCode == KnownTypeCode.Single || typeDef.KnownTypeCode == KnownTypeCode.Double);
 
56
                        }
 
57
 
 
58
                        public override void VisitUnaryOperatorExpression (UnaryOperatorExpression unaryOperatorExpression)
 
59
                        {
 
60
                                base.VisitUnaryOperatorExpression (unaryOperatorExpression);
 
61
 
 
62
                                if (unaryOperatorExpression.Operator != UnaryOperatorType.Not)
 
63
                                        return;
 
64
 
 
65
                                var expr = unaryOperatorExpression.Expression;
 
66
                                while (expr != null && expr is ParenthesizedExpression)
 
67
                                        expr = ((ParenthesizedExpression)expr).Expression;
 
68
 
 
69
                                var binaryOperatorExpr = expr as BinaryOperatorExpression;
 
70
                                if (binaryOperatorExpr == null)
 
71
                                        return;
 
72
 
 
73
                                var negatedOp = CSharpUtil.NegateRelationalOperator(binaryOperatorExpr.Operator);
 
74
                                if (negatedOp == BinaryOperatorType.Any)
 
75
                                        return;
 
76
 
 
77
                                if (IsFloatingPoint (binaryOperatorExpr.Left) || IsFloatingPoint (binaryOperatorExpr.Right)) {
 
78
                                        if (negatedOp != BinaryOperatorType.Equality && negatedOp != BinaryOperatorType.InEquality)
 
79
                                                return;
 
80
                                }
 
81
 
 
82
                                AddIssue (unaryOperatorExpression, ctx.TranslateString ("Simplify negative relational expression"),
 
83
                                        script => script.Replace (unaryOperatorExpression,
 
84
                                                new BinaryOperatorExpression (binaryOperatorExpr.Left.Clone (), negatedOp,
 
85
                                                        binaryOperatorExpr.Right.Clone ())));
 
86
                        }
 
87
                        
 
88
                        public override void VisitOperatorDeclaration(OperatorDeclaration operatorDeclaration)
 
89
                        {
 
90
                                if (operatorDeclaration.OperatorType.IsComparisonOperator()) {
 
91
                                        // Ignore operator declaration; within them it's common to define one operator
 
92
                                        // by negating another.
 
93
                                        return;
 
94
                                }
 
95
                                base.VisitOperatorDeclaration(operatorDeclaration);
 
96
                        }
 
97
                }
 
98
        }
 
99
}