← Back to branch summary

~ubuntu-branches/ubuntu/trusty/monodevelop/trusty-proposed

« back to all changes in this revision

Viewing changes to external/nrefactory/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ThreadStaticOnInstanceFieldIssue.cs

  • Committer: Package Import Robot
  • Author(s): Jo Shields
  • Date: 2013-05-12 09:46:03 UTC
  • mto: This revision was merged to the branch mainline in revision 29.
  • Revision ID: package-import@ubuntu.com-20130512094603-mad323bzcxvmcam0
Tags: upstream-4.0.5+dfsg
Import upstream version 4.0.5+dfsg

Show diffs side-by-side

added added

removed removed

Lines of Context:
external/nrefactory/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ThreadStaticOnInstanceFieldIssue.cs
 
1
//
 
2
// ThreadStaticOnInstanceFieldIssue.cs
 
3
//
 
4
// Author:
 
5
//       Simon Lindgren <simon.n.lindgren@gmail.com>
 
6
//
 
7
// Copyright (c) 2012 Simon Lindgren
 
8
//
 
9
// Permission is hereby granted, free of charge, to any person obtaining a copy
 
10
// of this software and associated documentation files (the "Software"), to deal
 
11
// in the Software without restriction, including without limitation the rights
 
12
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 
13
// copies of the Software, and to permit persons to whom the Software is
 
14
// furnished to do so, subject to the following conditions:
 
15
//
 
16
// The above copyright notice and this permission notice shall be included in
 
17
// all copies or substantial portions of the Software.
 
18
//
 
19
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 
20
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 
21
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 
22
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 
23
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 
24
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 
25
// THE SOFTWARE.
 
26
using System.Collections.Generic;
 
27
using System;
 
28
using ICSharpCode.NRefactory.TypeSystem;
 
29
using ICSharpCode.NRefactory.Semantics;
 
30
 
 
31
namespace ICSharpCode.NRefactory.CSharp.Refactoring
 
32
{
 
33
        [IssueDescription("The ThreadStatic attribute does nothing on instance fields",
 
34
                          Description = "Finds usages of ThreadStatic on instance fields.",
 
35
                          Category = IssueCategories.Notifications,
 
36
                          Severity = Severity.Warning,
 
37
                      ResharperDisableKeyword = "ThreadStaticAtInstanceField")]
 
38
        public class ThreadStaticOnInstanceFieldIssue : ICodeIssueProvider
 
39
        {
 
40
                public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
 
41
                {
 
42
                        return new GatherVisitor(context).GetIssues();
 
43
                }
 
44
                
 
45
                class GatherVisitor : GatherVisitorBase<ThreadStaticOnInstanceFieldIssue>
 
46
                {
 
47
                        ITypeDefinition threadStaticDefinition;
 
48
 
 
49
                        public GatherVisitor(BaseRefactoringContext context) : base (context)
 
50
                        {
 
51
                                var type = typeof(ThreadStaticAttribute).ToTypeReference().Resolve(ctx.Compilation.TypeResolveContext);
 
52
                                threadStaticDefinition = type.GetDefinition();
 
53
                        }
 
54
 
 
55
                        public override void VisitFieldDeclaration(FieldDeclaration fieldDeclaration)
 
56
                        {
 
57
                                if (fieldDeclaration.Modifiers.HasFlag(Modifiers.Static))
 
58
                                        return;
 
59
 
 
60
                                foreach (var attributeSection in fieldDeclaration.Attributes) {
 
61
                                        int attributeCount = attributeSection.Attributes.Count;
 
62
                                        foreach (var attribute in attributeSection.Attributes) {
 
63
                                                var resolvedAttribute = ctx.Resolve(attribute.Type) as TypeResolveResult;
 
64
                                                if (resolvedAttribute == null)
 
65
                                                        continue;
 
66
                                                if (threadStaticDefinition.Equals(resolvedAttribute.Type.GetDefinition())) {
 
67
                                                        string title = ctx.TranslateString("ThreadStatic does nothing on instance fields");
 
68
                                                        if (attributeCount == 1)
 
69
                                                                AddIssue(attributeSection, title, GetActions(attribute, attributeSection, fieldDeclaration));
 
70
                                                        else
 
71
                                                                AddIssue(attribute, title, GetActions(attribute, attributeSection, fieldDeclaration));
 
72
                                                }
 
73
                                        }
 
74
                                }
 
75
                        }
 
76
 
 
77
                        IEnumerable<CodeAction> GetActions(Attribute attribute, AttributeSection attributeSection, FieldDeclaration fieldDeclaration)
 
78
                        {
 
79
                                string removeAttributeMessage = ctx.TranslateString("Remove attribute");
 
80
                                yield return new CodeAction(removeAttributeMessage, script => {
 
81
                                        if (attributeSection.Attributes.Count > 1) {
 
82
                                                var newSection = new AttributeSection();
 
83
                                                newSection.AttributeTarget = attributeSection.AttributeTarget;
 
84
                                                foreach (var attr in attributeSection.Attributes) {
 
85
                                                        if (attr != attribute)
 
86
                                                                newSection.Attributes.Add((Attribute)attr.Clone());
 
87
                                                }
 
88
                                                script.Replace(attributeSection, newSection);
 
89
                                        } else {
 
90
                                                script.Remove(attributeSection);
 
91
                                        }
 
92
                                }, attribute);
 
93
 
 
94
                                var makeStaticMessage = ctx.TranslateString("Make the field static");
 
95
                                yield return new CodeAction(makeStaticMessage, script => {
 
96
                                        var newDeclaration = (FieldDeclaration)fieldDeclaration.Clone();
 
97
                                        newDeclaration.Modifiers |= Modifiers.Static;
 
98
                                        script.Replace(fieldDeclaration, newDeclaration);
 
99
                                }, fieldDeclaration.NameToken);
 
100
                        }
 
101
                }
 
102
        }
 
103
}
 
104