1
commit c28506b7b2fb0f34448fe6a52f5a31adcb1897ab
2
Author: Peng Huang <shawn.p.huang@gmail.com>
3
Date: 2010-11-25 11:28:22 +0900
9
commit cd7385f4cc1e729891bd878db12dfafad397b098
1
commit 2de728588c4ad8148a6d60092eb6db5d29766cab
2
Author: Peng Huang <shawn.p.huang@gmail.com>
3
Date: 2011-04-18 17:07:51 -0400
5
patch from issue 4442059
9
commit e3957545d18900109e19d607ad17eac136a38d1c
10
Author: Peng Huang <shawn.p.huang@gmail.com>
11
Date: 2011-04-18 11:18:27 -0400
13
Use g_initable_new to create BusFactoryProxy.
18
Review URL: http://codereview.appspot.com/4446051
22
commit 0838133ce617c6113574f12ab1ba6a8bb90aaf43
23
Author: Peng Huang <shawn.p.huang@gmail.com>
24
Date: 2011-04-08 23:29:23 -0400
26
Revert "Change default values of some config."
28
This change was commited by mistake.
30
This reverts commit ed4775b5fec355c1ccb13947d03dcac0aaaeb47f.
34
commit 0f08033ed8ea8fc494a459909722b19eb6e53427
35
Author: Peng Huang <shawn.p.huang@gmail.com>
36
Date: 2011-04-08 09:45:18 -0400
38
Fix problem in creating IBusPoxy in synchronous mode.
42
commit 2f358544a1fcc9c8c3924a722b38a86d297c9da1
43
Author: Peng Huang <shawn.p.huang@gmail.com>
44
Date: 2011-04-08 09:49:20 -0400
46
Refine RequestName code and fix make dpkg errors.
51
Review URL: http://codereview.appspot.com/4368056
57
M debian/libibus-1.0-0.symbols
64
commit 782566b452ca688e619bc66015bf9e8b0685ef41
65
Author: Peng Huang <shawn.p.huang@gmail.com>
66
Date: 2011-04-08 09:19:13 -0400
68
Fix focus issue when reconnect to ibus-daemon
73
Review URL: http://codereview.appspot.com/4365049
77
M client/gtk2/ibusimcontext.c
79
commit 37e6e58792bef4284653e4d8f4c93c901780eafd
80
Author: Takao Fujiwara <takao.fujiwara1@gmail.com>
81
Date: 2011-04-08 09:18:23 -0400
83
Implement APIs for another non-Python panel.
85
1. Support icon and prop_list = null in ibus_property_new with GIR.
86
2. Add getter methods in IBusText and IBusProperty since GJS cannot access
87
the members in C-Structure.
88
3. Add ibus_get_language_name() since GIR libxml2 does not provide the
90
4. Implement flags in ibus_bus_request_name() to follow DBus
91
RequestName signal spec.
92
http://dbus.freedesktop.org/doc/dbus-specification.html#message-bus-names
93
This is needed to terminate the current IBus panel.
94
E.g. IBus GTK panel is launched by ibus-daemon but another panel is
95
launched by gnome-shell.
96
5. Support IBUS_BUS_NAME_FLAG_ALLOW_REPLACEMENT in ui/gtk/main.py
97
6. Fix bus_component_set_factory() not to call
98
bus_component_factory_destroy_cb() twice.
99
7. Hide ibus_text_new_from_static_string() for GIR.
100
8. Add ibus_is_running_gnome_shell() for ibus-ui-gtk because
101
gnome-shell runs earlier than ibus-ui-gtk.
103
Review URL: http://codereview.appspot.com/4279042
104
Patch from Takao Fujiwara <takao.fujiwara1@gmail.com>.
111
M bus/marshalers.list
127
commit ac30990eddbe9e4a0f9b08cc86155654d8fb3c3d
128
Author: Daiki Ueno <ueno@unixuser.org>
129
Date: 2011-04-08 10:11:39 +0900
131
Export surrounding-text API to Python.
134
TEST=manually with modified ibus-anthy https://github.com/ueno/ibus-anthy/commit/2303095f
136
Review URL: http://codereview.appspot.com/4377045
139
M ibus/interface/iengine.py
141
commit 65c5465863bc4d9408cbec5ac0ef7f98d5db779f
142
Author: Peng Huang <shawn.p.huang@gmail.com>
143
Date: 2011-04-05 10:27:32 -0400
145
Fix make dpkg errors.
150
Review URL: http://codereview.appspot.com/4324047
152
M debian/libibus-1.0-0.symbols
155
commit 06e6abee9f221bdf7c277538ce136154465619d7
156
Author: Daiki Ueno <daiki.ueno@gmail.com>
157
Date: 2011-04-05 10:11:49 -0400
159
Support surrounding-text retrieval.
161
Unlike the GtkIMContext API, IBus automatically retrieves
162
surrounding-text when certain events occurred to the
163
client ("before filter_keypress", for example). This makes the
164
engine API simpler but causes periodical emission of D-Bus
165
signals for updating surrounding-text information, which is
166
unwanted for typical engines.
168
For this reason, the surrounding-text support is currently
169
disabled by default. To enable it, pass
170
--enable-surrounding-text to configure. Also, even
171
surrounding-text support is compiled in, IBus does not start
172
polling until an engine requests surrounding-text using
173
ibus_engine_get_surrounding_text(). To make the function work
174
for the first time, clients should retrieve
175
initial surrounding-text when the engine is enabled (see ibus_im_context_focus_in() and
176
_ibus_context_enabled_cb() in client/gtk2/ibusimcontext.c).
181
Review URL: http://codereview.appspot.com/4276082
182
Patch from Daiki Ueno <daiki.ueno@gmail.com>.
187
M client/gtk2/ibusimcontext.c
190
M ibus/interface/iengine.py
191
M ibus/interface/iinputcontext.py
194
M src/ibusinputcontext.c
195
M src/ibusinputcontext.h
196
M src/ibusmarshalers.list
198
commit 6a39a86f84fb59c06a246c1bb3f50abbf6c9f8d1
199
Author: Peng Huang <shawn.p.huang@gmail.com>
200
Date: 2011-04-05 10:08:34 -0400
202
Fix a crash during creating IBusProxy asynchronously
204
BUG=chromium-os:13629
207
Review URL: http://codereview.appspot.com/4344061
211
M src/tests/.gitignore
212
M src/tests/Makefile.am
213
A src/tests/ibus-inputcontext-create.c
215
commit 15e29ac3ad45c1b909fc532fe98cf3b09dfb6426
216
Author: fujiwarat <takao.fujiwara1@gmail.com>
217
Date: 2011-04-04 19:33:47 +0900
221
Update ar.po as.po da.po es.po fr.po gu.po hi.po kn.po mr.po nl.po
222
or.po pa.po pl.po pt_BR.po ta.po te.po uk.po zh_CN.po zh_TW.po
246
commit 1428a361cd3b416c4e4da7839f4a3ec23a67eb12
247
Author: fujiwarat <takao.fujiwara1@gmail.com>
248
Date: 2011-03-31 12:56:45 +0900
250
Use ibus panel icon from the desktop theme instead of ibus-keyboard.
256
commit ed4775b5fec355c1ccb13947d03dcac0aaaeb47f
257
Author: James Su <james.su@gmail.com>
258
Date: 2010-05-12 15:38:42 -0700
260
Change default values of some config.
262
This CL changes the default value of use_global_engine, enable_by_default and use_sys_layout to TRUE. And also removes the default trigger key.
267
Review URL: http://codereview.chromium.org/2008016
271
commit ef2be0415bbe948ce4be39b8a5d2bc60c3384bb2
272
Author: Daiki Ueno <daiki.ueno@gmail.com>
273
Date: 2011-03-29 09:39:44 -0400
275
Use gtk_status_icon_set_name() only if it is available.
277
gtk_status_icon_set_name() is not exported to python through pygtk2 <= 2.17,
278
which is the version from Debian sid and Fedora 14.
281
>>> gtk.pygtk_version
283
>>> hasattr(gtk.StatusIcon, 'set_name')
286
This patch checks the availability.
291
Review URL: http://codereview.appspot.com/4327042
292
Patch from Daiki Ueno <daiki.ueno@gmail.com>.
296
commit 5ef29602141945ed1255662576c2e8194af78325
297
Author: fujiwarat <takao.fujiwara1@gmail.com>
298
Date: 2011-03-25 13:57:31 +0900
300
Set WM_CLASS name instead of main.py
304
commit 637947404f977b830e2bd9719a292ad48d0dac5b
305
Author: Daiki Ueno <daiki.ueno@gmail.com>
306
Date: 2011-03-25 11:16:18 -0400
308
Add "in" keymap which maps Alt_R to AltGr.
311
TEST=manually with ibus-m17n
313
Review URL: http://codereview.appspot.com/4273109
314
Patch from Daiki Ueno <daiki.ueno@gmail.com>.
316
M data/keymaps/Makefile.am
319
commit ee54659184e384b25b7ee5016a12e1b81415fe66
320
Author: Peng Huang <shawn.p.huang@gmail.com>
321
Date: 2011-03-25 11:07:38 -0400
323
Verify global engine after changing preload_engines
325
BUG=http://crosbug.com/13406
328
Review URL: http://codereview.appspot.com/4273111
332
commit 7903a536375936efb6b8a38fd8f44b8d2ac6a837
333
Author: Peng Huang <shawn.p.huang@gmail.com>
334
Date: 2011-03-23 09:44:20 -0400
336
Fix make debian package errors.
341
Review URL: http://codereview.appspot.com/4279068
343
M debian/libibus-1.0-0.symbols
345
commit cff009de738fe0a6cb0cfdd725952b928afc6c58
346
Author: Peng Huang <shawn.p.huang@gmail.com>
347
Date: 2011-03-23 09:44:06 -0400
349
Fix typos in IBusInputContext document
354
Review URL: http://codereview.appspot.com/4273094
356
M src/ibusinputcontext.h
358
commit 0514dc88147f7f178325f546bf073d0e1a261ddb
359
Author: Peng Huang <shawn.p.huang@gmail.com>
360
Date: 2011-03-23 09:43:43 -0400
362
Use $(SED) to replace sed
367
Review URL: http://codereview.appspot.com/4280059
369
M docs/reference/ibus/Makefile.am
371
commit 597820e6ad9f59f596aec6f714ca6b37f2a991c6
372
Author: Yusuke Sato <yusukes@chromium.org>
373
Date: 2011-03-22 22:36:52 +0900
375
Link appropriate libraries to ibus-scan.
377
TEST=git clone the clean tree, ran ./autogen.sh --enable-gtk-doc, then ran make.
379
Review URL: http://codereview.appspot.com/4289060
381
M docs/reference/ibus/Makefile.am
383
commit 0929e30b91dbb7955c9f90e058bb644ff946298d
384
Author: Yusuke Sato <yusukes@chromium.org>
385
Date: 2011-03-22 14:09:34 +0900
387
Add asynchronous InputContext.IsEnabled and InputContext.GetEngine APIs.
389
* Added asynchronous InputContext.IsEnabled and InputContext.GetEngine APIs. Now
390
all InputContext IPCs can be async.
391
* Added comments to src/ibusinputcontext.h.
392
* Moved input context tests from ibus-bus.c to ibus-inputcontext.c (new file),
393
and fixed flaky tests.
394
* Fixed typos in bus/.
396
BUG=http://code.google.com/p/ibus/issues/detail?id=1215
397
TEST=ran the new test
399
Review URL: http://codereview.appspot.com/4298049
403
M src/ibusinputcontext.c
404
M src/ibusinputcontext.h
405
M src/tests/.gitignore
406
M src/tests/Makefile.am
407
M src/tests/ibus-bus.c
408
A src/tests/ibus-inputcontext.c
410
commit 8306617bc88fc85d818af749ee23ff115c3de5f8
411
Author: Peng Huang <shawn.p.huang@gmail.com>
412
Date: 2011-03-18 09:24:18 -0400
414
Create a separate test case for ibus_bus_create_input_context_async().
416
Create a separate test case for ibus_bus_create_input_context_async(),
417
so we can use `ibus-bus -p /ibus/create-input-context' to test and debug
418
ibus_bus_create_input_context_async() only.
423
Review URL: http://codereview.appspot.com/4298045
425
M src/tests/ibus-bus.c
427
commit 1861184a71b1210d7e07a19fdf90ecc4ce0be7b9
428
Author: Peng Huang <shawn.p.huang@gmail.com>
429
Date: 2011-03-17 10:52:38 -0400
431
Refine document and coding style in ibusbus.[ch] and trim some private structs and api from document
436
Review URL: http://codereview.appspot.com/4290053
439
M docs/reference/ibus/.gitignore
440
M docs/reference/ibus/Makefile.am
441
A docs/reference/ibus/trim.sed
446
commit 13697b0aec5efcb999d02720170fe968ac6dfaba
447
Author: Peng Huang <shawn.p.huang@gmail.com>
448
Date: 2011-03-17 10:49:03 -0400
450
Do not block UI in IBusIMContext anymore.
452
Replace some block IPC calls with async IPC calls, and then IBusIMContext will
453
not block UI anymore.
455
BUG=http://crosbug.com/12310
458
Review URL: http://codereview.appspot.com/4287054
462
M client/gtk2/ibusimcontext.c
463
M debian/libibus-1.0-0.symbols
466
M src/ibusinputcontext.c
467
M src/ibusinputcontext.h
468
M src/tests/ibus-bus.c
470
commit b9b2c42596e1a7394e89c11025074aed2fcb099a
471
Author: Peng Huang <shawn.p.huang@gmail.com>
472
Date: 2011-03-16 10:02:47 -0400
474
Fix issue of InputContext.SetEngine.
476
InputContext.SetEngine returns error sometimes, because "request-engine"
477
signal handler calls an async function to set the engine of the context.
478
So checking context->engine != NULL just after emiting "request-engine"
479
signal is not correct.
484
Review URL: http://codereview.appspot.com/4287049
488
M bus/marshalers.list
490
commit 14b7d1a071c08c327ab836a2b7bd3e3b2ab7d1af
491
Author: Peng Huang <shawn.p.huang@gmail.com>
492
Date: 2011-03-16 10:01:18 -0400
494
Add git.mk from gtk+ project, Use it to update .gitignore
499
Review URL: http://codereview.appspot.com/4280050
503
M bindings/Makefile.am
504
M bindings/vala/Makefile.am
508
M client/gtk2/Makefile.am
509
M client/gtk3/Makefile.am
510
M client/x11/.gitignore
511
M client/x11/Makefile.am
514
M data/icons/Makefile.am
515
M data/keymaps/Makefile.am
519
M docs/reference/Makefile.am
520
M docs/reference/ibus/.gitignore
521
M docs/reference/ibus/Makefile.am
527
M ibus/interface/Makefile.am
530
M memconf/Makefile.am
536
M src/tests/.gitignore
537
M src/tests/Makefile.am
541
M util/IMdkit/Makefile.am
544
commit 596680ba3cfd5aa8e4c2ef4bd5905a25c4c855b0
545
Author: Peng Huang <shawn.p.huang@gmail.com>
546
Date: 2011-03-15 13:32:55 -0400
553
Review URL: http://codereview.appspot.com/4277054
555
M docs/reference/ibus/Makefile.am
556
D docs/reference/ibus/ibus-sections.txt
559
commit 71bcf46f2aac7a81291bf2782915b8bf4cc36edf
560
Author: Zach Kuznia <zork@chromium.org>
561
Date: 2011-03-14 15:42:32 +0900
563
This can cause crashes on cleanup when multiple components are implemented in the same process.
565
Review URL: http://codereview.appspot.com/4241058
566
Patch from Zach Kuznia <zork@chromium.org>.
570
commit 26084822d7ac9395b4553a7852a78d6d0d4bed0f
571
Author: fujiwarat <takao.fujiwara1@gmail.com>
572
Date: 2011-03-11 15:53:53 +0900
574
Fix preedit_string = NULL in ibus-x11 _free_ic()
578
commit 5617ef1553bccb4894ef2e83f2021fda7ca6b815
579
Author: Peng Huang <shawn.p.huang@gmail.com>
580
Date: 2011-03-11 10:37:40 -0500
587
Review URL: http://codereview.appspot.com/4250077
591
commit 57eee844b6087c188be1c7f8676d2c5acdf89a7d
592
Author: Yusuke Sato <yusukes@chromium.org>
593
Date: 2011-03-10 08:44:38 +0900
598
./configure --enable-gtk-doc
600
cp ppa/ibus-1.3.99.20110309/debian/libibus-1.0-0/DEBIAN/symbols debian/libibus-1.0-0.symbols
601
vi debian/libibus-1.0-0.symbols # remove "-1phuang1~maverick1"
602
make dpkg # confirm that lintian does not report an error.
604
Review URL: http://codereview.appspot.com/4253068
606
M debian/libibus-1.0-0.symbols
608
commit 32367ad614c9f4bceb55eb812860ea8ae674925e
609
Author: Yusuke Sato <yusukes@chromium.org>
610
Date: 2010-09-15 12:25:17 +0900
612
Fix issues of the "previous_engine" hotkey.
614
Check global_previous_engine_name when the previous engine is requested and rewrite it if necessary.
615
This change ensures that the "previous_engine" hotkey (Ctrl+space on Chrome OS) always works
616
whenever two or more engines are preloaded.
618
Currently, Ctrl+space could become NOP by the following scenarios (http://crosbug.com/6609):
621
1. preload engines A, B, C.
624
4. at this point, ctrl+space works fine. It selectes A and B alternately.
626
6. remove B from the preloaded engline list.
627
7. at this point, ctrl+space suddenly becomes NOP although C is still preloaded.
628
This is because the callback function of ctrl+space detects
629
global_previous_engine_name (i.e. B) is removed and automatically selects A (not
630
C) as a global_previous_engine_name.
633
1. preload engines A, B.
636
4. at this point, ctrl+space works fine. It selectes A and B alternately.
638
6. remove B from the preloaded engline list.
639
7. press ctrl+space several times, confirm that nothing happens (this is
640
expected since only one engine, A, is preloaded).
641
8. preload additional engine, C.
642
9. at this point, ctrl+space is still NOP although two engines, A and C, are
647
commit 2fbbf4312d4b33885aa36df7b8d966c6ebf698c6
648
Author: James Su <james.su@gmail.com>
649
Date: 2010-05-26 22:31:06 -0700
651
If the current engine is removed, then switch to another engine automatically.
653
BUG=http://crosbug.com/3577
656
Review URL: http://codereview.chromium.org/2259004
660
commit f4eae684f5e83af489b3d36662f9eddb79a0cc8e
661
Author: Yusuke Sato <yusukes@chromium.org>
662
Date: 2011-03-08 21:57:10 +0900
664
Remove -Wall warnings.
666
Review URL: http://codereview.appspot.com/4261056
668
M client/gtk2/ibusimcontext.c
669
M src/tests/ibus-bus.c
671
commit 3980dd91d097a009e0967a122f284e5e4cfd07c6
672
Author: Yusuke Sato <yusukes@chromium.org>
673
Date: 2011-03-08 00:55:36 +0900
675
Add asynchronous APIs to ibusbus.h
677
Modified src/tests/ibus-bus.c so that it could be compiled with ibus-1.3.99 as well.
679
BUG=chromium-os:12581
680
TEST=added async api tests to the src/tests/ibus-bus.c and ran it locally.
682
Review URL: http://codereview.appspot.com/4179061
686
M src/tests/ibus-bus.c
688
commit fbdd157b2ab1e6e873818132530dd9e55e4f94dd
689
Author: Peng Huang <shawn.p.huang@gmail.com>
690
Date: 2011-03-07 10:26:04 -0500
692
Move gtk_key_snooper_remove from function object_fini to class_fini.
694
BUG=http://crosbug.com/12803
697
Review URL: http://codereview.appspot.com/4267044
699
M client/gtk2/ibusimcontext.c
701
commit 279ee5d5b3697b427cc22cd99a55f4e611318e25
702
Author: Peng Huang <shawn.p.huang@gmail.com>
703
Date: 2011-03-01 15:34:37 -0500
705
Optimize focus_in to avoid call some UI blocking functions.
707
focus_in calls some X blocking functions. It will block UI. This change delays the X blocking calls to idle callback, to avoid blocking UI.
709
BUG=http://crbug.com/74237
712
Review URL: http://codereview.appspot.com/4254048
714
M client/gtk2/ibusimcontext.c
716
commit 690be230c116afd52a6002d2ef92b56e28d829b1
717
Author: Peng Huang <shawn.p.huang@gmail.com>
718
Date: 2011-02-28 15:57:47 -0500
720
Unify async and sync function names.
725
Review URL: http://codereview.appspot.com/4246042
727
M client/gtk2/ibusimcontext.c
729
M debian/libibus-1.0-0.symbols
730
M src/ibusinputcontext.c
731
M src/ibusinputcontext.h
733
commit 31b3b6a9577bb4c2787c73675f53ba38647a1501
734
Author: Peng Huang <shawn.p.huang@gmail.com>
735
Date: 2011-02-28 10:25:54 -0500
737
Fix a race problem in SetGlobalEngine and add set_global_engine in python library
740
1. global engine == A
741
2. call SetGlobalEngine(B) asynchronously
742
3. call SetGlobalEngine(A) immediately
743
3.1 Because step 2 is not finished, so the global engine is still A,
744
and SetGlobalEngine(A) returns sucessfully.
745
4. SetGlobalEngine(B) is completed and the global engine becomes B
747
BUG=http://crosbug.com/12414
750
Review URL: http://codereview.appspot.com/4250041
754
M ibus/interface/iibus.py
756
commit 8ebad5f07b1ba821e278d4d04ab74e2d31a40139
757
Author: fujiwarat <takao.fujiwara1@gmail.com>
758
Date: 2011-02-19 04:52:40 +0900
760
Call gtk_key_snooper_remove when GTK IM client is switched.
762
M client/gtk2/ibusimcontext.c
764
commit fb153c2a95746fde7a166775c65d281cb757cbfa
765
Author: Peng Huang <shawn.p.huang@gmail.com>
766
Date: 2011-02-18 10:59:49 -0500
768
Fix make dpkg errors.
773
Review URL: http://codereview.appspot.com/4184055
775
M debian/libibus-1.0-0.symbols
777
commit 0b02c819eee5d7cf9b7be449887677af76ee4731
778
Author: Peng Huang <shawn.p.huang@gmail.com>
779
Date: 2011-02-18 10:59:06 -0500
781
Add enable_conditional and disable_conditional in gconf schemas file
786
Review URL: http://codereview.appspot.com/4183057
788
M data/ibus.schemas.in
790
commit d68f26bd70933df9d18d88e98c2079ce8c2f3dc2
791
Author: Peng Huang <shawn.p.huang@gmail.com>
792
Date: 2011-02-18 10:58:27 -0500
794
Fix crash when turn off "use global engine" option
799
Review URL: http://codereview.appspot.com/4170061
803
commit ff5db2e177944df295cf370ee066812223a75b0e
804
Author: Peng Huang <shawn.p.huang@gmail.com>
805
Date: 2011-02-18 09:08:41 -0500
807
Destroy IBusInputContext correctly in ibus-x11
812
Review URL: http://codereview.appspot.com/4178062
816
commit 5bd623d697da442c9107bcb8ecd9012d2e3f8731
817
Author: fujiwarat <takao.fujiwara1@gmail.com>
818
Date: 2011-02-17 15:08:37 +0900
820
s/LC_MESSAGES/LC_CTYPE/ in set_default_preload_engines.
824
commit 9edd39912564e07dc734b5101b2c9995389aa234
825
Author: Peng Huang <shawn.p.huang@gmail.com>
826
Date: 2011-02-16 15:49:09 -0500
828
Do not create GSimpleAsyncResult in ibus_input_context_process_key_event
830
This change also fixes memory leak of simple result object
835
Review URL: http://codereview.appspot.com/4175051
837
M src/ibusinputcontext.c
839
commit d0755b083d954383a791256b2db4f1b3d1f0a001
840
Author: Yusuke Sato <yusukes@chromium.org>
841
Date: 2011-02-16 23:42:27 +0900
843
Add async version of set_global_engine.
845
Patch from Zach Kuznia <zork@chromium.org>, modified by Yusuke Sato <yusukes@chromium.org>.
847
Review URL: http://codereview.appspot.com/4175047
852
commit d9f8ed3e18338afefe4cf0ec2c12ca6d6e76e3b6
853
Author: Yusuke Sato <yusukes@chromium.org>
854
Date: 2011-02-16 15:45:29 +0900
856
Implement async version of ibus_config_set_value.
858
BUG=crosbug.com/11903
860
Review URL: http://codereview.appspot.com/4185041
865
commit 07877cf6f15d4d222738ab18cb9860083581ca82
866
Author: Yusuke Sato <yusukes@chromium.org>
867
Date: 2011-02-15 16:44:05 +0900
869
Add engine_name parameter to the global-engine-changed signal.
871
This makes it possible for a client to know the current global engine w/o issuing GetGlobalEngine reqeust.
873
BUG=chromium-os:11908
875
Review URL: http://codereview.appspot.com/4177045
880
commit 661f1e860ea0d5145485a3c141c811e999f522a4
881
Author: Yusuke Sato <yusukes@chromium.org>
882
Date: 2011-02-15 10:27:03 +0900
884
Use LC_MESSAGES instead of LC_ALL in bus_ibus_impl_set_default_preload_engines.
886
This is a fix for https://bugs.launchpad.net/ubuntu/+source/ibus/+bug/716314. Calling setlocale(LC_ALL, NULL); in the function seems not to be a good idea since the function could return a complex string like "LC_CTYPE=ja_JP.UTF-8;LC_NUMERIC=C;LC..." when two or more values are used for LC_xxx variables (e.g. ja_JP.UTF-8 and C.)
890
Review URL: http://codereview.appspot.com/4160046
894
commit 5743b6da70f7722792c21ec50415dce4f1790af5
895
Author: Yusuke Sato <yusukes@chromium.org>
896
Date: 2011-02-15 10:24:20 +0900
898
Never use ibus's US keymap in bus_input_context_filter_key, and use the keyval from X as-is.
899
I think this is important for supporting non-US keyboards like a Japanese-106 keyboard correctly.
901
Currently, when use_sys_layout config is unchecked (the default), ibus-daemon discards a keyval being passed from X, and regenerates a keyval from a keycode assuming the US layout.
903
However, I believe this behavior is not good for non-US keyboard layout users (e.g. Japanese or Korean keyboard users.) For example, the Japanese 106 keyboard has a key called Zenkaku_Hankaku (全角_半角, whose keycode is 49) on the left hand of the '1' key, and most users want to use the key for toggling IME. But, even if a user set 'Zenkaku_Hankaku' as the toggle hotkey using ibus-setup, the user cannot toggle IME unless the 'Use system keyboard layout' option is explicitly turned on. This is because when use_sys_layout is unchecked, ibus-daemon treats the Zenkaku_Hankaku key press (keycode=49) as tilde (~) key press (remember that the tilde's keycode is also 49 in the US keyboard layout.) This is very inconvenient and confusing.
905
Please also note that the hotkey configuration tool in ibus-setup always respects a keyval from X, and never checks the use_sys_layout value.
907
Review URL: http://codereview.appspot.com/4173046
911
commit c394fea7874df0173cf07d891976086ab343bead
912
Author: Yusuke Sato <yusukes@chromium.org>
913
Date: 2011-02-15 10:22:48 +0900
915
Always call g_simple_async_result_complete in ibus_input_context_process_key_event_done in order to handle IPC errors correctly.
917
Review URL: http://codereview.appspot.com/4171049
919
M src/ibusinputcontext.c
921
commit b2c7173b30fb41925dbef8355477497fba43d887
922
Author: Ahmad Sharif <asharif@chromium.org>
923
Date: 2011-02-12 23:38:35 +0900
925
Fix compiler warnings in util/IMdkit/.
929
Review URL: http://codereview.appspot.com/4171046
930
Patch from Ahmad Sharif <asharif@chromium.org>.
932
M util/IMdkit/i18nPtHdr.c
933
M util/IMdkit/i18nX.c
935
commit 753835819886f7a46f938826632b123287f589f0
936
Author: Yusuke Sato <yusukes@chromium.org>
937
Date: 2011-02-12 22:56:49 +0900
939
Ran 'make update-po' in po/.
943
Review URL: http://codereview.appspot.com/4181044
976
commit b66b337e9a30d55542fbae4611565e47e932ce0a
977
Author: Yusuke Sato <yusukes@chromium.org>
978
Date: 2011-02-11 23:53:34 +0900
980
Reimplement ibus_bus_watch_dbus_signal for GDBus and export it.
982
BUG=crosbug.com/11479
984
Review URL: http://codereview.appspot.com/4186041
989
commit e3140b7206d409419faa0c8bfa50f25ad3644cd0
990
Author: Yusuke Sato <yusukes@chromium.org>
991
Date: 2011-02-11 23:48:42 +0900
993
Support enable/disable hotkeys that enable or disable ibus unconditionally (i.e. not toggle.)
995
I'll update ibus/po/*po files if the change looks good to you.
997
BUG=http://code.google.com/p/ibus/issues/detail?id=1173
1000
Review URL: http://codereview.appspot.com/3807047
1007
commit 377c06515e792c2da4f4cf342ba5faa26eac5170
1008
Author: phuang <shawn.p.huang@gmail.com>
1009
Date: 2011-02-09 21:02:44 +0900
1011
Fix ibus-daemon deadlock in engineproxy.c.
1013
How to reproduce the deadlock on a desktop Linux like Ubuntu Maverick:
1015
1. Add 20 seconds sleep in the beginning of the main() function of an engine (e.g. ibus-engine-mozc). See http://crosbug.com/11379#c16 .
1016
2. Set preload_engines to "mozc" using ibus-setup.
1017
3. Start ibus-daemon.
1018
4. press the trigger hotkey twice within the 20 seconds.
1021
The second trigger hotkey press cancels the bus_engine_proxy_new operation started by the first one.
1024
ibus-daemon freezes. Stack trace: http://crosbug.com/11379#c20
1026
BUG=http://crosbug.com/11379
1027
TEST=see the steps above.
1029
Review URL: http://codereview.appspot.com/4125053
1030
Patch from phuang <shawn.p.huang@gmail.com>.
1033
M bus/inputcontext.c
1035
commit 0501756a1e51469849eca064aeb1e340afbf8be2
1036
Author: fujiwarat <takao.fujiwara1@gmail.com>
1037
Date: 2011-02-09 00:51:39 +0900
1039
Add pkgdatadir in ibus-1.0.pc.in
1043
commit 8199abcde4175971da78141b680eb9bb80fc2ad2
1044
Author: fujiwarat <takao.fujiwara1@gmail.com>
1045
Date: 2011-02-09 00:50:44 +0900
1047
Add GTK3 definitions.
1049
M client/gtk2/ibusimcontext.c
1051
commit 31d1e1c41cc644d3c3c9da2e076728134d3b7439
1052
Author: fujiwarat <takao.fujiwara1@gmail.com>
1053
Date: 2011-02-09 00:50:56 +0900
1057
M client/gtk2/ibusimcontext.c
1059
commit 03c9e591430c62354bbf26ef7bd4a2e6acfb7c8f
1060
Author: Yusuke Sato <yusukes@chromium.org>
1061
Date: 2011-02-03 10:15:24 +0900
1063
Overwrite Gtk+'s default compose table to fix crosbug.com/11421.
1065
BUG=chromium-os:11421
1066
TEST=manually done on Chrome OS.
1068
Review URL: http://codereview.appspot.com/3989060
1070
M client/gtk2/ibusimcontext.c
1072
commit 0e6fa20c2521c5e23fe2f5bdd17bcbdfcf227da8
1073
Author: Peng Huang <shawn.p.huang@gmail.com>
1074
Date: 2011-01-27 18:01:34 -0500
1076
Fix build debian package error.
1081
Review URL: http://codereview.appspot.com/4013046
1083
M debian/libibus-1.0-0.symbols
1085
commit af0c9bcf7483a3d1f4520526f6d08222ae21ec1b
1086
Author: Peng Huang <shawn.p.huang@gmail.com>
1087
Date: 2011-01-27 10:06:09 -0500
1089
Export async version ibus_input_context_process_key_event.
1091
Some application may want to integrate with ibus directly, and want to
1092
use async mode for processing key events. So I make
1093
ibus_input_context_process_key_event to be an async function,
1094
and also added ibus_input_context_process_key_event_sync.
1096
Fix problem in introspection of Engine.
1099
TEST=Tested in Ubuntu 10.10
1101
Review URL: http://codereview.appspot.com/4032044
1103
M client/gtk2/ibusimcontext.c
1105
M debian/libibus-1.0-0.symbols
1106
M src/ibusinputcontext.c
1107
M src/ibusinputcontext.h
1109
commit 8f3bd1b11df8806c596b9b311997f24cbfec1e66
1110
Author: Peng Huang <shawn.p.huang@gmail.com>
1111
Date: 2011-01-26 19:18:05 -0500
1113
Fix problem in introspection of Engine.
1115
BUG=http://code.google.com/p/ibus/issues/detail?id=1194
1116
TEST=Tested in Ubuntu 10.10
1118
Review URL: http://codereview.appspot.com/4084046
1122
commit ea3917659bb7be5ee93ced938d5b522a468f7677
1123
Author: fujiwarat <takao.fujiwara1@gmail.com>
1124
Date: 2011-01-26 13:15:08 +0900
1126
Fix introspection definitions.
1129
M src/ibusinputcontext.h
1131
commit cc1d776aeb65b481b1bd93e1f7acfbe4fea8e1f2
1132
Author: fujiwarat <takao.fujiwara1@gmail.com>
1133
Date: 2011-01-26 14:01:25 +0900
1135
Set QT_IM_MODULE=xim in case of no ibus-qt.
1139
commit 73135d06d2195cee5630918e48003347315eb653
1140
Author: fujiwarat <takao.fujiwara1@gmail.com>
1141
Date: 2011-01-26 14:01:17 +0900
1143
Add signals in IBusPanelService for non-C classes.
1145
M src/ibuspanelservice.c
1146
M src/ibuspanelservice.h
1148
commit f28d3e30cb04dc0eee5a657469f2c8d49d7056e0
1149
Author: fujiwarat <takao.fujiwara1@gmail.com>
1150
Date: 2011-01-24 12:25:48 +0900
1152
Set GdkEventKey time for gdk_event_put with IBUS_FORWARD_MASK.
1154
M client/gtk2/ibusimcontext.c
1156
commit d26f418a3df4a9ad78dd952d997e028ba24c88f9
1157
Author: Yusuke Sato <yusukes@chromium.org>
1158
Date: 2011-01-24 10:56:05 +0900
1160
Add <signal name='ValueChanged'> to introspection_xml in src/ibusconfigservice.c.
1162
I don't think that GDBus library in glib-2.26.[01] uses the information to filter out undefined signals, but just in case.
1167
Review URL: http://codereview.appspot.com/4015043
1169
M src/ibusconfigservice.c
1171
commit e1e72a2052ea3c869002bbba9055eab4a9e88aaa
1172
Author: Peng Huang <shawn.p.huang@gmail.com>
1173
Date: 2011-01-21 10:57:54 -0500
1175
Fix some race conditions during create engine, also fix dpkg build error.
1177
BUG=chromium-os:10750
1178
TEST=on Linux desktop
1180
Review URL: http://codereview.appspot.com/3970044
1183
M debian/libibus-1.0-0.symbols
1185
commit 683e301b689f3fe74769f4a7f2ad1b159e54790d
1186
Author: Yusuke Sato <yusukes@chromium.org>
1187
Date: 2011-01-21 21:03:23 +0900
1189
Emit the connected signal after setting up the connection.
1191
Otherwise, we might miss the first a few DBus and IBus signals.
1193
BUG=http://crosbug.com/11144
1196
Review URL: http://codereview.appspot.com/4029043
1200
commit b5382549a2f4009e0e4da20c7491ba28e7cca60f
1201
Author: Yusuke Sato <yusukes@chromium.org>
1202
Date: 2011-01-19 10:55:16 +0900
1204
Fix race condition between ibus_bus_set_global_engine() and ibus_bus_get_global_engine().
1206
If focus moves between the two API calls, ibus_bus_get_global_engine() might return an unexpected engine name:
1208
1. context A is focused, and the current global engine is "X".
1209
2. ibus_bus_set_global_engine("Y") is called.
1210
3. a user moves the focus from A to B. First, A's engine is set to NULL in bus_ibus_impl_set_focused_context(). Then, in the same function, B's engine is set to "X" (not "Y") since the _ibus_set_global_engine asynchronous call is not finished yet.
1211
4. ibus_bus_set_global_engine("Y") async call successfully finishes. Context A's (not B's) engine is set to "Y", but context B, which has a focus, is not updated.
1212
5. ibus_bus_get_global_engine() is called.
1218
X is returned. Since the context B has a focus, and B's engine is X.
1220
BUG=http://crosbug.com/11031
1223
Review URL: http://codereview.appspot.com/4063041
1227
commit e194133baa0afc7fdb1befc18c2c1f516979a9be
1228
Author: Yusuke Sato <yusukes@chromium.org>
1229
Date: 2011-01-19 10:18:13 +0900
1231
Do not allow clients to destroy the server-side config service for safety.
1233
Unset the own flag of priv->config so that the config proxy object never destroys the config service even if a client wrongly unref()s the priv->config object.
1238
Review URL: http://codereview.appspot.com/4060041
1243
commit 302c85138bac23e7e5faf223119df0d5d04f9b0d
1244
Author: Yusuke Sato <yusukes@chromium.org>
1245
Date: 2011-01-18 22:00:57 +0900
1247
Fix possible SEGV in ibus_bus_get_global_engine.
1249
The g_variant_get returns NULL when the IPC call times out.
1254
Review URL: http://codereview.appspot.com/3974043
1258
commit 6b4874283c510869080eed2c63d61e54f8beeba8
1259
Author: Yusuke Sato <yusukes@chromium.org>
1260
Date: 2011-01-18 21:51:40 +0900
1262
Handle GlobalEngineChanged signals from ibus-daemon.
1264
BUG=http://crosbug.com/11011
1267
Review URL: http://codereview.appspot.com/4037042
1272
commit 469bfe396a0fa680ade8536b9bd9829918be2994
1273
Author: Yusuke Sato <yusukes@chromium.org>
1274
Date: 2011-01-18 10:33:48 +0900
1276
On ChromeOS, we don't have to (and don't want to) set default preload engines.
1281
Review URL: http://codereview.appspot.com/4054041
1285
commit 6a5c7666e1194e8ac8a3d0c3f680269b42fe80c2
1286
Author: Daiki Ueno <ueno@unixuser.org>
1287
Date: 2011-01-17 14:22:18 +0900
1289
Set nonzero serial number for RegistryChanged / EngineChanged signals.
1291
libdbus expects each message serial is greater than 0.
1292
https://code.google.com/p/ibus/issues/detail?id=1186
1295
TEST=manual test described in the issue#1186
1297
Review URL: http://codereview.appspot.com/4050041
1301
commit 990ff3920657584d356c48bebde031405285bf80
1302
Author: Yusuke Sato <yusukes@chromium.org>
1303
Date: 2011-01-16 11:35:09 +0900
1305
Fix typo in the default configuration of the trigger hotkeys.
1307
According to setup/keyboardshortcut.py, "Control" seems to be correct.
1310
TEST=compile ibus with --enable-memconf, start ibus-daemon, start ibus-setup, click "..." button for the "Enable or disable" hotkey, then verify that the "Control" checkbox in the pop-up dialog is checked from the beginning.
1312
Review URL: http://codereview.appspot.com/4017042
1316
commit ee6abd76f7b0f0fc8e1a8b6964f4d8216a3b6618
1317
Author: Yusuke Sato <yusukes@chromium.org>
1318
Date: 2011-01-16 11:34:34 +0900
1320
Set correct g-flags to proxy objects.
1322
This change is similar to https://github.com/ibus/ibus/commit/19247aac5a348185a0e180f254ab3858c5f85703.
1324
The flag can prevent unnecessary communications between ibus-daemon and e.g. engines like this:
1326
$ . ~/.config/ibus/bus/*-unix-0 ; dbus-monitor --address $IBUS_ADDRESS 2>&1 | tee /tmp/ibus.log
1328
method call sender=org.freedesktop.DBus -> dest=(null destination) serial=3 path=/org/freedesktop/IBus/Factory; interface=org.freedesktop.IBus.Factory; member=CreateEngine
1330
method return sender=:1.15 -> dest=org.freedesktop.DBus reply_serial=3
1331
object path "/org/freedesktop/IBus/Engine/1"
1332
method call sender=org.freedesktop.DBus -> dest=(null destination) serial=4 path=/org/freedesktop/IBus/Engine/1; interface=org.freedesktop.DBus.Properties; member=GetAll
1333
string "org.freedesktop.IBus.Engine"
1334
method return sender=:1.15 -> dest=org.freedesktop.DBus reply_serial=4
1338
Calling an engine's org.freedesktop.DBus.Properties.GetAll method when the engine is created is unnecessary for ibus-daemon, while it's not harmful though.
1341
TEST=verified using dbus-monitor that ibus-daemon does not call GetAll anymore.
1343
Review URL: http://codereview.appspot.com/4036041
1346
M bus/factoryproxy.c
1349
commit ca4909cc8349a9931958c3010f965cf19bf23cd7
1350
Author: Yusuke Sato <yusukes@chromium.org>
1351
Date: 2011-01-12 22:44:08 +0900
1353
Fix a gcc warning seen in Chromium OS build.
1355
Please note that gcc's warn_unused_result check is enforced on the build environment. Anyway, I believe it's good to check the return value in this case.
1358
TEST=ran emerge-x86-generic ibus.
1360
Review URL: http://codereview.appspot.com/3904044
1364
commit 199f80396f2c3db4953bac36c953742ece2d2270
1365
Author: Yusuke Sato <yusukes@chromium.org>
1366
Date: 2011-01-12 22:43:16 +0900
1368
Remove a gcc warning.
1370
ibusxml.c: In function 'ibus_xml_parse_file':
1371
ibusxml.c:213: error: 'retval' may be used uninitialized in this function
1374
TEST=ran make CFLAGS="-Wall -O2"
1376
Review URL: http://codereview.appspot.com/3858044
1380
commit 1403dc6abe87bd649c95b2454b49af2deba63461
1381
Author: Yusuke Sato <yusukes@chromium.org>
1382
Date: 2011-01-12 22:42:24 +0900
1384
Fix typo in ibus_bus_exit.
1387
TEST=ran make CFLAGS="-Wall -O2"
1389
Review URL: http://codereview.appspot.com/3900045
1393
commit 411d8c5f21ea0d3f65bfc0cbdc98733af360b441
1394
Author: Yusuke Sato <yusukes@chromium.org>
1395
Date: 2011-01-10 14:25:07 +0900
1397
Fix the return value of ibus_bus_register_component so it returns TRUE on success.
1399
Do the same for ibus_bus_set_global_engine as well. Currently it always returns TRUE regardless of the result of the method call.
1404
Review URL: http://codereview.appspot.com/3902043
1408
commit 783905fd6e6c8983237745ba90e05070559e0458
1409
Author: Yusuke Sato <yusukes@chromium.org>
1410
Date: 2011-01-09 15:12:11 +0900
1412
Change the return type of ibus_bus_exit to make it compatible with ibus-1.3 API.
1417
Review URL: http://codereview.appspot.com/3923042
1422
commit d5bdf851d25b07062ecb2ea932b91317b1d9e72a
1423
Author: Daiki Ueno <ueno@unixuser.org>
1424
Date: 2011-01-07 10:42:44 +0900
1426
Set correct sender and interface when sending org.freedesktop.IBus signals.
1431
Review URL: http://codereview.appspot.com/3775042
1435
M bus/inputcontext.c
1437
commit b24b403295a655e0c5644c5ddca1cf3488a938ce
1438
Author: Yusuke Sato <yusukes@chromium.org>
1439
Date: 2011-01-07 01:38:23 +0900
1441
Set the "g-default-timeout" property for ibusconfig, ibusinputcontext, and ibusbus objects. The GDBus default timeout (25 seconds) seems to be too long for IBus.
1444
TEST=manually, with IBUS_BUS_TIMEOUT=-3,-2,-1,0,1,1000,6000,abc,1abc,abc1
1446
Review URL: http://codereview.appspot.com/3799049
1450
M src/ibusinputcontext.c
1454
commit 144272e3a8b56cc9e9cec3f09688ae47c6166032
1455
Author: Yusuke Sato <yusukes@chromium.org>
1456
Date: 2011-01-06 12:28:54 +0900
1458
Use the G_DBUS_CALL_FLAGS_NO_AUTO_START flag just in case.
1461
TEST=manually on Chromium OS.
1463
Review URL: http://codereview.appspot.com/3774043
1467
commit dd4a4c1a7f64a9a7737171d7aeb8272de130475e
1468
Author: Yusuke Sato <yusukes@chromium.org>
1469
Date: 2011-01-06 12:24:36 +0900
1471
Do not write empty string to "preload_engines" for safety.
1473
Without the change, bus_ibus_impl_set_default_preload_engines() might erase an existing preload_engines config when --timeout option for ibus-daemon is too short for ibus_config_get() to success.
1476
TEST=manually with 'ibus-daemon --timeout=1'
1478
Review URL: http://codereview.appspot.com/3789046
1482
commit 44e94a3d0c7812fd24bd0548601682a1c0b043d7
1483
Author: Yusuke Sato <yusukes@chromium.org>
1484
Date: 2011-01-06 08:44:49 +0900
1486
Call ibus_hotkey_profile_remove_hotkey_by_event in bus_ibus_impl_set_trigger before registering the fallback hotkey, just in case.
1488
Probably it's better to call the remove function in bus_ibus_impl_set_trigger just as bus_ibus_impl_set_hotkey already does, so that a wierd error message like 'IBUS-CRITICAL **: ...: file ibushotkey.c: line 381 (ibus_hotkey_profile_add_hotkey): should not be reached' will not be shown.
1490
The fallback hotkey could be registered twice, via bus_ibus_impl_init and _dbus_name_owner_changed_cb, if the --timeout parameter is too small to talk to the configuration daemon, for example.
1493
TEST=ran ibus-daemon with --timeout=1 and verified that the IBUS-CRITICAL message above was not shown.
1495
Review URL: http://codereview.appspot.com/3796044
1499
commit af1460aea63a65877544e65a335398bd670ad6ee
1500
Author: Yusuke Sato <yusukes@chromium.org>
1501
Date: 2011-01-06 08:25:47 +0900
1503
Replace g_return_if_fail with g_warning since the error message 'desc != NULL' seems confusing.
1506
TEST=manually. removed all engines using ibus-setup and ran ibus-daemon, then press a trigger hot-key.
1508
Review URL: http://codereview.appspot.com/3786047
1512
commit c6e273c0ee91858bf5af2a87048f9d2977d368d5
1513
Author: Yusuke Sato <yusukes@chromium.org>
1514
Date: 2011-01-06 08:22:38 +0900
1516
Fix --timeout command line option of ibus-daemon.
1518
On 1.3.99, currently the option is just ignored and '-1' (i.e. the default timeout of gdbus which is 25 seconds in glib-2.26.1) is always used. We should fix this since the default, 25 secs, is too long for some platforms like Chromium OS.
1523
Review URL: http://codereview.appspot.com/3784047
1527
M bus/factoryproxy.c
1529
M bus/inputcontext.c
1534
commit 2f0877decf4adde5d4779a13ab15c40c41985525
1535
Author: Yusuke Sato <yusukes@chromium.org>
1536
Date: 2011-01-01 17:34:37 +0900
1538
Support hotkeys that use Super/Hyper modifiers.
1541
TEST=checked that Super+space and Hyper+space work as intended with and without the use_sys_layout option enabled.
1543
Review URL: http://codereview.appspot.com/3856041
1546
M src/ibuskeynames.c
1548
commit f4075519710719aa245ed8421f0219a129152fdb
1549
Author: Peng Huang <shawn.p.huang@gmail.com>
1550
Date: 2010-12-28 16:44:16 -0700
1552
Reply an error message to sender, if ibus-daemon can not forward method call message successfully.
1557
Review URL: http://codereview.appspot.com/3825042
1561
commit 017077ceb9ec2f26a8c524f3794a832164f21768
1562
Author: Daiki Ueno <ueno@unixuser.org>
1563
Date: 2010-12-28 12:46:25 +0900
1565
Fix g_variant_get() call in DeleteSurroundingText signal handler.
1570
Review URL: http://codereview.appspot.com/3820042
1572
M src/ibusinputcontext.c
1574
commit 61f0894c3555478117e9d5f286d0085bd5afdad3
1575
Author: Yusuke Sato <yusukes@chromium.org>
1576
Date: 2010-12-27 07:58:29 +0900
1578
Fix API compatibility issue in ibus_config_new.
1580
On ibus-1.3, ibus_config_new returns NULL when ibus-gconf is not started yet, but on 1.4 it returns a valid, non-NULL IBusConfig object. This patch fixes the discrepancy by changing the behavior of ibus_config_new of 1.4.
1582
If we don't return NULL when ibus-gconf does not exist, successive calls e.g. ibus_config_set_value will fail with a cryptic error message like 'IBUS-WARNING **: org.freedesktop.IBus.Config.SetValue: Cannot invoke method; proxy is for a well-known name without an owner and proxy was constructed with the G_DBUS_PROXY_FLAGS_DO_NOT_AUTO_START flag'. I believe returning NULL makes it easier to use the ibusconfig.h APIs.
1584
Please note that this patch is particularly important for Chromium OS. Since ibus_config_new is called shortly after ibus-daemon starts on the OS, ibus_config_new is sometimes called before ibus-memconf starts actually. This change helps the glue between chrome and ibus-daemon to remain clean.
1587
TEST=manually on Chromium OS
1589
Review URL: http://codereview.appspot.com/3784043
1593
commit 19247aac5a348185a0e180f254ab3858c5f85703
1594
Author: Yusuke Sato <yusukes@chromium.org>
1595
Date: 2010-12-27 07:57:09 +0900
1597
Create an instance of GDBusProxy with G_DBUS_PROXY_FLAGS_DO_NOT_LOAD_PROPERTIES flag.
1599
Without the flag, on_name_owner_changed() in glib-2.26.x/gio/gdbusproxy.c might invoke a remote method named GetAll in org.freedesktop.DBus.Properties interface, but the method is not implemented in ibus-daemon. Since ibus-daemon ignores the method call, the caller, which is UI thread of Chrome on Chromium OS, will block for 25 seconds (i.e. the default timeout of GDBus) waiting for a reply.
1604
Review URL: http://codereview.appspot.com/3836042
1607
M src/ibusinputcontext.c
1609
commit 7a8b3d722b83221168a339f46c7e8a617c735ade
1610
Author: Peng Huang <shawn.p.huang@gmail.com>
1611
Date: 2010-12-25 22:05:13 -0700
1613
Fix Alt+Shift hotkey issue for chrome os
1615
BUG=chromium-os:6225
1618
Review URL: http://codereview.appspot.com/3741043
1622
commit 911490b3f8adac433a91153000a63a0a7143fff2
1623
Author: Yusuke Sato <yusukes@chromium.org>
1624
Date: 2010-12-22 23:03:03 +0900
1626
Fix hot-key handling in inputcontext.c.
1628
Without the fix, some key combinations might not trigger a hot-key event.
1629
For example, one of Chrome OS hot-keys, "press Shift, then press Alt, then release Alt", does not work without the fix.
1632
TEST=manually checked using ChromeOS and IBus-1.4
1634
Review URL: http://codereview.appspot.com/3828041
1636
M bus/inputcontext.c
1638
commit 2c3021469f770666e54e72bf8e6c306c7dd3a046
1639
Author: Yusuke Sato <yusukes@chromium.org>
1640
Date: 2010-12-21 01:04:49 +0900
1642
Add comments to ibusproxy.[ch] and related functions.
1647
Review URL: http://codereview.appspot.com/3802042
1653
commit e4d8612776dbb5eca85ab35d9ad71ddd68db63e4
1654
Author: Yusuke Sato <yusukes@chromium.org>
1655
Date: 2010-12-21 01:04:05 +0900
1657
Fix ibus_input_context_get_input_context() so IBus.Service.Destroy will not be called when the returned object is disposed.
1660
TEST=verified that calling g_object_unref(the_returned_object) does not result in the remote method call.
1662
Review URL: http://codereview.appspot.com/3803041
1664
M src/ibusinputcontext.c
1668
commit fb0aee6d9f04e2b9e3177cfbd6cff359d40af879
1669
Author: Daiki Ueno <ueno@unixuser.org>
1670
Date: 2010-12-20 18:19:04 +0900
1672
Don't call nonexistent org.freedesktop.IBus.InputContext.Destroy.
1677
Review URL: http://codereview.appspot.com/3800041
1679
M ibus/inputcontext.py
1681
commit 7ca2d0f5b8fe5eb395fdff850d482d44b6216300
1682
Author: Yusuke Sato <yusukes@chromium.org>
1683
Date: 2010-12-20 15:02:20 +0900
1685
Fix typo in introspection_xml[] for InputContext.
1687
https://github.com/ibus/ibus/commit/ed778cd7cfc78eb39fc74167f2169b69f4d72a6b was incomplete, sorry.
1690
TEST=verified that properties can be changed via input context on Chrome OS.
1692
Review URL: http://codereview.appspot.com/3795041
1694
M bus/inputcontext.c
1696
commit 6a8b35d0d0ffd4c130a849a86e8c3e50cbeba14a
1697
Author: Daiki Ueno <ueno@unixuser.org>
1698
Date: 2010-12-15 18:33:33 +0900
1700
Init GError before calling g_dbus_proxy_call*().
1705
Review URL: http://codereview.appspot.com/3669041
1707
M src/ibusinputcontext.c
1709
commit c3c20f8e45c27440e188e2bac3baca05cc966d71
1710
Author: Daiki Ueno <ueno@unixuser.org>
1711
Date: 2010-12-15 18:32:17 +0900
1713
Fix gtk version check for deprecated keysyms.
1715
From the git log of gtk3, they started adding _KEY from 2.91.0 not 2.90.0.
1720
Review URL: http://codereview.appspot.com/3670041
1722
M client/gtk2/ibusimcontext.c
1724
commit bd5ead57debd3165d7dd89b099a1faadaa223eb3
1725
Author: Peng Huang <shawn.p.huang@gmail.com>
1726
Date: 2010-12-15 17:04:43 +0800
1728
Disconnect closed signal from GDBusConnection before creating a new connection.
1733
Review URL: http://codereview.appspot.com/3668041
1737
commit 4de438c3dbb35399b479b78ada3398c5319fb7ba
1738
Author: Yusuke Sato <yusukes@chromium.org>
1739
Date: 2010-12-15 15:13:00 +0900
1741
Fix assertion failure in ibusbus.c.
1743
The following code does not work since the underlying connection for IBus-1.4 is not a sub class of IBusObject.
1745
ibus_object_destroy ((IBusObject *)priv->connection);
1746
g_assert (priv->connection == NULL);
1749
TEST=ran Chrome for Chrome OS.
1751
Review URL: http://codereview.appspot.com/3658041
1755
commit 872aec110599de061e587746e8500e98f59feed9
1756
Author: Yusuke Sato <yusukes@chromium.org>
1757
Date: 2010-12-15 14:36:19 +0900
1759
Fix type mismatch in src/ibuspanelservice.c.
1762
TEST=ran candidate_window for Chrome OS.
1764
Review URL: http://codereview.appspot.com/3661041
1766
M src/ibuspanelservice.c
1768
commit ed778cd7cfc78eb39fc74167f2169b69f4d72a6b
1769
Author: Yusuke Sato <yusukes@chromium.org>
1770
Date: 2010-12-15 14:09:20 +0900
1772
Use unsigned for the parameter of the PropertyActivate message.
1774
unsigned would be better since the Python binding and engine proxy use unsigned for this purpose.
1777
TEST=ran Chrome for Chrome OS.
1779
Review URL: http://codereview.appspot.com/3660041
1781
M bus/inputcontext.c
1782
M src/ibusinputcontext.c
1783
M src/ibusinputcontext.h
1785
commit 2ce1bd05306e416d243c49eed5608b18b12f62cf
1786
Author: Yusuke Sato <yusukes@chromium.org>
1787
Date: 2010-12-15 11:55:16 +0900
1789
Fix type mismatch in the PropertyActivate message.
1791
src/ibusinputcontext.c sends the massage with "(si)" but the daemon use the massage as "(&su)". This triggers assertion failure on Chrome OS.
1794
TEST=change ibus-mozc's property on Chrome OS via the IME menu.
1796
Review URL: http://codereview.appspot.com/3636041
1798
M bus/inputcontext.c
1800
commit c2c4c6df3c0b650406be0615adb738540ebaf7af
1801
Author: Peng Huang <shawn.p.huang@gmail.com>
1802
Date: 2010-12-02 13:12:53 +0800
1804
Fix crash in im-ibus.so
1806
BUG=chromium-os:9868
1809
Review URL: http://codereview.appspot.com/3401041
1811
M client/gtk2/ibusimcontext.c
1813
commit e0b882f5fb5e274f8ae909c2b2c3b634890c31b5
1814
Author: Peng Huang <shawn.p.huang@gmail.com>
1815
Date: 2010-11-21 19:26:18 +0900
1817
Focus out/in fake input context if the input window changed.
1819
BUG=chromium-os:8855
1822
Review URL: http://codereview.appspot.com/3199042
1824
M client/gtk2/ibusimcontext.c
1826
commit 93ceb44131ad5cef4691dae151259f268f3ba986
1827
Author: Peng Huang <shawn.p.huang@gmail.com>
1828
Date: 2010-12-14 10:16:32 +0800
1830
Focus out the fake context in im-ibus.so, when a real context gets the focus.
1835
Review URL: http://codereview.appspot.com/3561042
1837
M client/gtk2/ibusimcontext.c
1839
commit 856bd2ea703a27fb88a82022392dbcd366a56d95
1840
Author: Peng Huang <shawn.p.huang@gmail.com>
1841
Date: 2010-12-14 10:14:45 +0800
1843
Add fake context back in IBusIMContext.
1845
The fake context is removed by mistake in ibus-1.4. It is necessary for Chrome OS.
1850
Review URL: http://codereview.appspot.com/3574042
1852
M client/gtk2/ibusimcontext.c
1854
commit ac1be736ab513b46c642e9ceb8bfc3bf4dc50de4
1855
Author: Peng Huang <shawn.p.huang@gmail.com>
1856
Date: 2010-12-13 17:37:09 +0800
1858
Fix typo and annotation.
1860
Fix typo in IBusEngineDesc:rank doc and GI transfer mode for
1861
ibus_component_get_engines().
1866
Review URL: http://codereview.appspot.com/3614041
1868
M src/ibuscomponent.h
1869
M src/ibusenginedesc.c
1871
commit 98419a4133f6358ec2e8ad56c62aacf3e3754c3e
1872
Author: Peng Huang <shawn.p.huang@gmail.com>
1873
Date: 2010-12-08 16:37:42 +0800
1875
Fix GI transfer mode annotation in ibus_bus_list_*engines() comment.
1877
See https://bugzilla.gnome.org/show_bug.cgi?id=635248. Also, do not mark those
1878
functions as "not implemented", since they are apparently implemented.
1883
Review URL: http://codereview.appspot.com/3274044
1887
commit 9b0e04d311f9e3e65cbdd245332502a7d36e9739
1888
Author: Yusuke Sato <yusukes@chromium.org>
1889
Date: 2010-12-03 00:42:45 +0900
1891
Add #include <ibuspanelservice.h> to ibus.h.
1893
Add #include <ibuspanelservice.h> to ibus.h so an external project (e.g. Chromium OS project) could implement its own panel component in C/C++.
1895
Review URL: http://codereview.appspot.com/3411041
1899
commit 036554a6106ba28bf2282ad63711a277c0abfe85
1900
Author: Yusuke Sato <yusukes@chromium.org>
1901
Date: 2010-12-03 00:41:15 +0900
1903
Remove unused header file, src/ibusconfigprivate.h
1905
Review URL: http://codereview.appspot.com/3412041
1908
D src/ibusconfigprivate.h
1910
commit 4f1f7e241edf9c41bc158c1367380e5b0da9a670
1911
Author: Yusuke Sato <yusukes@chromium.org>
1912
Date: 2010-12-01 22:00:44 +0900
1914
Fix compile errors on Chromium OS.
1916
This is for the master branch of ibus.
1918
BUG=crosbug.com/9685
1919
TEST=ran emerge-x86-generic ibus.
1921
Review URL: http://codereview.appspot.com/3368041
1923
M bus/inputcontext.c
1925
commit 50ceef360174ab6709a4215706ea527735f10c7e
1926
Author: Yusuke Sato <yusukes@chromium.org>
1927
Date: 2010-11-29 12:04:27 +0900
1929
Do not call g_critical when ibus->config is NULL since it's not an error.
1931
The change is originally for chromeos branch of ibus (http://codereview.appspot.com/3304043/) but I believe this is also good for the master branch of ibus.
1936
Review URL: http://codereview.appspot.com/3269043
1940
commit cf2c9302528b9ece00eb3430600e8391f05f2a5c
1941
Author: Yusuke Sato <yusukes@chromium.org>
1942
Date: 2010-11-26 16:07:56 +0900
1944
Add the "destroy" signal handler back following Peng's suggestion at http://codereview.appspot.com/3293042/.
1949
Review URL: http://codereview.appspot.com/3335041
1953
commit 85b5e0e92104d921f161bac22349db7f1f89790a
1954
Author: Yusuke Sato <yusukes@chromium.org>
1955
Date: 2010-11-26 10:15:08 +0900
1957
Add function comments to bus/panelproxy.[ch].
1962
Review URL: http://codereview.appspot.com/3293042
1967
commit ede7506ad1e69092a334bbd5b90a9f4b6c6349df
1968
Author: Yusuke Sato <yusukes@chromium.org>
1969
Date: 2010-11-25 17:54:19 +0900
1971
Fix unexpected client capabilities in ibus-daemon.
1976
Review URL: http://codereview.appspot.com/3323041
1978
M bus/inputcontext.c
1979
M src/ibusinputcontext.h
1981
commit a902bf42cb1bb8ce2ba9db147435cb52228281b4
1982
Author: Yusuke Sato <yusukes@chromium.org>
1983
Date: 2010-11-25 17:40:43 +0900
1985
Change the order of engine method calls for consistency.
1990
Review URL: http://codereview.appspot.com/3304042
1992
M bus/inputcontext.c
1994
commit 9ff18b80fdb3be5ed1209698c9f22d06cad4dc47
1995
Author: Yusuke Sato <yusukes@chromium.org>
1996
Date: 2010-11-25 16:55:04 +0900
1998
Add function comments to bus/inputcontext.[ch] and bus/engineproxy.[ch].
2000
Removed a temporary hack for PREEDIT_CONDITION by adding bus_ibus_impl_is_embed_preedit_text function to ibusimpl.c.
2005
Review URL: http://codereview.appspot.com/3321041
2011
M bus/inputcontext.c
2012
M bus/inputcontext.h
2014
commit 21c14908e7f274c32d1e454e57cd51840b15ed14
2015
Author: Yusuke Sato <yusukes@chromium.org>
2016
Date: 2010-11-24 18:50:57 +0900
2018
Re-enable the use_sys_layout feature.
2020
Currently use_sys_layout cannot be disabled.
2025
Review URL: http://codereview.appspot.com/3306041
2029
M bus/inputcontext.c
2031
commit 5d4f22c81caad3ea6503fa8e0862aacf7fc2107a
2032
Author: Peng Huang <shawn.p.huang@gmail.com>
2033
Date: 2010-11-24 17:46:12 +0900
2035
Pass cancellable object to bus_factory_proxy_create_engine
2040
Review URL: http://codereview.appspot.com/3304041
2044
commit 5f1d5dd0089094f4ace175b451387d646ce81877
2045
Author: Peng Huang <shawn.p.huang@gmail.com>
2046
Date: 2010-11-24 11:33:10 +0900
2048
Clean up the code of focus switch logic, and fix a crash when focused context is destroyed.
2053
Review URL: http://codereview.appspot.com/3192042
2056
M bus/inputcontext.c
2058
commit b483041c3b8b01ccc6a11dd97d313d191cb11093
2059
Author: Peng Huang <shawn.p.huang@gmail.com>
2060
Date: 2010-11-24 11:29:19 +0900
2062
Fix some crashs when engine processes are killed.
2067
Review URL: http://codereview.appspot.com/3152042
2073
M client/gtk2/ibusimcontext.c
2077
commit ee09d6331a4816044da78d8f5394da2b9d318989
2078
Author: Peng Huang <shawn.p.huang@gmail.com>
2079
Date: 2010-11-24 10:29:26 +0900
2081
Use g_object_add_weak_pointer to make code simpler.
2086
Review URL: http://codereview.appspot.com/3252041
2088
M client/gtk2/ibusimcontext.c
2090
commit 3460cc569fc5e58ed538c23b23582166ed796fba
2091
Author: Jim Huang <jserv@0xlab.org>
2092
Date: 2010-11-22 01:37:04 +0800
2094
Add generated files into .gitignore
2098
A src/tests/.gitignore
2100
commit 50c0d8399e7f31135647999fc9cd78f8a888264a
2101
Author: Jim Huang <jserv@0xlab.org>
2102
Date: 2010-11-22 01:24:08 +0800
2104
Avoid comparison of unsigned expression
2106
comparison of unsigned expression < 0 is always false
2110
commit 5fc6d9b8459ce47634012a42a638b6a091c205ee
2111
Author: Jim Huang <jserv@0xlab.org>
2112
Date: 2010-11-22 01:15:25 +0800
2114
Add assertions to connection_destroy callback
2116
M bus/inputcontext.c
2118
commit be50bec410f0b4730dd80c69c4037521eceae9d9
2119
Author: Peng Huang <shawn.p.huang@gmail.com>
2120
Date: 2010-11-21 19:13:34 +0900
2122
Remove some unused header files.
2127
Review URL: http://codereview.appspot.com/3218041
2129
M client/gtk2/ibusim.c
2130
M client/gtk2/ibusimcontext.c
2132
commit 4830992d531347f6cd464c384364e9b2cf7e96a6
2133
Author: fujiwarat <takao.fujiwara1@gmail.com>
2134
Date: 2010-11-18 12:23:45 +0900
2136
Fix NULL of focused input context
2138
M bus/inputcontext.c
2140
commit b1b50dbbf0d3117da388e8035b490fb4c3e19ab2
2141
Author: Yusuke Sato <yusukes@chromium.org>
2142
Date: 2010-11-17 19:15:38 +0900
2144
Add comments to bus/connection.[ch].
2149
Review URL: http://codereview.appspot.com/3164041
2154
commit 96cc5ab07c5c84e9807f3fb195166b7a5b09f2f5
2155
Author: Yusuke Sato <yusukes@chromium.org>
2156
Date: 2010-11-17 19:14:44 +0900
2158
Add comments to bus/factoryproxy.[ch].
2163
Review URL: http://codereview.appspot.com/3163041
2165
M bus/factoryproxy.c
2166
M bus/factoryproxy.h
2168
commit f8416ad2ed6bf581a1f746b4205eda25804ee9b9
2169
Author: Yusuke Sato <yusukes@chromium.org>
2170
Date: 2010-11-17 17:34:29 +0900
2172
Add comments to bus/registry.[ch].
2177
Review URL: http://codereview.appspot.com/3162041
2182
commit 2242d0279e7cc71c653c673acaedd4c47305ec17
2183
Author: Yusuke Sato <yusukes@chromium.org>
2184
Date: 2010-11-17 17:12:32 +0900
2186
Add comments about thread safety.
2191
Review URL: http://codereview.appspot.com/3156041
2195
commit a632d5e774eef4f5384f62580a682192c46ac9a9
2196
Author: Yusuke Sato <yusukes@chromium.org>
2197
Date: 2010-11-17 16:01:17 +0900
2199
Add comments to bus/component.[ch].
2204
Review URL: http://codereview.appspot.com/3161041
2209
commit e237282d262d27d97c441885c62aaacc4ae90f76
2210
Author: Yusuke Sato <yusukes@chromium.org>
2211
Date: 2010-11-17 13:49:55 +0900
2213
Add comments to bus/ibusimpl.[ch].
2218
Review URL: http://codereview.appspot.com/3154041
2223
commit 90305393b3862fdb9d5860fa81aab59bb5d1eccc
2224
Author: fujiwarat <takao.fujiwara1@gmail.com>
2225
Date: 2010-11-16 18:11:37 +0900
2227
Fix no defined '_' in EngineAbout
2229
M ui/gtk/engineabout.py
2231
commit 60c0bc54c0654ac89b56e94b756bbba95e8f3521
2232
Author: Peng Huang <shawn.p.huang@gmail.com>
2233
Date: 2010-11-16 17:59:48 +0900
2235
Add introspection data for org.freedesktop.IBus.Panel and remove Destroy method.
2237
Add introspection data for org.freedesktop.IBus.Panel interface.
2238
And remove Destroy method from Panel interface, because it is moved to
2239
org.freedesktop.IBus.Service interface.
2244
Review URL: http://codereview.appspot.com/3137041
2246
M src/ibuspanelservice.c
2247
M src/ibuspanelservice.h
2249
commit 217d2b49264d5335f8a0b5e8c70ff417547364aa
2250
Author: Yusuke Sato <yusukes@chromium.org>
2251
Date: 2010-11-16 15:43:12 +0900
2253
Add comments to bus/dbusimpl.[ch].
2258
Review URL: http://codereview.appspot.com/3132041
2263
commit 7ccb594a14ff3e2f189af80a34c92e6b1113f577
2264
Author: Peng Huang <shawn.p.huang@gmail.com>
2265
Date: 2010-11-16 14:22:23 +0900
2267
Make sure send the reply of method IBus.Exit out before the daemon exits.
2272
Review URL: http://codereview.appspot.com/3133041
2276
commit ac3ff55b7e4c23dd6ccd634b5b5eda683c0b2f43
2277
Author: Peng Huang <shawn.p.huang@gmail.com>
2278
Date: 2010-11-16 14:02:34 +0900
2280
Add global variable DOMAINNAME to replace "ibus10" in everywhere.
2285
Review URL: http://codereview.appspot.com/3093042
2290
commit 97fe1c47e189178b10c23fb18b575813f60fe72a
2291
Author: fujiwarat <takao.fujiwara1@gmail.com>
2292
Date: 2010-11-16 12:08:53 +0900
2294
Fix ibus_version in configure and translation domain in ibus-setup.
2299
commit 6e848591c101cbf6e14ed12f0e50deac7a486d71
10
2300
Author: fujiwarat <takao.fujiwara1@gmail.com>
11
2301
Date: 2010-11-11 18:09:52 +0900