1
commit 7e5b685255b2dbc9d96f954c86fcc86a56fee0c6
2
Author: aliguori <aliguori@c046a42c-6fe2-441c-8c8c-71466251a162>
3
Date: Wed Dec 10 15:12:57 2008 +0000
5
Fix off-by-one bug limiting VNC passwords to 7 chars (Chris Webb)
7
monitor_readline expects buf_size to include the terminating \0, but
8
do_change_vnc in monitor.c calls it as though it doesn't. The other site
9
where monitor_readline reads a password (in vl.c) passes the buffer
13
Signed-off-by: Chris Webb <chris@arachsys.com>
14
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
18
git-svn-id: svn+ssh://svn.savannah.nongnu.org/qemu/trunk@5966 c046a42c-6fe2-441c-8c8c-71466251a162
20
diff --git a/monitor.c b/monitor.c
21
index f142a87..bec9211 100644
24
@@ -434,8 +434,7 @@ static void do_change_vnc(const char *target)
25
if (strcmp(target, "passwd") == 0 ||
26
strcmp(target, "password") == 0) {
28
- monitor_readline("Password: ", 1, password, sizeof(password)-1);
29
- password[sizeof(password)-1] = '\0';
30
+ monitor_readline("Password: ", 1, password, sizeof(password));
31
if (vnc_display_password(NULL, password) < 0)
32
term_printf("could not set VNC server password\n");