← Back to branch summary

~ubuntu-branches/ubuntu/trusty/monodevelop/trusty-proposed

« back to all changes in this revision

Viewing changes to external/nrefactory/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ExplicitConversionInForEachIssue.cs

  • Committer: Package Import Robot
  • Author(s): Jo Shields
  • Date: 2013-05-12 09:46:03 UTC
  • mto: This revision was merged to the branch mainline in revision 29.
  • Revision ID: package-import@ubuntu.com-20130512094603-mad323bzcxvmcam0
Tags: upstream-4.0.5+dfsg
Import upstream version 4.0.5+dfsg

Show diffs side-by-side

added added

removed removed

Lines of Context:
external/nrefactory/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ExplicitConversionInForEachIssue.cs
 
1
// Copyright (c) 2010-2013 AlphaSierraPapa for the SharpDevelop Team
 
2
// 
 
3
// Permission is hereby granted, free of charge, to any person obtaining a copy of this
 
4
// software and associated documentation files (the "Software"), to deal in the Software
 
5
// without restriction, including without limitation the rights to use, copy, modify, merge,
 
6
// publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons
 
7
// to whom the Software is furnished to do so, subject to the following conditions:
 
8
// 
 
9
// The above copyright notice and this permission notice shall be included in all copies or
 
10
// substantial portions of the Software.
 
11
// 
 
12
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED,
 
13
// INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR
 
14
// PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE
 
15
// FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
 
16
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 
17
// DEALINGS IN THE SOFTWARE.
 
18
 
 
19
using System;
 
20
using System.Collections.Generic;
 
21
using ICSharpCode.NRefactory.CSharp.Resolver;
 
22
using ICSharpCode.NRefactory.Semantics;
 
23
using ICSharpCode.NRefactory.TypeSystem;
 
24
 
 
25
namespace ICSharpCode.NRefactory.CSharp.Refactoring
 
26
{
 
27
        [IssueDescription("Incorrect element type in foreach over generic collection",
 
28
                          Description= "Detects hidden explicit conversions in foreach loops.",
 
29
                          Category = IssueCategories.CodeQualityIssues,
 
30
                          Severity = Severity.Warning)]
 
31
        public class ExplicitConversionInForEachIssue : ICodeIssueProvider
 
32
        {
 
33
                public IEnumerable<CodeIssue> GetIssues(BaseRefactoringContext context)
 
34
                {
 
35
                        return new GatherVisitor(context).GetIssues();
 
36
                }
 
37
 
 
38
                class GatherVisitor : GatherVisitorBase<ExplicitConversionInForEachIssue>
 
39
                {
 
40
                        CSharpConversions conversions;
 
41
                        
 
42
                        public GatherVisitor (BaseRefactoringContext ctx) : base (ctx)
 
43
                        {
 
44
                        }
 
45
                        
 
46
                        public override void VisitForeachStatement(ForeachStatement foreachStatement)
 
47
                        {
 
48
                                base.VisitForeachStatement(foreachStatement);
 
49
                                var rr = ctx.Resolve(foreachStatement) as ForEachResolveResult;
 
50
                                if (rr == null)
 
51
                                        return;
 
52
                                if (rr.ElementType.Kind == TypeKind.Unknown)
 
53
                                        return;
 
54
                                if (ReflectionHelper.GetTypeCode(rr.ElementType) == TypeCode.Object)
 
55
                                        return;
 
56
                                if (conversions == null) {
 
57
                                        conversions = CSharpConversions.Get(ctx.Compilation);
 
58
                                }
 
59
                                Conversion c = conversions.ImplicitConversion(rr.ElementType, rr.ElementVariable.Type);
 
60
                                if (c.IsValid)
 
61
                                        return;
 
62
                                var csResolver = ctx.GetResolverStateBefore(foreachStatement);
 
63
                                var builder = new TypeSystemAstBuilder(csResolver);
 
64
                                AstType elementType = builder.ConvertType(rr.ElementType);
 
65
                                AstType variableType = foreachStatement.VariableType;
 
66
                                string issueText = ctx.TranslateString("Collection element type '{0}' is not implicitly convertible to '{1}'");
 
67
                                string fixText = ctx.TranslateString("Use type '{0}'");
 
68
                                AddIssue(variableType, string.Format(issueText, elementType.GetText(), variableType.GetText()),
 
69
                                         new CodeAction(
 
70
                                                                string.Format(fixText, elementType.GetText()),
 
71
                                                                script => script.Replace(variableType, elementType),
 
72
                                                                foreachStatement));
 
73
                        }
 
74
                }
 
75
        }
 
76
}