← Back to branch summary

~ubuntu-branches/ubuntu/trusty/monodevelop/trusty-proposed

« back to all changes in this revision

Viewing changes to external/nrefactory/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ReferenceEqualsCalledWithValueTypeIssue.cs

  • Committer: Package Import Robot
  • Author(s): Jo Shields
  • Date: 2013-05-12 09:46:03 UTC
  • mto: This revision was merged to the branch mainline in revision 29.
  • Revision ID: package-import@ubuntu.com-20130512094603-mad323bzcxvmcam0
Tags: upstream-4.0.5+dfsg
Import upstream version 4.0.5+dfsg

Show diffs side-by-side

added added

removed removed

Lines of Context:
external/nrefactory/ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/ReferenceEqualsCalledWithValueTypeIssue.cs
 
1
// 
 
2
// ReferenceEqualsCalledWithValueTypeIssue.cs
 
3
// 
 
4
// Author:
 
5
//      Mansheng Yang <lightyang0@gmail.com>
 
6
// 
 
7
// Copyright (c) 2012 Mansheng Yang <lightyang0@gmail.com>
 
8
// 
 
9
// Permission is hereby granted, free of charge, to any person obtaining a copy
 
10
// of this software and associated documentation files (the "Software"), to deal
 
11
// in the Software without restriction, including without limitation the rights
 
12
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 
13
// copies of the Software, and to permit persons to whom the Software is
 
14
// furnished to do so, subject to the following conditions:
 
15
// 
 
16
// The above copyright notice and this permission notice shall be included in
 
17
// all copies or substantial portions of the Software.
 
18
// 
 
19
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 
20
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 
21
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 
22
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 
23
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 
24
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 
25
// THE SOFTWARE.
 
26
 
 
27
using System.Collections.Generic;
 
28
using System.Linq;
 
29
using ICSharpCode.NRefactory.Semantics;
 
30
using ICSharpCode.NRefactory.TypeSystem;
 
31
 
 
32
namespace ICSharpCode.NRefactory.CSharp.Refactoring
 
33
{
 
34
        [IssueDescription ("'Object.ReferenceEquals' is always false because it is called with value type",
 
35
                                           Description = "'Object.ReferenceEquals' is always false because it is called with value type.",
 
36
                                           Category = IssueCategories.CodeQualityIssues,
 
37
                                           Severity = Severity.Warning,
 
38
                                           IssueMarker = IssueMarker.Underline)]
 
39
        public class ReferenceEqualsCalledWithValueTypeIssue : ICodeIssueProvider
 
40
        {
 
41
                public IEnumerable<CodeIssue> GetIssues (BaseRefactoringContext context)
 
42
                {
 
43
                        return new GatherVisitor (context).GetIssues ();
 
44
                }
 
45
 
 
46
                class GatherVisitor : GatherVisitorBase<ReferenceEqualsCalledWithValueTypeIssue>
 
47
                {
 
48
                        public GatherVisitor(BaseRefactoringContext ctx)
 
49
                                : base (ctx)
 
50
                        {
 
51
                        }
 
52
 
 
53
                        public override void VisitInvocationExpression (InvocationExpression invocationExpression)
 
54
                        {
 
55
                                base.VisitInvocationExpression (invocationExpression);
 
56
 
 
57
                                // Quickly determine if this invocation is eligible to speed up the inspector
 
58
                                var nameToken = invocationExpression.Target.GetChildByRole(Roles.Identifier);
 
59
                                if (nameToken.Name != "ReferenceEquals")
 
60
                                        return;
 
61
 
 
62
                                var resolveResult = ctx.Resolve (invocationExpression) as InvocationResolveResult;
 
63
                                if (resolveResult == null || 
 
64
                                        resolveResult.Member.DeclaringTypeDefinition == null ||
 
65
                                        resolveResult.Member.DeclaringTypeDefinition.KnownTypeCode != KnownTypeCode.Object ||
 
66
                                        resolveResult.Member.Name != "ReferenceEquals" ||
 
67
                                        invocationExpression.Arguments.All(arg => ctx.Resolve(arg).Type.IsReferenceType ?? true))
 
68
                                        return;
 
69
 
 
70
                                var action = new CodeAction (ctx.TranslateString ("Use Equals()"),
 
71
                                        script => script.Replace (invocationExpression.Target, new MemberReferenceExpression (
 
72
                                                new TypeReferenceExpression (new PrimitiveType ("object")), "Equals")), invocationExpression);
 
73
                                AddIssue (invocationExpression,
 
74
                                        ctx.TranslateString ("'Object.ReferenceEquals' is always false because it is called with value type"),
 
75
                                        new [] { action });
 
76
                        }
 
77
                }
 
78
        }
 
79
}