1
From: Ben Hutchings <ben@decadent.org.uk>
2
Date: Sat, 7 Nov 2009 11:53:39 +0000
3
Subject: [PATCH 05/24] bnx2x: declare MODULE_FIRMWARE
5
commit 45229b420f90bb6736dfeb7e491eb46cb02a3e9c upstream.
7
Replace run-time string formatting with preprocessor string
10
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
11
Acked-by: Eilon Greenstein <eilong@broadcom.com>
12
Signed-off-by: David S. Miller <davem@davemloft.net>
14
drivers/net/bnx2x_main.c | 27 ++++++++++++++-------------
15
1 files changed, 14 insertions(+), 13 deletions(-)
17
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
18
index 61974b7..5b6c68a 100644
19
--- a/drivers/net/bnx2x_main.c
20
+++ b/drivers/net/bnx2x_main.c
22
#include <linux/prefetch.h>
23
#include <linux/zlib.h>
25
+#include <linux/stringify.h>
30
#include <linux/firmware.h>
31
#include "bnx2x_fw_file_hdr.h"
33
-#define FW_FILE_PREFIX_E1 "bnx2x-e1-"
34
-#define FW_FILE_PREFIX_E1H "bnx2x-e1h-"
35
+#define FW_FILE_VERSION \
36
+ __stringify(BCM_5710_FW_MAJOR_VERSION) "." \
37
+ __stringify(BCM_5710_FW_MINOR_VERSION) "." \
38
+ __stringify(BCM_5710_FW_REVISION_VERSION) "." \
39
+ __stringify(BCM_5710_FW_ENGINEERING_VERSION)
40
+#define FW_FILE_NAME_E1 "bnx2x-e1-" FW_FILE_VERSION ".fw"
41
+#define FW_FILE_NAME_E1H "bnx2x-e1h-" FW_FILE_VERSION ".fw"
43
/* Time in jiffies before concluding the transmitter is hung */
44
#define TX_TIMEOUT (5*HZ)
45
@@ -77,6 +83,8 @@ MODULE_AUTHOR("Eliezer Tamir");
46
MODULE_DESCRIPTION("Broadcom NetXtreme II BCM57710/57711/57711E Driver");
47
MODULE_LICENSE("GPL");
48
MODULE_VERSION(DRV_MODULE_VERSION);
49
+MODULE_FIRMWARE(FW_FILE_NAME_E1);
50
+MODULE_FIRMWARE(FW_FILE_NAME_E1H);
52
static int multi_mode = 1;
53
module_param(multi_mode, int, 0);
54
@@ -12111,21 +12119,14 @@ static inline void be16_to_cpu_n(const u8 *_source, u8 *_target, u32 n)
56
static int __devinit bnx2x_init_firmware(struct bnx2x *bp, struct device *dev)
58
- char fw_file_name[40] = {0};
59
+ const char *fw_file_name;
60
struct bnx2x_fw_file_hdr *fw_hdr;
64
- /* Create a FW file name */
66
- offset = sprintf(fw_file_name, FW_FILE_PREFIX_E1);
67
+ fw_file_name = FW_FILE_NAME_E1;
69
- offset = sprintf(fw_file_name, FW_FILE_PREFIX_E1H);
71
- sprintf(fw_file_name + offset, "%d.%d.%d.%d.fw",
72
- BCM_5710_FW_MAJOR_VERSION,
73
- BCM_5710_FW_MINOR_VERSION,
74
- BCM_5710_FW_REVISION_VERSION,
75
- BCM_5710_FW_ENGINEERING_VERSION);
76
+ fw_file_name = FW_FILE_NAME_E1H;
78
printk(KERN_INFO PFX "Loading %s\n", fw_file_name);