1
2013-01-21 Allan Sandfeld Jensen <allan.jensen@digia.com>
3
[Qt][WK1] Permission request callbacks for non-legacy notifications
4
https://bugs.webkit.org/show_bug.cgi?id=107438
6
Reviewed by Jocelyn Turcotte.
8
Tracks the new callbacks the same way legacy callbacks are tracked.
10
No test affected yet as we are still lacking support for testing
11
feature permission callbacks.
13
* WebCoreSupport/NotificationPresenterClientQt.cpp:
14
(WebCore::NotificationPresenterClientQt::requestPermission):
15
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame):
16
* WebCoreSupport/NotificationPresenterClientQt.h:
17
(NotificationPresenterClientQt):
20
2013-01-21 Allan Sandfeld Jensen <allan.jensen@digia.com>
22
[Qt] Crash in gmail on enabling desktop notifications
23
https://bugs.webkit.org/show_bug.cgi?id=106699
26
Reviewed by Jocelyn Turcotte.
28
Protect against callback that may be null. This also matches WebKit2 behaviour.
30
* WebCoreSupport/NotificationPresenterClientQt.cpp:
31
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame):
33
2013-01-21 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
35
[Qt] Update the documentation about the storage of inspector settings
36
https://bugs.webkit.org/show_bug.cgi?id=106777
38
Reviewed by Allan Sandfeld Jensen.
40
Since r76770, QSettings isn't queried anymore to persist inspector
41
settings like whether or not the debugger is enabled by default.
42
It still seems to be used for the default attach height.
44
Update the documentation accordingly.
46
* WidgetApi/qwebinspector.cpp:
48
2013-01-16 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
50
[Qt] Use the shared HistoryItem serialization for QWebHistory
51
https://bugs.webkit.org/show_bug.cgi?id=106671
53
Reviewed by Allan Sandfeld Jensen.
55
Bump the serialization version and change the code to abort the
56
restore of a previous stream version rather than trying to keep the
57
support of restoring previous versions. This is mainly to simplify
58
things given that HistoryItem itself aborts in that case.
60
* Api/qwebhistory.cpp:
63
* tests/qwebhistory/tst_qwebhistory.cpp:
64
(tst_QWebHistory::serialize_2): Modify the test to cover same-document navigations.
65
(tst_QWebHistory::restoreIncompatibleVersion1): Add a previous version
66
hard-coded stream to verify that the deserialization doesn't hang or
69
2013-01-16 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
71
[Qt] Crash in WebCore::CachedFrame::destroy
72
https://bugs.webkit.org/show_bug.cgi?id=104525
74
Reviewed by Adam Barth.
76
Remove the call to HistoryController::setCurrentItem which is ultimately
77
causing the initial empty document of a page to be added to the page cache.
79
This re-introduce the bug that was fixed by this line, which will be
80
properly fixed in a follow-up patch.
82
* Api/qwebhistory.cpp:
84
* tests/qwebhistory/tst_qwebhistory.cpp:
85
(tst_QWebHistory::saveAndRestore_crash_4): Cover the crash.
87
2013-01-07 Michael Brüning <michael.bruning@digia.com>
89
[Qt] Apply correct patch for the scrolling issue from bug 105014
90
https://bugs.webkit.org/show_bug.cgi?id=106219
92
Correct the if condition when overwriting the layout direction option
93
with the values from the facade options to only overwrite if the facade
94
direction is not equal to LayoutDirectionAuto.
96
Reviewed by Allan Sandfeld Jensen.
98
* WidgetSupport/QStyleFacadeImp.cpp:
99
(WebKit::initGenericStyleOption):
101
2013-01-07 Michael Brüning <michael.bruning@digia.com>
103
[Qt] Horizontal scrollbars events are offseted making them difficult to use
104
https://bugs.webkit.org/show_bug.cgi?id=105014
106
Reviewed by Allan Sandfeld Jensen.
108
Patch co-authored by Simon Hausmann.
110
Only copy the layout direction from the facade options if the
111
current option is Qt::LayoutDirectionAuto in order to prevent
112
misinterpretations as different layout direction when hit testing.
114
Tests added to tst_qwebview and tst_qgraphicswebview to verify
115
that the view actually is scrolled in the right direction.
117
* WidgetSupport/QStyleFacadeImp.cpp:
118
(WebKit::initGenericStyleOption):
119
* tests/qgraphicswebview/resources/scrolltest_page.html: Added.
120
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
121
(tst_QGraphicsWebView):
122
(tst_QGraphicsWebView::horizontalScrollbarTest):
123
* tests/qgraphicswebview/tst_qgraphicswebview.qrc:
124
* tests/qwebview/resources/scrolltest_page.html: Added.
125
* tests/qwebview/tst_qwebview.cpp:
127
(tst_QWebView::horizontalScrollbarTest):
128
* tests/qwebview/tst_qwebview.qrc:
130
2012-12-03 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
132
Document::initSecurityContext() fails to call securityOrigin().grantLoadLocalResources()
133
https://bugs.webkit.org/show_bug.cgi?id=68711
135
Reviewed by Adam Barth.
137
* tests/qwebpage/tst_qwebpage.cpp:
138
(tst_QWebPage::testStopScheduledPageRefresh): Unmark the expected failure.
140
2012-11-30 Simon Hausmann <simon.hausmann@digia.com>
142
[Qt] Fix QML import installation with newer Qt
144
Reviewed by Tor Arne Vestbø.
146
The import path has been separated between QML1 and QML2. Use
147
QT_INSTALL_QML if it's available.
149
* declarative/experimental/experimental.pri:
150
* declarative/public.pri:
152
2012-11-30 Zeno Albisser <zeno@webkit.org>
154
[Qt] Enable WebGL by default.
155
https://bugs.webkit.org/show_bug.cgi?id=103731
157
Reviewed by Simon Hausmann.
159
* Api/qwebsettings.cpp:
160
(QWebSettings::QWebSettings):
162
2012-11-30 Mihai Maerean <mmaerean@adobe.com>
164
[CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
165
https://bugs.webkit.org/show_bug.cgi?id=101192
167
Reviewed by Hajime Morita.
169
Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
171
Tests: No new tests because there is no functional change.
173
* Api/qwebsettings.cpp:
174
(QWebSettingsPrivate::apply):
176
2012-11-29 Alexey Proskuryakov <ap@apple.com>
178
[WK2] Forward cookie jar calls to NetworkProcess
179
https://bugs.webkit.org/show_bug.cgi?id=103457
181
Reviewed by Darin Adler.
183
* WebCoreSupport/PlatformStrategiesQt.cpp:
184
(PlatformStrategiesQt::cookiesForDOM):
185
(PlatformStrategiesQt::setCookiesFromDOM):
186
(PlatformStrategiesQt::cookiesEnabled):
187
(PlatformStrategiesQt::cookieRequestHeaderFieldValue):
188
(PlatformStrategiesQt::getRawCookies):
189
(PlatformStrategiesQt::deleteCookie):
190
(PlatformStrategiesQt::getHostnamesWithCookies):
191
(PlatformStrategiesQt::deleteCookiesForHostname):
192
(PlatformStrategiesQt::deleteAllCookies):
194
2012-11-28 Huang Dongsung <luxtella@company100.net>
196
[Texmap] REGRESSION(r135620) QtTestBrowser crashes on Google-gravity.
197
https://bugs.webkit.org/show_bug.cgi?id=103410
199
Reviewed by Noam Rosenthal.
201
TextureMapperLayerClientQt::setTextureMapper() must call
202
flushCompositingStateForThisLayerOnly() of the root layer.
204
Currently, PageClientQGraphicsWidget::setRootGraphicsLayer does not flush layer
205
states of the root layer after setting TextureMapper while
206
PageClientQWidget::setRootGraphicsLayer() flushes them of the root layer. If
207
not flushing states, descendant layers can not reach the root layer. It means
208
descendant layers can not reach the TextureMapper that the root layer has.
210
This is already the behavior for PageClientQWidget, which should be the case
211
for PageClientQGraphicsWidget as well.
213
* WebCoreSupport/PageClientQt.cpp:
214
(WebCore::TextureMapperLayerClientQt::setTextureMapper):
215
(WebCore::PageClientQWidget::setRootGraphicsLayer):
217
2012-11-27 James Simonsen <simonjam@chromium.org>
219
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
220
https://bugs.webkit.org/show_bug.cgi?id=102151
222
Reviewed by Adam Barth.
225
(QWebFrame::QWebFrame):
227
(QWebFrame::setHtml):
228
(QWebFrame::setContent):
229
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
230
(DumpRenderTreeSupportQt::setAlternateHtml):
231
(qt_dump_set_accepts_editing):
232
* WebCoreSupport/FrameLoaderClientQt.cpp:
233
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
235
2012-11-27 Sheriff Bot <webkit.review.bot@gmail.com>
237
Unreviewed, rolling out r135786.
238
http://trac.webkit.org/changeset/135786
239
https://bugs.webkit.org/show_bug.cgi?id=103379
241
It made 3 plugin tests timeout on several platforms (Requested
245
(QWebFrame::setHtml):
246
(QWebFrame::setContent):
247
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
248
(DumpRenderTreeSupportQt::setAlternateHtml):
249
* WebCoreSupport/FrameLoaderClientQt.cpp:
250
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
251
* WebCoreSupport/QWebFrameAdapter.cpp:
252
(QWebFrameAdapter::load):
254
2012-11-26 James Simonsen <simonjam@chromium.org>
256
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
257
https://bugs.webkit.org/show_bug.cgi?id=102151
259
Reviewed by Adam Barth.
262
(QWebFrame::QWebFrame):
264
(QWebFrame::setHtml):
265
(QWebFrame::setContent):
266
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
267
(DumpRenderTreeSupportQt::setAlternateHtml):
268
(qt_dump_set_accepts_editing):
269
* WebCoreSupport/FrameLoaderClientQt.cpp:
270
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
272
2012-11-26 Pierre Rossi <pierre.rossi@gmail.com>
274
[Qt] REGRESSION(r135575): It made all tests assert
275
https://bugs.webkit.org/show_bug.cgi?id=103169
277
Reviewed by Simon Hausmann.
279
This fixes another regression introduced in r135515:
280
initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
281
since it can be called from WebKit2 to initialize QStyle for testing.
282
This would then lead to things such as PlatformStrategies being
285
* Api/qwebpage.cpp: Explicitely call initializeWebCoreQt().
286
(QWebPagePrivate::QWebPagePrivate):
287
* WebCoreSupport/InitWebCoreQt.cpp:
288
(WebKit::initializeWebKitQt):
289
(WebCore::initializeWebCoreQt):
290
* WebCoreSupport/InitWebCoreQt.h:
293
2012-11-26 Zeno Albisser <zeno@webkit.org>
295
[Qt] Make sure the QGLWidget context is current when creating the TextureMapper.
296
https://bugs.webkit.org/show_bug.cgi?id=103142
298
When creating the TextureMapperGL for WK1 we have to make sure
299
that the GL context provided by the QGLWidget is current.
300
Otherwise the GraphicsContext3DQt created by TextureMapperGL will pick up
301
the wrong pointer by calling QOpenGLContext::currentContext().
303
Reviewed by Simon Hausmann.
305
* WebCoreSupport/PageClientQt.cpp:
306
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
308
2012-11-26 Michael Brüning <michael.bruning@digia.com>
310
[Qt] QStyleFacadeImp build break with latest Qt 5
311
https://bugs.webkit.org/show_bug.cgi?id=103198
313
Reviewed by Simon Hausmann.
315
Original patch by J-P Nurmi <jpnurmi@digia.com>.
317
Fixes QtWebKit build by replacing qobject_cast to
318
QMacStyle with calls to QObject::inherits. Also
319
replaces Q_WS_MAC preprocesser directives with Q_OS_MAC
320
for Qt 5 compatibility.
322
* WebCoreSupport/QStyleFacadeImp.cpp:
323
(WebKit::QStyleFacadeImp::getButtonMetrics):
324
(WebKit::QStyleFacadeImp::paintComboBox):
325
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
326
(WebKit::QStyleFacadeImp::paintScrollBar):
328
2012-11-24 Sheriff Bot <webkit.review.bot@gmail.com>
330
Unreviewed, rolling out r135648 and r135649.
331
http://trac.webkit.org/changeset/135648
332
http://trac.webkit.org/changeset/135649
333
https://bugs.webkit.org/show_bug.cgi?id=103176
335
This change cannot be built with a qt-minimal configuration.
336
(Requested by zalbisser on #webkit).
338
* WebCoreSupport/PageClientQt.cpp:
339
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
341
2012-11-24 Zeno Albisser <zeno@webkit.org>
343
Unreviewed Qt build fix:
345
Make sure QGLWidget definition is available.
347
* WebCoreSupport/PageClientQt.cpp:
349
2012-11-24 Zeno Albisser <zeno@webkit.org>
351
[Qt] Make sure the QGLWidget context is current when creating the TextureMapper.
352
https://bugs.webkit.org/show_bug.cgi?id=103142
354
When creating the TextureMapperGL for WK1 we have to make sure
355
that the GL context provided by the QGLWidget is current.
356
Otherwise the GraphicsContext3DQt created by TextureMapperGL will pick up
357
the wrong pointer by calling QOpenGLContext::currentContext().
359
Reviewed by Kenneth Rohde Christiansen.
361
* WebCoreSupport/PageClientQt.cpp:
362
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
364
2012-11-23 Sheriff Bot <webkit.review.bot@gmail.com>
366
Unreviewed, rolling out r135575.
367
http://trac.webkit.org/changeset/135575
368
https://bugs.webkit.org/show_bug.cgi?id=103169
370
It made all tests assert (Requested by Ossy on #webkit).
373
(QWebPagePrivate::QWebPagePrivate):
374
* WebCoreSupport/InitWebCoreQt.cpp:
375
(WebKit::initializeWebKitQt):
377
2012-11-23 Simon Hausmann <simon.hausmann@digia.com>
379
[Qt] Compiling against QtWebkit API requires QT_DLL to be defined
380
https://bugs.webkit.org/show_bug.cgi?id=102942
382
Reviewed by Tor Arne Vestbø.
384
Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
385
macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
386
to follow the same rules as other Qt 5 modules, with the exception that instead of
387
QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
388
in other cross-platform header files to determine the correct meaning of export
391
* Api/qwebkitglobal.h:
393
2012-11-23 Simon Hausmann <simon.hausmann@digia.com>
395
Unreviewed trivial Qt/Win build fix:
397
Include FormState.h/HTMLFormElement.h in the FrameLoaderClient
398
declaration because MSVC needs it. Also fix Q_DECL_EXPORT declarations
399
for functions that are supposed to be exported.
401
* Api/qwebelement.cpp:
402
* WebCoreSupport/FrameLoaderClientQt.h:
403
* WebCoreSupport/InitWebCoreQt.h:
405
* WebCoreSupport/InitWebKitQt.h:
408
2012-11-22 Simon Hausmann <simon.hausmann@digia.com>
410
Unreviewed MSVC Windows build fix: Include header files referenced in RefPtr
413
* Api/qwebelement.cpp:
415
2012-11-21 Allan Sandfeld Jensen <allan.jensen@digia.com>
417
Position in QWebHitTestResult does not match documentation
418
https://bugs.webkit.org/show_bug.cgi?id=102909
420
Reviewed by Simon Hausmann.
422
Correct documentation and simplify using the new innerNodeFrame method.
425
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
427
2012-11-21 Allan Sandfeld Jensen <allan.jensen@digia.com>
429
Disambiguate innerNodeFramePoint and mainFramePoint
430
https://bugs.webkit.org/show_bug.cgi?id=98139
432
Reviewed by Julien Chaffraix.
435
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
437
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
439
2012-11-20 Sheriff Bot <webkit.review.bot@gmail.com>
441
Unreviewed, rolling out r135295.
442
http://trac.webkit.org/changeset/135295
443
https://bugs.webkit.org/show_bug.cgi?id=102834
445
This patch causes assertion to some layout tests on chromium
446
(Requested by jianli on #webkit).
449
(QWebFrame::QWebFrame):
451
(QWebFrame::setHtml):
452
(QWebFrame::setContent):
453
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
454
(DumpRenderTreeSupportQt::setAlternateHtml):
455
* WebCoreSupport/FrameLoaderClientQt.cpp:
456
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
458
2012-11-20 James Simonsen <simonjam@chromium.org>
460
Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
461
https://bugs.webkit.org/show_bug.cgi?id=102151
463
Reviewed by Adam Barth.
466
(QWebFrame::QWebFrame):
468
(QWebFrame::setHtml):
469
(QWebFrame::setContent):
470
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
471
(DumpRenderTreeSupportQt::setAlternateHtml):
472
(qt_dump_set_accepts_editing):
473
* WebCoreSupport/FrameLoaderClientQt.cpp:
474
(WebCore::FrameLoaderClientQt::callErrorPageExtension):
476
2012-11-18 Laszlo Gombos <l.gombos@samsung.com>
478
[Qt] Remove remaining traces of symbian
479
https://bugs.webkit.org/show_bug.cgi?id=102634
481
Reviewed by Kenneth Rohde Christiansen.
483
Remove symbian related part from the API documentation.
485
* Api/qgraphicswebview.cpp:
488
2012-11-16 Kihong Kwon <kihong.kwon@samsung.com>
490
Add DeviceController base-class to remove duplication of DeviceXXXControler
491
https://bugs.webkit.org/show_bug.cgi?id=96894
493
Reviewed by Hajime Morita.
495
Change client() to deviceOrientationClient() to get DeviceOrientationClient*.
497
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
498
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
500
2012-11-14 Csaba Osztrogonác <ossy@webkit.org>
502
[Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
503
https://bugs.webkit.org/show_bug.cgi?id=63237
505
Reviewed by Jocelyn Turcotte.
507
Uncomment this API test, because it works fine now.
509
* tests/qwebframe/tst_qwebframe.cpp:
511
(tst_QWebFrame::setUrlWithPendingLoads):
513
2012-11-14 Andras Becsi <andras.becsi@digia.com>
515
[Qt] QStyleFacadeImp should use a QPointer to store the application style
516
https://bugs.webkit.org/show_bug.cgi?id=102084
518
Reviewed by Simon Hausmann.
520
QStyleFacadeImp implicitly creates a default style during the first
521
call to QApplication::style() in QStyleFacadeImp::style() but this
522
style is deleted when a custom style is set, thus the stored m_style
523
raw pointer in QStyleFacadeImp becomes dangling.
524
Use a QPointer to cache the style instead of a raw pointer.
526
This fixes the start-up crash in the anomaly example.
527
(https://bugreports.qt-project.org/browse/QTBUG-27924)
529
* WebCoreSupport/QStyleFacadeImp.h:
532
2012-11-13 Andreas Kling <kling@webkit.org>
534
Move inline style logic from ElementAttributeData to StyledElement.
535
<http://webkit.org/b/102120>
537
Reviewed by Antti Koivisto.
539
* Api/qwebelement.cpp:
540
(QWebElement::styleProperty):
542
2012-11-09 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
544
[Qt] Fix tst_QWebPage::findText
546
Reviewed by Simon Hausmann.
548
Details of the failure:
549
FAIL! : tst_QWebPage::findText() Compared values are not the same
550
Actual (m_page->selectedHtml().trimmed().replace(regExp, "")): <span>foo</span>
551
Expected (subString): foo
552
Loc: [/home/joce/dev/webkit/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(2964)]
554
The format returned by selectedHtml changed.
555
Make the test a bit more robust by just checking that the HTML
556
contains our search value.
558
* tests/qwebpage/tst_qwebpage.cpp:
559
(tst_QWebPage::findText):
561
2012-11-09 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
563
[Qt] Fix tst_QWebPage::testLocalStorageVisibility
565
Reviewed by Simon Hausmann.
567
window.localStorage is expected to work for file URLs.
568
I'm not sure why it did work when this test was written,
569
but I believe that it had the wrong expected value.
571
* tests/qwebpage/tst_qwebpage.cpp:
573
2012-11-08 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
575
[Qt] Fix tst_QObjectBridge::callQtInvokable
577
Reviewed by Simon Hausmann.
579
Q_DECLARE_METATYPE now calls qRegisterMetaType so just prevent
580
the value from being wrapped by QVariant since this code shouldn't
583
* tests/qobjectbridge/tst_qobjectbridge.cpp:
584
(MyQObject::myInvokableWithBrushStyleArg):
586
2012-11-08 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
588
[Qt] Fix tst_QWebPage::inputMethods
590
Reviewed by Simon Hausmann.
592
Details of the failure:
593
FAIL! : tst_QWebPage::inputMethods(QWebView) Compared values are not the same
594
Actual (page->settings()->fontFamily(QWebSettings::SerifFont)): FooSerifFont
595
Expected (font.family()): Helvetica
596
Loc: [Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1691)]
598
The issue was that WebCore wouldn't find FooSerifFont and would have
599
RenderStyle::font() return the fallback font it used instead.
601
* tests/qwebpage/tst_qwebpage.cpp:
602
(tst_QWebPage::inputMethods):
604
2012-11-09 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
606
[Qt] Fix tst_QWebPage::showModalDialog() API test
607
https://bugs.webkit.org/show_bug.cgi?id=63244
609
Reviewed by Simon Hausmann.
611
* tests/qwebpage/tst_qwebpage.cpp:
613
2012-11-09 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
615
[Qt] tst_QWebElement::style() fails because QWebElement::InlineStyle now works as expected
616
https://bugs.webkit.org/show_bug.cgi?id=60372
618
Reviewed by Simon Hausmann.
620
Update the expected value to follow this comment in StylePropertySet::addParsedProperty:
621
"Only add properties that have no !important counterpart present"
623
* tests/qwebelement/tst_qwebelement.cpp:
624
(tst_QWebElement::style):
626
2012-11-09 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
628
[Qt] tst_QWebElement::style() fails because QWebElement::CascadedStyle doesn't work as expected
629
https://bugs.webkit.org/show_bug.cgi?id=65244
631
Reviewed by Kenneth Rohde Christiansen.
633
StyleResolver::styleRulesForElement now takes flags as parameter instead of a bool to specify
634
that we want to exclude UI and user style sheets.
636
* Api/qwebelement.cpp:
637
(QWebElement::styleProperty):
638
* tests/qwebelement/tst_qwebelement.cpp:
639
(tst_QWebElement::style):
641
2012-11-09 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
643
[Qt] Appending "!important" to the property value of QWebElement::setStyleProperty isn't working
644
https://bugs.webkit.org/show_bug.cgi?id=101763
646
Reviewed by Kenneth Rohde Christiansen.
648
In the pastWebCore have been considering the important token of a CSS
649
property value if it was followed by !important as well as the
650
important parameter of setInlineStyleProperty, but not anymore.
652
Since we need to keep the behavior compatible, do the parsing of the
653
value and extract the token if present. Ideally this would be passed
654
as a parameter to the function but I think it's not worth deprecating
656
The parsing is pretty dumb, so this will break applications that
657
passed a value with spaces between the "!" and "important".
659
This fixes part of tst_QWebElement::style
661
* Api/qwebelement.cpp:
662
(QWebElement::setStyleProperty):
664
2012-11-09 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
666
[Qt] Fix URL issues in tst_qwebframe
667
https://bugs.webkit.org/show_bug.cgi?id=101741
669
Reviewed by Simon Hausmann.
671
* tests/qwebframe/tst_qwebframe.cpp:
672
(FakeReply::FakeReply):
673
Properly forward the request URL to our custom reply.
674
This would cause redirections not to occur. The requestedUrl and setUrlSameUrl tests
675
would fail because of this.
677
(tst_QWebFrame::setUrlToInvalid):
678
- http:/example.com is a valid URL, but not a valid HTTP URL, so remove this check.
679
- QCOMPARE uses testlib's toString on the QUrls to compare them and it now
680
also output the error description. Since we want to compare the resulting
681
URL instead, compare their toEncoded() value.
683
2012-11-08 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
685
[Qt] Fix a crash in tst_QWebInspector::attachAndDestroy
686
https://bugs.webkit.org/show_bug.cgi?id=101575
688
Reviewed by Simon Hausmann.
690
It can now happen that destroyInspectorView is called when the Page
691
is destroyed. This would call getOrCreateInspector and re-create a
694
Since the new instance is created after our setInspector(0) cleanup
695
in ~QWebPagePrivate, this runs into the same crash that this line was
696
protecting us against.
698
* WebCoreSupport/InspectorClientQt.cpp:
699
(WebCore::InspectorFrontendClientQt::destroyInspectorView):
701
2012-11-09 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
703
[Qt] Unmark now passing tests
704
https://bugs.webkit.org/show_bug.cgi?id=65531
706
Reviewed by Csaba Osztrogonác.
708
* tests/qwebpage/tst_qwebpage.cpp:
709
(tst_QWebPage::viewModes):
711
2012-11-07 Allan Sandfeld Jensen <allan.jensen@digia.com>
713
[Qt] API test tst_qwebinspector crashes
714
https://bugs.webkit.org/show_bug.cgi?id=101599
716
Reviewed by Simon Hausmann.
718
Delete the internal inspector from QWebPage destructor, instead of causing recursions
719
between QWebPagePrivate::setInspector and QWebInspector::setPage.
721
Also separate the three tests in tst_QWebInspector to better tell which one is failing.
724
(QWebPagePrivate::~QWebPagePrivate):
725
(QWebPagePrivate::setInspector):
726
* tests/qwebinspector/tst_qwebinspector.cpp:
728
(tst_QWebInspector::attachAndDestroyPageFirst):
729
(tst_QWebInspector::attachAndDestroyInspectorFirst):
730
(tst_QWebInspector::attachAndDestroyInternalInspector):
732
2012-11-08 Allan Sandfeld Jensen <allan.jensen@digia.com>
734
[Qt] Open link in this window action
735
https://bugs.webkit.org/show_bug.cgi?id=101226
737
Reviewed by Csaba Osztrogonác.
739
* Api/qwebpage.cpp: Fix after r133763, move the initialization of OpenLinkInThisWindow to the proper place.
741
2012-11-07 Allan Sandfeld Jensen <allan.jensen@digia.com>
743
[Qt] Open link in this window action
744
https://bugs.webkit.org/show_bug.cgi?id=101226
746
Reviewed by Simon Hausmann.
748
Adds the action to QtWebKit.
751
(webActionForContextMenuAction):
752
(QWebPage::triggerAction):
756
2012-11-01 Stephen White <senorblanco@chromium.org>
758
Unreviewed, rolling out r133143.
759
http://trac.webkit.org/changeset/133143
760
https://bugs.webkit.org/show_bug.cgi?id=96894
762
Causing content_browsertests failures
764
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
765
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
767
2012-11-01 Kihong Kwon <kihong.kwon@samsung.com>
769
Add DeviceController base-class to remove duplication of DeviceXXXControler
770
https://bugs.webkit.org/show_bug.cgi?id=96894
772
Reviewed by Hajime Morita.
774
Change client() to deviceOrientationClient() to get DeviceOrientationClient*.
776
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
777
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
779
2012-10-31 Sheriff Bot <webkit.review.bot@gmail.com>
781
Unreviewed, rolling out r133016.
782
http://trac.webkit.org/changeset/133016
783
https://bugs.webkit.org/show_bug.cgi?id=100856
785
broke compile-webkit on several bots (Requested by podivilov
788
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
789
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
791
2012-10-31 Kihong Kwon <kihong.kwon@samsung.com>
793
Add DeviceController base-class to remove duplication of DeviceXXXControler
794
https://bugs.webkit.org/show_bug.cgi?id=96894
796
Reviewed by Hajime Morita.
798
Change client() to deviceOrientationClient() to get DeviceOrientationClient*.
800
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
801
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
803
2012-10-30 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
805
[QT][DRT] Remove unneeded testRunner.setMediaType() implementation
806
https://bugs.webkit.org/show_bug.cgi?id=100740
808
Reviewed by Kenneth Rohde Christiansen.
810
Removed unneeded testRunner.setMediaType() implementation, as tests use
811
cross-platform window.internals.settings.setMediaTypeOverride instead.
813
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
814
* WebCoreSupport/DumpRenderTreeSupportQt.h:
816
2012-10-24 Brady Eidson <beidson@apple.com>
818
Add a strategy for loader customization.
819
https://bugs.webkit.org/show_bug.cgi?id=100278
821
Reviewed by Alexey Proskuryakov.
823
* WebCoreSupport/PlatformStrategiesQt.cpp:
824
(PlatformStrategiesQt::createLoaderStrategy):
825
* WebCoreSupport/PlatformStrategiesQt.h:
826
(PlatformStrategiesQt):
828
2012-10-23 Alexey Proskuryakov <ap@apple.com>
830
Add a strategy for shared workers
831
https://bugs.webkit.org/show_bug.cgi?id=100165
833
Reviewed by Brady Eidson.
835
* WebCoreSupport/PlatformStrategiesQt.cpp:
836
(PlatformStrategiesQt::createPasteboardStrategy):
837
(PlatformStrategiesQt::createSharedWorkerStrategy):
838
(PlatformStrategiesQt::createVisitedLinkStrategy):
839
* WebCoreSupport/PlatformStrategiesQt.h:
841
2012-10-24 Allan Sandfeld Jensen <allan.jensen@digia.com>
843
[Qt] Expose useful WebCore::Settings
844
https://bugs.webkit.org/show_bug.cgi?id=100239
846
Reviewed by Kenneth Rohde Christiansen.
848
Expose the two settings CaretBrowsingEnabled and NotificationsEnabled.
850
* Api/qwebsettings.cpp:
851
(QWebSettingsPrivate::apply):
852
(QWebSettings::QWebSettings):
853
* Api/qwebsettings.h:
855
2012-10-23 Andras Becsi <andras.becsi@digia.com>
857
Remove devicePixelRatio from ViewportAttributes
858
https://bugs.webkit.org/show_bug.cgi?id=99845
860
Reviewed by Adam Barth.
862
Pass the device pixel ratio as a function argument to
866
(QWebPage::viewportAttributesForSize):
867
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
868
(DumpRenderTreeSupportQt::viewportAsText):
870
2012-10-23 Simon Hausmann <simon.hausmann@digia.com>
872
Unreviewed build fix with newer Qt 5.
874
QPlastiqueStyle has been removed, but as pointed out by Jens it's also not
875
maintained anymore and hence safe to remove. We can do tweaks with the new
876
fusion style if required.
878
* WebCoreSupport/QStyleFacadeImp.cpp:
879
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
881
2012-10-22 Simon Hausmann <simon.hausmann@digia.com>
883
[Qt] Fix build without QtWidgets
884
https://bugs.webkit.org/show_bug.cgi?id=99981
886
Reviewed by Tor Arne Vestbø.
888
Remove dependency to QtWidgets that is not needed here anymore since
889
the removal of the QtQuick1 code.
891
* declarative/experimental/experimental.pri:
892
* declarative/public.pri:
894
2012-10-22 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
896
[Qt] Fix "ASSERTION FAILED: !document->inPageCache()" when loading a page
897
https://bugs.webkit.org/show_bug.cgi?id=98514
899
Reviewed by Kenneth Rohde Christiansen.
901
* WebCoreSupport/FrameLoaderClientQt.cpp:
902
(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage): Use FrameView::fixedVisibleContentRect
903
instead of FrameView::visibleContentRect as the source to always keep the correct state.
905
2012-10-22 Allan Sandfeld Jensen <allan.jensen@digia.com>
907
[Qt] Basic gesture event handling
908
https://bugs.webkit.org/show_bug.cgi?id=66173
910
Reviewed by Simon Hausmann.
912
Implement basic handling of QGestureEvent converting and forwarding
913
Tap and TapAndHold gestures to WebCore.
916
(QWebPagePrivate::gestureEvent):
920
* WebCoreSupport/WebEventConversion.cpp:
921
(WebKitPlatformGestureEvent):
922
(WebCore::WebKitPlatformGestureEvent::WebKitPlatformGestureEvent):
923
(WebCore::convertGesture):
924
* WebCoreSupport/WebEventConversion.h:
926
2012-11-06 Allan Sandfeld Jensen <allan.jensen@digia.com>
928
Partial revert of r115998
930
Commit broke both ABI and API in QtWebKit.
933
(QWebPage::viewportAttributesForSize):
936
2012-10-17 Tor Arne Vestbø <tor.arne.vestbo@digia.com>
938
[Qt] Modularize documentation for QtWebKit
940
Running 'make docs' would fail unless 'make qmake_all' was ran first,
941
but qmake_all involved generating all the derived sources, which seems
942
overly complex just for building documentation.
944
We solve this by preventing all subdirs except QtWebKit from having a
945
docs target. This would normally work fine on its own, but since we
946
use CONFIG += ordered, there's now a missing doc target for the
947
immediate dependency of the QtWebKit subdir. We solve this by adding
948
a dummy-target ourselves.
950
Finally, we clean up the qdocconf file to match the rest of the Qt
951
documentation modularization efforts.
953
Reviewed by Simon Hausmann.
955
* docs/docs.pri: Removed.
956
* docs/qtwebkit.qdocconf: Removed.
958
2012-10-10 Jon Lee <jonlee@apple.com>
960
[WK2] Activate plugins when user clicks on snapshot
961
https://bugs.webkit.org/show_bug.cgi?id=98328
962
<rdar://problem/12426681>
964
Reviewed by Brady Eidson.
966
* WebCoreSupport/FrameLoaderClientQt.h:
967
(WebCore::FrameLoaderClientQt::recreatePlugin): Stub implementation of recreatePlugin().
969
2012-10-10 Balazs Kelemen <kbalazs@webkit.org>
971
[Qt] Test drivers should handle repaint rects
972
https://bugs.webkit.org/show_bug.cgi?id=68870
974
Reviewed by Zoltan Herczeg.
976
Added helpers to enable and get the repaint rects.
978
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
979
(DumpRenderTreeSupportQt::setTrackRepaintRects):
980
(DumpRenderTreeSupportQt::trackRepaintRects):
981
(DumpRenderTreeSupportQt::getTrackedRepaintRects):
982
* WebCoreSupport/DumpRenderTreeSupportQt.h:
984
2012-10-08 Simon Hausmann <simon.hausmann@digia.com>
986
[Qt] Make RenderThemeQStyle/ScrollbarThemeQStyle compile without QStyle/QtWidgets
987
https://bugs.webkit.org/show_bug.cgi?id=98268
989
Reviewed by Tor Arne Vestbø.
991
Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.
993
QStyleFacade is a pure interface that lives in WebCore/platform/qt
994
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
995
minimal interface of what we need to draw with QStyle as well as basic
996
hit testing and metric retrieval. It also provides a
997
QStyleFacadeOption class that aggregates common meta-data for
998
rendering primitives, such as direction, rectangle, state (sunken,
999
enabled, etc.) or palette. It also provides some more slider/scrollbar
1000
specific fields in a slider sub-structure.
1002
RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
1003
them with state information from render objects, before calling straight to QStyle. Most of the common code
1004
was encapsulated in StylePainterQStyle.
1006
The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
1007
StylePainterQStyle to populate state into QStyleFacadeOption before
1008
calling into QStyleFacade.
1010
The style facade is then implemented by QStyleFacadeImp, which extracts
1011
meta-data from QStyleFacadeOption arguments, populates style
1012
primitive specific QStyleOption objects and then calls on QStyle.
1014
RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
1015
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
1016
separate QtWebKitWidgets library in the future and therefore cannot use
1019
* WebCoreSupport/InitWebCoreQt.cpp:
1020
(WebCore::initializeWebCoreQt):
1021
* WebCoreSupport/QStyleFacadeImp.cpp: Added.
1023
(WebKit::convertToQStyleState):
1024
(WebKit::convertToQStyleSubControl):
1025
(WebKit::initGenericStyleOption):
1026
(WebKit::initSpecificStyleOption):
1027
(MappedStyleOption):
1028
(WebKit::MappedStyleOption::MappedStyleOption):
1029
(WebKit::convertPixelMetric):
1030
(WebKit::convertToQStyleFacadeSubControl):
1031
(WebKit::QStyleFacadeImp::QStyleFacadeImp):
1032
(WebKit::QStyleFacadeImp::~QStyleFacadeImp):
1033
(WebKit::QStyleFacadeImp::buttonSubElementRect):
1034
(WebKit::QStyleFacadeImp::findFrameLineWidth):
1035
(WebKit::QStyleFacadeImp::simplePixelMetric):
1036
(WebKit::QStyleFacadeImp::buttonMargin):
1037
(WebKit::QStyleFacadeImp::sliderLength):
1038
(WebKit::QStyleFacadeImp::sliderThickness):
1039
(WebKit::QStyleFacadeImp::progressBarChunkWidth):
1040
(WebKit::QStyleFacadeImp::getButtonMetrics):
1041
(WebKit::QStyleFacadeImp::sizeFromContents):
1042
(WebKit::QStyleFacadeImp::paintButton):
1043
(WebKit::QStyleFacadeImp::paintTextField):
1044
(WebKit::QStyleFacadeImp::paintComboBox):
1045
(WebKit::QStyleFacadeImp::paintComboBoxArrow):
1046
(WebKit::QStyleFacadeImp::paintSliderTrack):
1047
(WebKit::QStyleFacadeImp::paintSliderThumb):
1048
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
1049
(WebKit::QStyleFacadeImp::paintProgressBar):
1050
(WebKit::QStyleFacadeImp::scrollBarExtent):
1051
(WebKit::QStyleFacadeImp::scrollBarMiddleClickAbsolutePositionStyleHint):
1052
(WebKit::QStyleFacadeImp::paintScrollCorner):
1053
(WebKit::QStyleFacadeImp::hitTestScrollBar):
1054
(WebKit::QStyleFacadeImp::scrollBarSubControlRect):
1055
(WebKit::QStyleFacadeImp::paintScrollBar):
1056
(WebKit::QStyleFacadeImp::widgetForPainter):
1057
(WebKit::QStyleFacadeImp::style):
1058
* WebCoreSupport/QStyleFacadeImp.h: Added.
1062
(WebKit::QStyleFacadeImp::create):
1063
(WebKit::QStyleFacadeImp::isValid):
1065
2012-10-08 Zoltan Horvath <zoltan@webkit.org>
1067
[Qt] r122720 causes performance regression with DirectFB on ARMv7
1068
https://bugs.webkit.org/show_bug.cgi?id=97548
1070
Reviewed by Jocelyn Turcotte.
1072
Revert the rest of r122720. This change modifies the NativeImagePtr from QImage* to QPixmap*.
1074
Covered by existing tests.
1076
* Api/qwebframe.cpp:
1077
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
1078
* Api/qwebhistory.cpp:
1079
(QWebHistoryItem::icon):
1080
* Api/qwebsettings.cpp:
1081
(QWebSettings::iconForUrl):
1082
(QWebSettings::setWebGraphic):
1083
(QWebSettings::webGraphic):
1084
* WebCoreSupport/DragClientQt.cpp:
1085
(WebCore::DragClientQt::startDrag):
1086
* WebCoreSupport/InitWebCoreQt.cpp:
1087
(WebCore::initializeWebCoreQt):
1089
2012-10-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1091
Rename first/second to key/value in HashMap iterators
1092
https://bugs.webkit.org/show_bug.cgi?id=82784
1094
Reviewed by Eric Seidel.
1097
(extractContentTypeFromPluginVector):
1098
* Api/qwebplugindatabase.cpp:
1099
(QWebPluginInfo::mimeTypes):
1100
* WebCoreSupport/PlatformStrategiesQt.cpp:
1101
(PlatformStrategiesQt::getPluginInfo):
1103
2012-10-05 Simon Hausmann <simon.hausmann@digia.com>
1105
Unreviewed, rolling out r130495.
1106
http://trac.webkit.org/changeset/130495
1107
https://bugs.webkit.org/show_bug.cgi?id=98268
1109
Made WK2 tests crash.
1111
* WebCoreSupport/InitWebCoreQt.cpp:
1112
(WebCore::initializeWebCoreQt):
1113
* WebCoreSupport/QStyleFacadeImp.cpp: Removed.
1114
* WebCoreSupport/QStyleFacadeImp.h: Removed.
1115
* WebCoreSupport/RenderThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.cpp.
1117
(WebCore::initStyleOption):
1118
(WebCore::RenderThemeQStyle::getStylePainter):
1119
(WebCore::StylePainterQStyle::StylePainterQStyle):
1120
(WebCore::StylePainterQStyle::init):
1121
(WebCore::RenderThemeQStyle::create):
1122
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
1123
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
1124
(WebCore::RenderThemeQStyle::fallbackStyle):
1125
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists):
1126
(WebCore::RenderThemeQStyle::qStyle):
1127
(WebCore::RenderThemeQStyle::findFrameLineWidth):
1128
(WebCore::RenderThemeQStyle::inflateButtonRect):
1129
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
1130
(WebCore::RenderThemeQStyle::adjustButtonStyle):
1131
(WebCore::RenderThemeQStyle::setButtonPadding):
1132
(WebCore::RenderThemeQStyle::paintButton):
1133
(WebCore::RenderThemeQStyle::paintTextField):
1134
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
1135
(WebCore::RenderThemeQStyle::paintTextArea):
1136
(WebCore::RenderThemeQStyle::setPopupPadding):
1137
(WebCore::RenderThemeQStyle::colorPalette):
1138
(WebCore::RenderThemeQStyle::paintMenuList):
1139
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
1140
(WebCore::RenderThemeQStyle::paintMenuListButton):
1141
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
1142
(WebCore::RenderThemeQStyle::paintProgressBar):
1143
(WebCore::RenderThemeQStyle::paintSliderTrack):
1144
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
1145
(WebCore::RenderThemeQStyle::paintSliderThumb):
1146
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
1147
(WebCore::RenderThemeQStyle::paintSearchField):
1148
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
1149
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
1150
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
1151
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
1152
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
1153
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
1154
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
1155
* WebCoreSupport/RenderThemeQStyle.h: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.h.
1157
(RenderThemeQStyle):
1158
(StylePainterQStyle):
1159
(WebCore::StylePainterQStyle::isValid):
1160
(WebCore::StylePainterQStyle::drawPrimitive):
1161
(WebCore::StylePainterQStyle::drawControl):
1162
(WebCore::StylePainterQStyle::drawComplexControl):
1163
* WebCoreSupport/ScrollbarThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQStyle.cpp.
1165
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
1167
(WebCore::scrollbarPart):
1168
(WebCore::styleOptionSlider):
1169
(WebCore::ScrollbarThemeQStyle::paint):
1170
(WebCore::ScrollbarThemeQStyle::hitTest):
1171
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
1172
(WebCore::ScrollbarThemeQStyle::invalidatePart):
1173
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
1174
(WebCore::ScrollbarThemeQStyle::thumbPosition):
1175
(WebCore::ScrollbarThemeQStyle::thumbLength):
1176
(WebCore::ScrollbarThemeQStyle::trackPosition):
1177
(WebCore::ScrollbarThemeQStyle::trackLength):
1178
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
1179
(WebCore::ScrollbarThemeQStyle::style):
1180
* WebCoreSupport/ScrollbarThemeQStyle.h: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQStyle.h.
1182
(ScrollbarThemeQStyle):
1184
2012-10-05 Simon Hausmann <simon.hausmann@digia.com>
1186
[Qt] Make RenderThemeQStyle/ScrollbarThemeQStyle compile without QStyle/QtWidgets
1187
https://bugs.webkit.org/show_bug.cgi?id=98268
1189
Reviewed by Tor Arne Vestbø.
1191
Extracted QStyle/QWidget related code into a QWebStyle class that implements the QStyleFacade interface.
1193
QStyleFacade is a pure interface that lives in WebCore/platform/qt
1194
(next to RenderThemeQStyle and ScrollbarThemeQStyle) and provides a
1195
minimal interface of what we need to draw with QStyle as well as basic
1196
hit testing and metric retrieval. It also provides a
1197
QStyleFacadeOption class that aggregates common meta-data for
1198
rendering primitives, such as direction, rectangle, state (sunken,
1199
enabled, etc.) or palette. It also provides some more slider/scrollbar
1200
specific fields in a slider sub-structure.
1202
RenderThemeQStyle/ScrollbarThemeQStyle used to instantiate specific QStyleOption sub-classes and populate
1203
them with state information from render objects, before calling straight to QStyle. Most of the common code
1204
was encapsulated in StylePainterQStyle.
1206
The new RenderThemeQStyle/ScrolllbarThemeQStyle uses common code in
1207
StylePainterQStyle to populate state into QStyleFacadeOption before
1208
calling into QStyleFacade.
1210
The style facade is then implemented by QStyleFacadeImp, which extracts
1211
meta-data from QStyleFacadeOption arguments, populates style
1212
primitive specific QStyleOption objects and then calls on QStyle.
1214
RenderThemeQStyle/ScrollbarThemeQStyle can only use interface methods
1215
from QStyleFacade. QStyleFacadeImp on the other hand will live in the
1216
separate QtWebKitWidgets library in the future and therefore cannot use
1219
* WebCoreSupport/InitWebCoreQt.cpp:
1220
(WebCore::initializeWebCoreQt):
1221
* WebCoreSupport/QStyleFacadeImp.cpp: Added.
1223
(WebKit::convertToQStyleState):
1224
(WebKit::convertToQStyleSubControl):
1225
(WebKit::initGenericStyleOption):
1226
(WebKit::initSpecificStyleOption):
1227
(MappedStyleOption):
1228
(WebKit::MappedStyleOption::MappedStyleOption):
1229
(WebKit::convertPixelMetric):
1230
(WebKit::convertToQStyleFacadeSubControl):
1231
(WebKit::QStyleFacadeImp::QStyleFacadeImp):
1232
(WebKit::QStyleFacadeImp::~QStyleFacadeImp):
1233
(WebKit::QStyleFacadeImp::buttonSubElementRect):
1234
(WebKit::QStyleFacadeImp::findFrameLineWidth):
1235
(WebKit::QStyleFacadeImp::simplePixelMetric):
1236
(WebKit::QStyleFacadeImp::buttonMargin):
1237
(WebKit::QStyleFacadeImp::sliderLength):
1238
(WebKit::QStyleFacadeImp::sliderThickness):
1239
(WebKit::QStyleFacadeImp::progressBarChunkWidth):
1240
(WebKit::QStyleFacadeImp::getButtonMetrics):
1241
(WebKit::QStyleFacadeImp::sizeFromContents):
1242
(WebKit::QStyleFacadeImp::paintButton):
1243
(WebKit::QStyleFacadeImp::paintTextField):
1244
(WebKit::QStyleFacadeImp::paintComboBox):
1245
(WebKit::QStyleFacadeImp::paintComboBoxArrow):
1246
(WebKit::QStyleFacadeImp::paintSliderTrack):
1247
(WebKit::QStyleFacadeImp::paintSliderThumb):
1248
(WebKit::QStyleFacadeImp::paintInnerSpinButton):
1249
(WebKit::QStyleFacadeImp::paintProgressBar):
1250
(WebKit::QStyleFacadeImp::scrollBarExtent):
1251
(WebKit::QStyleFacadeImp::scrollBarMiddleClickAbsolutePositionStyleHint):
1252
(WebKit::QStyleFacadeImp::paintScrollCorner):
1253
(WebKit::QStyleFacadeImp::hitTestScrollBar):
1254
(WebKit::QStyleFacadeImp::scrollBarSubControlRect):
1255
(WebKit::QStyleFacadeImp::paintScrollBar):
1256
(WebKit::QStyleFacadeImp::widgetForPainter):
1257
(WebKit::QStyleFacadeImp::style):
1258
* WebCoreSupport/QStyleFacadeImp.h: Added.
1262
(WebKit::QStyleFacadeImp::create):
1263
(WebKit::QStyleFacadeImp::isValid):
1265
2012-10-05 Simon Hausmann <simon.hausmann@digia.com>
1267
[Qt] Remove dead code
1268
https://bugs.webkit.org/show_bug.cgi?id=98491
1270
Reviewed by Jocelyn Turcotte.
1272
This code was added long time ago for a Symbian related project and is
1275
* Api/qwebframe.cpp:
1277
2012-10-04 Simon Fraser <simon.fraser@apple.com>
1279
Final part of "sync" to "flush" renaming
1280
https://bugs.webkit.org/show_bug.cgi?id=98430
1282
Reviewed by Tim Horton.
1284
Change method names on GraphicsLayer and GraphicsLayerClient that
1285
refer to "sync" to use the term "flush" instead, to be consistent
1286
with the rest of the code.
1288
* WebCoreSupport/PageClientQt.cpp:
1289
(WebCore::TextureMapperLayerClientQt::syncRootLayer):
1291
2012-10-04 Simon Fraser <simon.fraser@apple.com>
1293
Standardize on "flush" terminology for compositing layer flushing/syncing
1294
https://bugs.webkit.org/show_bug.cgi?id=98321
1296
Reviewed by Simon Fraser.
1298
Rename compositing-related methods that refer to "syncing" to instead
1299
refer to "flushing".
1301
* WebCoreSupport/ChromeClientQt.cpp:
1302
(WebCore::ChromeClientQt::scheduleCompositingLayerFlush):
1303
* WebCoreSupport/ChromeClientQt.h:
1305
* WebCoreSupport/PageClientQt.cpp:
1306
(WebCore::PageClientQGraphicsWidget::syncLayers):
1308
2012-10-03 Balazs Kelemen <kbalazs@webkit.org>
1310
[Qt] Enable mock scrollbars
1311
https://bugs.webkit.org/show_bug.cgi?id=98011
1313
Reviewed by Csaba Osztrogonác.
1315
Added helper to enable mock scrollbars.
1317
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1318
(DumpRenderTreeSupportQt::enableMockScrollbars):
1319
* WebCoreSupport/DumpRenderTreeSupportQt.h:
1321
2012-10-01 Brady Eidson <beidson@apple.com>
1323
Remove the Safari 2 -> Safari 3 icon database import code.
1324
https://bugs.webkit.org/show_bug.cgi?id=98113
1326
Reviewed by Maciej Stachowiak.
1328
Nuke the performImport() IconDatabaseClient method.
1330
* WebCoreSupport/IconDatabaseClientQt.cpp:
1331
* WebCoreSupport/IconDatabaseClientQt.h:
1332
(IconDatabaseClientQt):
1334
2012-09-28 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
1336
Code inside FrameLoaderClient::canShowMIMEType() implementations can be shared among different WK ports
1337
https://bugs.webkit.org/show_bug.cgi?id=97547
1339
Reviewed by Adam Barth.
1341
Newly added WebCore::MIMETypeRegistry::canShowMIMEType() function is used
1342
inside WebCore::FrameLoaderClientQt::canShowMIMEType().
1344
* WebCoreSupport/FrameLoaderClientQt.cpp:
1345
(WebCore::FrameLoaderClientQt::canShowMIMEType):
1347
2012-09-27 Allan Sandfeld Jensen <allan.jensen@digia.com>
1349
Unify event handling of middle mouse button.
1350
https://bugs.webkit.org/show_bug.cgi?id=97690
1352
Reviewed by Tony Chang.
1354
Remove port specific handling of middle mouse button press.
1357
(QWebPagePrivate::mouseReleaseEvent):
1361
2012-09-25 Beth Dakin <bdakin@apple.com>
1363
https://bugs.webkit.org/show_bug.cgi?id=95397
1364
Need to merge didFirstVisuallyNonEmptyLayout and
1365
didNewFirstVisuallyNonEmptyLayout
1367
<rdar://problem/10791680>
1369
Reviewed by Sam Weinig.
1371
Remove dispatchDidFirstLayout,
1372
dispatchDidFirstVisuallyNonEmptyLayout, and
1373
dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
1374
is now replaced by dispatchDidLayout(LayoutMilestoneOptions)
1375
* WebCoreSupport/FrameLoaderClientQt.cpp:
1376
(WebCore::FrameLoaderClientQt::dispatchDidLayout):
1377
* WebCoreSupport/FrameLoaderClientQt.h:
1378
(FrameLoaderClientQt):
1380
It is now necessary to opt into getting any of the
1381
"layout milestone" notifications.
1383
(QWebPagePrivate::QWebPagePrivate):
1385
2012-09-25 Simon Hausmann <simon.hausmann@digia.com>
1387
[Qt] Fix failing assertion when calling QWebSettings::setIconDatabasePath multiple times
1389
Reviewed by Jocelyn Turcotte.
1391
This happens in various auto-tests. We can implement this by closing the database before
1392
opening it with the new path.
1394
* Api/qwebsettings.cpp:
1395
(QWebSettings::setIconDatabasePath):
1397
2012-09-24 Benjamin Poulain <bpoulain@apple.com>
1399
Fix Geolocation error reporting in the test support
1400
https://bugs.webkit.org/show_bug.cgi?id=97386
1402
Reviewed by Sam Weinig.
1404
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1405
(DumpRenderTreeSupportQt::setMockGeolocationPositionUnavailableError):
1406
* WebCoreSupport/DumpRenderTreeSupportQt.h:
1408
2012-09-20 Csaba Osztrogonác <ossy@webkit.org>
1410
[Qt] Enable CSS regions by default
1411
https://bugs.webkit.org/show_bug.cgi?id=97196
1413
Reviewed by Dirk Schulze.
1415
* Api/qwebsettings.cpp:
1416
(QWebSettings::QWebSettings):
1418
2012-09-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1420
[Qt] Use UndoStep::editingAction() to set the text of undo/redo actions
1421
https://bugs.webkit.org/show_bug.cgi?id=96921
1423
Reviewed by Ryosuke Niwa.
1425
Set the text of QUndoCommands we create for undo/redo actions based on the
1426
editing action from UndoStep.
1428
This change is visible using QtTestBrowser, and looking at the Edit menu after
1429
doing HTML editing changes. I've used http://simple-rte.rniwa.com for testing.
1431
* WebCoreSupport/UndoStepQt.cpp:
1432
(undoNameForEditAction): This function returns a localized name of the action.
1433
(UndoStepQt::UndoStepQt): Set the text based on UndoStep::editingAction.
1434
* tests/qwebpage/tst_qwebpage.cpp:
1436
(tst_QWebPage::undoActionHaveCustomText): Create a new test to verify that the text
1437
describing the undo action after inserting a text and indenting the text is different.
1439
2012-09-17 Leo Franchi <lfranchi@kde.org>
1441
[Qt] Inspector WebSocket backend protocol update
1442
https://bugs.webkit.org/show_bug.cgi?id=77031
1444
Also adds support for multi-frame messages and non-text messages.
1445
Thanks to Jocelyn Turcotte for most of the WebSocket update code!
1447
Reviewed by Simon Hausmann.
1449
* WebCoreSupport/InspectorServerQt.cpp:
1451
(WebCore::generateWebSocketChallengeResponse):
1452
(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
1453
(WebCore::InspectorServerRequestHandlerQt::webSocketSend):
1454
(WebCore::applyMask):
1455
(WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):
1456
* WebCoreSupport/InspectorServerQt.h:
1457
(InspectorServerRequestHandlerQt):
1459
2012-09-15 Pierre Rossi <pierre.rossi@gmail.com>
1461
[Qt] QDoc fixes for Qt 5 documentation
1462
https://bugs.webkit.org/show_bug.cgi?id=96796
1464
Reviewed by Simon Hausmann.
1466
Produce fewer warnings and a better documentation.
1467
Having two QML modules providing a WebView component is a bit too much for poor old qdoc to
1468
cope with (or would require a lot of painful disambiguation by hand). Since the plan is to have
1469
QDeclarativeWebView living in the qtquick1 module, we can already take it out of the
1470
documentation generation for now.
1472
* declarative/qdeclarativewebview.cpp: s/qmlclass/qmltype/ out of principle
1473
* docs/qtwebkit.qdocconf: Remove the \i alias that caused a warning. Use *.h as headers suffix, not sources.
1474
Also remove QDeclarativeWebView from the documentation.
1476
2012-09-13 Lauro Neto <lauro.neto@openbossa.org>
1478
[Qt][WK2] fast/forms/access-key-for-all-elements.html fails
1479
https://bugs.webkit.org/show_bug.cgi?id=73917
1481
Reviewed by Simon Hausmann.
1483
Access-key tests were failing due to hardcoded Mac OS X in the
1484
Qt WK2 user agent string. This commit moves the WK1 implementation
1485
to a shared one to be used by both versions.
1487
Change QWebPage to use the shared user agent implementation.
1490
(QWebPage::userAgentForUrl):
1492
2012-09-13 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
1494
[Qt] Fix qdoc executable preparation
1496
Reviewed by Tor Arne Vestbø.
1500
2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
1502
Unreviewed, rolling out r127876.
1503
http://trac.webkit.org/changeset/127876
1504
https://bugs.webkit.org/show_bug.cgi?id=96600
1506
mouse click doesn't work for spin button if spin button in
1507
iframe (Requested by yosin on #webkit).
1509
* Api/qwebframe.cpp:
1510
(QWebFrame::hitTestContent):
1512
(QWebPagePrivate::handleSoftwareInputPanel):
1513
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
1514
(QWebPage::updatePositionDependentActions):
1515
* WebCoreSupport/FrameLoaderClientQt.cpp:
1516
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
1518
2012-09-12 Roland Takacs <rtakacs@inf.u-szeged.hu>
1520
[Qt] Segmentation fault when closing QtTestBrowser
1521
https://bugs.webkit.org/show_bug.cgi?id=95003
1523
Reviewed by Simon Hausmann.
1525
Defined a new QObject* variable that points to the QGLWidget that was created
1526
in 'createPlatformGraphicsContext3DFromWidget'.
1527
It is neccessary for deallocating it.
1529
* WebCoreSupport/PageClientQt.cpp:
1530
(createPlatformGraphicsContext3DFromWidget):
1531
(WebCore::PageClientQWidget::createPlatformGraphicsContext3D):
1532
(WebCore::PageClientQGraphicsWidget::createPlatformGraphicsContext3D):
1533
* WebCoreSupport/PageClientQt.h:
1534
(PageClientQWidget):
1535
(PageClientQGraphicsWidget):
1537
2012-09-12 Andras Becsi <andras.becsi@nokia.com>
1539
[Qt] Add module identifier directive to the qmldir files
1540
https://bugs.webkit.org/show_bug.cgi?id=96406
1542
Reviewed by Simon Hausmann.
1544
Qt5 QML modules need to be identified. Type registrations are only permitted
1545
into the namespace identified in the qmldir file's module identifier directive.
1546
Additionally this also facilitates the protection against external registrations.
1547
This patch suppresses a warning when importing the QtWebKit module.
1549
* declarative/experimental/qmldir:
1550
* declarative/qmldir:
1552
2012-09-11 Marcelo Lira <marcelo.lira@openbossa.org>
1554
Restore original value of mock scrollbars enabled in InternalSettings
1555
https://bugs.webkit.org/show_bug.cgi?id=87680
1557
Reviewed by Adam Barth.
1559
Added backup support for mock scrollbars state in
1560
InternalSettings::Backup, and removed support for these
1561
from Qt's DumpRenderTree.
1563
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1564
* WebCoreSupport/DumpRenderTreeSupportQt.h:
1566
2012-09-09 Emil A Eklund <eae@chromium.org>
1568
Rename Node::getRect/getPixelSnappedRect and remove ContainerNode::getRect
1569
https://bugs.webkit.org/show_bug.cgi?id=81413
1571
Reviewed by David Hyatt.
1573
Update qwebelement and qwebpage to call pixelSnappedBoundingBox.
1575
* Api/qwebelement.cpp:
1576
(QWebElement::geometry):
1577
(QWebElement::render):
1579
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
1581
2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com>
1583
Simplify hitTestResultAtPoint and nodesFromRect APIs
1584
https://bugs.webkit.org/show_bug.cgi?id=95720
1586
Reviewed by Antonio Gomes.
1588
Update calls to new API.
1590
* Api/qwebframe.cpp:
1591
(QWebFrame::hitTestContent):
1593
(QWebPagePrivate::handleSoftwareInputPanel):
1594
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
1595
(QWebPage::updatePositionDependentActions):
1596
* WebCoreSupport/FrameLoaderClientQt.cpp:
1597
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
1599
2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com>
1601
X11 Global Selection
1602
https://bugs.webkit.org/show_bug.cgi?id=88238
1604
Reviewed by Tony Chang.
1606
Use new editor command for pasting global selection, and update it using
1607
the respondToChangedSelection callback.
1610
(QWebPagePrivate::handleClipboard):
1611
* WebCoreSupport/EditorClientQt.cpp:
1612
(WebCore::EditorClientQt::respondToChangedSelection):
1613
(WebCore::EditorClientQt::supportsGlobalSelection):
1614
* WebCoreSupport/EditorClientQt.h:
1617
2012-09-05 Sam Weinig <sam@webkit.org>
1619
Part 2 of removing PlatformString.h, remove PlatformString.h
1620
https://bugs.webkit.org/show_bug.cgi?id=95931
1622
Reviewed by Adam Barth.
1624
Remove PlatformString.h
1626
* Api/qwebdatabase_p.h:
1627
* Api/qwebframe_p.h:
1628
* Api/qwebhistory.cpp:
1629
* Api/qwebhistoryinterface.cpp:
1631
* Api/qwebsettings.cpp:
1632
* WebCoreSupport/ChromeClientQt.h:
1633
* WebCoreSupport/InspectorClientQt.cpp:
1635
2012-09-05 Kaustubh Atrawalkar <kaustubh@motorola.com>
1637
[DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
1638
https://bugs.webkit.org/show_bug.cgi?id=92735
1640
Reviewed by Hajime Morita.
1642
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
1644
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1645
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
1646
* WebCoreSupport/DumpRenderTreeSupportQt.h:
1648
2012-09-04 Jon Lee <jonlee@apple.com>
1650
[Qt] REGRESSION(r127321): It made 3 notification test timeout
1651
https://bugs.webkit.org/show_bug.cgi?id=95638
1653
Reviewed by Csaba Osztrogonác.
1655
Dispatch show event instead of display after r127321.
1657
* WebCoreSupport/NotificationPresenterClientQt.cpp:
1658
(WebCore::NotificationPresenterClientQt::sendDisplayEvent):
1660
2012-08-31 Simon Hausmann <simon.hausmann@nokia.com>
1662
[Qt] Port convertValueToQVariant to use the JSC C API
1663
https://bugs.webkit.org/show_bug.cgi?id=94695
1665
Reviewed by Kenneth Rohde Christiansen.
1667
Minor adaptations are needed here to accomodate the changed signature of
1668
convertValueToQVariant.
1670
* Api/qwebelement.cpp:
1671
(QWebElement::evaluateJavaScript):
1672
(convertJSValueToWebElementVariant):
1673
* Api/qwebframe.cpp:
1674
(QWebFrame::evaluateJavaScript):
1675
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
1676
(convertJSValueToNodeVariant):
1678
2012-08-30 Geoffrey Garen <ggaren@apple.com>
1680
Use one object instead of two for closures, eliminating ScopeChainNode
1681
https://bugs.webkit.org/show_bug.cgi?id=95501
1683
Reviewed by Filip Pizlo.
1685
Mechanical change to update for JSC interface change.
1687
* Api/qwebelement.cpp:
1688
(QWebElement::evaluateJavaScript):
1690
2012-08-30 Benjamin Poulain <bpoulain@apple.com>
1692
Replace JSC::UString by WTF::String
1693
https://bugs.webkit.org/show_bug.cgi?id=95271
1695
Reviewed by Geoffrey Garen.
1697
Replace UString by String.
1699
* Api/qwebelement.cpp:
1700
(QWebElement::evaluateJavaScript):
1702
2012-08-29 Simon Hausmann <simon.hausmann@nokia.com>
1704
[Qt] Fix doc generation with make docs
1705
https://bugs.webkit.org/show_bug.cgi?id=95340
1707
Reviewed by Kenneth Rohde Christiansen.
1709
Fix doc target, similar to what the other Qt 5 modules are using and comment out the indexes
1710
line, because cross-referencing doesn't work right now and the use of the QTDIR environment
1714
* docs/qtwebkit.qdocconf:
1716
2012-08-22 Simon Hausmann <simon.hausmann@nokia.com>
1718
[Qt] REGRESSION(r125428): fast/profiler/nested-start-and-stop-profiler.html fails
1719
https://bugs.webkit.org/show_bug.cgi?id=93897
1721
Reviewed by Kenneth Rohde Christiansen.
1723
Fixed some test expectations.
1725
* tests/qobjectbridge/tst_qobjectbridge.cpp:
1726
(tst_QObjectBridge::objectDeleted): Since runtime methods are real function objects again, we
1727
can go back to testing Function.prototype.call, as it was done before r125428.
1728
(tst_QObjectBridge::introspectQtMethods_data): Removed tests for the length property.
1729
(tst_QObjectBridge::introspectQtMethods): Changed test expectation of the properties of
1730
run-time methods back to being non-configurable, as before r125428.
1732
2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com>
1734
Unreviewed, rolling out r126914.
1735
http://trac.webkit.org/changeset/126914
1736
https://bugs.webkit.org/show_bug.cgi?id=95239
1738
it breaks everything and fixes nothing (Requested by pizlo on
1742
(extractContentTypeFromPluginVector):
1743
* Api/qwebplugindatabase.cpp:
1744
(QWebPluginInfo::mimeTypes):
1745
* WebCoreSupport/PlatformStrategiesQt.cpp:
1746
(PlatformStrategiesQt::getPluginInfo):
1748
2012-08-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1750
Rename first/second to key/value in HashMap iterators
1751
https://bugs.webkit.org/show_bug.cgi?id=82784
1753
Reviewed by Eric Seidel.
1756
(extractContentTypeFromPluginVector):
1757
* Api/qwebplugindatabase.cpp:
1758
(QWebPluginInfo::mimeTypes):
1759
* WebCoreSupport/PlatformStrategiesQt.cpp:
1760
(PlatformStrategiesQt::getPluginInfo):
1762
2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
1764
Unreviewed, rolling out r126836.
1765
http://trac.webkit.org/changeset/126836
1766
https://bugs.webkit.org/show_bug.cgi?id=95163
1768
Broke all Apple ports, EFL, and Qt. (Requested by tkent on
1772
(extractContentTypeFromPluginVector):
1773
* Api/qwebplugindatabase.cpp:
1774
(QWebPluginInfo::mimeTypes):
1775
* WebCoreSupport/PlatformStrategiesQt.cpp:
1776
(PlatformStrategiesQt::getPluginInfo):
1778
2012-08-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1780
Rename first/second to key/value in HashMap iterators
1781
https://bugs.webkit.org/show_bug.cgi?id=82784
1783
Reviewed by Eric Seidel.
1786
(extractContentTypeFromPluginVector):
1787
* Api/qwebplugindatabase.cpp:
1788
(QWebPluginInfo::mimeTypes):
1789
* WebCoreSupport/PlatformStrategiesQt.cpp:
1790
(PlatformStrategiesQt::getPluginInfo):
1792
2012-08-22 Sheriff Bot <webkit.review.bot@gmail.com>
1794
Unreviewed, rolling out r126287.
1795
http://trac.webkit.org/changeset/126287
1796
https://bugs.webkit.org/show_bug.cgi?id=94708
1798
It made WK1 layout testing 3.7x slower (>1hours) (Requested by
1801
* tests/qobjectbridge/tst_qobjectbridge.cpp:
1802
(tst_QObjectBridge::objectDeleted):
1803
(tst_QObjectBridge::introspectQtMethods_data):
1804
(tst_QObjectBridge::introspectQtMethods):
1806
2012-08-22 Allan Sandfeld Jensen <allan.jensen@nokia.com>
1808
[Qt] Optionally support smooth-scrolling on all platforms
1809
https://bugs.webkit.org/show_bug.cgi?id=74926
1811
Reviewed by Simon Hausmann.
1813
Expose the enable scroll animator setting.
1815
* Api/qwebsettings.cpp:
1816
(QWebSettingsPrivate::apply):
1817
(QWebSettings::QWebSettings):
1818
* Api/qwebsettings.h:
1820
2012-08-22 Simon Hausmann <simon.hausmann@nokia.com>
1822
[Qt] REGRESSION(r125428): fast/profiler/nested-start-and-stop-profiler.html fails
1823
https://bugs.webkit.org/show_bug.cgi?id=93897
1825
Reviewed by Kenneth Rohde Christiansen.
1827
Fixed some test expectations.
1829
* tests/qobjectbridge/tst_qobjectbridge.cpp:
1830
(tst_QObjectBridge::objectDeleted): Since runtime methods are real function objects again, we
1831
can go back to testing Function.prototype.call, as it was done before r125428.
1832
(tst_QObjectBridge::introspectQtMethods_data): Removed tests for the length property.
1833
(tst_QObjectBridge::introspectQtMethods): Changed test expectation of the properties of
1834
run-time methods back to being non-configurable, as before r125428.
1836
2012-08-21 Sheriff Bot <webkit.review.bot@gmail.com>
1838
Unreviewed, rolling out r126146.
1839
http://trac.webkit.org/changeset/126146
1840
https://bugs.webkit.org/show_bug.cgi?id=94606
1842
It made all tests assert (Requested by Ossy on #webkit).
1844
* tests/qobjectbridge/tst_qobjectbridge.cpp:
1845
(tst_QObjectBridge::objectDeleted):
1846
(tst_QObjectBridge::introspectQtMethods_data):
1847
(tst_QObjectBridge::introspectQtMethods):
1849
2012-08-17 Simon Hausmann <simon.hausmann@nokia.com>
1851
[Qt] REGRESSION(r125428): fast/profiler/nested-start-and-stop-profiler.html fails
1852
https://bugs.webkit.org/show_bug.cgi?id=93897
1854
Reviewed by Kenneth Rohde Christiansen.
1856
Fixed some test expectations.
1858
* tests/qobjectbridge/tst_qobjectbridge.cpp:
1859
(tst_QObjectBridge::objectDeleted): Since runtime methods are real function objects again, we
1860
can go back to testing Function.prototype.call, as it was done before r125428.
1861
(tst_QObjectBridge::introspectQtMethods_data): Removed tests for the length property.
1862
(tst_QObjectBridge::introspectQtMethods): Changed test expectation of the properties of
1863
run-time methods back to being non-configurable, as before r125428.
1865
2012-08-15 Ryosuke Niwa <rniwa@webkit.org>
1867
Update manual tests and comments to refer to TestRunner instead of LayoutTestController
1868
https://bugs.webkit.org/show_bug.cgi?id=94168
1870
Reviewed by Kent Tamura.
1872
* Api/qwebelement.cpp:
1873
(convertJSValueToWebElementVariant):
1874
* WebCoreSupport/DumpRenderTreeSupportQt.h:
1876
2012-08-14 Adam Barth <abarth@webkit.org>
1878
Delete Frame::domWindow() and Frame::existingDOMWindow()
1879
https://bugs.webkit.org/show_bug.cgi?id=93990
1881
Reviewed by Eric Seidel.
1883
* WebCoreSupport/FrameLoaderClientQt.cpp:
1884
(WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):
1886
2012-08-14 Lauro Neto <lauro.neto@openbossa.org>
1888
Convert signals/slots to Q_* macros.
1890
[Qt] Use Q_SLOTS and Q_SIGNALS instead of slots and signals
1891
https://bugs.webkit.org/show_bug.cgi?id=93996
1893
Reviewed by Kenneth Rohde Christiansen.
1895
Change usage of keyword-conflicting 'signals' and 'slots' for
1896
Q_SIGNALS and Q_SLOTS macro.
1898
* WebCoreSupport/FrameLoaderClientQt.h:
1899
(FrameLoaderClientQt):
1900
* WebCoreSupport/FullScreenVideoQt.h:
1901
(FullScreenVideoQt):
1902
* WebCoreSupport/FullScreenVideoWidget.h:
1903
(FullScreenVideoWidget):
1904
* WebCoreSupport/IconDatabaseClientQt.h:
1905
(IconDatabaseClientQt):
1906
* WebCoreSupport/InspectorClientQt.cpp:
1907
(InspectorClientWebPage):
1908
* WebCoreSupport/InspectorServerQt.h:
1909
(InspectorServerQt):
1910
(InspectorServerRequestHandlerQt):
1911
* WebCoreSupport/PopupMenuQt.h:
1913
* WebCoreSupport/QtFallbackWebPopup.h:
1914
(QtFallbackWebPopup):
1915
* docs/webkitsnippets/qtwebkit_bridge_snippets.cpp:
1917
* docs/webkitsnippets/webpage/main.cpp:
1919
* examples/platformplugin/WebPlugin.h:
1922
* tests/benchmarks/webgl/tst_webgl.cpp:
1923
(tst_WebGlPerformance):
1924
* tests/hybridPixmap/tst_hybridPixmap.cpp:
1926
* tests/hybridPixmap/widget.h:
1928
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
1929
(tst_QDeclarativeWebView):
1930
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
1931
(tst_QGraphicsWebView):
1934
* tests/qobjectbridge/tst_qobjectbridge.cpp:
1935
(MyWebElementSlotOnlyObject):
1936
(tst_QObjectBridge):
1938
* tests/qwebelement/tst_qwebelement.cpp:
1940
* tests/qwebframe/tst_qwebframe.cpp:
1943
* tests/qwebhistory/tst_qwebhistory.cpp:
1944
* tests/qwebhistoryinterface/tst_qwebhistoryinterface.cpp:
1945
(tst_QWebHistoryInterface):
1946
* tests/qwebinspector/tst_qwebinspector.cpp:
1947
(tst_QWebInspector):
1948
* tests/qwebpage/tst_qwebpage.cpp:
1951
(RepaintRequestedRenderer):
1952
(SpyForLoadSignalsOrder):
1953
* tests/qwebplugindatabase/tst_qwebplugindatabase.cpp:
1954
(tst_QWebPluginDatabase):
1955
* tests/qwebview/tst_qwebview.cpp:
1959
2012-08-14 Simon Hausmann <simon.hausmann@nokia.com>
1961
[Qt] Fix failing tst_QWebPage::findText unit test
1962
https://bugs.webkit.org/show_bug.cgi?id=93951
1964
Reviewed by Kenneth Rohde Christiansen.
1966
Adjust the expected text, as the HTML editing code improved to avoid unnecessary tags.
1968
* tests/qwebpage/tst_qwebpage.cpp:
1969
(tst_QWebPage::findText):
1971
2012-08-13 Tom Sepez <tsepez@chromium.org>
1973
[chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
1974
https://bugs.webkit.org/show_bug.cgi?id=93283
1976
Reviewed by Eric Seidel.
1978
Change the client redirectDataToPlugin method(s) to expect the possibility of
1979
a NULL argument, keeping existing behaviour otherwise.
1981
* WebCoreSupport/FrameLoaderClientQt.cpp:
1982
(WebCore::FrameLoaderClientQt::redirectDataToPlugin):
1984
2012-08-13 Simon Hausmann <simon.hausmann@nokia.com>
1986
[Qt] Port meta method/signal/slot handling in run-time bridge to use JSC C API
1987
https://bugs.webkit.org/show_bug.cgi?id=93476
1989
Reviewed by Kenneth Rohde Christiansen.
1991
Changed semantics of some test expectations. Similarly to r125032 when generating
1992
error exceptions for connect/disconnect, we cannot generate explicit type error
1993
exceptions but only generic errors. Another change is that the meta-method wrapper
1994
doesn't support the call() through Function.prototype anymore. See WebCore changelog
1997
* tests/qobjectbridge/tst_qobjectbridge.cpp:
1998
(tst_QObjectBridge::connectAndDisconnect):
1999
(tst_QObjectBridge::objectDeleted):
2000
(tst_QObjectBridge::introspectQtMethods):
2002
2012-08-13 Kwang Yul Seo <skyul@company100.net>
2004
[Qt] Add gprof.prf to build WebKit with gprof enabled
2005
https://bugs.webkit.org/show_bug.cgi?id=90283
2007
Reviewed by Eric Seidel.
2009
* tests/MIMESniffing/MIMESniffing.pro:
2010
Don't build MIMESniffing.cpp because MIMESniffing test links
2011
WebKitQt statically when gprof is enabled.
2013
2012-08-12 Loïc Yhuel <loic.yhuel@softathome.com>
2015
[Qt] Make it possible to build without QtTest/QtPrintSupport
2016
https://bugs.webkit.org/show_bug.cgi?id=93492
2018
Reviewed by Tor Arne Vestbø.
2020
* Api/qwebframe.cpp:
2021
(QWebFrame::print): Does nothing if no printsupport
2023
(QWebView::print): Does nothing if no printsupport
2025
2012-08-11 Pierre Rossi <pierre.rossi@gmail.com>
2027
[Qt] Add support for HTML5 state object history API in FrameLoaderClientQt
2028
https://bugs.webkit.org/show_bug.cgi?id=93648
2030
Reviewed by Kenneth Rohde Christiansen.
2032
Add support for push/replace/pop by implementing dispatchDidNavigateWithinPage.
2034
* WebCoreSupport/FrameLoaderClientQt.cpp:
2035
(WebCore::FrameLoaderClientQt::dispatchDidNavigateWithinPage):
2036
(WebCore::FrameLoaderClientQt::dispatchDidPushStateWithinPage):
2037
(WebCore::FrameLoaderClientQt::dispatchDidReplaceStateWithinPage):
2038
(WebCore::FrameLoaderClientQt::dispatchDidPopStateWithinPage):
2039
* WebCoreSupport/FrameLoaderClientQt.h:
2040
(FrameLoaderClientQt):
2041
* tests/qwebframe/tst_qwebframe.cpp:
2043
(tst_QWebFrame::setUrlUsingStateObject): Added. Tests that the urlChanged signal is fired.
2045
2012-08-10 Simon Hausmann <simon.hausmann@nokia.com>
2047
[Qt] Remove QRegExp <> JS RegExp conversion
2048
https://bugs.webkit.org/show_bug.cgi?id=93716
2050
Reviewed by Kenneth Rohde Christiansen.
2052
Removed tests that cover the automatic QRegExp <> JS RegExp conversion. See WebCore
2053
ChangeLog for details.
2055
* tests/qobjectbridge/tst_qobjectbridge.cpp:
2056
(MyQObject::emitMySignalWithDateTimeArg):
2058
(tst_QObjectBridge::overloadedSlots):
2059
(tst_QObjectBridge::typeConversion):
2061
2012-08-09 Simon Hausmann <simon.hausmann@nokia.com>
2063
[Qt] Remove support for __qt_sender__ in QObject bridge
2064
https://bugs.webkit.org/show_bug.cgi?id=93649
2066
Reviewed by Kenneth Rohde Christiansen.
2068
Support for __qt_sender__ has also been removed from QtScript/QJSEngine. The right
2069
JavaScript solution to the problem is Function.prototype.bind.
2071
* Api/qwebframe.cpp:
2072
(QWebFramePrivate::didClearWindowObject):
2073
* Api/qwebframe_p.h:
2075
* tests/qobjectbridge/tst_qobjectbridge.cpp:
2076
(tst_QObjectBridge::connectAndDisconnect):
2078
2012-08-08 Simon Hausmann <simon.hausmann@nokia.com>
2080
[Qt] Port internal findMethodIndex method matcher to use JSC C API
2081
https://bugs.webkit.org/show_bug.cgi?id=93463
2083
Reviewed by Kenneth Rohde Christiansen.
2085
Adjust the expectations of the unit test for some of the exceptions the
2086
method throws when signals/slots cannot be found/matched. The C API doesn't allow
2087
us to create syntax (type) errors, only generic error exceptions.
2089
* tests/qobjectbridge/tst_qobjectbridge.cpp:
2090
(tst_QObjectBridge::callQtInvokable):
2092
2012-08-08 Simon Hausmann <simon.hausmann@nokia.com>
2094
[Qt] Add unit test for QObject bindings for scriptable plugins
2095
https://bugs.webkit.org/show_bug.cgi?id=93462
2097
Reviewed by Kenneth Rohde Christiansen.
2099
The bindings code is subject to refactoring in the future, so added a unit test to verify that
2100
accessing an embedded QWidget from JavaScript goes through the QObject bindings.
2102
* tests/qobjectbridge/tst_qobjectbridge.cpp:
2103
(tst_QObjectBridge):
2105
(TestPluginWidget::TestPluginWidget):
2106
(TestPluginWidget::slotWithReturnValue):
2108
(TestWebPage::TestWebPage):
2109
(TestWebPage::createPlugin):
2110
(tst_QObjectBridge::scriptablePlugin):
2112
2012-08-01 Zeno Albisser <zeno@webkit.org>
2114
[Qt]REGRESSION(r123786): It made 3 fast/animation tests fail.
2115
https://bugs.webkit.org/show_bug.cgi?id=92490
2117
QAbstractAnimation:start() is implicitly calling updateTime
2118
without going through the event loop. This resulted in executing
2119
scripted animation callbacks right when registering a first callback.
2121
Reviewed by Noam Rosenthal.
2123
* WebCoreSupport/ChromeClientQt.cpp:
2124
(WebCore::RefreshAnimation::scheduleAnimation):
2125
Invoke QAbstractAnimation::start() method through the event loop.
2127
2012-07-27 Csaba Osztrogonác <ossy@webkit.org>
2129
[Qt][WK2] REGRESSION(r119127): resetting window.internals settings between tests doesn't work properly
2130
https://bugs.webkit.org/show_bug.cgi?id=88064
2132
Reviewed by Zoltan Herczeg.
2134
Add missing DumpRenderTreeSupportQt::resetInternalsObject(JSContextRef context) function.
2136
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2137
(DumpRenderTreeSupportQt::resetInternalsObject):
2138
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2140
2012-07-26 Zeno Albisser <zeno@webkit.org>
2142
Unreviewed Qt buildfix after r123786.
2144
Qt-minimal builds with ENABLE_REQUEST_ANIMATION_FRAME=0.
2145
Therefore adding #ifdefs to allow for that configuration.
2147
* WebCoreSupport/ChromeClientQt.cpp:
2149
* WebCoreSupport/ChromeClientQt.h:
2152
2012-07-26 Zeno Albisser <zeno@webkit.org>
2154
[Qt] requestAnimationFrame should only trigger when a new frame can be displayed.
2155
https://bugs.webkit.org/show_bug.cgi?id=88638
2157
Disable REQUEST_ANIMATION_FRAME_TIMER for the Qt port and tie
2158
the servicing of scripted animations to the renderNextFrame call for WK2.
2159
For WK1 we rely on the RefreshAnimation that is based on QAbstractAnimation.
2161
Reviewed by Jocelyn Turcotte.
2163
* WebCoreSupport/ChromeClientQt.cpp:
2165
Add a RefreshAnimation that is based on QAbstractAnimation
2166
and drives the servicing of the scripted animations for WK1.
2167
(WebCore::RefreshAnimation::RefreshAnimation):
2168
(WebCore::RefreshAnimation::duration):
2169
(WebCore::RefreshAnimation::scheduleAnimation):
2170
Set m_animationScheduled to true and start the animation
2171
timer in case it is not running yet.
2172
(WebCore::RefreshAnimation::updateCurrentTime):
2173
Call serviceScriptedAnimations if m_animationScheduled is true.
2174
If this is not the case, the animation timer can be stopped,
2175
because no animation needs to be scheduled anymore.
2177
(WebCore::ChromeClientQt::scheduleAnimation):
2178
Create and start the RefreshAnimation instance with the
2179
first call to scheduleAnimation.
2180
* WebCoreSupport/ChromeClientQt.h:
2184
2012-07-26 Kaustubh Atrawalkar <kaustubh@motorola.com>
2186
[DRT] LTC:: pageNumberForElementById() could be moved to Internals
2187
https://bugs.webkit.org/show_bug.cgi?id=92091
2189
Reviewed by Adam Barth.
2191
Move the pageNumberForElementById from LayoutTestCotroller to Internals and
2192
remove the old platform specific implementations as it exclusively tests WebCore functionality.
2194
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2195
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2197
2012-07-24 Pierre Rossi <pierre.rossi@gmail.com>
2199
[Qt][WK1] color input type support
2200
https://bugs.webkit.org/show_bug.cgi?id=91998
2202
Reviewed by Simon Hausmann.
2204
Using QColorDialog. This is private for now, but
2205
it could be exposed via a virtual function in
2206
QWebPage at a later point in a Qt 5 minor release
2207
if there are requests for that.
2210
(QWebPagePrivate::colorSelectionRequested):
2213
* WebCoreSupport/ChromeClientQt.cpp:
2214
(WebCore::ChromeClientQt::createColorChooser):
2216
2012-07-23 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
2218
[Qt] Fix compilation against namespaced Qt
2220
Reviewed by Simon Hausmann.
2222
* WebCoreSupport/GeolocationClientQt.h:
2223
* examples/platformplugin/WebPlugin.h:
2225
2012-07-23 Pierre Rossi <pierre.rossi@gmail.com>
2227
Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client
2228
https://bugs.webkit.org/show_bug.cgi?id=91006
2230
Reviewed by Ryosuke Niwa.
2232
Remove numTouchEventHandlersChanged stub.
2234
* WebCoreSupport/ChromeClientQt.h:
2236
2012-07-23 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
2238
[Qt] RenderThemeQtMobile highlight colors are not being used
2239
https://bugs.webkit.org/show_bug.cgi?id=92004
2241
Reviewed by Noam Rosenthal.
2243
* WebCoreSupport/RenderThemeQStyle.cpp:
2244
(WebCore::RenderThemeQStyle::setPaletteFromPageClientIfExists): Moved here since
2245
it's used only by RenderThemeQStyle. Remove unnecessary check for m_page->chrome().
2247
(WebCore::RenderThemeQStyle::colorPalette):
2248
* WebCoreSupport/RenderThemeQStyle.h:
2249
(RenderThemeQStyle):
2251
2012-07-22 Kent Tamura <tkent@chromium.org>
2253
Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
2254
https://bugs.webkit.org/show_bug.cgi?id=91941
2256
Reviewed by Kentaro Hara.
2258
A flag name for an elmement should be ENABLE_*_ELEMENT.
2260
* WebCoreSupport/RenderThemeQStyle.cpp:
2262
* WebCoreSupport/RenderThemeQStyle.h:
2264
2012-07-19 No'am Rosenthal <noam.rosenthal@nokia.com>
2266
[Qt] Enable CSS shaders in Qt (software mode)
2267
https://bugs.webkit.org/show_bug.cgi?id=85140
2269
Reviewed by Simon Hausmann.
2271
Enable CSS Shaders in settings when WebGL is enabled.
2273
* Api/qwebsettings.cpp:
2274
(QWebSettingsPrivate::apply):
2276
2012-07-19 Simon Hausmann <simon.hausmann@nokia.com>
2278
[Qt] Remove support for Qt versions before 4.8.0
2279
https://bugs.webkit.org/show_bug.cgi?id=91730
2281
Reviewed by Kenneth Rohde Christiansen.
2283
Remove Qt version check #ifdefs for Qt versions before 4.8.0.
2285
* Api/qwebsettings.cpp:
2286
(QWebSettingsPrivate):
2287
(QWebSettings::QWebSettings):
2288
(QWebSettings::thirdPartyCookiePolicy):
2289
* Api/qwebsettings.h:
2290
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2291
(DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows):
2292
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2293
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
2294
(tst_QDeclarativeWebView):
2295
(tst_QDeclarativeWebView::backgroundColor):
2296
* tests/qwebelement/tst_qwebelement.cpp:
2297
(tst_QWebElement::render):
2298
* tests/qwebpage/tst_qwebpage.cpp:
2300
(tst_QWebPage::thirdPartyCookiePolicy):
2302
2012-07-17 Gabor Ballabas <gaborb@inf.u-szeged.hu>
2304
[Qt][V8] Remove the V8 related codepaths and configuration
2305
https://bugs.webkit.org/show_bug.cgi?id=90863
2307
Reviewed by Simon Hausmann.
2309
* Api/qwebelement.cpp:
2310
(setupScriptContext):
2311
(QWebElement::evaluateJavaScript):
2312
(convertWebElementVariantToJSValue):
2313
(QtWebElementRuntime::initialize):
2314
* Api/qwebframe.cpp:
2315
(QWebFramePrivate::didClearWindowObject):
2316
(QWebFramePrivate::addQtSenderToGlobalObject):
2317
(QWebFrame::addToJavaScriptWindowObject):
2318
(QWebFrame::evaluateJavaScript):
2319
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2320
(convertNodeVariantToJSValue):
2321
(QtDRTNodeRuntime::initialize):
2322
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
2323
(DumpRenderTreeSupportQt::garbageCollectorCollect):
2324
(DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
2325
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
2326
(DumpRenderTreeSupportQt::injectInternalsObject):
2327
(DumpRenderTreeSupportQt::resetInternalsObject):
2328
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2329
* WebCoreSupport/FrameLoaderClientQt.cpp:
2330
(WebCore::FrameLoaderClientQt::createDocumentLoader):
2331
* WebCoreSupport/FrameLoaderClientQt.h:
2332
(FrameLoaderClientQt):
2333
* v8/ForwardingHeaders/v8-debug.h: Removed.
2334
* v8/ForwardingHeaders/v8-preparser.h: Removed.
2335
* v8/ForwardingHeaders/v8-profiler.h: Removed.
2336
* v8/ForwardingHeaders/v8-testing.h: Removed.
2337
* v8/ForwardingHeaders/v8.h: Removed.
2338
* v8/ForwardingHeaders/v8stdint.h: Removed.
2340
2012-07-17 Vivek Galatage <vivekgalatage@gmail.com>
2342
Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.
2343
https://bugs.webkit.org/show_bug.cgi?id=91196
2345
Reviewed by Pavel Feldman.
2347
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
2348
now returning the InspectorFrontendChannel.
2350
* WebCoreSupport/InspectorClientQt.cpp:
2351
(WebCore::InspectorClientQt::openInspectorFrontend):
2352
(WebCore::InspectorClientQt::attachAndReplaceRemoteFrontend):
2353
* WebCoreSupport/InspectorClientQt.h:
2354
(InspectorClientQt):
2356
2012-07-17 Sheriff Bot <webkit.review.bot@gmail.com>
2358
Unreviewed, rolling out r122834.
2359
http://trac.webkit.org/changeset/122834
2360
https://bugs.webkit.org/show_bug.cgi?id=91492
2362
it broke the chromium (Requested by kkristof on #webkit).
2364
* Api/qwebelement.cpp:
2365
(setupScriptContext):
2366
(QWebElement::evaluateJavaScript):
2367
(QtWebElementRuntime::initialize):
2368
* Api/qwebframe.cpp:
2369
(QWebFramePrivate::didClearWindowObject):
2370
(QWebFrame::addToJavaScriptWindowObject):
2371
(QWebFrame::evaluateJavaScript):
2372
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2373
(QtDRTNodeRuntime::initialize):
2374
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
2375
(DumpRenderTreeSupportQt::garbageCollectorCollect):
2376
(DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
2377
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
2378
(DumpRenderTreeSupportQt::injectInternalsObject):
2379
(DumpRenderTreeSupportQt::resetInternalsObject):
2380
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2382
* WebCoreSupport/FrameLoaderClientQt.cpp:
2384
(WebCore::FrameLoaderClientQt::didCreateScriptContext):
2385
(WebCore::FrameLoaderClientQt::willReleaseScriptContext):
2386
(WebCore::FrameLoaderClientQt::didCreateIsolatedScriptContext):
2387
(WebCore::FrameLoaderClientQt::createDocumentLoader):
2388
* WebCoreSupport/FrameLoaderClientQt.h:
2389
(FrameLoaderClientQt):
2390
(WebCore::FrameLoaderClientQt::allowScriptExtension):
2391
* v8/ForwardingHeaders/v8-debug.h: Added.
2392
* v8/ForwardingHeaders/v8-preparser.h: Added.
2393
* v8/ForwardingHeaders/v8-profiler.h: Added.
2394
* v8/ForwardingHeaders/v8-testing.h: Added.
2395
* v8/ForwardingHeaders/v8.h: Added.
2396
* v8/ForwardingHeaders/v8stdint.h: Added.
2398
2012-07-17 Gabor Ballabas <gaborb@inf.u-szeged.hu>
2400
[Qt][V8] Remove the V8 related codepaths and configuration
2401
https://bugs.webkit.org/show_bug.cgi?id=90863
2403
Reviewed by Simon Hausmann.
2405
* Api/qwebelement.cpp:
2406
(setupScriptContext):
2407
(QWebElement::evaluateJavaScript):
2408
(convertWebElementVariantToJSValue):
2409
(QtWebElementRuntime::initialize):
2410
* Api/qwebframe.cpp:
2411
(QWebFramePrivate::didClearWindowObject):
2412
(QWebFramePrivate::addQtSenderToGlobalObject):
2413
(QWebFrame::addToJavaScriptWindowObject):
2414
(QWebFrame::evaluateJavaScript):
2415
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2416
(convertNodeVariantToJSValue):
2417
(QtDRTNodeRuntime::initialize):
2418
(DumpRenderTreeSupportQt::javaScriptObjectsCount):
2419
(DumpRenderTreeSupportQt::garbageCollectorCollect):
2420
(DumpRenderTreeSupportQt::garbageCollectorCollectOnAlternateThread):
2421
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
2422
(DumpRenderTreeSupportQt::injectInternalsObject):
2423
(DumpRenderTreeSupportQt::resetInternalsObject):
2424
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2425
* WebCoreSupport/FrameLoaderClientQt.cpp:
2426
(WebCore::FrameLoaderClientQt::createDocumentLoader):
2427
* WebCoreSupport/FrameLoaderClientQt.h:
2428
(FrameLoaderClientQt):
2429
* v8/ForwardingHeaders/v8-debug.h: Removed.
2430
* v8/ForwardingHeaders/v8-preparser.h: Removed.
2431
* v8/ForwardingHeaders/v8-profiler.h: Removed.
2432
* v8/ForwardingHeaders/v8-testing.h: Removed.
2433
* v8/ForwardingHeaders/v8.h: Removed.
2434
* v8/ForwardingHeaders/v8stdint.h: Removed.
2436
2012-07-16 Simon Hausmann <simon.hausmann@nokia.com>
2438
[Qt] Fix inconsistent DLL linkage on Windows with WebKit1
2439
https://bugs.webkit.org/show_bug.cgi?id=91375
2441
Reviewed by Laszlo Gombos.
2443
Export QWebHistoryItemPrivate as required for tests. Unfortunately we cannot use
2444
Q_AUTOTEST_EXPORT outside of Qt.
2446
* Api/qwebhistory_p.h:
2448
2012-07-16 Zoltan Horvath <zoltan@webkit.org>
2450
[Qt] Change NativeImagePtr from QPixmap* to QImage*
2451
https://bugs.webkit.org/show_bug.cgi?id=88785
2453
Reviewed by Simon Hausmann.
2455
Since we use raster engine there is no difference between QPixmap and QImage, so we are going
2456
to use QImage everywhere where it is possible. This refactoring contains the change of the
2457
NativeImagePtr typedef from QPixmap* to QImage* and covers the related modifications.
2459
Part of the change is similar to Viatcheslav Ostapenko's internal work.
2461
Covered by existing tests.
2463
* Api/qwebframe.cpp:
2464
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
2465
* Api/qwebhistory.cpp:
2466
(QWebHistoryItem::icon):
2467
* Api/qwebsettings.cpp:
2468
(QWebSettings::iconForUrl):
2469
(QWebSettings::setWebGraphic):
2470
(QWebSettings::webGraphic):
2471
* WebCoreSupport/DragClientQt.cpp:
2472
(WebCore::DragClientQt::startDrag):
2473
* WebCoreSupport/InitWebCoreQt.cpp:
2474
(WebCore::initializeWebCoreQt):
2476
2012-07-16 Frederik Gladhorn <frederik.gladhorn@nokia.com>
2478
Accessible Widget for QWebView
2479
https://bugs.webkit.org/show_bug.cgi?id=91073
2481
Added classes that allow navigation to the web view widget.
2482
This is the glue to later access webkit's accessible objects
2483
though the Qt accessibility framework.
2485
Reviewed by Simon Hausmann.
2488
(QWebView::QWebView):
2489
* Api/qwebviewaccessible.cpp: Added.
2490
(accessibleInterfaceFactory):
2491
(QWebFrameAccessible::QWebFrameAccessible):
2492
(QWebFrameAccessible::frame):
2493
(QWebFrameAccessible::parent):
2494
(QWebFrameAccessible::text):
2495
(QWebFrameAccessible::childCount):
2496
(QWebFrameAccessible::child):
2497
(QWebFrameAccessible::indexOfChild):
2498
(QWebFrameAccessible::state):
2499
(QWebFrameAccessible::role):
2500
(QWebFrameAccessible::navigate):
2501
(QWebPageAccessible::QWebPageAccessible):
2502
(QWebPageAccessible::page):
2503
(QWebPageAccessible::text):
2504
(QWebPageAccessible::parent):
2505
(QWebPageAccessible::child):
2506
(QWebPageAccessible::childCount):
2507
(QWebPageAccessible::indexOfChild):
2508
(QWebPageAccessible::navigate):
2509
(QWebPageAccessible::role):
2510
(QWebPageAccessible::state):
2511
(QWebViewAccessible::QWebViewAccessible):
2512
(QWebViewAccessible::view):
2513
(QWebViewAccessible::childCount):
2514
(QWebViewAccessible::child):
2515
* Api/qwebviewaccessible_p.h: Added.
2516
(QWebFrameAccessible):
2517
(QWebPageAccessible):
2518
(QWebViewAccessible):
2520
2012-07-12 Huang Dongsung <luxtella@company100.net>
2522
[Qt] Increase the drawing performance by merging dirty rects.
2523
https://bugs.webkit.org/show_bug.cgi?id=91075
2525
Reviewed by Noam Rosenthal.
2527
QWebFramePrivate calls FrameView::paintContents as many as the number of dirty
2528
rects, so it causes too many redundant render tree traversals.
2529
I changed it to merge dirty rects and call FrameView::paintContents only once.
2530
The algorithm to merge rects is copied from GTK.
2532
When parallel image decoders are in use, each image is independently repainted
2533
when decoding is finished. This creates a lot by repaint requests. So by merging
2534
these repaint requests, I could improve rendering performance.
2536
For example, I tested parallel image decoders on the locally mirrored Pinterest site.
2537
QWebFramePrivate called FrameView::paintContents 165 times after parallel image
2538
decoders decoded all the images. It took about 120ms on my six-core Intel Xeon machine.
2539
This patch decreases painting time from 120ms to 30ms.
2541
* Api/qwebframe.cpp:
2542
(coalesceRectsIfPossible):
2543
(QWebFramePrivate::renderRelativeCoords):
2545
2012-07-11 Steffen Imhof <steffen.imhof@basyskom.com>
2547
[Qt] Middle clicking a scrollbar causes text to be pasted.
2548
https://bugs.webkit.org/show_bug.cgi?id=78444
2550
Check if the event was already accepted before handling the clipboard.
2552
Reviewed by Simon Hausmann.
2555
(QWebPagePrivate::mouseReleaseEvent):
2557
2012-07-10 Adam Barth <abarth@webkit.org>
2559
WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed
2560
https://bugs.webkit.org/show_bug.cgi?id=90910
2562
Reviewed by Eric Seidel.
2565
(QWebPagePrivate::QWebPagePrivate):
2566
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2567
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2569
2012-07-09 No'am Rosenthal <noam.rosenthal@nokia.com>
2571
Shared code that is guarded with ENABLE(WEBGL) should be guarded with USE()
2572
https://bugs.webkit.org/show_bug.cgi?id=90506
2574
Reviewed by Martin Robinson.
2576
Updated necessary parts of PageClientQt to be guarded with USE(3D_GRAPHICS) instead of
2577
ENABLE(WEBGL). The WebKit1 glue to WebGL still requires the Qt OpenGL module, so it's
2578
disable if QT_OPENGL_LIB is not defined.
2580
* WebCoreSupport/PageClientQt.cpp:
2581
(createPlatformGraphicsContext3DFromWidget):
2583
* WebCoreSupport/PageClientQt.h:
2584
(PageClientQWidget):
2585
(PageClientQGraphicsWidget):
2587
2012-07-06 Csaba Osztrogonác <ossy@webkit.org>
2589
[Qt] Buildfix for newer Qt5
2590
https://bugs.webkit.org/show_bug.cgi?id=90519
2592
Reviewed by Tor Arne Vestbø.
2594
* WebCoreSupport/QtFallbackWebPopup.cpp: Include QtGui/QStandardItemModel instead of deprecated QStandardItemModel.
2596
2012-07-06 Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
2598
[Qt] Adjust to changed generation of master include file
2600
The responsiblity for creating the master include was moved out of syncqt.
2601
@ignore_for_master_contents still stays, as syncqt (ab-)uses this for
2602
determining whether a header is private.
2604
https://bugs.webkit.org/show_bug.cgi?id=90461
2606
Reviewed by Tor Arne Vestbø.
2608
* Api/qwebscriptworld.h:
2611
2012-07-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2613
[Qt] Get rid of un-needed QT += declarative for Qt 5
2615
The declarative module has been renamed to quick1 in Qt 5, and the
2616
engine-only module for Qt 5 is named 'qml'. For many of the instances
2617
we could just remove 'declarative', since the project file was only
2618
used for Qt5/WebKit2 builds. In the other cases the module was wrapped
2619
in a haveQt(4) scope.
2621
Reviewed by Csaba Osztrogonác.
2623
* declarative/experimental/experimental.pri:
2624
* declarative/public.pri:
2626
2012-07-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2628
[Qt] Make use of .qmake.cache for caching features
2630
Instead of loading() features from the files that need them (and re-running
2631
a bunch of checks), we now run feature detection as part of configure.pro,
2632
and have build-webkit write the computed feature-defines and CONFIG to
2633
.qmake.cache, which is then loaded by qmake _before_ even defaults_pre
2634
when building WebKit.pro.
2636
At some point we'll be able to selectivly prevent running of config tests
2637
in configure.pro, which means we don't need a separate code-path for
2638
the build-webkit --help case.
2640
We should also move the code in build-webkit that now uses .webkit.config
2641
to detect clean builds, to use .qmake.cache, since we now store the same
2644
Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
2646
Reviewed by Tor Arne Vestbø.
2648
* declarative/declarative.pro:
2649
* declarative/public.pri:
2650
* tests/qgraphicswebview/qgraphicswebview.pro:
2652
2012-07-03 Sheriff Bot <webkit.review.bot@gmail.com>
2654
Unreviewed, rolling out r121766.
2655
http://trac.webkit.org/changeset/121766
2656
https://bugs.webkit.org/show_bug.cgi?id=90465
2658
It caused flakey build errors on the bots (Requested by Ossy
2661
* declarative/declarative.pro:
2662
* declarative/public.pri:
2663
* tests/qgraphicswebview/qgraphicswebview.pro:
2665
2012-07-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
2667
[Qt] Make use of .qmake.cache for caching features
2669
Instead of loading() features from the files that need them (and re-running
2670
a bunch of checks), we now run feature detection as part of configure.pro,
2671
and have build-webkit write the computed feature-defines and CONFIG to
2672
.qmake.cache, which is then loaded by qmake _before_ even defaults_pre
2673
when building WebKit.pro.
2675
At some point we'll be able to selectivly prevent running of config tests
2676
in configure.pro, which means we don't need a separate code-path for
2677
the build-webkit --help case.
2679
We should also move the code in build-webkit that now uses .webkit.config
2680
to detect clean builds, to use .qmake.cache, since we now store the same
2683
Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
2685
Reviewed by Tor Arne Vestbø.
2687
* declarative/declarative.pro:
2688
* declarative/public.pri:
2689
* tests/qgraphicswebview/qgraphicswebview.pro:
2691
2012-07-02 No'am Rosenthal <noam.rosenthal@nokia.com>
2693
[Qt] Get rid of GraphicsLayerQt
2694
https://bugs.webkit.org/show_bug.cgi?id=78598
2696
Reviewed by Luiz Agostini.
2698
Removed all references to GraphicsLayerQt, including #ifdef code paths that only apply
2699
when TEXTURE_MAPPER is disabled.
2701
* Api/qgraphicswebview.cpp:
2702
(QGraphicsWebView::paint):
2703
* Api/qwebframe.cpp:
2704
(QWebFramePrivate::renderFromTiledBackingStore):
2705
(QWebFramePrivate::renderRelativeCoords):
2706
* Api/qwebframe_p.h:
2707
(QWebFramePrivate::QWebFramePrivate):
2709
* Api/qwebsettings.cpp:
2710
(QWebSettingsPrivate::apply):
2711
* WebCoreSupport/PageClientQt.cpp:
2713
(WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget):
2714
(WebCore::PageClientQGraphicsWidget::update):
2715
(WebCore::PageClientQGraphicsWidget::syncLayers):
2716
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
2717
* WebCoreSupport/PageClientQt.h:
2719
(WebCore::PageClientQWidget::PageClientQWidget):
2720
(PageClientQWidget):
2721
(PageClientQGraphicsWidget):
2723
2012-07-02 Benjamin Poulain <bpoulain@apple.com>
2725
Do not do any logging initialization when logging is disabled
2726
https://bugs.webkit.org/show_bug.cgi?id=90228
2728
Reviewed by Simon Fraser.
2730
* WebCoreSupport/InitWebCoreQt.cpp:
2731
(WebCore::initializeWebCoreQt):
2733
2012-06-29 Konrad Piascik <kpiascik@rim.com>
2735
Don't hardcode target dpi of 160 (it should be 96 on desktop)
2736
https://bugs.webkit.org/show_bug.cgi?id=88114
2738
Reviewed by Adam Barth.
2740
Updated the call to computeViewportAttributes.
2743
(QWebPage::viewportAttributesForSize):
2744
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2745
(DumpRenderTreeSupportQt::viewportAsText):
2747
2012-06-28 Alexander Pavlov <apavlov@chromium.org>
2749
[Qt] inspector/styles/inject-stylesheet.html makes 4 tests flakey (TEXT PASS)
2750
https://bugs.webkit.org/show_bug.cgi?id=90167
2752
Reviewed by Csaba Osztrogonác.
2754
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2755
(DumpRenderTreeSupportQt::removeUserStyleSheets):
2756
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2758
2012-06-28 Csaba Osztrogonác <ossy@webkit.org>
2760
[Qt] Restore original value of mock scrollbars between tests
2761
https://bugs.webkit.org/show_bug.cgi?id=90155
2763
Reviewed by Simon Hausmann.
2765
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2766
(DumpRenderTreeSupportQt::setMockScrollbarsEnabled):
2767
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2769
2012-06-25 Mark Hahnenberg <mhahnenberg@apple.com>
2771
JSLock should be per-JSGlobalData
2772
https://bugs.webkit.org/show_bug.cgi?id=89123
2774
Reviewed by Geoffrey Garen.
2776
Changed all sites that used JSLock to instead use the new JSLockHolder
2777
and pass in the correct JS context that the code is about to interact with that
2778
needs protection. Also added a couple JSLocks to places that didn't already
2779
have it that needed it.
2781
* Api/qwebframe.cpp:
2782
(QWebFramePrivate::addQtSenderToGlobalObject):
2783
(QWebFrame::addToJavaScriptWindowObject):
2784
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2785
(DumpRenderTreeSupportQt::injectInternalsObject):
2786
(DumpRenderTreeSupportQt::resetInternalsObject):
2788
2012-06-27 Simon Hausmann <simon.hausmann@nokia.com>
2790
[Qt] Fix compilation of example platform plugin with Qt 5
2792
Reviewed by Kenneth Christiansen.
2794
Use QLatin1String where appropriate and use the Qt 5 plugin
2797
* examples/platformplugin/WebPlugin.cpp:
2798
(SingleSelectionPopup::SingleSelectionPopup):
2799
(MultipleItemListDelegate::MultipleItemListDelegate):
2800
(MultipleSelectionPopup::MultipleSelectionPopup):
2801
* examples/platformplugin/WebPlugin.h:
2804
2012-06-26 Tony Chang <tony@chromium.org>
2806
[Qt] Enable grid layout LayoutTests
2807
https://bugs.webkit.org/show_bug.cgi?id=89909
2809
Reviewed by Csaba Osztrogonác.
2811
These tests pass, we just need to hook up the overridePreference.
2813
* Api/qwebsettings.cpp:
2814
(QWebSettingsPrivate::apply):
2815
(QWebSettings::QWebSettings):
2816
* Api/qwebsettings.h: Add enum value for CSS grid layout
2818
2012-06-25 Simon Hausmann <simon.hausmann@nokia.com>
2820
Unreviewed build fix: Don't do QT += widgets with Qt 4
2822
* examples/platformplugin/platformplugin.pro:
2824
2012-06-23 Sheriff Bot <webkit.review.bot@gmail.com>
2826
Unreviewed, rolling out r121058.
2827
http://trac.webkit.org/changeset/121058
2828
https://bugs.webkit.org/show_bug.cgi?id=89809
2830
Patch causes plugins tests to crash in GTK debug builds
2831
(Requested by zdobersek on #webkit).
2833
* Api/qwebframe.cpp:
2834
(QWebFramePrivate::addQtSenderToGlobalObject):
2835
(QWebFrame::addToJavaScriptWindowObject):
2836
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2837
(DumpRenderTreeSupportQt::injectInternalsObject):
2838
(DumpRenderTreeSupportQt::resetInternalsObject):
2840
2012-06-20 Mark Hahnenberg <mhahnenberg@apple.com>
2842
JSLock should be per-JSGlobalData
2843
https://bugs.webkit.org/show_bug.cgi?id=89123
2845
Reviewed by Gavin Barraclough.
2847
Changed all sites that used JSLock to instead use the new JSLockHolder
2848
and pass in the correct JS context that the code is about to interact with that
2851
* Api/qwebframe.cpp:
2852
(QWebFramePrivate::addQtSenderToGlobalObject):
2853
(QWebFrame::addToJavaScriptWindowObject):
2854
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2855
(DumpRenderTreeSupportQt::injectInternalsObject):
2856
(DumpRenderTreeSupportQt::resetInternalsObject):
2858
2012-06-22 Amy Ousterhout <aousterh@chromium.org>
2860
Renamed DeviceOrientation to DeviceOrientationData
2861
https://bugs.webkit.org/show_bug.cgi?id=88663
2863
Reviewed by Steve Block.
2865
Updated files to use the renamed DeviceOrientationData instead of DeviceOrientation.
2866
This change makes DeviceOrientationData consistent with DeviceMotionData.
2868
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2869
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
2871
2012-06-21 Thiago Marcos P. Santos <thiago.santos@intel.com>
2873
[WK2][Qt] Color chooser API missing
2874
https://bugs.webkit.org/show_bug.cgi?id=87749
2876
Reviewed by Kenneth Rohde Christiansen.
2878
Added ColorChooser API stub to WebKit. Otherwise
2879
it will break the build for Qt WebKit2 (that now has
2880
complete support for color chooser) when INPUT_TYPE_COLOR is set.
2882
* WebCoreSupport/ChromeClientQt.cpp:
2884
(WebCore::ChromeClientQt::createColorChooser):
2885
* WebCoreSupport/ChromeClientQt.h:
2888
2012-06-20 Simon Hausmann <simon.hausmann@nokia.com>
2890
[Qt] Unreviewed build fix
2892
The platform plugin example uses QGridLayout and thus needs QT += widgets
2894
* examples/platformplugin/platformplugin.pro:
2896
2012-06-19 Csaba Osztrogonác <ossy@webkit.org>
2898
[Qt] Buildfix for newer Qt5, use QPointer instead of the deprecated QWeakPointer.
2899
https://bugs.webkit.org/show_bug.cgi?id=89449
2901
Reviewed by Simon Hausmann.
2903
* Api/qwebframe_p.h:
2904
(QWebHitTestResultPrivate):
2907
* WebCoreSupport/FrameLoaderClientQt.cpp:
2908
(WebCore::FrameLoaderClientQt::createFrame):
2909
* WebCoreSupport/PageClientQt.h:
2910
(PageClientQGraphicsWidget):
2912
2012-06-19 Albert Astals Cid <albert.astals@canonical.com>
2914
[Qt] Document the versions enums where added
2915
https://bugs.webkit.org/show_bug.cgi?id=89452
2917
Reviewed by Simon Hausmann.
2921
2012-06-19 Sergio Villar Senin <svillar@igalia.com>
2923
Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()
2924
https://bugs.webkit.org/show_bug.cgi?id=67582
2926
Reviewed by David Levin.
2928
Use synchronousNativeIconForPageURL() to retrieve favicons.
2930
* Api/qwebhistory.cpp:
2931
(QWebHistoryItem::icon):
2932
* Api/qwebsettings.cpp:
2933
(QWebSettings::iconForUrl):
2935
2012-06-18 Andras Becsi <andras.becsi@nokia.com>
2937
[Qt] Update QML plugins to Qt 5 style
2938
https://bugs.webkit.org/show_bug.cgi?id=89027
2940
Reviewed by Csaba Osztrogonác.
2942
Since support for Qt 4 style plugins was removed from Qt 5
2943
we need to update our plugins to the new style to be able
2944
to build with a more recent Qt 5 hash.
2945
Add empty plugin description json files for now.
2947
* declarative/experimental/plugin.cpp:
2948
* declarative/experimental/plugin.json: Added.
2949
* declarative/plugin.cpp:
2951
* declarative/plugin.json: Added.
2953
2012-06-13 Simon Hausmann <simon.hausmann@nokia.com>
2955
[Qt] Remove dependency to QtScript for the Qt 5 build
2956
https://bugs.webkit.org/show_bug.cgi?id=88993
2958
Reviewed by Kenneth Rohde Christiansen.
2960
When building against Qt 5, replace the use of QScriptEngine::ValueOwnership with
2961
a (compatible) QWebFrame::ValueOwnership enum.
2963
* Api/qwebframe.cpp:
2965
(QWebFrame::addToJavaScriptWindowObject):
2967
* tests/qobjectbridge/tst_qobjectbridge.cpp:
2968
(tst_QObjectBridge::arrayObjectEnumerable):
2969
(tst_QObjectBridge::ownership):
2970
(tst_QObjectBridge::qObjectWrapperWithSameIdentity):
2973
2012-06-12 Csaba Osztrogonác <ossy@webkit.org>
2975
[Qt][Mac] Unreviewed buildfix after r120076.
2977
* WebCoreSupport/QTKitFullScreenVideoHandler.h:
2979
2012-06-11 Kaustubh Atrawalkar <kaustubh@motorola.com>
2981
[DRT] LTC:: counterValueForElementById() could be moved to Internals.
2982
https://bugs.webkit.org/show_bug.cgi?id=84406
2984
Reviewed by Hajime Morita.
2986
Move the counterValueForElementById from LayoutTestCotroller to Internals and
2987
remove the old platform specific implementations as it exclusively tests WebCore functionality.
2989
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
2990
* WebCoreSupport/DumpRenderTreeSupportQt.h:
2992
2012-06-11 Csaba Osztrogonác <ossy@webkit.org>
2994
[Qt][Win] Add missing includes to fix the build
2995
https://bugs.webkit.org/show_bug.cgi?id=88538
2997
Reviewed by Simon Hausmann.
2999
* Api/qwebframe.cpp:
3000
* WebCoreSupport/ChromeClientQt.cpp:
3001
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3002
* WebCoreSupport/GeolocationClientQt.cpp:
3003
* WebCoreSupport/IconDatabaseClientQt.cpp:
3005
2012-06-08 Simon Hausmann <simon.hausmann@nokia.com>
3007
Unreviewed, fix file permissions.
3009
* WebCoreSupport/FrameLoaderClientQt.cpp:
3011
2012-06-07 Zoltan Horvath <zoltan@webkit.org>
3013
[Qt] Qt DRT should load external resources - cleanup
3014
https://bugs.webkit.org/show_bug.cgi?id=88568
3016
Make things more straighforward to load external URLs in DRT.
3018
Reviewed by Ryosuke Niwa.
3020
* WebCoreSupport/FrameLoaderClientQt.cpp:
3021
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
3023
2012-06-06 Zoltan Horvath <zoltan@webkit.org>
3025
[Qt] Qt DRT / WTR should be able to load external resources
3026
https://bugs.webkit.org/show_bug.cgi?id=87326
3028
Reviewed by Hajime Morita.
3030
Allow external resources to be loaded when the main frame's URL is also an external resource.
3031
This change is analogous to r118231 for Mac port and to r119153 Chromium port.
3033
* WebCoreSupport/FrameLoaderClientQt.cpp:
3034
(WebCore::blockRequest):
3036
(WebCore::isLocalhost):
3037
(WebCore::hostIsUsedBySomeTestsToGenerateError):
3038
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
3040
2012-06-05 Max Feil <mfeil@rim.com>
3042
[BlackBerry] Conditionally enlarge HTML5 video controls in fullscreen mode
3043
https://bugs.webkit.org/show_bug.cgi?id=87551
3045
Reviewed by Antonio Gomes.
3047
Add a new parameter to adjustSliderThumbSize() for BlackBerry
3048
port. Fixing compiles of other ports.
3050
* WebCoreSupport/RenderThemeQStyle.cpp:
3051
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
3052
* WebCoreSupport/RenderThemeQStyle.h:
3053
(RenderThemeQStyle):
3055
2012-06-04 Sheriff Bot <webkit.review.bot@gmail.com>
3057
Unreviewed, rolling out r119384.
3058
http://trac.webkit.org/changeset/119384
3059
https://bugs.webkit.org/show_bug.cgi?id=88227
3061
Need to update some tests, I'll roll in later. (Requested by
3064
* WebCoreSupport/FrameLoaderClientQt.cpp:
3065
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
3067
2012-06-04 Zoltan Horvath <zoltan@webkit.org>
3069
[Qt] Qt DRT / WTR should be able to load external resources
3070
https://bugs.webkit.org/show_bug.cgi?id=87326
3072
Reviewed by Ryosuke Niwa.
3074
Allow external resources to be loaded when the main frame's URL is also an external resource.
3075
This change is analogous to r118231 for Mac port and to r119153 Chromium port.
3077
* WebCoreSupport/FrameLoaderClientQt.cpp:
3078
(WebCore::blockRequest):
3080
(WebCore::isLocalhost):
3081
(WebCore::hostIsUsedBySomeTestsToGenerateError):
3082
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
3084
2012-06-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3086
[Qt] Don't use WebKit HAVE() macro in public Qt headers
3088
Reviewed by Kenneth Rohde Christiansen.
3090
* Api/qgraphicswebview.h:
3091
* Api/qwebframe_p.h:
3095
2012-06-02 Zoltan Arvai <zarvai@inf.u-szeged.hu>
3097
[Qt] Use 'Ok' and 'Cancel' buttons in JavaScript confirm box.
3098
https://bugs.webkit.org/show_bug.cgi?id=76190
3099
Based on Johannes Obermayrs (johannesobermayr@gmx.de) patch.
3100
See: http://www.javascripter.net/faq/confirm.htm
3101
Fixes: https://bugs.kde.org/show_bug.cgi?id=287629
3103
Reviewed by Simon Hausmann.
3106
(QWebPage::javaScriptConfirm):
3108
2012-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
3110
[Qt] Fix QObject bridge tests in Qt5 after (not so) recent QVariant changes
3111
https://bugs.webkit.org/show_bug.cgi?id=88127
3113
Reviewed by Noam Rosenthal.
3115
We were checking for invalid QVariants in a very odd way. Since in Qt5 the
3116
userType of invalid changed to not be Void, this broke the tests for QtWebKit
3117
with Qt5. Replace those checks with QVariant::isValid() calls.
3119
* tests/qobjectbridge/tst_qobjectbridge.cpp:
3120
(tst_QObjectBridge::evalJS):
3121
(tst_QObjectBridge::evalJSV):
3123
2012-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
3125
[Qt] Move QObject bridge related tests from tst_qwebframe to tst_qobjectbridge
3126
https://bugs.webkit.org/show_bug.cgi?id=88117
3128
Reviewed by Noam Rosenthal.
3130
Five tests (classEnums, classConstructor, transferInvokable, findObject and
3131
findChildren) were removed since they contained commented code since the file was
3132
added back in 2008. The QObject bridge tests were probably inspired in similar
3133
tests for QtScript, so many features not yet implemented were present in QtWebKit
3134
tests but commented.
3136
Other minor changes:
3137
- Moved MyEnumTestQObject near the only test function that uses it.
3138
- Removed unnecessary Q_INVOKABLE from setBrushProperty.
3139
- Removed some bits of dead / commented code.
3141
* tests/qobjectbridge/qobjectbridge.pro: Added.
3142
* tests/qobjectbridge/tst_qobjectbridge.cpp: Copied from Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp.
3143
Kept only the tests related to QObject bridge implementation.
3144
* tests/qwebframe/tst_qwebframe.cpp:
3146
(tst_QWebFrame::init):
3147
(tst_QWebFrame::cleanup):
3149
2012-06-01 Thiago Marcos P. Santos <thiago.santos@intel.com>
3151
[Qt] Remove deprecated to/fromAscii()
3152
https://bugs.webkit.org/show_bug.cgi?id=88086
3154
Reviewed by Simon Hausmann.
3156
Replacing to/fromAscii with to/fromLatin1 since it
3157
is deprecated on Qt5.
3159
* WebCoreSupport/InspectorClientQt.cpp:
3161
* WebCoreSupport/InspectorServerQt.cpp:
3162
(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
3163
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
3164
(tst_QDeclarativeWebView::settings):
3166
2012-05-31 Hajime Morrita <morrita@chromium.org>
3168
REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac
3169
https://bugs.webkit.org/show_bug.cgi?id=86859
3171
Reviewed by Ryosuke Niwa.
3173
* WebCoreSupport/TextCheckerClientQt.h:
3174
(WebCore::TextCheckerClientQt::requestCheckingOfString):
3176
2012-05-31 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3178
[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
3179
https://bugs.webkit.org/show_bug.cgi?id=87955
3181
Reviewed by Simon Hausmann.
3183
* Api/qgraphicswebview.cpp:
3184
* Api/qgraphicswebview.h:
3185
* Api/qwebframe.cpp:
3186
* Api/qwebframe_p.h:
3189
* Api/qwebsettings.cpp:
3192
* WebCoreSupport/FrameLoaderClientQt.cpp:
3193
* WebCoreSupport/GeolocationClientQt.cpp:
3194
* WebCoreSupport/GeolocationClientQt.h:
3195
* WebCoreSupport/PageClientQt.cpp:
3196
* WebCoreSupport/WebEventConversion.cpp:
3197
* declarative/plugin.cpp:
3198
* tests/qwebframe/tst_qwebframe.cpp:
3201
2012-05-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3203
[Qt] Sync up favicon-implementation with WebView url changes in r118158
3205
https://bugs.webkit.org/show_bug.cgi?id=87133
3207
We now base64-encode the page url in the image-provider url, so that any
3208
normalization done by QUrl will not mess up the page-url. The logic of
3209
creating and parsing the provider-url has been moved into the image
3210
provider, to keep it in one place.
3212
We were also releasing icons (even ones we hadn't retained), which we can't
3213
do since we don't know when the icon url is no longer in use.
3215
Reviewed-by Simon Hausmann.
3217
* declarative/plugin.cpp:
3218
* declarative/public.pri:
3220
2012-05-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
3222
WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
3223
https://bugs.webkit.org/show_bug.cgi?id=42328
3225
Reviewed by Eric Seidel.
3227
Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
3228
move to windows.internals.settings.
3230
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3231
* WebCoreSupport/DumpRenderTreeSupportQt.h:
3233
2012-05-27 Simon Hausmann <simon.hausmann@nokia.com>
3235
[Qt] Trivial unreviewed build fix with newer Qt
3238
(QWebPage::javaScriptPrompt): Don't use deprecated QString/QChar functions.
3240
2012-05-24 Ryosuke Niwa <rniwa@webkit.org>
3242
createContextualFragment and insertAdjacentHTML should throw syntax error
3243
https://bugs.webkit.org/show_bug.cgi?id=87454
3245
Reviewed by Darin Adler.
3247
Pass an ExceptionCode to createContextualFragment.
3249
* Api/qwebelement.cpp:
3250
(QWebElement::appendInside):
3251
(QWebElement::prependInside):
3252
(QWebElement::prependOutside):
3253
(QWebElement::appendOutside):
3254
(QWebElement::encloseContentsWith):
3255
(QWebElement::encloseWith):
3257
2012-05-25 Csaba Osztrogonác <ossy@webkit.org>
3259
[Qt] Buildfix for newer Qt5
3260
https://bugs.webkit.org/show_bug.cgi?id=87257
3262
Reviewed by Simon Hausmann.
3264
* Api/qgraphicswebview.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
3265
* Api/qwebframe.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
3266
* Api/qwebhistory.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
3267
* Api/qwebsettings.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
3268
* Api/qwebview.h: QtWidgets/qicon.h -> QtGui/qicon.h renaming.
3269
* WebCoreSupport/FrameLoaderClientQt.cpp: Adjust QCoreApplication::translate() parameter list to newer Qt 5.
3270
(WebCore::FrameLoaderClientQt::cancelledError):
3271
(WebCore::FrameLoaderClientQt::blockedError):
3272
(WebCore::FrameLoaderClientQt::cannotShowURLError):
3273
(WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
3274
(WebCore::FrameLoaderClientQt::cannotShowMIMETypeError):
3275
(WebCore::FrameLoaderClientQt::fileDoesNotExistError):
3276
(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):
3277
* declarative/experimental/plugin.cpp: QDeclarativeExtensionPlugin -> QQmlExtensionPlugin renaming.
3278
* declarative/plugin.cpp: QDeclarativeExtensionPlugin -> QQmlExtensionPlugin renaming.
3281
2012-05-24 Ryosuke Niwa <rniwa@webkit.org>
3283
There are too many poorly named functions to create a fragment from markup
3284
https://bugs.webkit.org/show_bug.cgi?id=87339
3286
Reviewed by Eric Seidel.
3288
Replace calls to Range::createDocumentFragmentForElement by calls to
3289
createContextualDocumentFragment.
3291
* Api/qwebelement.cpp:
3292
(QWebElement::appendInside):
3293
(QWebElement::prependInside):
3294
(QWebElement::prependOutside):
3295
(QWebElement::appendOutside):
3296
(QWebElement::encloseContentsWith):
3297
(QWebElement::encloseWith):
3299
2012-05-24 Gabor Ballabas <gaborb@inf.u-szeged.hu>
3301
[Qt] Fix Webkit1 + V8 build.
3302
https://bugs.webkit.org/show_bug.cgi?id=87368
3304
Reviewed by Eric Seidel.
3306
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3307
(DumpRenderTreeSupportQt::evaluateScriptInIsolatedWorld):
3309
2012-05-24 Steffen Imhof <steffen.imhof@basyskom.com>
3311
https://bugs.webkit.org/show_bug.cgi?id=67093
3312
[Qt] Default window.alert shows HTML entities in certain cases
3314
Instead of HTML escaping the text of JS alerts (which does not work
3315
consistently because of Qt's automatisms), build message boxes
3316
explicitly to be able set the text format to plain text.
3317
QInputDialog is a bit hacky, because there is no way to access or
3318
control the contained QLabel.
3320
Reviewed by Simon Hausmann.
3323
(QWebPage::javaScriptAlert):
3324
(QWebPage::javaScriptConfirm):
3325
(QWebPage::javaScriptPrompt):
3327
2012-05-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
3329
Move setEditingBehavior() from layoutTestController to window.internals
3330
https://bugs.webkit.org/show_bug.cgi?id=42689
3332
Reviewed by Hajime Morita and Kenneth Rohde Christiansen.
3334
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3335
(DumpRenderTreeSupportQt::setWindowsBehaviorAsEditingBehavior): Reduce the job
3336
done by this function to the minimal.
3337
* WebCoreSupport/DumpRenderTreeSupportQt.h:
3339
2012-05-18 MORITA Hajime <morrita@google.com>
3341
https://bugs.webkit.org/show_bug.cgi?id=85515
3342
Stale frame in WebCore::SpellChecker::didCheckSucceeded
3344
Reviewed by Ryosuke Niwa.
3346
* WebCoreSupport/EditorClientQt.h:
3347
(WebCore::EditorClientQt::frameWillDetachPage):
3349
2012-05-17 Hironori Bono <hbono@chromium.org>
3351
[Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
3352
https://bugs.webkit.org/show_bug.cgi?id=86591
3354
Reviewed by Ryosuke Niwa.
3356
This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection
3357
function to remove platform-specific code from Editor::respondToChangedSelection
3360
No new tests, no change in behavior.
3362
* WebCoreSupport/TextCheckerClientQt.cpp:
3363
(WebCore::TextCheckerClientQt::shouldEraseMarkersAfterChangeSelection):
3365
* WebCoreSupport/TextCheckerClientQt.h:
3366
(TextCheckerClientQt):
3368
2012-05-17 Dan Bernstein <mitz@apple.com>
3370
REGRESSION (r117428): WebKit API/SPI was removed
3371
https://bugs.webkit.org/show_bug.cgi?id=86748
3375
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3376
(DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme):
3377
* WebCoreSupport/DumpRenderTreeSupportQt.h:
3379
2012-05-17 Tsarko Yaroslav <eriktsarko@googlemail.com>
3381
Reviewed by Yury Semikhatsky.
3383
Bug 71271: [Qt] Web Inspector: local inspector client UI becomes unresponsive on debugger pause during
3384
https://bugs.webkit.org/show_bug.cgi?id=71271
3386
Web Inspector should not belong to any other page groups since it is a specialized debugger window.
3387
The reason for this change is when debugger pauses web page it pauses all the pages in the page group of debuggee.
3388
This leads that Web Inspector front-end is paused too leading to locked Web Inspector GUI (bugzilla ticket 71271).
3390
* WebCoreSupport/InspectorClientQt.cpp:
3391
(WebCore::InspectorClientQt::openInspectorFrontend):
3393
2012-05-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3395
Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
3396
https://bugs.webkit.org/show_bug.cgi?id=86704
3398
Reviewed by Eric Seidel.
3400
Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
3401
cross-port way through the InternalSettings interface.
3403
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3404
* WebCoreSupport/DumpRenderTreeSupportQt.h:
3406
2012-05-15 Kenneth Rohde Christiansen <kenneth@webkit.org>
3408
[Qt] Add infra for testing double-tap to zoom functionality etc
3409
https://bugs.webkit.org/show_bug.cgi?id=86474
3411
Reviewed by Simon Hausmann.
3413
The WebViewportInfo class was renamed to QWebKitTest in preparation
3414
of becoming a separate module. Adapt the use API.
3416
* declarative/experimental/plugin.cpp:
3418
2012-05-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3420
Move resumeAnimations to use Internals interface
3421
https://bugs.webkit.org/show_bug.cgi?id=86063
3423
Reviewed by Alexey Proskuryakov.
3425
Remove resumeAnimations functions, because it is able to work in the
3426
cross-port way through the Internals interface.
3428
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3429
* WebCoreSupport/DumpRenderTreeSupportQt.h:
3431
2012-05-10 Marius Storm-Olsen <marius.storm-olsen@nokia.com>
3433
[Qt] Fix \sa usage in documentation
3435
Ensure comma between elements (6 missing).
3437
Reviewed by Tor Arne Vestbø.
3441
2012-05-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3443
Move suspendAnimations to use Internals interface.
3444
https://bugs.webkit.org/show_bug.cgi?id=85986
3446
Reviewed by Ryosuke Niwa.
3448
Remove suspendAnimations functions, because it is able to work in the
3449
cross-port way through the Internals interface.
3451
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3452
* WebCoreSupport/DumpRenderTreeSupportQt.h:
3454
2012-05-08 Balazs Kelemen <kbalazs@webkit.org>
3456
[Qt] X11 plugins need to be reworked for Qt5+WK1
3457
https://bugs.webkit.org/show_bug.cgi?id=80691
3459
Reviewed by Simon Hausmann.
3461
* Api/qwebsettings.cpp:
3462
(QWebSettings::enablePersistentStorage):
3464
* WebCoreSupport/FrameLoaderClientQt.cpp:
3465
(WebCore::FrameLoaderClientQt::createPlugin):
3466
Inject the wmode parameter for flash so it will
3467
work in windowless, non-transparent mode which
3468
is the only one we support currently.
3469
* WebCoreSupport/PageClientQt.cpp:
3471
(WebCore::QWebPageClient::ownerWindow):
3472
Added a getter for the top level window so the PluginView
3473
can get it without calling into QtWidgets code.
3475
2012-05-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3477
Convert isPageBoxVisible to use Internals interface.
3478
https://bugs.webkit.org/show_bug.cgi?id=85692
3480
Reviewed by Darin Adler.
3482
Remove isPageBoxVisible functions, because it is able to work in the
3483
cross-port way through the Internals interface.
3485
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3486
* WebCoreSupport/DumpRenderTreeSupportQt.h:
3488
2012-05-04 Nate Chapin <japhet@chromium.org>
3490
Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
3491
https://bugs.webkit.org/show_bug.cgi?id=85533
3493
Reviewed by Alexey Proskuryakov.
3495
* WebCoreSupport/FrameLoaderClientQt.cpp:
3496
(WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
3498
(WebCore::FrameLoaderClientQt::finishedLoading):
3499
* WebCoreSupport/FrameLoaderClientQt.h:
3500
(WebCore::FrameLoaderClientQt::makeRepresentation):
3501
(WebCore::FrameLoaderClientQt::revertToProvisionalState):
3502
(FrameLoaderClientQt):
3504
2012-05-03 Fady Samuel <fsamuel@chromium.org>
3506
Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
3507
https://bugs.webkit.org/show_bug.cgi?id=70609
3509
Reviewed by Kenneth Rohde Christiansen.
3512
(QWebPage::viewportAttributesForSize):
3514
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3515
(DumpRenderTreeSupportQt::viewportAsText):
3517
2012-04-27 Jon Lee <jonlee@apple.com>
3519
Migrate permission functions to Notification from NotificationCenter
3520
https://bugs.webkit.org/show_bug.cgi?id=80485
3521
<rdar://problem/10965458>
3523
Reviewed by Jian Li.
3525
* WebCoreSupport/NotificationPresenterClientQt.h:
3526
(NotificationPresenterClientQt): Add stub implementation of requestPermission.
3527
(WebCore::NotificationPresenterClientQt::requestPermission):
3529
2012-05-02 Sheriff Bot <webkit.review.bot@gmail.com>
3531
Unreviewed, rolling out r115907.
3532
http://trac.webkit.org/changeset/115907
3533
https://bugs.webkit.org/show_bug.cgi?id=85458
3535
It broke all viewport tests on Qt and on GTK (Requested by
3539
(QWebPage::viewportAttributesForSize):
3541
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3542
(DumpRenderTreeSupportQt::viewportAsText):
3544
2012-04-18 Jon Honeycutt <jhoneycutt@apple.com>
3546
FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more
3547
information about the form being submitted
3548
https://bugs.webkit.org/show_bug.cgi?id=84297
3550
Reviewed by Andy Estes.
3552
* WebCoreSupport/FrameLoaderClientQt.h:
3553
(WebCore::FrameLoaderClientQt::dispatchWillSendSubmitEvent):
3554
Updated method declaration.
3556
2012-05-02 Fady Samuel <fsamuel@chromium.org>
3558
Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
3559
https://bugs.webkit.org/show_bug.cgi?id=70609
3561
Reviewed by Kenneth Rohde Christiansen.
3564
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3565
(DumpRenderTreeSupportQt::viewportAsText):
3567
2012-05-02 Milian Wolff <milian.wolff@kdab.com>
3569
[Qt] Pass page-height to PrintContext::begin to fix print layouting
3570
https://bugs.webkit.org/show_bug.cgi?id=84864
3572
Reviewed by Simon Hausmann.
3574
* Api/qwebframe.cpp:
3577
2012-05-02 Kenneth Rohde Christiansen <kenneth@webkit.org>
3579
[Qt] Add initial QML documentation
3580
https://bugs.webkit.org/show_bug.cgi?id=85370
3582
Reviewed by Simon Hausmann.
3584
* docs/qtwebkit.qdocconf: Add WebKit2 dirs.
3586
2012-05-02 Csaba Osztrogonác <ossy@webkit.org>
3588
[Qt] Buildfix after r115812 for !ENABLE(DEVICE_ORIENTATION) builds.
3589
https://bugs.webkit.org/show_bug.cgi?id=64595
3591
Reviewed by Kenneth Rohde Christiansen.
3595
2012-04-27 Allan Sandfeld Jensen <allan.jensen@nokia.com>
3597
Move WebKit1 specific conversion of touch-events to WebKit1
3598
https://bugs.webkit.org/show_bug.cgi?id=84951
3600
Reviewed by Kenneth Rohde Christiansen.
3602
Fix compile when touch-events are disabled.
3604
* WebCoreSupport/WebEventConversion.cpp:
3606
* WebCoreSupport/WebEventConversion.h:
3609
2012-04-26 Allan Sandfeld Jensen <allan.jensen@nokia.com>
3611
Move WebKit1 specific conversion of touch-events to WebKit1.
3612
https://bugs.webkit.org/show_bug.cgi?id=84951
3614
Reviewed by Kenneth Rohde Christiansen.
3617
(QWebPagePrivate::touchEvent):
3618
* WebCoreSupport/WebEventConversion.cpp:
3619
(WebKitPlatformTouchEvent):
3620
(WebKitPlatformTouchPoint):
3621
(WebCore::WebKitPlatformTouchEvent::WebKitPlatformTouchEvent):
3622
(WebCore::WebKitPlatformTouchPoint::WebKitPlatformTouchPoint):
3623
(WebCore::convertTouchEvent):
3624
* WebCoreSupport/WebEventConversion.h:
3626
2012-04-25 Alexis Menard <alexis.menard@openbossa.org>
3628
Rename CSSStyleSelector files to StyleResolver.
3629
https://bugs.webkit.org/show_bug.cgi?id=84814
3631
Reviewed by Antti Koivisto.
3633
Rename CSSStyleSelector files to match the new class name StyleResolver.
3634
Update the includes all over the code base to the new name.
3636
* Api/qwebelement.cpp:
3637
* WebCoreSupport/RenderThemeQStyle.cpp:
3639
2012-04-25 Milian Wolff <milian.wolff@kdab.com>
3641
[Qt] add LayoutTestController::setPrinting support to Qt unit tests
3642
https://bugs.webkit.org/show_bug.cgi?id=84246
3644
Reviewed by Simon Hausmann.
3646
* Api/qwebframe.cpp:
3647
(QWebFrame::paintPagesWithBoundaries):
3649
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3650
(DumpRenderTreeSupportQt::paintPagesWithBoundaries):
3651
* WebCoreSupport/DumpRenderTreeSupportQt.h:
3653
2012-04-24 Alexis Menard <alexis.menard@openbossa.org>
3655
Replace occurences of style selector from variables and methods names by style resolver.
3656
https://bugs.webkit.org/show_bug.cgi?id=84765
3658
Reviewed by Andreas Kling.
3660
Rename methods and variables to follow the new name StyleResolver. It requires to update the
3661
local variables, methods parameters, and function names to match the new name and to remove
3662
the concept of "selector" to avoid clashing with the CSS concept. The next and last patch
3663
will be to rename CSSStyleSelector file and update the includes.
3665
* Api/qwebelement.cpp:
3666
(QWebElement::styleProperty):
3667
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3668
(DumpRenderTreeSupportQt::setMediaType):
3669
* WebCoreSupport/RenderThemeQStyle.cpp:
3670
(WebCore::RenderThemeQStyle::adjustButtonStyle):
3671
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
3672
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
3673
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
3674
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
3675
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
3677
2012-04-24 Alexis Menard <alexis.menard@openbossa.org>
3679
Rename CSSStyleSelector class to StyleResolver.
3680
https://bugs.webkit.org/show_bug.cgi?id=84734
3682
Reviewed by Andreas Kling.
3684
The name CSSStyleSelector is confusing as it conflicts a bit with
3685
the CSS concept of selectors. One could think it's an encapsulation
3686
of the CSS selectors but it's not, in fact this class is responsible
3687
of finding the RenderStyle for a given element. This is the first patch
3688
as I will later rename the files, and then rename the local variables.
3690
* WebCoreSupport/RenderThemeQStyle.cpp:
3691
(WebCore::RenderThemeQStyle::adjustButtonStyle):
3692
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
3693
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
3694
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
3695
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
3696
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
3697
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
3698
* WebCoreSupport/RenderThemeQStyle.h:
3699
(RenderThemeQStyle):
3701
2012-04-24 Yael Aharon <yael.aharon@nokia.com>
3703
[Qt] Move notification icon download out of WebCore
3704
https://bugs.webkit.org/show_bug.cgi?id=80700
3706
Reviewed by Simon Hausmann.
3708
Remove the code that handles the notification's icon and use the icon url instead.
3709
The "display" event has to be asynchronous, so a timer was added to achieve that.
3710
The platform plugin API and example were updated to reflect this change.
3711
This change does not address the recent changes in web notifications spec.
3713
* Api/qwebkitplatformplugin.h:
3714
(QWebNotificationData):
3715
* WebCoreSupport/NotificationPresenterClientQt.cpp:
3716
(WebCore::NotificationWrapper::NotificationWrapper):
3717
(WebCore::NotificationWrapper::sendDisplayEvent):
3719
(WebCore::NotificationWrapper::iconUrl):
3720
(WebCore::NotificationPresenterClientQt::show):
3721
(WebCore::NotificationPresenterClientQt::displayNotification):
3722
(WebCore::NotificationPresenterClientQt::sendDisplayEvent):
3723
* WebCoreSupport/NotificationPresenterClientQt.h:
3724
(NotificationWrapper):
3725
(NotificationPresenterClientQt):
3726
* examples/platformplugin/WebNotificationPresenter.cpp:
3727
(WebNotificationWidget::showNotification):
3728
* examples/platformplugin/qwebkitplatformplugin.h:
3729
(QWebNotificationData):
3731
2012-04-18 Allan Sandfeld Jensen <allan.jensen@nokia.com>
3733
Clean-up WheelEvent Conversion.
3734
https://bugs.webkit.org/show_bug.cgi?id=84243
3736
Reviewed by Simon Hausmann.
3738
* WebCoreSupport/WebEventConversion.cpp:
3739
(WebCore::WebKitPlatformWheelEvent::applyDelta):
3741
2012-04-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3743
[Qt] Build fix with QT_NO_BEARERMANAGEMENT
3745
Reviewed by Jocelyn Turcotte.
3747
* tests/benchmarks/loading/tst_loading.cpp:
3749
(tst_Loading::load):
3750
* tests/benchmarks/painting/tst_painting.cpp:
3752
(tst_Painting::paint):
3754
2012-04-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
3756
[Qt] Fix build on OS X
3758
We were manually including the directories needed from WTF, instead of
3759
using the WEBKIT qmake variable to add dependencies, which also adds
3760
other tricks from WTF.pri, such as the right include paths for ICU.
3762
Reviewed by Simon Hausmann.
3764
* declarative/experimental/experimental.pri:
3765
* declarative/public.pri:
3767
2012-04-12 Balazs Kelemen <kbalazs@webkit.org>
3769
[Qt] Fix WebKit1 build with V8
3770
https://bugs.webkit.org/show_bug.cgi?id=83322
3772
Reviewed by Adam Barth.
3774
* WebCoreSupport/FrameLoaderClientQt.cpp:
3775
(WebCore::FrameLoaderClientQt::didCreateScriptContext):
3776
* WebCoreSupport/FrameLoaderClientQt.h:
3777
(FrameLoaderClientQt):
3778
(WebCore::FrameLoaderClientQt::allowScriptExtension):
3779
* WebCoreSupport/InitWebCoreQt.cpp:
3781
2012-03-05 Pierre Rossi <pierre.rossi@gmail.com>
3783
[Qt] Use QRawFont when building with Qt 5
3784
https://bugs.webkit.org/show_bug.cgi?id=78001
3786
Since QFont is not used internally, we now need
3787
to query for a QFont that should be a good
3790
Reviewed by Simon Hausmann.
3793
(QWebPage::inputMethodQuery):
3794
* WebCoreSupport/PopupMenuQt.cpp:
3795
(WebCore::PopupMenuQt::show):
3796
* WebCoreSupport/RenderThemeQStyle.cpp:
3797
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
3799
2012-04-06 Levi Weintraub <leviw@chromium.org>
3801
Correct LayoutUnit usgae in RenderThemeQt and RenderThemeQStyle
3802
https://bugs.webkit.org/show_bug.cgi?id=83376
3804
Reviewed by Eric Seidel.
3806
Calculating the progress animation using the pixel-snapped RenderProgress size instead
3807
of the internal sub-pixel version.
3809
* WebCoreSupport/RenderThemeQStyle.cpp:
3810
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
3812
2012-04-05 Patrick Gansterer <paroga@webkit.org>
3814
[Qt] Correct <wtf/*.h> include paths.
3815
https://bugs.webkit.org/show_bug.cgi?id=83270
3817
Reviewed by Eric Seidel.
3819
Modify the #include declerations so that the
3820
wtf types are included using the full path.
3823
* WebCoreSupport/ContextMenuClientQt.h:
3824
* WebCoreSupport/EditorClientQt.h:
3825
* WebCoreSupport/FrameLoaderClientQt.h:
3826
* WebCoreSupport/InspectorServerQt.cpp:
3828
2012-04-05 Csaba Osztrogonác <ossy@webkit.org>
3830
[Qt] Fix includes after QtDeclarative -> QtQML renaming
3831
https://bugs.webkit.org/show_bug.cgi?id=82195
3833
Relanding r112651, because Qt5 is updated everywhere.
3835
* declarative/experimental/plugin.cpp:
3836
* declarative/plugin.cpp:
3837
(WebKitQmlPlugin::initializeEngine):
3839
2012-04-04 Andras Becsi <andras.becsi@nokia.com>
3841
[Qt][WK2] Make the WebView a subclass of Flickable
3842
https://bugs.webkit.org/show_bug.cgi?id=83033
3844
Reviewed by Kenneth Rohde Christiansen.
3846
Add needed dependency to quick-private for projects that include the WebView header.
3848
* declarative/experimental/experimental.pri:
3849
* declarative/public.pri:
3851
2012-04-03 Alexis Menard <alexis.menard@openbossa.org>
3853
[Part 2] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
3854
https://bugs.webkit.org/show_bug.cgi?id=82977
3856
Reviewed by Andreas Kling.
3858
Update the code to use CSSPropertyID rather than an integer.
3860
* Api/qwebelement.cpp:
3861
(QWebElement::setStyleProperty):
3863
2012-04-02 Alexis Menard <alexis.menard@openbossa.org>
3865
We should use CSSPropertyID rather than integers when manipulating CSS property ids.
3866
https://bugs.webkit.org/show_bug.cgi?id=82941
3868
Reviewed by Andreas Kling.
3870
CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
3871
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
3872
functions manipulating property ids, as we ensure that the value passed will be an
3873
existing value. It will also feel more correct after this patch that CSSProperty::id()
3874
return a value of the enum rather than an integer. As this modification is quite big this
3875
is the first part only so it will be easier to review.
3877
* Api/qwebelement.cpp:
3878
(QWebElement::styleProperty): Adapt to the API change and also remove an unecessary name->id
3881
2012-04-02 Casper van Donderen <casper.vandonderen@nokia.com>
3883
Qt: Doc: Fix typo which marks document to be printed in console font.
3884
https://bugs.webkit.org/show_bug.cgi?id=82893
3886
Reviewed by Simon Hausmann.
3888
The qtwebkit-bridge.qdoc file contained a typo where a \c {} was
3889
missing its closing curly bracket, this marked the rest of the page as
3890
text to be printed using the code/console font.
3891
* docs/qtwebkit-bridge.qdoc:
3893
2012-04-02 Sheriff Bot <webkit.review.bot@gmail.com>
3895
Unreviewed, rolling out r112651.
3896
http://trac.webkit.org/changeset/112651
3897
https://bugs.webkit.org/show_bug.cgi?id=82887
3899
It doesn't work with older Qt5 (Requested by Ossy on #webkit).
3901
* declarative/experimental/plugin.cpp:
3902
* declarative/plugin.cpp:
3903
(WebKitQmlPlugin::initializeEngine):
3905
2012-04-01 Jon Lee <jonlee@apple.com>
3907
Rename notification properties and functions
3908
https://bugs.webkit.org/show_bug.cgi?id=80482
3909
<rdar://problem/10912432>
3911
Reviewed by Kentaro Hara.
3913
* WebCoreSupport/NotificationPresenterClientQt.cpp:
3914
(WebCore::NotificationPresenterClientQt::show): Refactor to call tag().
3915
(WebCore::NotificationPresenterClientQt::removeReplacedNotificationFromQueue): Refactor to call tag().
3917
2012-03-30 Emil A Eklund <eae@chromium.org>
3919
Change WebKit/WebKit2 platform code to use pixel snapped values
3920
https://bugs.webkit.org/show_bug.cgi?id=82549
3922
Reviewed by Eric Seidel.
3924
* Api/qwebelement.cpp:
3925
(QWebElement::geometry):
3926
Replace getRect with getPixelSnappedRect to avoid having to expose
3927
subpixel types to the platform layer.
3930
(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):
3931
Use pixel snapped element rect when comparing with the touch rect as the
3932
touch rect use screen cordinates which are represented with pixel
3935
* WebCoreSupport/ChromeClientQt.h:
3936
(WebCore::ChromeClientQt::scrollRectIntoView):
3937
Change scrollRectIntoView to take a LayoutRect to match base class
3940
2012-03-30 Mark Pilgrim <pilgrim@chromium.org>
3942
GEOLOCATION should be implemented as Page Supplement
3943
https://bugs.webkit.org/show_bug.cgi?id=82228
3945
Reviewed by Adam Barth.
3947
Geolocation is now a Supplement in Page so the interface
3948
has changed for setting up the page's geolocation client
3949
initially and accessing the controller later.
3952
(QWebPagePrivate::QWebPagePrivate):
3953
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3954
(DumpRenderTreeSupportQt::resetGeolocationMock):
3955
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
3956
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
3957
(DumpRenderTreeSupportQt::setMockGeolocationError):
3958
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
3959
* WebCoreSupport/GeolocationClientQt.cpp:
3960
(WebCore::GeolocationClientQt::positionUpdated):
3961
(WebCore::GeolocationClientQt::startUpdating):
3963
2012-03-29 Ádám Kallai <kadam@inf.u-szeged.hu>
3965
[Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
3966
https://bugs.webkit.org/show_bug.cgi?id=82195
3968
Reviewed by Simon Hausmann.
3970
* declarative/experimental/plugin.cpp:
3971
* declarative/plugin.cpp:
3972
(WebKitQmlPlugin::initializeEngine):
3974
2012-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
3976
Unreviewed, rolling out r112553.
3977
http://trac.webkit.org/changeset/112553
3978
https://bugs.webkit.org/show_bug.cgi?id=82638
3980
It made all tests crash on Qt WK2 (Requested by Ossy_away on
3984
(QWebPagePrivate::QWebPagePrivate):
3985
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
3986
(DumpRenderTreeSupportQt::resetGeolocationMock):
3987
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
3988
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
3989
(DumpRenderTreeSupportQt::setMockGeolocationError):
3990
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
3991
* WebCoreSupport/GeolocationClientQt.cpp:
3992
(WebCore::GeolocationClientQt::positionUpdated):
3993
(WebCore::GeolocationClientQt::startUpdating):
3995
2012-03-29 Mark Pilgrim <pilgrim@chromium.org>
3997
GEOLOCATION should be implemented as Page Supplement
3998
https://bugs.webkit.org/show_bug.cgi?id=82228
4000
Reviewed by Adam Barth.
4002
Geolocation is now a Supplement in Page so the interface
4003
has changed for setting up the page's geolocation client
4004
initially and accessing the controller later.
4007
(QWebPagePrivate::QWebPagePrivate):
4008
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
4009
(DumpRenderTreeSupportQt::resetGeolocationMock):
4010
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
4011
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
4012
(DumpRenderTreeSupportQt::setMockGeolocationError):
4013
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
4014
* WebCoreSupport/GeolocationClientQt.cpp:
4015
(WebCore::GeolocationClientQt::positionUpdated):
4016
(WebCore::GeolocationClientQt::startUpdating):
4018
2012-03-28 Nate Chapin <japhet@chromium.org>
4020
Remove dispatchDidLoadMainResource callback, since no
4022
https://bugs.webkit.org/show_bug.cgi?id=82539
4024
Reviewed by Alexey Proskuryakov.
4026
* WebCoreSupport/FrameLoaderClientQt.cpp:
4028
* WebCoreSupport/FrameLoaderClientQt.h:
4029
(FrameLoaderClientQt):
4031
2012-03-20 Eric Seidel <eric@webkit.org>
4033
Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
4034
https://bugs.webkit.org/show_bug.cgi?id=80911
4036
Reviewed by Adam Barth.
4038
Fix WTF header include paths since although
4039
Source/WTF is included, no longer are all the
4040
subdirectories (thus "RefPtr.h" can't work).
4042
* Api/qwebdatabase_p.h:
4043
* Api/qwebscriptworld_p.h:
4044
* Api/qwebsecurityorigin_p.h:
4045
* WebCoreSupport/InspectorClientQt.h:
4046
* WebCoreSupport/QtFallbackWebPopup.h:
4047
* WebCoreSupport/QtWebComboBox.h:
4048
* declarative/experimental/experimental.pri:
4049
* declarative/public.pri:
4050
* tests/MIMESniffing/MIMESniffing.pro:
4052
2012-03-19 Adam Barth <abarth@webkit.org>
4054
Remove support for "magic" iframe
4055
https://bugs.webkit.org/show_bug.cgi?id=81590
4057
Reviewed by Eric Seidel.
4059
Remove FrameLoaderClient methods that no longer exist.
4061
* WebCoreSupport/FrameLoaderClientQt.cpp:
4063
* WebCoreSupport/FrameLoaderClientQt.h:
4064
(FrameLoaderClientQt):
4066
2012-03-19 Emil A Eklund <eae@chromium.org>
4068
[mac/qt/chromium] Change platform code to use pixelSnappedRect methods
4069
https://bugs.webkit.org/show_bug.cgi?id=81016
4071
Reviewed by Eric Seidel.
4073
* Api/qwebelement.cpp:
4074
(QWebElement::geometry):
4075
(QWebElement::render):
4077
2012-03-16 Teemu Katajisto <teemu.katajisto@digia.com>
4079
[Qt] QtWebKit documentation missing a few since 4.6 information
4080
https://bugs.webkit.org/show_bug.cgi?id=81328
4082
Reviewed by Simon Hausmann.
4085
* Api/qwebsettings.cpp:
4087
2012-03-15 Yuta Kitamura <yutak@chromium.org>
4089
[Qt] Change default WebSocket protocol to the latest one
4090
https://bugs.webkit.org/show_bug.cgi?id=73630
4092
Reviewed by Simon Hausmann.
4095
(QWebPagePrivate::QWebPagePrivate):
4096
Use RFC6455 WebSocket protocol by default.
4098
2012-03-07 Jon Lee <jonlee@apple.com>
4100
Move NotificationContents into Notification
4101
https://bugs.webkit.org/show_bug.cgi?id=80487
4102
<rdar://problem/10965519>
4104
Reviewed by Jian Li.
4106
Refactor to use accessor methods on Notification.
4107
* WebCoreSupport/NotificationPresenterClientQt.cpp:
4108
(WebCore::NotificationWrapper::title):
4109
(WebCore::NotificationWrapper::message):
4110
(WebCore::NotificationPresenterClientQt::displayNotification):
4111
(WebCore::NotificationPresenterClientQt::cancel):
4112
(WebCore::NotificationPresenterClientQt::notificationClicked):
4113
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
4114
(WebCore::NotificationPresenterClientQt::dumpShowText):
4116
2012-03-13 Jon Lee <jonlee@apple.com>
4118
Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
4119
https://bugs.webkit.org/show_bug.cgi?id=80922
4120
<rdar://problem/11035082>
4122
Reviewed by Jian Li.
4124
You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
4125
LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
4126
new API. Therefore, APIs that are common between the two will have:
4127
#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
4129
This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
4130
the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
4132
Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
4134
(QWebPagePrivate::QWebPagePrivate):
4135
(QWebPagePrivate::~QWebPagePrivate):
4136
(QWebPage::setFeaturePermission):
4137
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
4138
(DumpRenderTreeSupportQt::dumpNotification):
4139
(DumpRenderTreeSupportQt::simulateDesktopNotificationClick):
4140
* WebCoreSupport/NotificationPresenterClientQt.cpp:
4142
(WebCore::NotificationWrapper::NotificationWrapper):
4143
(WebCore::NotificationWrapper::close):
4144
(WebCore::NotificationWrapper::title):
4145
(WebCore::NotificationWrapper::message):
4146
(WebCore::NotificationWrapper::iconData):
4147
(WebCore::NotificationWrapper::openerPageUrl):
4148
(WebCore::NotificationWrapper::notificationClicked):
4149
(WebCore::NotificationWrapper::notificationClosed):
4150
* WebCoreSupport/NotificationPresenterClientQt.h:
4153
2012-03-14 Csaba Osztrogonác <ossy@webkit.org>
4155
Last buildfix for Qt after r110595. :)
4157
Reviewed by Benjamin Poulain.
4160
* WebCoreSupport/GeolocationClientQt.h:
4162
2012-03-13 Benjamin Poulain <bpoulain@apple.com>
4164
Attempt to fix QtMinimal bot after r110595
4167
(QWebPagePrivate::QWebPagePrivate):
4169
2012-03-13 Benjamin Poulain <bpoulain@apple.com>
4171
Another attempt at fixing QtMinimal bot after r110595
4173
Blind fix, unreviewed.
4175
* WebCoreSupport/GeolocationClientQt.h:
4177
2012-03-13 Benjamin Poulain <bpoulain@apple.com>
4179
Attempt to fix QtMinimal bot after r110595
4181
Blind fix, unreviewed.
4184
(QWebPagePrivate::QWebPagePrivate):
4185
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
4186
(DumpRenderTreeSupportQt::resetGeolocationMock):
4187
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
4188
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
4189
(DumpRenderTreeSupportQt::setMockGeolocationError):
4190
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
4191
* WebCoreSupport/GeolocationPermissionClientQt.h:
4193
2012-03-13 Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>
4195
Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
4196
https://bugs.webkit.org/show_bug.cgi?id=78853
4198
Reviewed by Adam Barth.
4201
(QWebPagePrivate::QWebPagePrivate):
4202
* WebCoreSupport/ChromeClientQt.h:
4203
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
4204
(toGeolocationClientMock):
4205
(DumpRenderTreeSupportQt::resetGeolocationMock):
4206
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
4207
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
4208
(DumpRenderTreeSupportQt::setMockGeolocationError):
4209
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
4210
* WebCoreSupport/GeolocationClientQt.h:
4213
2012-03-12 Antonio Gomes <agomes@rim.com>
4215
Convert nodesFromRect tests to use Internals interface
4216
https://bugs.webkit.org/show_bug.cgi?id=80886
4218
Reviewed by Ryosuke Niwa.
4220
Removed DRTSupportQt::nodesFromRect support, since
4221
it can work in the cross-port way through the
4222
Internals interface.
4224
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
4225
* WebCoreSupport/DumpRenderTreeSupportQt.h:
4227
2012-03-09 Jon Lee <jonlee@apple.com>
4229
Rename NotificationPresenter to NotificationClient
4230
https://bugs.webkit.org/show_bug.cgi?id=80488
4231
<rdar://problem/10965558>
4233
Reviewed by Kentaro Hara.
4235
Refactor to use renamed WebCore::NotificationClient.
4236
* WebCoreSupport/NotificationPresenterClientQt.cpp:
4237
(WebCore::NotificationPresenterClientQt::checkPermission):
4238
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame):
4239
* WebCoreSupport/NotificationPresenterClientQt.h:
4240
(NotificationPresenterClientQt):
4242
2012-03-09 Emil A Eklund <eae@chromium.org>
4244
Add roundedPoint to HitTestResult and change platform code to use it
4245
https://bugs.webkit.org/show_bug.cgi?id=80715
4247
Reviewed by James Robinson.
4249
Change ports to use roundedPoint to avoid exposing subpixel types to
4252
* Api/qwebframe.cpp:
4253
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
4255
2012-03-09 Jon Lee <jonlee@apple.com>
4257
Add support for ENABLE(LEGACY_NOTIFICATIONS)
4258
https://bugs.webkit.org/show_bug.cgi?id=80497
4260
Reviewed by Adam Barth.
4262
Prep for b80472: Update API for Web Notifications
4263
* examples/platformplugin/platformplugin.pro:
4265
2012-03-09 Csaba Osztrogonác <ossy@webkit.org>
4267
[Qt] Fix compilation without QtQuick1
4268
https://bugs.webkit.org/show_bug.cgi?id=80503
4270
Qt 4.8 API test fix after r110050.
4272
Reviewed by Zoltan Herczeg.
4274
* declarative/public.pri: Add load(features) to ensure HAVE_QQUICK1=1 is set.
4276
2012-03-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
4278
[Qt] Use Qt's module system for install rules and depending on QtWebKit
4280
Instead of rolling our own install rules we now use the same approach as
4281
every other Qt module, by loading qt_module.prf and qt_module_config.prf.
4283
This ensures that we follow the same semantics as the rest of Qt on
4284
what sort of config options are enabled by default (create_cmake eg.).
4285
It also allows us to use QT += webkit instead of the workaround we had
4286
with CONFIG += qtwebkit.
4288
We do however force Qt to always treat our build as a non-developer build,
4289
so the libraries will end up in the WebKit lib directory instead of the
4290
qtbase directory (as with a normal developer-build). This allows us to
4291
keep the webkit-build self-contained. If Qt is a developer build we still
4292
copy the module file manually to Qt, so that you don't have to install
4293
WebKit to make it available.
4295
For non-developer builds of Qt, it is still possible to use the built
4296
WebKit libraries without having to install them, by having the variable
4297
QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
4298
pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
4300
https://bugs.webkit.org/show_bug.cgi?id=80590
4302
Reviewed by Simon Hausmann.
4304
* declarative/experimental/experimental.pri:
4305
* declarative/experimental/plugin.cpp:
4306
* declarative/plugin.cpp:
4307
* declarative/public.pri:
4310
2012-03-08 Antti Koivisto <antti@apple.com>
4312
https://bugs.webkit.org/show_bug.cgi?id=80370
4313
Enable matched declaration caching for elements with a style attribute
4315
Reviewed by Andreas Kling
4317
* Api/qwebelement.cpp:
4318
(QWebElement::styleProperty):
4319
(QWebElement::setStyleProperty):
4321
2012-03-07 Simon Hausmann <simon.hausmann@nokia.com>
4323
[Qt] Fix compilation without QtQuick1
4324
https://bugs.webkit.org/show_bug.cgi?id=80503
4326
Reviewed by Tor Arne Vestbø.
4328
Compile and enable the QtQuick1/QML1 plugin and webview
4329
only if we're using Qt 4 at the moment. QQuick1 clashes
4330
with QQuick2 right now because both declare QDeclarativeEngine
4331
and friends as classes.
4333
* declarative/plugin.cpp:
4334
(WebKitQmlPlugin::registerTypes):
4335
* declarative/public.pri:
4338
2012-03-07 Kangil Han <kangil.han@samsung.com>
4340
[DRT] Remove PlainTextController implementations.
4341
https://bugs.webkit.org/show_bug.cgi?id=79959
4343
Reviewed by Hajime Morita.
4345
PlainTextController usages in existing tests have been
4346
replaced by internals API by bug 78570.
4347
So this patch will remove PlainTextController implementations
4348
to avoid further usage in new tests.
4350
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
4351
* WebCoreSupport/DumpRenderTreeSupportQt.h:
4353
2012-03-06 Philippe Normand <pnormand@igalia.com>
4355
[GStreamer] disable GStreamerGWorld when building against 0.11
4356
https://bugs.webkit.org/show_bug.cgi?id=77088
4358
Reviewed by Martin Robinson.
4360
* WebCoreSupport/ChromeClientQt.cpp:
4361
(WebCore::ChromeClientQt::ChromeClientQt):
4362
(WebCore::ChromeClientQt::~ChromeClientQt):
4364
* WebCoreSupport/FullScreenVideoQt.cpp:
4366
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
4367
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
4368
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
4369
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
4370
(WebCore::FullScreenVideoQt::isValid):
4371
* WebCoreSupport/FullScreenVideoQt.h:
4374
2012-03-03 Simon Hausmann <simon.hausmann@nokia.com>
4376
[Qt] Fix static_libs_as_shared build
4377
https://bugs.webkit.org/show_bug.cgi?id=80214
4379
Reviewed by Tor Arne Vestbø.
4381
Add helper function to be called by WebProcess main
4382
to potentially initialize the QStyle theme.
4384
* WebCoreSupport/InitWebCoreQt.cpp:
4386
(WebKit::initializeWebKit2Theme):
4388
2012-03-02 Casper van Donderen <casper.vandonderen@nokia.com>
4390
[Qt] Documentation cleanup
4391
https://bugs.webkit.org/show_bug.cgi?id=80131
4393
Reviewed by Simon Hausmann.
4395
QDoc uses different commands to do bold, lists, and italics.
4396
This change updates the documentation accordingly.
4399
* Api/qwebframe.cpp:
4400
* Api/qwebhistory.cpp:
4401
* Api/qwebinspector.cpp:
4403
* Api/qwebpluginfactory.cpp:
4404
* Api/qwebsettings.cpp:
4405
* declarative/qdeclarativewebview.cpp:
4406
* docs/qtwebkit-bridge.qdoc:
4407
* docs/qtwebkit.qdoc:
4408
* docs/qtwebkit.qdocconf:
4410
2012-03-02 Simon Hausmann <simon.hausmann@nokia.com>
4412
[Qt] Build system cleanup
4414
Rubber-stamped by Antti Koivisto.
4416
* tests/MIMESniffing/MIMESniffing.pro: Don't link in WTFAssertions.cpp for ASSERT, now
4417
that the symbols are properly exported with export macros from the DLL.
4419
2012-03-02 Simon Hausmann <simon.hausmann@nokia.com>
4421
[Qt] Move QStyle theming code out of WebCore into WebKit1
4422
https://bugs.webkit.org/show_bug.cgi?id=80128
4424
Reviewed by Kenneth Rohde Christiansen.
4426
Moved the bulk of the QStyle dependant code here, where it's okay to depend on QtWidgets/QStyle.
4427
Install the QStyle factory functions in initWebCoreQt.cpp.
4430
(QWebPage::swallowContextMenuEvent):
4431
* WebCoreSupport/InitWebCoreQt.cpp:
4432
(WebCore::initializeWebCoreQt):
4433
* WebCoreSupport/RenderThemeQStyle.cpp: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.cpp.
4435
(WebCore::initStyleOption):
4436
(WebCore::RenderThemeQStyle::getStylePainter):
4437
(WebCore::StylePainterQStyle::StylePainterQStyle):
4438
(WebCore::StylePainterQStyle::init):
4439
(WebCore::RenderThemeQStyle::create):
4440
(WebCore::RenderThemeQStyle::RenderThemeQStyle):
4441
(WebCore::RenderThemeQStyle::~RenderThemeQStyle):
4442
(WebCore::RenderThemeQStyle::fallbackStyle):
4443
(WebCore::RenderThemeQStyle::qStyle):
4444
(WebCore::RenderThemeQStyle::findFrameLineWidth):
4445
(WebCore::RenderThemeQStyle::inflateButtonRect):
4446
(WebCore::RenderThemeQStyle::computeSizeBasedOnStyle):
4447
(WebCore::RenderThemeQStyle::adjustButtonStyle):
4448
(WebCore::RenderThemeQStyle::setButtonPadding):
4449
(WebCore::RenderThemeQStyle::paintButton):
4450
(WebCore::RenderThemeQStyle::paintTextField):
4451
(WebCore::RenderThemeQStyle::adjustTextAreaStyle):
4452
(WebCore::RenderThemeQStyle::paintTextArea):
4453
(WebCore::RenderThemeQStyle::setPopupPadding):
4454
(WebCore::RenderThemeQStyle::paintMenuList):
4455
(WebCore::RenderThemeQStyle::adjustMenuListButtonStyle):
4456
(WebCore::RenderThemeQStyle::paintMenuListButton):
4457
(WebCore::RenderThemeQStyle::animationDurationForProgressBar):
4458
(WebCore::RenderThemeQStyle::paintProgressBar):
4459
(WebCore::RenderThemeQStyle::paintSliderTrack):
4460
(WebCore::RenderThemeQStyle::adjustSliderTrackStyle):
4461
(WebCore::RenderThemeQStyle::paintSliderThumb):
4462
(WebCore::RenderThemeQStyle::adjustSliderThumbStyle):
4463
(WebCore::RenderThemeQStyle::paintSearchField):
4464
(WebCore::RenderThemeQStyle::adjustSearchFieldDecorationStyle):
4465
(WebCore::RenderThemeQStyle::paintSearchFieldDecoration):
4466
(WebCore::RenderThemeQStyle::adjustSearchFieldResultsDecorationStyle):
4467
(WebCore::RenderThemeQStyle::paintSearchFieldResultsDecoration):
4468
(WebCore::RenderThemeQStyle::paintInnerSpinButton):
4469
(WebCore::RenderThemeQStyle::initializeCommonQStyleOptions):
4470
(WebCore::RenderThemeQStyle::adjustSliderThumbSize):
4471
* WebCoreSupport/RenderThemeQStyle.h: Renamed from Source/WebCore/platform/qt/RenderThemeQStyle.h.
4473
(RenderThemeQStyle):
4474
(StylePainterQStyle):
4475
(WebCore::StylePainterQStyle::isValid):
4476
(WebCore::StylePainterQStyle::drawPrimitive):
4477
(WebCore::StylePainterQStyle::drawControl):
4478
(WebCore::StylePainterQStyle::drawComplexControl):
4479
* WebCoreSupport/ScrollbarThemeQStyle.cpp: Copied from Source/WebCore/platform/qt/ScrollbarThemeQt.cpp.
4481
(WebCore::ScrollbarThemeQStyle::~ScrollbarThemeQStyle):
4483
(WebCore::scrollbarPart):
4484
(WebCore::styleOptionSlider):
4485
(WebCore::ScrollbarThemeQStyle::paint):
4486
(WebCore::ScrollbarThemeQStyle::hitTest):
4487
(WebCore::ScrollbarThemeQStyle::shouldCenterOnThumb):
4488
(WebCore::ScrollbarThemeQStyle::invalidatePart):
4489
(WebCore::ScrollbarThemeQStyle::scrollbarThickness):
4490
(WebCore::ScrollbarThemeQStyle::thumbPosition):
4491
(WebCore::ScrollbarThemeQStyle::thumbLength):
4492
(WebCore::ScrollbarThemeQStyle::trackPosition):
4493
(WebCore::ScrollbarThemeQStyle::trackLength):
4494
(WebCore::ScrollbarThemeQStyle::paintScrollCorner):
4495
(WebCore::ScrollbarThemeQStyle::style):
4496
* WebCoreSupport/ScrollbarThemeQStyle.h: Renamed from Source/WebCore/platform/qt/ScrollbarThemeQt.h.
4498
(ScrollbarThemeQStyle):
4500
2012-02-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
4502
[Qt] Move registration of experimental types to the proper plugin
4503
https://bugs.webkit.org/show_bug.cgi?id=79706
4505
Reviewed by Tor Arne Vestbø.
4507
* declarative/experimental/plugin.cpp:
4508
* declarative/plugin.cpp:
4509
(WebKitQmlPlugin::registerTypes):
4511
2012-02-28 Antti Koivisto <antti@apple.com>
4517
* Api/qwebelement.cpp:
4518
(QWebElement::styleProperty):
4520
2012-02-26 Hajime Morrita <morrita@chromium.org>
4522
Move ChromeClient::showContextMenu() to ContextMenuClient
4523
https://bugs.webkit.org/show_bug.cgi?id=79427
4525
Reviewed by Adam Barth.
4527
* WebCoreSupport/ChromeClientQt.h:
4530
2012-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
4532
[Qt] API: Unify the loading properties and signals.
4533
https://bugs.webkit.org/show_bug.cgi?id=79486
4535
Reviewed by Simon Hausmann.
4537
* declarative/plugin.cpp:
4538
(WebKitQmlPlugin::registerTypes):
4540
2012-02-24 Holger Hans Peter Freyther <holger@moiji-mobile.com>
4542
[Qt] Build fix. macro "QSKIP" now only takes 1 argument on Qt5
4543
https://bugs.webkit.org/show_bug.cgi?id=79328
4545
Reviewed by Csaba Osztrogonác.
4547
Introduce an alternative QSKIP that can work with both Qt4
4548
and Qt5 without adding #ifdef to each usage site.
4550
* tests/benchmarks/loading/tst_loading.cpp:
4551
(tst_Loading::load):
4552
* tests/benchmarks/painting/tst_painting.cpp:
4553
(tst_Painting::paint):
4554
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
4555
(tst_QDeclarativeWebView::elementAreaAt):
4556
* tests/qwebframe/tst_qwebframe.cpp:
4557
(tst_QWebFrame::setHtmlWithBaseURL):
4558
* tests/qwebpage/tst_qwebpage.cpp:
4559
(tst_QWebPage::geolocationRequestJS):
4560
(tst_QWebPage::loadHtml5Video):
4561
(tst_QWebPage::screenshot):
4562
* tests/qwebview/tst_qwebview.cpp:
4563
(tst_QWebView::reusePage):
4565
2012-02-24 Shinya Kawanaka <shinyak@chromium.org>
4567
SpellCheckRequest needs to know the context where the spellcheck happened.
4568
https://bugs.webkit.org/show_bug.cgi?id=79320
4570
Reviewed by Hajime Morita.
4572
* WebCoreSupport/TextCheckerClientQt.h:
4573
(WebCore::TextCheckerClientQt::requestCheckingOfString):
4575
2012-02-23 Simon Hausmann <simon.hausmann@nokia.com>
4577
[Qt] Add support for touch cancellation
4578
https://bugs.webkit.org/show_bug.cgi?id=79348
4580
Reviewed by Kenneth Rohde Christiansen.
4582
Forward incoming touch cancellation events to the WebCore
4585
* Api/qgraphicswebview.cpp:
4586
(QGraphicsWebView::sceneEvent):
4592
2012-02-22 Hajime Morrita <morrita@chromium.org>
4594
NOTIFICATIONS should be implemented as PageSupplement
4595
https://bugs.webkit.org/show_bug.cgi?id=79052
4597
Reviewed by Adam Barth.
4600
(QWebPagePrivate::QWebPagePrivate):
4602
2012-02-21 Ryosuke Niwa <rniwa@webkit.org>
4604
Remove the remaining uses of CSSStyleDeclaration in Editor
4605
https://bugs.webkit.org/show_bug.cgi?id=78939
4607
Reviewed by Enrica Casucci.
4609
* WebCoreSupport/EditorClientQt.cpp:
4610
(WebCore::EditorClientQt::shouldApplyStyle):
4611
* WebCoreSupport/EditorClientQt.h:
4614
2012-02-22 Mihnea Ovidenie <mihnea@adobe.com>
4616
[Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
4617
https://bugs.webkit.org/show_bug.cgi?id=78960
4619
Reviewed by Csaba Osztrogonác.
4621
* Api/qwebsettings.cpp:
4622
(QWebSettingsPrivate::apply):
4623
(QWebSettings::QWebSettings):
4624
* Api/qwebsettings.h:
4626
2012-02-22 Simon Hausmann <simon.hausmann@nokia.com>
4628
[Qt] Move QMenu dependant scrollbar context menu handling out of WebCore
4629
https://bugs.webkit.org/show_bug.cgi?id=79233
4631
Reviewed by Kenneth Rohde Christiansen.
4633
Move scrollbar context menu handling here, it's the only place where it is
4637
(handleScrollbarContextMenuEvent):
4638
(QWebPage::swallowContextMenuEvent):
4640
2012-02-22 Kenneth Rohde Christiansen <kenneth@webkit.org>
4642
Merge setVisibleRectTrajectoryVector and adjustVisibleRect to
4643
the more descriptive coverWithTilesIfNeeded
4644
https://bugs.webkit.org/show_bug.cgi?id=79230
4646
Reviewed by Simon Hausmann.
4648
* Api/qgraphicswebview.cpp:
4649
(QGraphicsWebView::paint):
4651
Use coverWithTilesIfNeeded().
4653
2012-02-22 Ryosuke Niwa <rniwa@webkit.org>
4655
Remove the remaining uses of CSSStyleDeclaration in Editor
4656
https://bugs.webkit.org/show_bug.cgi?id=78939
4658
Reviewed by Enrica Casucci.
4660
* WebCoreSupport/EditorClientQt.cpp:
4661
(WebCore::EditorClientQt::shouldApplyStyle):
4662
* WebCoreSupport/EditorClientQt.h:
4665
2012-02-21 Csaba Osztrogonác <ossy@webkit.org>
4667
[Qt] tst_QWebPage::infiniteLoopJS() timeouts with DFG JIT
4668
https://bugs.webkit.org/show_bug.cgi?id=79040
4670
Reviewed by Simon Hausmann.
4672
* tests/qwebpage/tst_qwebpage.cpp:
4673
(tst_QWebPage): Disable tst_QWebPage::infiniteLoopJS() until proper fix.
4675
2012-02-21 Andras Becsi <andras.becsi@nokia.com>
4677
[Qt] Print warning when importing experimental WK2 APIs in QML
4678
https://bugs.webkit.org/show_bug.cgi?id=78817
4680
Reviewed by Simon Hausmann.
4682
* declarative/experimental/plugin.cpp:
4684
2012-02-20 Benjamin Poulain <benjamin@webkit.org>
4686
Get rid of the LocalizationStrategy
4687
https://bugs.webkit.org/show_bug.cgi?id=78324
4689
Reviewed by Sam Weinig.
4691
Move the localization code from PlatformStrategiesQt.cpp
4692
to LocalizedStringsQt.cpp.
4694
Get rid of LocalizationStrategy from PlatformStrategiesQt
4696
* WebCoreSupport/PlatformStrategiesQt.cpp:
4697
* WebCoreSupport/PlatformStrategiesQt.h:
4698
(PlatformStrategiesQt):
4700
2012-02-16 Simon Hausmann <simon.hausmann@nokia.com>
4702
Unreviewed brown-paper bag build fix.
4704
* WebCoreSupport/WebEventConversion.cpp:
4705
(WebCore::WebKitPlatformWheelEvent::WebKitPlatformWheelEvent):
4707
2012-02-16 Simon Hausmann <simon.hausmann@nokia.com>
4709
[Qt] Move event conversion functions from WebCore to WebKit
4710
https://bugs.webkit.org/show_bug.cgi?id=78788
4712
Reviewed by Kenneth Rohde Christiansen.
4714
Move QtWidgets dependent mouse event constructors out of WebCore
4715
into WebKit, similar to the web event conversions of WebKit2.
4718
(QWebPagePrivate::mouseMoveEvent):
4719
(QWebPagePrivate::mousePressEvent):
4720
(QWebPagePrivate::mouseDoubleClickEvent):
4721
(QWebPagePrivate::mouseTripleClickEvent):
4722
(QWebPagePrivate::mouseReleaseEvent):
4723
(QWebPagePrivate::wheelEvent):
4724
(QWebPage::swallowContextMenuEvent):
4725
* WebCoreSupport/FrameLoaderClientQt.cpp:
4726
(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
4727
* WebCoreSupport/WebEventConversion.cpp: Added.
4729
(WebCore::mouseEventModifiersFromQtKeyboardModifiers):
4730
(WebCore::mouseEventTypeAndMouseButtonFromQEvent):
4731
(WebKitPlatformMouseEvent):
4732
(WebCore::WebKitPlatformMouseEvent::WebKitPlatformMouseEvent):
4733
(WebCore::convertMouseEvent):
4734
(WebKitPlatformWheelEvent):
4735
(WebCore::WebKitPlatformWheelEvent::applyDelta):
4736
(WebCore::WebKitPlatformWheelEvent::WebKitPlatformWheelEvent):
4737
(WebCore::convertWheelEvent):
4738
* WebCoreSupport/WebEventConversion.h: Added.
4741
2012-02-16 Adenilson Cavalcanti <cavalcantii@gmail.com>
4743
[Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin
4744
https://bugs.webkit.org/show_bug.cgi?id=73215
4746
Reviewed by Kenneth Rohde Christiansen.
4748
Adding a class to access security information data
4749
(e.g. port/scheme/etc),
4750
while allowing it to be handled in QML side.
4752
* declarative/plugin.cpp:
4753
(WebKitQmlPlugin::registerTypes):
4755
2012-02-15 Sadrul Habib Chowdhury <sadrul@chromium.org>
4757
Notify ChromeClient when touch-event handlers are installed/removed.
4758
https://bugs.webkit.org/show_bug.cgi?id=77440
4760
Reviewed by Darin Fisher and Ryosuke Niwa.
4762
* WebCoreSupport/ChromeClientQt.h:
4763
(WebCore::ChromeClientQt::numTouchEventHandlersChanged):
4765
2012-02-15 Simon Hausmann <simon.hausmann@nokia.com>
4767
Unreviewed Qt 4.x build fix.
4769
* WebCoreSupport/PageClientQt.cpp: Fix the QT_VERSION_CHECK pre-processor foo.
4771
2012-02-15 Simon Hausmann <simon.hausmann@nokia.com>
4773
[Qt] Replace use of QGLWidget/QGLContext with QOpenGLContext and QSurface for Qt 5
4774
https://bugs.webkit.org/show_bug.cgi?id=78694
4776
Reviewed by Noam Rosenthal.
4778
* WebCoreSupport/PageClientQt.cpp:
4779
(createPlatformGraphicsContext3DFromWidget): Return the QOpenGLContext and QSurface
4780
from the QGLWidget when compiling with Qt 5, as that's what WebCore expects.
4782
2012-02-15 Simon Hausmann <simon.hausmann@nokia.com>
4784
[Qt] Move Qt platform specific GL Context/Surface creation out of WebCore into WebKit
4785
https://bugs.webkit.org/show_bug.cgi?id=78692
4787
Reviewed by Noam Rosenthal.
4789
Implement GLWidget and GLContext creation from the page client interface.
4791
* WebCoreSupport/PageClientQt.cpp:
4792
(createPlatformGraphicsContext3DFromWidget):
4794
(WebCore::PageClientQWidget::createPlatformGraphicsContext3D):
4795
(WebCore::PageClientQGraphicsWidget::createPlatformGraphicsContext3D):
4796
* WebCoreSupport/PageClientQt.h:
4797
(PageClientQWidget):
4798
(PageClientQGraphicsWidget):
4800
2012-02-14 Simon Hausmann <simon.hausmann@nokia.com>
4802
[Qt] Eliminate first set of QtWidgets dependencies from WebCore
4803
https://bugs.webkit.org/show_bug.cgi?id=78611
4805
Reviewed by Kenneth Rohde Christiansen.
4807
* Api/qwebpage.cpp: Add missing includes.
4808
* WebCoreSupport/DumpRenderTreeSupportQt.cpp: Ditto.
4809
* WebCoreSupport/FrameLoaderClientQt.cpp: Make it compile by casting
4810
the QObject based PlatformWidget back to QWidget before doing QWidget
4811
specific function calls.
4812
* WebCoreSupport/InitWebCoreQt.cpp:
4813
(WebCore::initializeWebCoreQt): Moved QStyle specific web-graphic initialization
4815
* WebCoreSupport/PageClientQt.cpp:
4816
(WebCore::PageClientQWidget::setWidgetVisible): Implement show/hiding of widgets
4817
through delegation to QWidget.
4819
(WebCore::PageClientQGraphicsWidget::setWidgetVisible): Provide empty widget
4820
show/hide implementation, as it doesn't seem to make sense for graphicsviews.
4821
* WebCoreSupport/PageClientQt.h:
4822
(PageClientQWidget):
4823
(PageClientQGraphicsWidget):
4825
2012-02-15 Kenneth Rohde Christiansen <kenneth@webkit.org>
4827
[Qt] Be smarted with tile usages during tiling
4828
https://bugs.webkit.org/show_bug.cgi?id=78243
4830
Reviewed by Simon Hausmann.
4832
Remove internal API used by Symbian.
4835
(QWebPagePrivate::dynamicPropertyChangeEvent):
4837
2012-02-15 No'am Rosenthal <noam.rosenthal@nokia.com>
4839
[Texmap] Divide TextureMapperNode.cpp to 3 files.
4840
https://bugs.webkit.org/show_bug.cgi?id=76660
4842
Rename TextureMapperNode to TextureMapperLayer.
4844
Reviewed by Kenneth Rohde Christiansen.
4846
* Api/qwebframe.cpp:
4847
(QWebFramePrivate::renderCompositedLayers):
4850
* Api/qwebframe_p.h:
4852
(QWebFramePrivate::QWebFramePrivate):
4854
* WebCoreSupport/PageClientQt.cpp:
4855
(WebCore::TextureMapperLayerClientQt::TextureMapperLayerClientQt):
4856
(WebCore::TextureMapperLayerClientQt::setTextureMapper):
4857
(WebCore::TextureMapperLayerClientQt::~TextureMapperLayerClientQt):
4858
(WebCore::TextureMapperLayerClientQt::syncRootLayer):
4859
(WebCore::TextureMapperLayerClientQt::rootLayer):
4860
(WebCore::PageClientQWidget::setRootGraphicsLayer):
4861
(WebCore::PageClientQWidget::syncLayers):
4862
(WebCore::PageClientQGraphicsWidget::syncLayers):
4863
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
4864
* WebCoreSupport/PageClientQt.h:
4865
(TextureMapperLayerClientQt):
4866
(PageClientQWidget):
4867
(PageClientQGraphicsWidget):
4869
2012-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
4871
Convert svg/animations to use SMIL methods for driving the timeline
4872
https://bugs.webkit.org/show_bug.cgi?id=78422
4874
Reviewed by Dirk Schulze.
4876
Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
4877
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
4879
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
4880
* WebCoreSupport/DumpRenderTreeSupportQt.h:
4882
2012-02-13 Enrica Casucci <enrica@apple.com>
4884
Build fix. Unreviewed.
4886
* WebCoreSupport/PlatformStrategiesQt.cpp:
4887
(PlatformStrategiesQt::createPasteboardStrategy):
4889
2012-02-13 Enrica Casucci <enrica@apple.com>
4891
Refactor Mac platform implementation of the Pasteboard class to use Platform Strategies.
4892
https://bugs.webkit.org/show_bug.cgi?id=78282
4894
Build fix. Unreviewed.
4896
* WebCoreSupport/PlatformStrategiesQt.cpp:
4897
(WebPlatformStrategies::createPasteboardStrategy):
4898
* WebCoreSupport/PlatformStrategiesQt.h:
4899
(PlatformStrategiesQt):
4901
2012-02-12 Hajime Morrita <morrita@chromium.org>
4903
Page should have less intrusive way to associate API implementation objects.
4904
https://bugs.webkit.org/show_bug.cgi?id=78085
4906
Reviewed by Adam Barth.
4909
(QWebPagePrivate::QWebPagePrivate):
4910
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
4911
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
4913
2012-02-09 Simon Hausmann <simon.hausmann@nokia.com>
4915
[Qt] Fix compilation with newer Qt5
4916
https://bugs.webkit.org/show_bug.cgi?id=77653
4918
Reviewed by Tor Arne Vestbø.
4920
* Api/qgraphicswebview.cpp: Removed unnecessary inclusion of removed header file.
4921
* declarative/public.pri: Use quick1 instead of qtquick1. It's mandator with Qt 5.
4922
* tests/tests.pri: Ditto.
4923
* declarative/qdeclarativewebview_p.h: Fix includes, just use the module-less
4924
version that works with all Qt versions.
4925
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Ditto.
4927
2012-02-08 Leo Franchi <lfranchi@kde.org>
4929
Remote web inspector reentrancy fixes
4930
https://bugs.webkit.org/show_bug.cgi?id=77022
4932
Reviewed by Joseph Pecoraro.
4934
* WebCoreSupport/InspectorServerQt.cpp:
4935
(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
4936
(WebCore::InspectorServerRequestHandlerQt::webSocketReadyRead):
4938
2012-02-06 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
4940
Provide more attribute methods in Element
4941
https://bugs.webkit.org/show_bug.cgi?id=77800
4943
Reviewed by Ryosuke Niwa.
4945
* Api/qwebelement.cpp:
4946
(QWebElement::attributeNames): access attributes via Element interface.
4948
2012-02-03 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
4950
[Qt] Don't version QtWebKit.experimental.
4951
https://bugs.webkit.org/show_bug.cgi?id=77739
4953
Reviewed by Tor Arne Vestbø.
4955
We won't support previous versions of the experimental API.
4957
* declarative/experimental/plugin.cpp:
4959
2012-02-05 Gavin Barraclough <barraclough@apple.com>
4961
Remove JSObject defineGetter/defineSetter lookupGetter/lookupSetter
4962
https://bugs.webkit.org/show_bug.cgi?id=77451
4964
Reviewed by Sam Weinig.
4966
These can now all be implemented in terms of defineOwnProperty & getPropertyDescriptor.
4967
Also remove initializeGetterSetterProperty, since this is equivalent to putDirectAccessor.
4969
* Api/qwebframe.cpp:
4970
(QWebFramePrivate::addQtSenderToGlobalObject):
4972
2012-02-03 Antti Koivisto <antti@apple.com>
4974
Rename CSSMutableStyleDeclaration.h/.cpp to StylePropertySet.h/.cpp
4975
https://bugs.webkit.org/show_bug.cgi?id=77779
4977
Reviewed by Darin Adler.
4979
* Api/qwebelement.cpp:
4981
2012-02-03 Antti Koivisto <antti@apple.com>
4983
https://bugs.webkit.org/show_bug.cgi?id=77740
4984
Split CSSMutableStyleDeclaration into separate internal and CSSOM types
4986
Reviewed by Andreas Kling and Darin Adler.
4988
* Api/qwebelement.cpp:
4989
(QWebElement::styleProperty):
4991
2012-02-03 No'am Rosenthal <noam.rosenthal@nokia.com>
4993
[Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.
4994
https://bugs.webkit.org/show_bug.cgi?id=77148
4996
Reviewed by Martin Robinson.
4998
Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.
5000
* Api/qwebframe.cpp:
5001
(QWebFramePrivate::renderCompositedLayers):
5002
* WebCoreSupport/PageClientQt.cpp:
5003
(WebCore::PageClientQWidget::setRootGraphicsLayer):
5004
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
5006
2012-02-02 Sheriff Bot <webkit.review.bot@gmail.com>
5008
Unreviewed, rolling out r106620.
5009
http://trac.webkit.org/changeset/106620
5010
https://bugs.webkit.org/show_bug.cgi?id=77716
5012
It broke non ENABLE(3D_RENDERING) builds (Requested by
5013
Ossy_morning on #webkit).
5015
* Api/qwebframe.cpp:
5016
(QWebFramePrivate::renderCompositedLayers):
5017
* WebCoreSupport/PageClientQt.cpp:
5018
(WebCore::PageClientQWidget::setRootGraphicsLayer):
5019
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
5021
2012-02-02 No'am Rosenthal <noam.rosenthal@nokia.com>
5023
[Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.
5024
https://bugs.webkit.org/show_bug.cgi?id=77148
5026
Reviewed by Martin Robinson.
5028
Use TextureMapper::create instead of creating TextureMapperGL/TextureMapperQt directly.
5030
* Api/qwebframe.cpp:
5031
(QWebFramePrivate::renderCompositedLayers):
5032
* WebCoreSupport/PageClientQt.cpp:
5033
(WebCore::PageClientQWidget::setRootGraphicsLayer):
5034
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
5036
2012-02-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
5038
Avoid creating NamedNodeMap unnecessarily
5039
https://bugs.webkit.org/show_bug.cgi?id=77574
5041
Reviewed by Ryosuke Niwa.
5043
* Api/qwebelement.cpp:
5044
(QWebElement::attributeNames): use updateAttributes().
5046
2012-02-01 Alexis Menard <alexis.menard@openbossa.org>
5048
CSSStyleDeclaration.getPropertyPriority() fails for CSS shorthand properties with 'important' priority
5049
https://bugs.webkit.org/show_bug.cgi?id=49058
5051
Reviewed by Andreas Kling.
5053
Update the code as getPropertyPriority has been renamed to propertyIsImportant.
5055
* Api/qwebelement.cpp:
5056
(QWebElement::styleProperty):
5058
2012-01-31 Antti Koivisto <antti@apple.com>
5060
Try to fix Qt build.
5064
* Api/qwebelement.cpp:
5065
(QWebElement::styleProperty):
5067
2012-01-30 Antti Koivisto <antti@apple.com>
5069
Reduce non-CSSOM API of CSSStyleDeclaration
5070
https://bugs.webkit.org/show_bug.cgi?id=77299
5072
Reviewed by Andreas Kling.
5074
* Api/qwebelement.cpp:
5075
(QWebElement::styleProperty):
5076
(QWebElement::setStyleProperty):
5077
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
5078
(DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
5080
2012-01-25 Zeno Albisser <zeno@webkit.org>
5082
[Qt] public.pri is missing dependency to quick module.
5083
https://bugs.webkit.org/show_bug.cgi?id=77016
5085
Reviewed by Tor Arne Vestbø.
5087
* declarative/public.pri:
5089
2012-01-17 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
5091
[Qt] Debug build fails with debug qt5
5092
https://bugs.webkit.org/show_bug.cgi?id=76463
5094
Reviewed by Simon Hausmann.
5096
Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
5098
* WebCoreSupport/FrameNetworkingContextQt.cpp:
5100
2012-01-13 Marcelo Lira <marcelo.lira@openbossa.org>
5102
[Qt] Fix missing signal in qwebframe API test for Qt5
5103
https://bugs.webkit.org/show_bug.cgi?id=76195
5105
Reviewed by Noam Rosenthal.
5107
In Qt5 QObject has a new signal with this signature: "objectNameChanged(QString)".
5109
* tests/qwebframe/tst_qwebframe.cpp:
5110
(tst_QWebFrame::enumerate_data):
5112
2012-01-11 Vsevolod Vlasov <vsevik@chromium.org>
5114
Make default console messages line numbers consistent.
5115
https://bugs.webkit.org/show_bug.cgi?id=74075
5117
Reviewed by Pavel Feldman.
5119
Unset line numbers are not printed to console now.
5122
(QWebPage::javaScriptConsoleMessage):
5124
2012-01-11 Simon Hausmann <simon.hausmann@nokia.com>
5126
Unreviewed trivial build fix: Removed unnecessary QHttpRequestHeader
5127
inclusion (and the file is removed in newer Qt 5 versions).
5131
2012-01-11 Rafael Brandao <rafael.lobo@openbossa.org>
5133
[Qt][WK2] Fix the build for newer Qt5
5134
https://bugs.webkit.org/show_bug.cgi?id=75964
5136
Reviewed by Simon Hausmann.
5138
Added QHttpHeader, QHttpResponseHeader and QHttpRequestHeader
5139
that were removed from Qt. They are now kept under a private header
5140
and only the relevant code is present.
5142
* Api/qhttpheader.cpp: Added.
5143
(QHttpHeader::QHttpHeader):
5144
(QHttpHeader::~QHttpHeader):
5145
(QHttpHeader::parse):
5146
(QHttpHeader::value):
5147
(QHttpHeader::hasKey):
5148
(QHttpHeader::setValue):
5149
(QHttpHeader::addValue):
5150
(QHttpHeader::parseLine):
5151
(QHttpHeader::toString):
5152
(QHttpHeader::hasContentLength):
5153
(QHttpHeader::contentLength):
5154
(QHttpHeader::setContentLength):
5155
(QHttpHeader::hasContentType):
5156
(QHttpHeader::contentType):
5157
(QHttpHeader::setContentType):
5158
(QHttpResponseHeader::QHttpResponseHeader):
5159
(QHttpResponseHeader::parseLine):
5160
(QHttpResponseHeader::toString):
5161
(QHttpRequestHeader::QHttpRequestHeader):
5162
(QHttpRequestHeader::parseLine):
5163
(QHttpRequestHeader::toString):
5164
* Api/qhttpheader_p.h: Added.
5165
(QHttpHeader::isValid):
5166
(QHttpHeader::setValid):
5167
(QHttpResponseHeader::statusCode):
5168
(QHttpResponseHeader::reasonPhrase):
5169
(QHttpResponseHeader::majorVersion):
5170
(QHttpResponseHeader::minorVersion):
5171
(QHttpRequestHeader::method):
5172
(QHttpRequestHeader::path):
5173
(QHttpRequestHeader::majorVersion):
5174
(QHttpRequestHeader::minorVersion):
5175
* WebCoreSupport/InspectorServerQt.cpp:
5177
2012-01-10 No'am Rosenthal <noam.rosenthal@nokia.com>
5179
[Qt] Enable CSS_FILTERS in Qt build
5180
https://bugs.webkit.org/show_bug.cgi?id=75777
5182
For now, disallow compositing for filters. We will change that trigger when
5183
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.
5185
Reviewed by Kenneth Rohde Christiansen.
5187
* WebCoreSupport/ChromeClientQt.cpp:
5188
(WebCore::ChromeClientQt::allowedCompositingTriggers):
5190
2012-01-08 Sheriff Bot <webkit.review.bot@gmail.com>
5192
Unreviewed, rolling out r104421.
5193
http://trac.webkit.org/changeset/104421
5194
https://bugs.webkit.org/show_bug.cgi?id=75816
5196
Need to rebaseline some tests on Linux (Requested by noamr on
5199
* WebCoreSupport/ChromeClientQt.cpp:
5200
(WebCore::ChromeClientQt::allowedCompositingTriggers):
5202
2012-01-08 No'am Rosenthal <noam.rosenthal@nokia.com>
5204
[Qt] Enable CSS_FILTERS in Qt build
5205
https://bugs.webkit.org/show_bug.cgi?id=75777
5207
For now, disallow compositing for filters. We will change that trigger when
5208
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.
5210
Reviewed by Kenneth Rohde Christiansen.
5212
* WebCoreSupport/ChromeClientQt.cpp:
5213
(WebCore::ChromeClientQt::allowedCompositingTriggers):
5215
2012-01-08 Sheriff Bot <webkit.review.bot@gmail.com>
5217
Unreviewed, rolling out r104403.
5218
http://trac.webkit.org/changeset/104403
5219
https://bugs.webkit.org/show_bug.cgi?id=75803
5221
It broke all tests on Qt5 (Requested by Ossy_weekend on
5224
* WebCoreSupport/ChromeClientQt.cpp:
5225
(WebCore::ChromeClientQt::allowedCompositingTriggers):
5227
2012-01-08 No'am Rosenthal <noam.rosenthal@nokia.com>
5229
[Qt] Enable CSS_FILTERS in Qt build
5230
https://bugs.webkit.org/show_bug.cgi?id=75777
5232
For now, disallow compositing for filters. We will change that trigger when
5233
https://bugs.webkit.org/show_bug.cgi?id=75778 is implemented.
5235
Reviewed by Kenneth Rohde Christiansen.
5237
* WebCoreSupport/ChromeClientQt.cpp:
5238
(WebCore::ChromeClientQt::allowedCompositingTriggers):
5240
2012-01-05 Sheriff Bot <webkit.review.bot@gmail.com>
5242
Unreviewed, rolling out r104231.
5243
http://trac.webkit.org/changeset/104231
5244
https://bugs.webkit.org/show_bug.cgi?id=75668
5246
Breaks the Qt build (Requested by abarth on #webkit).
5249
(QWebPage::acceptNavigationRequest):
5251
2012-01-05 Adam Barth <abarth@webkit.org>
5253
Introduce Platform namespace for WebCore/platform
5254
https://bugs.webkit.org/show_bug.cgi?id=75653
5256
Reviewed by Eric Seidel.
5259
(QWebPage::acceptNavigationRequest):
5261
2012-01-05 Zeno Albisser <zeno@webkit.org>
5263
[Qt][WK2] Implement custom URL schemes defined in QML.
5264
https://bugs.webkit.org/show_bug.cgi?id=74931
5266
Make classes QQuickUrlSchemeDelegate, QQuickNetworkRequest
5267
and QQuickNetworkReply accessible from QML.
5269
Reviewed by Kenneth Rohde Christiansen.
5271
* declarative/experimental/experimental.pri:
5272
* declarative/experimental/plugin.cpp:
5273
* declarative/public.pri:
5275
2012-01-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
5277
[Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
5279
The custom qmake variable 'WEBKIT' is used for signaling that a
5280
target depends in some way on other subproject of the WebKit
5281
project. For now this is limited to the set of intermediate
5282
libraries: wtf, javascriptcore, webcore, and webkit2.
5284
This replaces the previous convension of using load(foo) for
5285
just include paths, and CONFIG += foo to also link against foo.
5287
Adding a dependency results in additional include paths being
5288
available, and potentially linking to the library. This is
5289
decided by the build system based on conditions such as what
5290
kind of target is being built and the general build config.
5292
An advantage to his approach is that it simplifies the individual
5293
foo.prf files, for example by allowing us to use INCLUDEPATH +=
5294
and LIBS += as normal instead of prepending.
5296
Reviewed by Simon Hausmann.
5298
* tests/qgraphicswebview/qgraphicswebview.pro:
5300
2012-01-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
5302
[Qt] Move use of $$qtLibraryTarget() to a single place
5304
Reviewed by Kenneth Rohde Christiansen.
5306
* declarative/experimental/experimental.pri:
5307
* declarative/public.pri:
5308
* examples/platformplugin/platformplugin.pro:
5310
2012-01-03 Jon Lee <jonlee@apple.com>
5312
Leak of WebNotificationClient when page is destroyed
5313
https://bugs.webkit.org/show_bug.cgi?id=74980
5314
<rdar://problem/10611231>
5316
Reviewed by Mark Rowe.
5318
* WebCoreSupport/NotificationPresenterClientQt.cpp:
5319
(WebCore::NotificationPresenterClientQt::notificationControllerDestroyed): Empty implementation, because
5320
ownership model differs.
5321
* WebCoreSupport/NotificationPresenterClientQt.h:
5323
2011-12-20 Adam Klein <adamk@chromium.org>
5325
Avoid unnecessary work when removing attributes from an element
5326
https://bugs.webkit.org/show_bug.cgi?id=74953
5328
Reviewed by Ryosuke Niwa.
5330
* Api/qwebelement.cpp:
5331
(QWebElement::removeAttribute): Updated a caller of
5332
WebCore::Element::removeAttribute to remove ExceptionCode argument.
5334
2011-12-20 Rafael Brandao <rafael.lobo@openbossa.org>
5336
[Qt] Extend QQuickWebview::navigationRequested API
5337
https://bugs.webkit.org/show_bug.cgi?id=73818
5339
Reviewed by Simon Hausmann.
5341
* declarative/experimental/plugin.cpp:
5343
2011-12-20 Jarred Nicholls <jarred@sencha.com>
5345
[Qt] HTTP header injection via QWebPage::userAgentForUrl()
5346
https://bugs.webkit.org/show_bug.cgi?id=68560
5348
Strip out newline characters from the result of userAgentForUrl() to prevent additional
5349
HTTP headers in HTTP requests.
5351
New QtTest case that validates the user agent, as returned by navigator.userAgent, does not
5352
contain any newline characters.
5354
Reviewed by Simon Hausmann.
5356
* WebCoreSupport/FrameLoaderClientQt.cpp:
5357
(WebCore::FrameLoaderClientQt::userAgent):
5358
* tests/qwebpage/tst_qwebpage.cpp:
5359
(CustomUserAgentWebPage::userAgentForUrl):
5360
(tst_QWebPage::userAgentNewlineStripping):
5362
2011-12-20 Rafael Brandao <rafael.lobo@openbossa.org>
5364
[Qt][WK2] Implement favicon support
5365
https://bugs.webkit.org/show_bug.cgi?id=71082
5367
Reviewed by Simon Hausmann.
5369
* declarative/plugin.cpp:
5370
(WebKitQmlPlugin::initializeEngine): Setup for the QDeclarativeImageProvider to display favicons.
5371
Its handles the following url format: "image://webicon/<iconID>#<pageURL>".
5373
2011-12-19 Sam Weinig <sam@webkit.org>
5375
More PlatformEvent cleanup
5376
https://bugs.webkit.org/show_bug.cgi?id=74831
5378
Reviewed by Dan Bernstein.
5381
(QWebPage::swallowContextMenuEvent):
5382
Update to use new names, access style.
5384
2011-12-19 Alexander Færøy <ahf@0x90.dk>
5386
[Qt] Cleanup QTM_NAMESPACE usage in DeviceOrientationProviderQt
5387
https://bugs.webkit.org/show_bug.cgi?id=74853
5389
Reviewed by Simon Hausmann.
5391
* Api/qwebframe_p.h:
5392
* WebCoreSupport/DeviceOrientationProviderQt.cpp:
5393
* WebCoreSupport/DeviceOrientationProviderQt.h:
5395
2011-12-19 Alexander Færøy <ahf@0x90.dk>
5397
[Qt] Cleanup DeviceMotionClientQt and friends.
5398
https://bugs.webkit.org/show_bug.cgi?id=74849
5400
This patch cleans up the DeviceMotionQt class and friends by applying
5401
the following changes:
5403
- Remove unnecessary pointer to QWebPage. This is needed to be able to
5404
reuse the code for WebKit2.
5405
- Remove QObject dependencies and all signals/slots. Instead, we call
5406
didChangeDeviceMotion() on the controller directly from
5407
DeviceMotionProviderQt.
5409
Reviewed by Simon Hausmann.
5412
(QWebPagePrivate::QWebPagePrivate):
5413
* WebCoreSupport/DeviceMotionClientQt.cpp:
5414
(WebCore::DeviceMotionClientQt::DeviceMotionClientQt):
5415
(WebCore::DeviceMotionClientQt::~DeviceMotionClientQt):
5416
(WebCore::DeviceMotionClientQt::setController):
5417
* WebCoreSupport/DeviceMotionClientQt.h:
5418
* WebCoreSupport/DeviceMotionProviderQt.cpp:
5419
(WebCore::DeviceMotionProviderQt::DeviceMotionProviderQt):
5420
(WebCore::DeviceMotionProviderQt::setController):
5421
(WebCore::DeviceMotionProviderQt::filter):
5422
* WebCoreSupport/DeviceMotionProviderQt.h:
5424
2011-12-18 Simon Hausmann <simon.hausmann@nokia.com>
5426
Rename EditCommandQt to UndoStepQt
5427
https://bugs.webkit.org/show_bug.cgi?id=74754
5429
Reviewed by Ryosuke Niwa.
5431
* WebCoreSupport/EditorClientQt.cpp:
5432
(WebCore::EditorClientQt::registerUndoStep):
5433
* WebCoreSupport/UndoStepQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/EditCommandQt.cpp.
5434
(UndoStepQt::UndoStepQt):
5435
(UndoStepQt::~UndoStepQt):
5438
* WebCoreSupport/UndoStepQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/EditCommandQt.h.
5440
2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
5442
Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
5443
https://bugs.webkit.org/show_bug.cgi?id=74748
5445
Reviewed by Eric Seidel.
5447
* WebCoreSupport/EditorClientQt.cpp:
5448
(WebCore::EditorClientQt::registerUndoStep):
5449
(WebCore::EditorClientQt::registerRedoStep):
5450
* WebCoreSupport/EditorClientQt.h:
5452
2011-12-16 Sam Weinig <sam@webkit.org>
5454
Give PlatformEvents a base class
5455
https://bugs.webkit.org/show_bug.cgi?id=74685
5457
Reviewed by Anders Carlsson.
5459
Add a base class for PlatformMouseEvent, PlatformKeyboardEvent, PlatformWheelEvent
5460
and PlatformGestureEvent and move Type enumeration and modifiers down to it.
5462
* WebCoreSupport/DragClientQt.cpp:
5463
(WebCore::DragClientQt::startDrag):
5464
* WebCoreSupport/EditorClientQt.cpp:
5465
(WebCore::EditorClientQt::handleKeyboardEvent):
5467
2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
5469
Only EditCommandComposition should implement unapply and reapply
5470
https://bugs.webkit.org/show_bug.cgi?id=74490
5472
Reviewed by Eric Seidel.
5474
EditCommandQt is to be renamed to UndoStepQt in a follow up patch.
5476
* WebCoreSupport/EditCommandQt.cpp:
5477
(EditCommandQt::EditCommandQt):
5478
* WebCoreSupport/EditCommandQt.h:
5479
* WebCoreSupport/EditorClientQt.cpp:
5480
(WebCore::EditorClientQt::registerCommandForUndo):
5481
(WebCore::EditorClientQt::registerCommandForRedo):
5483
2011-12-14 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
5485
[Qt] Get rid of layering violation in PluginViewQt
5487
PluginViewQt has a layering violation in relying on QWebPagePrivate for
5488
the check if running under DRT. We remove this and add a specific flag
5489
in the PluginView for this check, enabled from DRTSupport. This isn't
5490
pretty, but an improvement over what's currently there.
5492
Reviewed by Simon Hausmann.
5494
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
5495
(DumpRenderTreeSupportQt::setDumpRenderTreeModeEnabled):
5497
2011-12-15 Michael Brüning <michael.bruning@nokia.com>
5499
[QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
5500
https://bugs.webkit.org/show_bug.cgi?id=72893
5502
Reviewed by Kenneth Rohde Christiansen.
5504
This patch extends QQuickWebViewExperimental by a property named
5505
viewportInfo, which contains the viewport scalability and
5506
layout and contents size information. This property is exposed to
5507
QML through the experimental extension for QQuickWebView.
5509
* declarative/experimental/plugin.cpp:
5511
2011-12-15 Alexander Færøy <ahf@0x90.dk>
5513
[Qt] Remove unnecessary methods and members from DeviceOrientationClientQt
5514
https://bugs.webkit.org/show_bug.cgi?id=74588
5516
Reviewed by Simon Hausmann.
5518
Remove the unused method changeDeviceOrientation() from
5519
DeviceOrientationClientQt and remove the DeviceOrientationController
5520
member since it is unused.
5522
* WebCoreSupport/DeviceOrientationClientQt.cpp:
5523
(WebCore::DeviceOrientationClientQt::DeviceOrientationClientQt):
5524
(WebCore::DeviceOrientationClientQt::setController):
5525
* WebCoreSupport/DeviceOrientationClientQt.h:
5527
2011-12-14 Jing Zhao <jingzhao@chromium.org>
5529
Opening two popup menus by dispatchEvent() makes problems.
5530
https://bugs.webkit.org/show_bug.cgi?id=73304
5532
Reviewed by Kent Tamura.
5534
* WebCoreSupport/ChromeClientQt.cpp:
5535
(WebCore::ChromeClientQt::hasOpenedPopup): Not implemented.
5536
* WebCoreSupport/ChromeClientQt.h: Overrides hasOpenedPopup().
5538
2011-12-14 Hajime Morrita <morrita@chromium.org>
5540
JS_INLINE and WTF_INLINE should be visible from WebCore
5541
https://bugs.webkit.org/show_bug.cgi?id=73191
5543
Reviewed by Kevin Ollivier.
5545
Added a INCLUDEPATH to make JSExportMacros.h visible.
5547
* tests/MIMESniffing/MIMESniffing.pro
5549
2011-12-14 Alexander Færøy <ahf@0x90.dk>
5551
[Qt] DeviceOrientationClientQt should initialize m_controller to zero.
5552
https://bugs.webkit.org/show_bug.cgi?id=74522
5554
Reviewed by Kenneth Rohde Christiansen.
5556
* WebCoreSupport/DeviceOrientationProviderQt.cpp:
5557
(WebCore::DeviceOrientationProviderQt::DeviceOrientationProviderQt):
5559
2011-12-14 Alexander Færøy <alexander.faeroy@nokia.com>
5561
[Qt] Fix compilation of QtWebKit with --orientation-events without ENABLE_DEVICE_ORIENTATION
5562
https://bugs.webkit.org/show_bug.cgi?id=74492
5564
Reviewed by Simon Hausmann.
5566
* Api/qwebframe.cpp:
5567
(QWebFramePrivate::_q_orientationChanged):
5568
* Api/qwebframe_p.h:
5569
* WebCoreSupport/DeviceMotionProviderQt.cpp:
5570
* WebCoreSupport/DeviceMotionProviderQt.h:
5571
* WebCoreSupport/DeviceOrientationProviderQt.cpp:
5572
* WebCoreSupport/DeviceOrientationProviderQt.h:
5574
2011-12-14 Alexander Færøy <alexander.faeroy@nokia.com>
5576
Fix compilation for Qt with --minimal option after r102755.
5578
Reviewed by Csaba Osztrogonác.
5581
(QWebPagePrivate::QWebPagePrivate):
5583
2011-12-14 Alexander Færøy <alexander.faeroy@nokia.com>
5585
[Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
5586
https://bugs.webkit.org/show_bug.cgi?id=74417
5588
Reviewed by Simon Hausmann.
5590
Based on original patch by Kenneth Christiansen.
5592
Already covered by current tests.
5595
(QWebPagePrivate::QWebPagePrivate):
5596
* WebCoreSupport/DeviceMotionProviderQt.cpp:
5597
(WebCore::DeviceMotionProviderQt::DeviceMotionProviderQt):
5598
(WebCore::DeviceMotionProviderQt::filter):
5599
* WebCoreSupport/DeviceMotionProviderQt.h:
5600
* WebCoreSupport/DeviceOrientationClientMockQt.cpp: Removed.
5601
* WebCoreSupport/DeviceOrientationClientMockQt.h: Removed.
5602
* WebCoreSupport/DeviceOrientationClientQt.cpp:
5603
(WebCore::DeviceOrientationClientQt::DeviceOrientationClientQt):
5604
(WebCore::DeviceOrientationClientQt::~DeviceOrientationClientQt):
5605
(WebCore::DeviceOrientationClientQt::lastOrientation):
5606
* WebCoreSupport/DeviceOrientationClientQt.h:
5607
* WebCoreSupport/DeviceOrientationProviderQt.cpp:
5608
(WebCore::DeviceOrientationProviderQt::DeviceOrientationProviderQt):
5609
(WebCore::DeviceOrientationProviderQt::setController):
5610
(WebCore::DeviceOrientationProviderQt::start):
5611
(WebCore::DeviceOrientationProviderQt::stop):
5612
(WebCore::DeviceOrientationProviderQt::filter):
5613
* WebCoreSupport/DeviceOrientationProviderQt.h:
5614
(WebCore::DeviceOrientationProviderQt::isActive):
5615
(WebCore::DeviceOrientationProviderQt::lastOrientation):
5616
(WebCore::DeviceOrientationProviderQt::hasAlpha):
5617
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
5618
(toDeviceOrientationClientMock):
5619
(DumpRenderTreeSupportQt::setMockDeviceOrientation):
5620
* WebCoreSupport/DumpRenderTreeSupportQt.h:
5622
2011-12-12 Nándor Huszka <huszka.nandor@stud.u-szeged.hu>
5624
[Qt] Missing layoutTestController.dumpWillCacheResponse
5625
https://bugs.webkit.org/show_bug.cgi?id=74287
5627
Reviewed by Csaba Osztrogonác.
5629
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
5630
(DumpRenderTreeSupportQt::dumpWillCacheResponseCallbacks):
5631
* WebCoreSupport/DumpRenderTreeSupportQt.h:
5632
* WebCoreSupport/FrameLoaderClientQt.cpp:
5633
(WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
5634
* WebCoreSupport/FrameLoaderClientQt.h:
5636
2011-12-12 Alexis Menard <alexis.menard@openbossa.org>
5638
[Qt][WK2] History is not accessible in QML.
5639
https://bugs.webkit.org/show_bug.cgi?id=73016
5641
Reviewed by Simon Hausmann.
5643
Register QWebNavigationHistory and QWebNavigationListModel in the QML plugin.
5645
* declarative/experimental/plugin.cpp:
5646
(WebKitQmlPlugin::registerTypes):
5648
2011-12-09 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
5650
[Qt] request parameter of QQuickWebView::navigationRequested is not a registered type
5651
https://bugs.webkit.org/show_bug.cgi?id=73826
5653
Reviewed by Tor Arne Vestbø.
5655
* declarative/plugin.cpp:
5656
(WebKitQmlPlugin::registerTypes): Registering QWebNavigationRequest
5658
2011-12-08 Pierre Rossi <pierre.rossi@gmail.com>
5660
Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
5661
https://bugs.webkit.org/show_bug.cgi?id=73916
5663
Reviewed by Kent Tamura.
5665
* WebCoreSupport/PopupMenuQt.cpp:
5666
(SelectData::multiple):
5667
(WebCore::PopupMenuQt::selectItem):
5669
2011-12-07 Csaba Osztrogonác <ossy@webkit.org>
5671
[Qt] Unreviewed buildfix after r102262.
5673
* Api/qwebelement.cpp:
5674
(QWebElement::setStyleProperty):
5676
2011-12-07 Mary Wu <mary.wu@torchmobile.com.cn>
5678
Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline
5679
https://bugs.webkit.org/show_bug.cgi?id=73986
5681
Reviewed by Kenneth Rohde Christiansen.
5683
* WebCoreSupport/InitWebCoreQt.cpp:
5684
(WebCore::initializeWebCoreQt):
5686
2011-12-06 Zeno Albisser <zeno@webkit.org>
5688
[Qt][Mac] Building debug version only fails.
5689
https://bugs.webkit.org/show_bug.cgi?id=73895
5691
WebKit pro/pri files should not explicitly adjust
5692
the debug_and_release settings.
5694
Reviewed by Kenneth Rohde Christiansen.
5696
* declarative/experimental/experimental.pri:
5697
* declarative/public.pri:
5699
2011-12-02 Hajime Morrita <morrita@chromium.org>
5701
Unreviewed, rolling out r101751 and r101775.
5702
http://trac.webkit.org/changeset/101751
5703
http://trac.webkit.org/changeset/101775
5704
https://bugs.webkit.org/show_bug.cgi?id=73191
5706
breaks Windows build
5708
* tests/MIMESniffing/MIMESniffing.pro:
5710
2011-12-01 Hajime Morrita <morrita@chromium.org>
5712
JS_INLINE and WTF_INLINE should be visible from WebCore
5713
https://bugs.webkit.org/show_bug.cgi?id=73191
5715
Reviewed by Kevin Ollivier.
5717
Added a INCLUDEPATH to make JSExportMacros.h visible.
5719
* tests/MIMESniffing/MIMESniffing.pro
5721
2011-11-30 Alexey Proskuryakov <ap@apple.com>
5723
Remove an unneeded argument from FrameLoaderClient::download
5724
https://bugs.webkit.org/show_bug.cgi?id=73486
5726
Reviewed by Andreas Kling.
5728
* WebCoreSupport/FrameLoaderClientQt.cpp:
5729
(WebCore::FrameLoaderClientQt::download):
5730
* WebCoreSupport/FrameLoaderClientQt.h:
5731
Updated for the change.
5733
2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
5735
[Qt] Fix crash when using Qt DRT with V8.
5737
Reviewed by Csaba Osztrogonác.
5739
Add missing handle scopes for the handles returned by mainWorldContext.
5741
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
5742
(DumpRenderTreeSupportQt::injectInternalsObject):
5743
(DumpRenderTreeSupportQt::resetInternalsObject):
5745
2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
5747
[Qt] Fix crashing layout tests
5749
Reviewed by Kenneth Rohde Christiansen.
5751
Fix ASSERTION FAILED: m_key != PTHREAD_KEYS_MAX in ThreadIdentifierDataPthreads.cpp(65)
5752
static WTF::ThreadIdentifier WTF::ThreadIdentifierData::identifier()
5754
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
5755
(DumpRenderTreeSupportQt::initialize): Add missing WebCore::initializeWebCoreQt().
5757
2011-11-30 Andrew Wason <rectalogic@rectalogic.com>
5759
Replace Qt QThread threading back-end with pthread/Win32 threading back-ends
5760
https://bugs.webkit.org/show_bug.cgi?id=72155
5762
Reviewed by Simon Hausmann.
5764
Extract WebCore initialization out of QWebPagePrivate into a
5765
separate initialization function. This also needs to be called
5766
from public static QWebSettings methods that call into WebCore,
5767
since those can be used before a QWebPage has been constructed.
5770
(QWebPagePrivate::QWebPagePrivate):
5771
* Api/qwebsettings.cpp:
5772
(QWebSettings::globalSettings):
5773
(QWebSettings::setIconDatabasePath):
5774
(QWebSettings::iconDatabasePath):
5775
(QWebSettings::clearIconDatabase):
5776
(QWebSettings::iconForUrl):
5777
(QWebSettings::setWebGraphic):
5778
(QWebSettings::webGraphic):
5779
(QWebSettings::clearMemoryCaches):
5780
(QWebSettings::maximumPagesInCache):
5781
(QWebSettings::setObjectCacheCapacities):
5782
(QWebSettings::setOfflineStoragePath):
5783
(QWebSettings::offlineStoragePath):
5784
(QWebSettings::setOfflineWebApplicationCachePath):
5785
(QWebSettings::offlineWebApplicationCachePath):
5786
(QWebSettings::setOfflineWebApplicationCacheQuota):
5787
(QWebSettings::offlineWebApplicationCacheQuota):
5788
(QWebSettings::enablePersistentStorage):
5789
* WebCoreSupport/InitWebCoreQt.cpp: Added.
5790
(WebCore::initializeWebCoreQt):
5791
* WebCoreSupport/InitWebCoreQt.h: Added.
5793
2011-11-30 Adenilson Cavalcanti <adenilson.silva@openbossa.org>
5795
[Qt][WK2] Implement permission API for Qt port
5796
https://bugs.webkit.org/show_bug.cgi?id=59200
5798
Permission API hookup for Geolocation, it allows to receive in WebView
5799
a signal when a permission request is done (e.g. to grant permission
5800
for accessing geolocation information) and set it accordingly.
5802
Reviewed by Simon Hausmann.
5804
* declarative/plugin.cpp:
5805
(WebKitQmlPlugin::registerTypes):
5807
2011-11-29 Simon Hausmann <simon.hausmann@nokia.com>
5809
[Qt] Make WebKit/qt build with V8 and Qt 5
5810
https://bugs.webkit.org/show_bug.cgi?id=73315
5812
Reviewed by Kenneth Rohde Christiansen.
5814
* Api/qwebelement.cpp:
5815
(QtWebElementRuntime::initialize): #ifdef JSC code
5816
properly. There's no V8 equivalent just yet.
5817
* Api/qwebelement.h: Get rid of old V8 cruft.
5818
* Api/qwebframe.cpp:
5819
(QWebFrame::addToJavaScriptWindowObject): QScriptEngine -> QJSEngine.
5820
(QWebFrame::evaluateJavaScript): Ditto.
5821
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
5822
(QtDRTNodeRuntime::initialize): #ifdef JSC code.
5823
* WebCoreSupport/FrameLoaderClientQt.cpp:
5824
(WebCore::FrameLoaderClientQt::didCreateScriptContext): Adapt to FrameLoaderClient
5825
V8 API changes that happened long time ago.
5826
(WebCore::FrameLoaderClientQt::willReleaseScriptContext): Ditto.
5827
* WebCoreSupport/FrameLoaderClientQt.h: Ditto.
5828
* WebCoreSupport/InspectorClientQt.cpp: Add missing include for V8 build.
5830
2011-11-28 Jon Lee <jonlee@apple.com>
5832
Create skeleton framework for notifications support in WK2
5833
https://bugs.webkit.org/show_bug.cgi?id=73253
5834
<rdar://problem/10356943>
5836
Reviewed by Sam Weinig.
5838
* Api/qwebpage.cpp: Add notification client to pageClients.
5839
(QWebPagePrivate::QWebPagePrivate):
5840
* WebCoreSupport/ChromeClientQt.cpp: Remove notification client from ChromeClient implementation.
5841
* WebCoreSupport/ChromeClientQt.h:
5842
* WebCoreSupport/NotificationPresenterClientQt.cpp: Refactor with change of NotificationContents to struct
5843
(WebCore::NotificationWrapper::title):
5844
(WebCore::NotificationWrapper::message):
5845
(WebCore::NotificationPresenterClientQt::displayNotification):
5846
(WebCore::NotificationPresenterClientQt::cancel):
5847
(WebCore::NotificationPresenterClientQt::notificationClicked):
5848
(WebCore::NotificationPresenterClientQt::dumpReplacedIdText):
5849
(WebCore::NotificationPresenterClientQt::dumpShowText):
5851
2011-11-28 Simon Hausmann <simon.hausmann@nokia.com>
5853
[Qt] Build system fixes against V8.
5855
Reviewed by Tor Arne Vestbø.
5857
Add forwarding headers for building against Qt's v8 with
5860
* v8/ForwardingHeaders/v8-debug.h: Added.
5861
* v8/ForwardingHeaders/v8-preparser.h: Added.
5862
* v8/ForwardingHeaders/v8-profiler.h: Added.
5863
* v8/ForwardingHeaders/v8-testing.h: Added.
5864
* v8/ForwardingHeaders/v8.h: Added.
5865
* v8/ForwardingHeaders/v8stdint.h: Added.
5867
2011-11-26 Pavel Feldman <pfeldman@google.com>
5869
Web Inspector: remove disconnectFromBackend from the protocol.
5870
https://bugs.webkit.org/show_bug.cgi?id=73127
5872
Reviewed by Yury Semikhatsky.
5874
* WebCoreSupport/InspectorClientQt.cpp:
5875
(WebCore::InspectorClientQt::inspectorDestroyed):
5876
(WebCore::InspectorClientQt::closeInspectorFrontend):
5877
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):
5878
* WebCoreSupport/InspectorClientQt.h:
5880
2011-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
5882
Unreviewed, rolling out r101193.
5883
http://trac.webkit.org/changeset/101193
5884
https://bugs.webkit.org/show_bug.cgi?id=73158
5886
Breaks Windows and Qt minimal. (Requested by pfeldman on
5889
* WebCoreSupport/InspectorClientQt.cpp:
5890
(WebCore::InspectorClientQt::inspectorDestroyed):
5891
(WebCore::InspectorFrontendClientQt::disconnectFromBackend):
5892
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):
5893
* WebCoreSupport/InspectorClientQt.h:
5895
2011-11-26 Pavel Feldman <pfeldman@google.com>
5897
Web Inspector: remove disconnectFromBackend from the protocol.
5898
https://bugs.webkit.org/show_bug.cgi?id=73127
5900
Reviewed by Yury Semikhatsky.
5902
* WebCoreSupport/InspectorClientQt.cpp:
5903
(WebCore::InspectorClientQt::inspectorDestroyed):
5904
(WebCore::InspectorClientQt::closeInspectorFrontend):
5905
(WebCore::InspectorFrontendClientQt::inspectorClientDestroyed):
5906
* WebCoreSupport/InspectorClientQt.h:
5908
2011-11-25 Alexis Menard <alexis.menard@openbossa.org>
5910
[Qt][WK2] QWebDownloadItem should be registered in the experimental plugin.
5911
https://bugs.webkit.org/show_bug.cgi?id=73132
5913
Reviewed by Simon Hausmann.
5915
Make sure QWebDownloadItem is registered in the right plugin.
5917
* declarative/experimental/plugin.cpp:
5918
* declarative/plugin.cpp:
5919
(WebKitQmlPlugin::registerTypes):
5921
2011-11-22 Pavel Feldman <pfeldman@google.com>
5923
Web Inspector: remove Inspector::bringToFront from the protocol.
5924
https://bugs.webkit.org/show_bug.cgi?id=72937
5926
Reviewed by Yury Semikhatsky.
5928
* WebCoreSupport/InspectorClientQt.cpp:
5929
(WebCore::InspectorClientQt::bringFrontendToFront):
5930
* WebCoreSupport/InspectorClientQt.h:
5932
2011-10-17 Antonio Gomes <agomes@rim.com>
5934
Pass a Frame* parameter in EditorClient::respondToChangedSelection
5935
https://bugs.webkit.org/show_bug.cgi?id=70248
5937
Reviewed by Ryosuke Niwa.
5939
* WebCoreSupport/EditorClientQt.cpp: Make use of the newly added Frame* parameter.
5940
(WebCore::EditorClientQt::respondToChangedSelection):
5941
* WebCoreSupport/EditorClientQt.h:
5943
2011-11-18 Yuta Kitamura <yutak@chromium.org>
5945
[Qt] Enable WebSocket hybi tests
5946
https://bugs.webkit.org/show_bug.cgi?id=72687
5948
Reviewed by Simon Hausmann.
5950
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
5951
(DumpRenderTreeSupportQt::defaultHixie76WebSocketProtocolEnabled):
5952
(DumpRenderTreeSupportQt::setHixie76WebSocketProtocolEnabled):
5953
Call WebCore::Settings::setUseHixie76WebSocketProtocol() to switch WebSocket protocols.
5954
* WebCoreSupport/DumpRenderTreeSupportQt.h:
5956
2011-11-17 Simon Hausmann <simon.hausmann@nokia.com>
5958
[Qt] Layer violation: ThirdPartyCookiesQt.cpp uses QWebSettings in two places
5959
https://bugs.webkit.org/show_bug.cgi?id=72597
5961
Reviewed by Kenneth Rohde Christiansen.
5963
Implemented NetworkingContext::thirdPartyCookiePolicyPermission, which queries
5964
the global QWebSettings.
5966
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
5967
(DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows): Adapt to the
5968
changed thirdPartyCookiePolicyPermits WebCore API that operates on a networking context.
5969
* WebCoreSupport/DumpRenderTreeSupportQt.h:
5970
* WebCoreSupport/FrameLoaderClientQt.cpp:
5971
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction): Pass networking
5972
context to ResourceRequest::toNetworkRequest.
5973
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): Ditto.
5974
(WebCore::FrameLoaderClientQt::startDownload): Ditto.
5975
* WebCoreSupport/FrameNetworkingContextQt.cpp:
5976
(WebCore::FrameNetworkingContextQt::thirdPartyCookiePolicyPermission): Implement.
5977
* WebCoreSupport/FrameNetworkingContextQt.h:
5978
* tests/qwebpage/tst_qwebpage.cpp:
5979
(tst_QWebPage::thirdPartyCookiePolicy): Adapt to QtDRTSupport API change.
5981
2011-11-17 Simon Hausmann <simon.hausmann@nokia.com>
5983
[Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
5984
https://bugs.webkit.org/show_bug.cgi?id=72595
5986
Reviewed by Noam Rosenthal.
5988
Move QWebElement and QtDRTNode JS bindings from WebCore to WebKit/qt.
5990
* Api/qwebelement.cpp: Add QWebElement to JSValue and JSValue to QWebElement
5991
conversion through intermediate QVariant.
5992
(QtWebElementRuntime::create):
5993
(QtWebElementRuntime::get):
5994
(convertJSValueToWebElementVariant):
5995
(convertWebElementVariantToJSValue):
5996
(QtWebElementRuntime::initialize): Register conversion functions for QWebElement.
5997
* Api/qwebelement.h:
5998
* Api/qwebelement_p.h: Added.
6000
(QWebPagePrivate::QWebPagePrivate): Initialize QWebElement conversion functions for
6002
* WebCoreSupport/DumpRenderTreeSupportQt.cpp: Add QtDRTNode to JSValue and JSValue to
6003
QtDRTNode conversion through intermediate QVariant.
6004
(QtDRTNodeRuntime::create):
6005
(QtDRTNodeRuntime::get):
6006
(convertJSValueToNodeVariant):
6007
(convertNodeVariantToJSValue):
6008
(QtDRTNodeRuntime::initialize):
6009
(DumpRenderTreeSupportQt::initialize): Register conversion functions for QtDRTNode.
6010
* WebCoreSupport/DumpRenderTreeSupportQt.h:
6012
2011-11-17 Alexis Menard <alexis.menard@openbossa.org>
6014
[Qt] The experimental plugin doesn't work after being renamed.
6016
Reviewed by Tor Arne Vestbø.
6018
It was renamed from private to experimental but the qmldir file
6021
* declarative/experimental/qmldir:
6023
2011-11-17 Simon Hausmann <simon.hausmann@nokia.com>
6025
[Qt] Layer violation: WebCore::dnsPrefetch uses QWebSettings::globalSettings()
6026
https://bugs.webkit.org/show_bug.cgi?id=72596
6028
Reviewed by Kenneth Rohde Christiansen.
6030
* Api/qwebsettings.cpp:
6031
(QWebSettingsPrivate::apply): Propagate the DNS prefetch setting to WebCore::Settings.
6033
2011-11-17 Simon Hausmann <simon.hausmann@nokia.com>
6035
[Qt] Layer violation: Image::loadPlatformResource uses QWebSettings::webGraphic
6036
https://bugs.webkit.org/show_bug.cgi?id=72594
6038
Reviewed by Kenneth Rohde Christiansen.
6040
Move resource pixmap cache into ImageQt.cpp.
6042
* Api/qwebsettings.cpp:
6043
(resourceNameForWebGraphic): Helper function to translate between public API enums and
6045
(QWebSettings::setWebGraphic): Call the new ImageQt::setPlatformResource setter.
6046
(QWebSettings::webGraphic): Call Image::loadPlatformResource to read from the cache
6049
2011-11-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
6051
[Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
6053
A new extension object has been added to QQuickWebView (the same approach should be used
6054
for other API classes that need experimental APIs). The QML extension mechanism is then
6055
built on top of the experimental object.
6057
https://bugs.webkit.org/show_bug.cgi?id=72522
6059
Reviewed by Simon Hausmann.
6061
* declarative/declarative.pro:
6062
* declarative/experimental/experimental.pri: Renamed from Source/WebKit/qt/declarative/private/private.pro.
6063
* declarative/experimental/plugin.cpp: Renamed from Source/WebKit/qt/declarative/private/plugin.cpp.
6064
(QQuickWebViewExperimentalExtension::QQuickWebViewExperimentalExtension):
6065
(QQuickWebViewExperimentalExtension::experimental):
6066
* declarative/experimental/qmldir: Renamed from Source/WebKit/qt/declarative/private/qmldir.
6067
* declarative/plugin.cpp:
6068
* declarative/public.pri: Copied from Source/WebKit/qt/declarative/declarative.pro.
6070
2011-11-16 Sheriff Bot <webkit.review.bot@gmail.com>
6072
Unreviewed, rolling out r100448.
6073
http://trac.webkit.org/changeset/100448
6074
https://bugs.webkit.org/show_bug.cgi?id=72512
6076
It caused a regression breaking LayoutTests/http/tests/loading
6077
/text-content-type-with-binary-extension.html (Requested by
6080
* WebCoreSupport/FrameLoaderClientQt.cpp:
6081
(WebCore::FrameLoaderClientQt::canShowMIMEType):
6083
2011-11-16 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
6085
[Qt] FrameLoaderClientQt::canShowMIMEType should always return true
6086
https://bugs.webkit.org/show_bug.cgi?id=72169
6088
Reviewed by Simon Hausmann.
6090
Currently FrameLoaderClientQt::canShowMIMEType is called after
6091
dispatchDecidePolicyForResponse. If decidePolicyForResponse returns
6092
PolicyUse and canShowMIMEType returns false, then we have a bug.
6093
Therefore, FrameLoaderClientQt::canShowMIMEType now will always
6094
return true, following the implemenation of WebKit2.
6096
* WebCoreSupport/FrameLoaderClientQt.cpp:
6097
(WebCore::FrameLoaderClientQt::canShowMIMEType):
6099
2011-11-15 Huang Dongsung <luxtella@company100.net>
6101
[TexMap][Qt] Start PageClientQ[Graphics]Widget::syncTimer only when the syncTimer
6103
https://bugs.webkit.org/show_bug.cgi?id=70407
6105
Make sure we only activate the synchronization timer in
6106
PageClientQWidget/PageClientQGraphicsWidget if it's not already active,
6107
otherwise syncLayers may be called redundantly.
6109
Reviewed by Noam Rosenthal.
6111
* WebCoreSupport/PageClientQt.cpp:
6112
(WebCore::PageClientQWidget::markForSync):
6113
(WebCore::PageClientQWidget::syncLayers):
6114
(WebCore::PageClientQGraphicsWidget::syncLayers):
6115
(WebCore::PageClientQGraphicsWidget::markForSync):
6116
* WebCoreSupport/PageClientQt.h:
6117
(WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
6119
2011-11-15 Jochen Eisinger <jochen@chromium.org>
6121
Rename ReferrerPolicy to clarify its meaning
6122
https://bugs.webkit.org/show_bug.cgi?id=72420
6124
Reviewed by Nate Chapin.
6128
(QWebPage::triggerAction):
6130
2011-11-15 Anders Carlsson <andersca@apple.com>
6132
HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
6133
https://bugs.webkit.org/show_bug.cgi?id=72397
6135
Reviewed by Dan Bernstein.
6137
* WebCoreSupport/ChromeClientQt.cpp:
6138
(WebCore::ChromeClientQt::rootViewToScreen):
6139
(WebCore::ChromeClientQt::screenToRootView):
6140
* WebCoreSupport/ChromeClientQt.h:
6142
2011-11-14 Anders Carlsson <andersca@apple.com>
6144
HostWindow invalidation functions should use root view coordinates
6145
https://bugs.webkit.org/show_bug.cgi?id=72338
6147
Reviewed by Dan Bernstein.
6149
* WebCoreSupport/ChromeClientQt.cpp:
6150
(WebCore::ChromeClientQt::invalidateRootView):
6151
(WebCore::ChromeClientQt::invalidateContentsAndRootView):
6152
(WebCore::ChromeClientQt::invalidateContentsForSlowScroll):
6153
* WebCoreSupport/ChromeClientQt.h:
6155
2011-11-11 Pierre Rossi <pierre.rossi@gmail.com>
6157
[Qt] Remove the QStyle dependency in Qt's mobile theme
6158
https://bugs.webkit.org/show_bug.cgi?id=67773
6160
This refactoring splits up RenderThemeQt with two
6161
subclasses, a QStyle-backed one, and a Mobile version
6162
that uses the old mobile theme for now.
6164
QStyle availability is detected at compile time, and
6165
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
6166
environment variable.
6168
Reviewed by Simon Hausmann.
6171
(QWebPage::swallowContextMenuEvent):
6174
2011-11-11 Luiz Agostini <luiz.agostini@palm.com>
6176
[Qt] Removing unneeded #ifdef from PopupMenuQt.cpp
6177
https://bugs.webkit.org/show_bug.cgi?id=72193
6179
Reviewed by Noam Rosenthal.
6181
Part of PopupMenuQt.cpp code is guarded by #ifndef QT_NO_COMBOBOX although that
6182
code is not related to the class QComboBox.
6184
* WebCoreSupport/PopupMenuQt.cpp:
6185
(WebCore::PopupMenuQt::show):
6187
2011-11-11 Bruno de Oliveira Abinader <bruno.abinader@basyskom.com>
6189
[Qt] Skip tests when no network is present
6190
https://bugs.webkit.org/show_bug.cgi?id=72031
6192
Reviewed by Simon Hausmann.
6194
Some benchmark tests requires network connection (they fetch data from
6195
external URL's) and so they fail if no network is present. These tests
6196
should be skipped instead.
6198
* tests/benchmarks/loading/tst_loading.cpp:
6199
(tst_Loading::load): Skip test if no network is present.
6200
* tests/benchmarks/painting/tst_painting.cpp:
6201
(tst_Painting::paint): Skip test if no network is present.
6203
2011-11-11 Sheriff Bot <webkit.review.bot@gmail.com>
6205
Unreviewed, rolling out r99964.
6206
http://trac.webkit.org/changeset/99964
6207
https://bugs.webkit.org/show_bug.cgi?id=72124
6209
Broke too many Qt tests (Requested by tronical_ on #webkit).
6212
(QWebPage::swallowContextMenuEvent):
6215
2011-11-11 Pierre Rossi <pierre.rossi@gmail.com>
6217
[Qt] Remove the QStyle dependency in Qt's mobile theme
6218
https://bugs.webkit.org/show_bug.cgi?id=67773
6220
This refactoring splits up RenderThemeQt with two
6221
subclasses, a QStyle-backed one, and a Mobile version
6222
that uses the old mobile theme for now.
6224
QStyle availability is detected at compile time, and
6225
its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
6226
environment variable.
6228
Reviewed by Simon Hausmann.
6231
(QWebPage::swallowContextMenuEvent):
6234
2011-11-11 Alexis Menard <alexis.menard@openbossa.org>
6236
[Qt] Add a way to have experimental features in WebKit2
6237
https://bugs.webkit.org/show_bug.cgi?id=67707
6239
Reviewed by Kenneth Rohde Christiansen.
6241
This patch is adding a new module for accessing private
6242
method and property from the view. It requires an import
6243
QtWebKit.private in QML to be used.
6245
* declarative/private/plugin.cpp: Added.
6246
(WebKitQmlPluginPrivate::registerTypes):
6247
* declarative/private/private.pro: Added.
6248
* declarative/private/qmldir: Added.
6250
2011-11-11 Simon Hausmann <simon.hausmann@nokia.com>
6252
[Qt][WK2] Remove QWebNavigationController
6253
https://bugs.webkit.org/show_bug.cgi?id=72113
6255
Reviewed by Andreas Kling.
6257
* declarative/plugin.cpp:
6258
(WebKitQmlPlugin::registerTypes): Don't register QWebNavigationController with qml.
6260
2011-11-03 Luiz Agostini <luiz.agostini@palm.com>
6262
[Qt] Adding methods setGeometry and setFont to QWebSelectMethod class.
6263
https://bugs.webkit.org/show_bug.cgi?id=71530
6265
Reviewed by Simon Hausmann.
6267
Adding methods setGeometry and setFont so that users of platform plugin may show the
6268
popup menus in proper position and using proper font.
6270
* Api/qwebkitplatformplugin.h:
6271
* WebCoreSupport/PopupMenuQt.cpp:
6272
(WebCore::PopupMenuQt::show):
6273
* examples/platformplugin/WebPlugin.h:
6274
(WebPopup::setGeometry):
6275
(WebPopup::setFont):
6276
* examples/platformplugin/qwebkitplatformplugin.h:
6278
2011-11-10 Alexis Menard <alexis.menard@openbossa.org>
6280
[Qt] Merge QTouchWebView and QDesktopWebView into one class
6281
https://bugs.webkit.org/show_bug.cgi?id=71355
6283
Reviewed by Kenneth Rohde Christiansen.
6285
Register only QQuickWebView and QQuickWebPage in the plugin.
6287
* declarative/plugin.cpp:
6288
(WebKitQmlPlugin::registerTypes):
6290
2011-11-09 Simon Hausmann <simon.hausmann@nokia.com>
6292
[Qt] Enable exports and constructor functions in static libs
6294
Reviewed by Tor Arne Vestbø.
6297
(QWebPagePrivate::QWebPagePrivate): Remove unnecessary manual Qt resource
6300
2011-11-09 Simon Hausmann <simon.hausmann@nokia.com>
6302
Unreviewed, rolling out r99701.
6303
http://trac.webkit.org/changeset/99701
6309
(QWebPagePrivate::QWebPagePrivate):
6311
2011-11-09 Simon Hausmann <simon.hausmann@nokia.com>
6313
[Qt] Enable exports and constructor functions in static libs
6315
Reviewed by Tor Arne Vestbø.
6318
(QWebPagePrivate::QWebPagePrivate): Remove unnecessary manual Qt resource
6321
2011-11-09 Deepak Sherveghar <bpwv64@motorola.com>
6323
[Qt] 4 Layout test fail due to network error constant values clash with WebkitError enum values in FrameloaderclientQt
6324
https://bugs.webkit.org/show_bug.cgi?id=71554
6326
Reviewed by Simon Hausmann.
6328
We should check the error domain when checking the error code in shouldFallBack()
6330
* WebCoreSupport/FrameLoaderClientQt.cpp:
6331
(WebCore::FrameLoaderClientQt::shouldFallBack): added error domain check
6333
2011-11-08 Simon Hausmann <simon.hausmann@nokia.com>
6335
[Qt] Replace use of QApplication with QGuiApplication
6336
https://bugs.webkit.org/show_bug.cgi?id=71794
6338
Reviewed by Andreas Kling.
6340
* WebCoreSupport/QtWebComboBox.cpp:
6341
(WebCore::QtWebComboBox::showPopupAtCursorPosition): Replace use of QApplication
6342
with QCoreApplication.
6344
2011-11-07 Adam Barth <abarth@webkit.org>
6346
Move static "policy" state from SecurityOrigin.cpp to SecurityPolicy.cpp
6347
https://bugs.webkit.org/show_bug.cgi?id=71755
6349
Reviewed by Eric Seidel.
6352
(QWebPagePrivate::QWebPagePrivate):
6353
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
6354
(DumpRenderTreeSupportQt::whiteListAccessFromOrigin):
6355
(DumpRenderTreeSupportQt::removeWhiteListAccessFromOrigin):
6356
(DumpRenderTreeSupportQt::resetOriginAccessWhiteLists):
6358
2011-11-08 Luiz Agostini <luiz.agostini@palm.com>
6360
[Qt] Removing qwebkitglobal.h inclusion from qwebkitplatformplugin.h
6361
https://bugs.webkit.org/show_bug.cgi?id=71759
6363
Reviewed by Simon Hausmann.
6365
qwebkitplatformplugin.h must not depend on qwebkitglobal.h.
6367
* Api/qwebkitplatformplugin.h:
6369
Updating the copy of qwebkitplatformplugin.h that is used by the example plugin. The previous
6370
one was very outdated.
6372
* examples/platformplugin/qwebkitplatformplugin.h:
6374
2011-11-07 Adam Barth <abarth@webkit.org>
6376
Move DomainRelaxationForbidden scheme registry to SchemeRegistry
6377
https://bugs.webkit.org/show_bug.cgi?id=71750
6379
Reviewed by Eric Seidel.
6381
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
6382
(DumpRenderTreeSupportQt::setDomainRelaxationForbiddenForURLScheme):
6384
2011-11-07 Michael Saboff <msaboff@apple.com>
6386
Towards 8 Bit Strings: Templatize JSC::Lexer class by character type
6387
https://bugs.webkit.org/show_bug.cgi?id=71331
6389
Changed Identifier() constructor to use JSGlobalData*.
6391
Reviewed by Darin Adler.
6393
* Api/qwebframe.cpp:
6394
(QWebFrame::addToJavaScriptWindowObject):
6396
2011-11-07 Simon Hausmann <simon.hausmann@nokia.com>
6398
[Qt] Fix failing inspector tests after build system changes
6399
https://bugs.webkit.org/show_bug.cgi?id=71677
6401
Reviewed by Tor Arne Vestbø.
6403
Ensure symbols from the qt resource system are referenced
6404
from outside the static webcore library. One way of doing that is
6405
to initialize the resources right away, as explained in the documentation
6406
of th Qt resource system.
6410
(QWebPagePrivate::QWebPagePrivate):
6412
2011-11-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
6414
[Qt] Refactor and clean up the qmake build system
6416
The qmake build system has accumulated a bit of cruft and redundancy
6417
over time. There's also a fairly tight coupling between how to build
6418
the various targets, and _what_ to build, making it harder to add new
6419
rules or sources. This patch aims to elevate these issues somewhat.
6421
This is a short-list of the changes:
6423
* The rules for how to build targets are now mostly contained as
6424
prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
6425
allows us to do pre- and post-processing of each project file,
6426
which helps to clean up the actual project files.
6428
* Derived sources are no longer generated as a separate make-step
6429
but is part of each target's project file as a subdir. Makefile
6430
rules are used to ensure that we run make on the derived sources
6431
before running qmake on the actual target makefile. This makes
6432
it easier to keep a proper dependency between derived sources
6435
* We use GNU make and the compiler to generate dependencies on
6436
UNIX-based systems running Qt 5. This allows us to lessen the
6437
need to run qmake, which should reduce compile time.
6439
* WebKit2 is now build by default if building with Qt 5. It can
6440
be disabled by passing --no-webkit2 to build-webkit.
6442
The result of these changes are hopefully a cleaner and easier
6443
build system to modify, and faster build times due to no longer
6444
running qmake on every single build. It's also a first step
6445
towards possibly generating the list of sources using another
6448
https://bugs.webkit.org/show_bug.cgi?id=71222
6450
Reviewed by Simon Hausmann.
6452
* Api/DerivedSources.pro: Removed.
6453
* Api/headers.pri: Removed.
6455
(QWebPagePrivate::QWebPagePrivate):
6456
* QtWebKit.pro: Removed.
6457
* WebCoreSupport/FrameLoaderClientQt.h: Rename due to name clash with WK2 header
6458
* WebCoreSupport/PlatformStrategiesQt.cpp: Renamed from Source/WebKit/qt/WebCoreSupport/WebPlatformStrategies.cpp.
6459
(PlatformStrategiesQt::initialize):
6460
(PlatformStrategiesQt::PlatformStrategiesQt):
6461
(PlatformStrategiesQt::createCookiesStrategy):
6462
(PlatformStrategiesQt::createPluginStrategy):
6463
(PlatformStrategiesQt::createLocalizationStrategy):
6464
(PlatformStrategiesQt::createVisitedLinkStrategy):
6465
(PlatformStrategiesQt::notifyCookiesChanged):
6466
(PlatformStrategiesQt::refreshPlugins):
6467
(PlatformStrategiesQt::getPluginInfo):
6468
(PlatformStrategiesQt::inputElementAltText):
6469
(PlatformStrategiesQt::resetButtonDefaultLabel):
6470
(PlatformStrategiesQt::searchableIndexIntroduction):
6471
(PlatformStrategiesQt::submitButtonDefaultLabel):
6472
(PlatformStrategiesQt::fileButtonChooseFileLabel):
6473
(PlatformStrategiesQt::fileButtonChooseMultipleFilesLabel):
6474
(PlatformStrategiesQt::fileButtonNoFileSelectedLabel):
6475
(PlatformStrategiesQt::fileButtonNoFilesSelectedLabel):
6476
(PlatformStrategiesQt::defaultDetailsSummaryText):
6477
(PlatformStrategiesQt::contextMenuItemTagOpenLinkInNewWindow):
6478
(PlatformStrategiesQt::contextMenuItemTagDownloadLinkToDisk):
6479
(PlatformStrategiesQt::contextMenuItemTagCopyLinkToClipboard):
6480
(PlatformStrategiesQt::contextMenuItemTagOpenImageInNewWindow):
6481
(PlatformStrategiesQt::contextMenuItemTagDownloadImageToDisk):
6482
(PlatformStrategiesQt::contextMenuItemTagCopyImageToClipboard):
6483
(PlatformStrategiesQt::contextMenuItemTagCopyImageUrlToClipboard):
6484
(PlatformStrategiesQt::contextMenuItemTagOpenVideoInNewWindow):
6485
(PlatformStrategiesQt::contextMenuItemTagOpenAudioInNewWindow):
6486
(PlatformStrategiesQt::contextMenuItemTagCopyVideoLinkToClipboard):
6487
(PlatformStrategiesQt::contextMenuItemTagCopyAudioLinkToClipboard):
6488
(PlatformStrategiesQt::contextMenuItemTagToggleMediaControls):
6489
(PlatformStrategiesQt::contextMenuItemTagToggleMediaLoop):
6490
(PlatformStrategiesQt::contextMenuItemTagEnterVideoFullscreen):
6491
(PlatformStrategiesQt::contextMenuItemTagMediaPlay):
6492
(PlatformStrategiesQt::contextMenuItemTagMediaPause):
6493
(PlatformStrategiesQt::contextMenuItemTagMediaMute):
6494
(PlatformStrategiesQt::contextMenuItemTagOpenFrameInNewWindow):
6495
(PlatformStrategiesQt::contextMenuItemTagCopy):
6496
(PlatformStrategiesQt::contextMenuItemTagGoBack):
6497
(PlatformStrategiesQt::contextMenuItemTagGoForward):
6498
(PlatformStrategiesQt::contextMenuItemTagStop):
6499
(PlatformStrategiesQt::contextMenuItemTagReload):
6500
(PlatformStrategiesQt::contextMenuItemTagCut):
6501
(PlatformStrategiesQt::contextMenuItemTagPaste):
6502
(PlatformStrategiesQt::contextMenuItemTagSelectAll):
6503
(PlatformStrategiesQt::contextMenuItemTagNoGuessesFound):
6504
(PlatformStrategiesQt::contextMenuItemTagIgnoreSpelling):
6505
(PlatformStrategiesQt::contextMenuItemTagLearnSpelling):
6506
(PlatformStrategiesQt::contextMenuItemTagSearchWeb):
6507
(PlatformStrategiesQt::contextMenuItemTagLookUpInDictionary):
6508
(PlatformStrategiesQt::contextMenuItemTagOpenLink):
6509
(PlatformStrategiesQt::contextMenuItemTagIgnoreGrammar):
6510
(PlatformStrategiesQt::contextMenuItemTagSpellingMenu):
6511
(PlatformStrategiesQt::contextMenuItemTagShowSpellingPanel):
6512
(PlatformStrategiesQt::contextMenuItemTagCheckSpelling):
6513
(PlatformStrategiesQt::contextMenuItemTagCheckSpellingWhileTyping):
6514
(PlatformStrategiesQt::contextMenuItemTagCheckGrammarWithSpelling):
6515
(PlatformStrategiesQt::contextMenuItemTagFontMenu):
6516
(PlatformStrategiesQt::contextMenuItemTagBold):
6517
(PlatformStrategiesQt::contextMenuItemTagItalic):
6518
(PlatformStrategiesQt::contextMenuItemTagUnderline):
6519
(PlatformStrategiesQt::contextMenuItemTagOutline):
6520
(PlatformStrategiesQt::contextMenuItemTagWritingDirectionMenu):
6521
(PlatformStrategiesQt::contextMenuItemTagTextDirectionMenu):
6522
(PlatformStrategiesQt::contextMenuItemTagDefaultDirection):
6523
(PlatformStrategiesQt::contextMenuItemTagLeftToRight):
6524
(PlatformStrategiesQt::contextMenuItemTagRightToLeft):
6525
(PlatformStrategiesQt::contextMenuItemTagInspectElement):
6526
(PlatformStrategiesQt::searchMenuNoRecentSearchesText):
6527
(PlatformStrategiesQt::searchMenuRecentSearchesText):
6528
(PlatformStrategiesQt::searchMenuClearRecentSearchesText):
6529
(PlatformStrategiesQt::AXWebAreaText):
6530
(PlatformStrategiesQt::AXLinkText):
6531
(PlatformStrategiesQt::AXListMarkerText):
6532
(PlatformStrategiesQt::AXImageMapText):
6533
(PlatformStrategiesQt::AXHeadingText):
6534
(PlatformStrategiesQt::AXDefinitionListTermText):
6535
(PlatformStrategiesQt::AXDefinitionListDefinitionText):
6536
(PlatformStrategiesQt::AXButtonActionVerb):
6537
(PlatformStrategiesQt::AXRadioButtonActionVerb):
6538
(PlatformStrategiesQt::AXTextFieldActionVerb):
6539
(PlatformStrategiesQt::AXCheckedCheckBoxActionVerb):
6540
(PlatformStrategiesQt::AXUncheckedCheckBoxActionVerb):
6541
(PlatformStrategiesQt::AXMenuListActionVerb):
6542
(PlatformStrategiesQt::AXMenuListPopupActionVerb):
6543
(PlatformStrategiesQt::AXLinkActionVerb):
6544
(PlatformStrategiesQt::missingPluginText):
6545
(PlatformStrategiesQt::crashedPluginText):
6546
(PlatformStrategiesQt::multipleFileUploadText):
6547
(PlatformStrategiesQt::unknownFileSizeText):
6548
(PlatformStrategiesQt::imageTitle):
6549
(PlatformStrategiesQt::mediaElementLoadingStateText):
6550
(PlatformStrategiesQt::mediaElementLiveBroadcastStateText):
6551
(PlatformStrategiesQt::localizedMediaControlElementString):
6552
(PlatformStrategiesQt::localizedMediaControlElementHelpText):
6553
(PlatformStrategiesQt::localizedMediaTimeDescription):
6554
(PlatformStrategiesQt::validationMessageValueMissingText):
6555
(PlatformStrategiesQt::validationMessageTypeMismatchText):
6556
(PlatformStrategiesQt::validationMessagePatternMismatchText):
6557
(PlatformStrategiesQt::validationMessageTooLongText):
6558
(PlatformStrategiesQt::validationMessageRangeUnderflowText):
6559
(PlatformStrategiesQt::validationMessageRangeOverflowText):
6560
(PlatformStrategiesQt::validationMessageStepMismatchText):
6561
(PlatformStrategiesQt::isLinkVisited):
6562
(PlatformStrategiesQt::addVisitedLink):
6563
* WebCoreSupport/PlatformStrategiesQt.h: Renamed from Source/WebKit/qt/WebCoreSupport/WebPlatformStrategies.h.
6564
* declarative/declarative.pro:
6566
* docs/webkitsnippets/webelement/webelement.pro:
6567
* tests/MIMESniffing/MIMESniffing.pro:
6568
* tests/benchmarks/loading/loading.pro:
6569
* tests/benchmarks/painting/painting.pro:
6570
* tests/benchmarks/webgl/webgl.pro:
6571
* tests/hybridPixmap/hybridPixmap.pro:
6572
* tests/qdeclarativewebview/qdeclarativewebview.pro:
6573
* tests/qgraphicswebview/qgraphicswebview.pro:
6574
* tests/qwebelement/qwebelement.pro:
6575
* tests/qwebframe/qwebframe.pro:
6576
* tests/qwebhistory/qwebhistory.pro:
6577
* tests/qwebhistoryinterface/qwebhistoryinterface.pro:
6578
* tests/qwebinspector/qwebinspector.pro:
6579
* tests/qwebpage/qwebpage.pro:
6580
* tests/qwebplugindatabase/qwebplugindatabase.pro:
6581
* tests/qwebview/qwebview.pro:
6583
* tests/tests.pro: Removed.
6585
2011-11-03 Rafael Brandao <rafael.lobo@openbossa.org>
6587
Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
6588
https://bugs.webkit.org/show_bug.cgi?id=61042
6590
Reviewed by Simon Hausmann.
6592
At some points we didn't have any guarantee that a favicon has been loaded, so now
6593
it stops to wait for the IconChanged signal. It also had some file paths in wrong format,
6594
making some files to not be resolved and comparing meaningless bitmaps.
6596
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
6597
(tst_QDeclarativeWebView::initTestCase):
6598
(tst_QDeclarativeWebView::basicProperties):
6599
(tst_QDeclarativeWebView::historyNav):
6601
2011-11-03 Simon Hausmann <simon.hausmann@nokia.com>
6603
[Qt] Remove Maemo specific code paths
6604
https://bugs.webkit.org/show_bug.cgi?id=71476
6606
Reviewed by Kenneth Rohde Christiansen.
6609
(QWebPage::userAgentForUrl):
6611
(QWebView::QWebView):
6613
* WebCoreSupport/ChromeClientQt.cpp:
6614
(WebCore::ChromeClientQt::createSelectPopup):
6615
* WebCoreSupport/EditorClientQt.cpp:
6616
(WebCore::EditorClientQt::setInputMethodState):
6617
* WebCoreSupport/FrameLoaderClientQt.cpp:
6618
(WebCore::FrameLoaderClientQt::createPlugin):
6619
* WebCoreSupport/QtMaemoWebPopup.cpp: Removed.
6620
* WebCoreSupport/QtMaemoWebPopup.h: Removed.
6621
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
6622
(tst_QGraphicsWebView::focusInputTypes):
6623
* tests/qwebframe/tst_qwebframe.cpp:
6624
* tests/qwebview/tst_qwebview.cpp:
6625
(tst_QWebView::focusInputTypes):
6627
2011-11-03 Jesus Sanchez-Palencia <jesus@webkit.org>
6629
Reviewed by Kenneth Rohde Christiansen.
6631
[Qt] QtWebKit should have documentation clarifying its mobile features usage
6632
https://bugs.webkit.org/show_bug.cgi?id=41465
6634
Add "QtWebKit Goes Mobile" documentation
6636
* docs/qtwebkit-goes-mobile.qdoc: Added.
6637
* docs/qtwebkit.qdoc: Linked to qtwebkit-goes-mobile documentation
6638
* docs/webkitsnippets/qtwebkit_goes_mobile_snippets.cpp: Added.
6640
2011-11-03 Fady Samuel <fsamuel@chromium.org>
6642
Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
6643
https://bugs.webkit.org/show_bug.cgi?id=70609
6645
Reviewed by Kenneth Rohde Christiansen.
6648
(QWebPage::viewportAttributesForSize):
6649
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
6650
(DumpRenderTreeSupportQt::viewportAsText):
6652
2011-11-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
6654
[Qt][WK2] Download support and API in UIProcess
6655
https://bugs.webkit.org/show_bug.cgi?id=68962
6657
Reviewed by Simon Hausmann.
6659
Registering new qml type QWebDownloadItem.
6661
* declarative/plugin.cpp:
6662
(WebKitQmlPlugin::registerTypes):
6664
2011-11-02 Jon Lee <jonlee@apple.com>
6666
Expand DragController to provide more information about the dragging session
6667
https://bugs.webkit.org/show_bug.cgi?id=71324
6668
<rdar://problem/10379175>
6670
Reviewed by Darin Adler.
6673
(QWebPagePrivate::dragEnterEvent): Minor refactoring because operation is stored in
6674
new DragSession struct.
6675
(QWebPagePrivate::dragMoveEvent): Ditto.
6677
2011-11-02 Tom Sepez <tsepez@chromium.org>
6679
XSSAuditor is silent
6680
https://bugs.webkit.org/show_bug.cgi?id=70973
6682
Reviewed by Adam Barth.
6684
* WebCoreSupport/FrameLoaderClientQt.cpp:
6685
(WebCore::FrameLoaderClientQt::didDetectXSS):
6686
* WebCoreSupport/FrameLoaderClientQt.h:
6688
2011-11-02 Jon Lee <jonlee@apple.com>
6690
<input=file multiple> default text uses singular instead of plural
6691
https://bugs.webkit.org/show_bug.cgi?id=71319
6692
<rdar://problem/10379021>
6694
Reviewed by Darin Adler.
6696
* WebCoreSupport/WebPlatformStrategies.cpp:
6697
(WebPlatformStrategies::fileButtonNoFilesSelectedLabel):
6698
* WebCoreSupport/WebPlatformStrategies.h:
6700
2011-11-02 Deepak Sherveghar <bpwv64@motorola.com>
6702
[Qt] Failing test media/video-document-types.html
6703
https://bugs.webkit.org/show_bug.cgi?id=62108
6705
Reviewed by Simon Hausmann.
6707
Match what Mac has been doing since r36001: cancel the main load,
6708
and handle failures caused by 'will be handled by plugin' errors.
6710
* WebCoreSupport/FrameLoaderClientQt.cpp:
6711
(WebCore::FrameLoaderClientQt::committedLoad):
6712
(WebCore::FrameLoaderClientQt::shouldFallBack):
6714
2011-11-01 Simon Hausmann <simon.hausmann@nokia.com>
6716
[Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
6717
https://bugs.webkit.org/show_bug.cgi?id=71299
6719
Reviewed by Andreas Kling.
6721
Export an overload of QtDRT::injectInternalsObjects that is used by
6722
the WK2 injected bundle.
6724
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
6725
(DumpRenderTreeSupportQt::injectInternalsObject):
6726
* WebCoreSupport/DumpRenderTreeSupportQt.h:
6728
2011-11-01 Alexis Menard <alexis.menard@openbossa.org>
6730
Unreviewed Qt documentation fix.
6732
This signal is Qt 4.8 material.
6736
2011-10-31 Mark Hahnenberg <mhahnenberg@apple.com>
6738
De-virtualize JSObject::defineGetter
6739
https://bugs.webkit.org/show_bug.cgi?id=71134
6741
Reviewed by Darin Adler.
6743
Added defineGetter to the MethodTable. Replaced all virtual versions of defineGetter
6744
with static versions. Replaced all call sites with lookups in the MethodTable.
6746
* Api/qwebframe.cpp:
6747
(QWebFramePrivate::addQtSenderToGlobalObject):
6749
2011-10-28 Jochen Eisinger <jochen@chromium.org>
6751
Rename a number of methods mentioning JavaScript to just Script instead
6752
https://bugs.webkit.org/show_bug.cgi?id=71105
6754
Reviewed by Adam Barth.
6756
* Api/qwebsettings.cpp:
6757
(QWebSettingsPrivate::apply):
6759
2011-10-28 Simon Hausmann <simon.hausmann@nokia.com>
6761
[Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
6762
https://bugs.webkit.org/show_bug.cgi?id=70494
6764
Reviewed by Kenneth Christiansen.
6766
Use QQuick* instead of QSG* as well as QStandardPaths
6767
instead of QDesktopLocation.
6769
* Api/qwebsettings.cpp:
6770
(QWebSettings::enablePersistentStorage):
6772
2011-10-27 Helder Correia <helder.correia@palm.com>
6774
[Qt] Failure to build when QT_NO_MENU defined
6775
https://bugs.webkit.org/show_bug.cgi?id=70970
6777
Reviewed by Andreas Kling.
6779
iterateContextMenu() must be wrapped around #ifndef QT_NO_MENU.
6781
Build fix, no new tests.
6783
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
6785
2011-10-26 Zalan Bujtas <zbujtas@gmail.com>
6787
Name viewport change event consistently.
6788
https://bugs.webkit.org/show_bug.cgi?id=70901
6790
Reviewed by Kenneth Rohde Christiansen.
6792
Use ViewportPropertiesDidChange term consistently throughout WebKit.
6794
* WebCoreSupport/ChromeClientQt.cpp:
6795
(WebCore::ChromeClientQt::dispatchViewportPropertiesDidChange):
6796
* WebCoreSupport/ChromeClientQt.h:
6798
2011-10-25 Mark Hahnenberg <mhahnenberg@apple.com>
6801
https://bugs.webkit.org/show_bug.cgi?id=70740
6803
Reviewed by Geoffrey Garen.
6805
Removed all declarations and definitions of putVirtual.
6806
Also replaced all call sites to putVirtual with a
6807
corresponding lookup in the MethodTable.
6809
* Api/qwebframe.cpp:
6810
(QWebFrame::addToJavaScriptWindowObject):
6812
2011-10-24 Deepak Sherveghar <bpwv64@motorola.com>
6814
[Qt] fast/events/media-focus-in-standalone-media-document.html fails
6815
https://bugs.webkit.org/show_bug.cgi?id=70110
6817
Reviewed by Simon Hausmann.
6819
We should check for supported media mime types as well in the MIMETypeRegistry.
6821
* WebCoreSupport/FrameLoaderClientQt.cpp:
6822
(WebCore::FrameLoaderClientQt::canShowMIMEType): check for supported media mime type.
6824
2011-10-21 Luiz Agostini <luiz.agostini@palm.com>
6826
[Qt] Remote debugging needs QWebInspector to work
6827
https://bugs.webkit.org/show_bug.cgi?id=70651
6829
Reviewed by Kenneth Rohde Christiansen.
6831
Removing QWebInspector dependency from remote inspector.
6833
* Api/qwebinspector.cpp:
6834
* Api/qwebinspector_p.h:
6835
(QWebInspectorPrivate::QWebInspectorPrivate):
6836
* WebCoreSupport/InspectorClientQt.cpp:
6837
(WebCore::InspectorClientQt::InspectorClientQt):
6838
(WebCore::InspectorClientQt::openInspectorFrontend):
6839
(WebCore::InspectorClientQt::attachAndReplaceRemoteFrontend):
6840
(WebCore::InspectorClientQt::detachRemoteFrontend):
6841
(WebCore::InspectorClientQt::sendMessageToFrontend):
6842
* WebCoreSupport/InspectorClientQt.h:
6843
* WebCoreSupport/InspectorServerQt.cpp:
6844
(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
6845
* WebCoreSupport/InspectorServerQt.h:
6847
2011-10-21 Luiz Agostini <luiz.agostini@palm.com>
6849
[Qt] Wrong type conversion in InspectorServerQt.cpp
6850
https://bugs.webkit.org/show_bug.cgi?id=70639
6852
Reviewed by Noam Rosenthal.
6854
Wrong type conversion causes WebSocket handshake failures for the remote inspector.
6856
* WebCoreSupport/InspectorServerQt.cpp:
6857
(WebCore::parseWebSocketChallengeNumber):
6859
2011-10-21 Zeno Albisser <zeno.albisser@nokia.com>
6861
[Qt] WebKit build does not respect QMAKE_MAC_SDK variable.
6862
https://bugs.webkit.org/show_bug.cgi?id=70596
6864
Instead of only relying on DARWIN_MAJOR_VERSION we also
6865
check QMAKE_MAC_SDK. In case QMAKE_MAC_SDK is not defined
6866
we are still falling back to DARWIN_MAJOR_VERSION.
6868
Patch by Andy Shaw <andy.shaw@digia.com>
6870
Reviewed by Noam Rosenthal.
6874
2011-10-21 Csaba Osztrogonác <ossy@webkit.org>
6880
2011-10-21 Csaba Osztrogonác <ossy@webkit.org>
6882
[Qt][WK2] Buildfix for newer Qt5. Remove duplicated defines.
6884
Reviewed by Simon Hausmann.
6888
2011-10-21 Sheriff Bot <webkit.review.bot@gmail.com>
6890
Unreviewed, rolling out r98085.
6891
http://trac.webkit.org/changeset/98085
6892
https://bugs.webkit.org/show_bug.cgi?id=70589
6894
It broke the build (Requested by Ossy on #webkit).
6898
2011-10-21 Csaba Osztrogonác <ossy@webkit.org>
6900
[Qt][WK2] Unreviewed buildfix for newer Qt5. Remove duplicated defines.
6905
2011-10-20 Carol Szabo <carol@webkit.org>
6907
Tiled Backing Store does not regenerate tiles when it should
6908
https://bugs.webkit.org/show_bug.cgi?id=57798
6910
Reviewed by Darin Adler.
6912
Provided test for this bug. Changed the name of the resource I added
6913
for a previous test so that the name is descriptive such that it can
6914
be shared across several tests.
6916
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
6917
(tst_QGraphicsWebView::bug57798):
6918
(tst_QGraphicsWebView::bug56929):
6919
* tests/qgraphicswebview/tst_qgraphicswebview.qrc:
6921
2011-10-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
6923
[Qt] Merge QML plugin for WebKit2 with the original WebKit1 plugin
6925
We don't need a separate plugin, as we no longer expose the WK2
6926
APIs under QtWebKit.experimental, but now use QtWebKit. The version
6927
was also changed to 3.0 instead of 5.0, as the original plugin was
6928
versioned 1.0, and bumping to 3.0 fits the scheme used by QtWebKit releases.
6930
Reviewed by Andreas Kling.
6932
* declarative/declarative.pro:
6933
* declarative/plugin.cpp:
6934
(WebKitQmlPlugin::registerTypes):
6936
2011-10-15 Adam Barth <abarth@webkit.org>
6938
Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
6939
https://bugs.webkit.org/show_bug.cgi?id=70194
6941
Reviewed by Daniel Bates.
6943
* Api/qgraphicswebview.cpp:
6944
(QGraphicsWebViewPrivate::_q_scaleChanged):
6945
(QGraphicsWebView::QGraphicsWebView):
6946
(QGraphicsWebView::paint):
6947
(QGraphicsWebView::isTiledBackingStoreFrozen):
6948
(QGraphicsWebView::setTiledBackingStoreFrozen):
6949
* Api/qwebframe.cpp:
6950
* Api/qwebframe_p.h:
6952
(QWebPagePrivate::dynamicPropertyChangeEvent):
6953
* Api/qwebsettings.cpp:
6954
(QWebSettingsPrivate::apply):
6955
* WebCoreSupport/ChromeClientQt.cpp:
6956
(WebCore::ChromeClientQt::invalidateWindow):
6957
* WebCoreSupport/ChromeClientQt.h:
6958
* WebCoreSupport/PageClientQt.cpp:
6959
(WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):
6960
* WebCoreSupport/PageClientQt.h:
6961
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
6963
2011-10-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
6965
[Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
6966
https://bugs.webkit.org/show_bug.cgi?id=69920
6968
Reviewed by Kenneth Rohde Christiansen.
6970
* Api/qgraphicswebview.cpp:
6971
(QGraphicsWebView::setPage):
6973
(QWebPage::userAgentForUrl):
6975
(QWebView::QWebView):
6977
* WebCoreSupport/EditorClientQt.cpp:
6978
(WebCore::EditorClientQt::setInputMethodState):
6979
* WebCoreSupport/QtFallbackWebPopup.cpp:
6980
(WebCore::QtFallbackWebPopup::populate):
6981
* declarative/declarative.pro:
6982
* declarative/qdeclarativewebview.cpp:
6983
(QDeclarativeWebView::setPage):
6985
* symbian/backup_registration.xml: Removed.
6986
* symbian/bwins: Removed.
6987
* symbian/bwins/QtWebKitu.def: Removed.
6988
* symbian/eabi: Removed.
6989
* symbian/eabi/QtWebKitu.def: Removed.
6990
* symbian/platformplugin: Removed.
6991
* symbian/platformplugin/HTML5VideoPlugin.cpp: Removed.
6992
* symbian/platformplugin/HTML5VideoPlugin.h: Removed.
6993
* symbian/platformplugin/HTML5VideoWidget.cpp: Removed.
6994
* symbian/platformplugin/HTML5VideoWidget.h: Removed.
6995
* symbian/platformplugin/OverlayWidget.cpp: Removed.
6996
* symbian/platformplugin/OverlayWidget.h: Removed.
6997
* symbian/platformplugin/PlayerButton.cpp: Removed.
6998
* symbian/platformplugin/PlayerButton.h: Removed.
6999
* symbian/platformplugin/PlayerLabel.cpp: Removed.
7000
* symbian/platformplugin/PlayerLabel.h: Removed.
7001
* symbian/platformplugin/WebPlugin.cpp: Removed.
7002
* symbian/platformplugin/WebPlugin.h: Removed.
7003
* symbian/platformplugin/images: Removed.
7004
* symbian/platformplugin/images/button_cannotplay.png: Removed.
7005
* symbian/platformplugin/images/button_close.png: Removed.
7006
* symbian/platformplugin/images/button_pause.png: Removed.
7007
* symbian/platformplugin/images/button_play.png: Removed.
7008
* symbian/platformplugin/images/button_sound_off.png: Removed.
7009
* symbian/platformplugin/images/button_sound_on.png: Removed.
7010
* symbian/platformplugin/images/loading_buffering_1.png: Removed.
7011
* symbian/platformplugin/images/loading_buffering_2.png: Removed.
7012
* symbian/platformplugin/images/loading_buffering_3.png: Removed.
7013
* symbian/platformplugin/images/loading_buffering_4.png: Removed.
7014
* symbian/platformplugin/platformplugin.pro: Removed.
7015
* symbian/platformplugin/platformplugin.qrc: Removed.
7016
* symbian/platformplugin/qss: Removed.
7017
* symbian/platformplugin/qss/OverlayWidget.qss: Removed.
7018
* symbian/platformplugin/qwebkitplatformplugin.h: Removed.
7019
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
7020
(tst_QGraphicsWebView::focusInputTypes):
7021
* tests/qwebframe/qwebframe.pro:
7022
* tests/qwebframe/tst_qwebframe.cpp:
7023
* tests/qwebview/tst_qwebview.cpp:
7024
(tst_QWebView::focusInputTypes):
7027
2011-10-14 Mark Hahnenberg <mhahnenberg@apple.com>
7029
Rename virtual put to putVirtual
7030
https://bugs.webkit.org/show_bug.cgi?id=69851
7032
Reviewed by Darin Adler.
7034
Renamed virtual versions of put to putVirtual in prepration for
7035
adding the static put to the MethodTable in ClassInfo since the
7036
compiler gets mad if the virtual and static versions have the same
7039
* Api/qwebframe.cpp:
7040
(QWebFrame::addToJavaScriptWindowObject):
7042
2011-10-12 Ryosuke Niwa <rniwa@webkit.org>
7044
Make the interface of locationAndLengthFromRange and rangeFromLocationAndLength consistent
7045
https://bugs.webkit.org/show_bug.cgi?id=69964
7047
Reviewed by Enrica Casucci.
7049
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
7050
(DumpRenderTreeSupportQt::firstRectForCharacterRange):
7052
2011-10-13 Adenilson Cavalcanti <adenilson.silva@openbossa.org>
7054
[Qt] GeolocationClient cleanups
7055
https://bugs.webkit.org/show_bug.cgi?id=69737
7057
Reviewed by Kenneth Rohde Christiansen.
7059
Qt5 has a location module, so no need to use an external
7060
library like Qt Mobility. This patch will allow the GeolocationClientQt
7061
to compile with both Qt5 and Qt4.
7064
* WebCoreSupport/GeolocationClientQt.cpp:
7065
(WebCore::GeolocationClientQt::positionUpdated):
7066
* WebCoreSupport/GeolocationClientQt.h:
7068
2011-10-11 Simon Fraser <simon.fraser@apple.com>
7070
Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
7071
https://bugs.webkit.org/show_bug.cgi?id=68134
7073
Reviewed by Darin Adler.
7075
Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.
7077
Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
7078
that reads the setting, and returns the mock theme if set. All callers now use
7079
theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.
7081
* WebCoreSupport/ChromeClientQt.cpp:
7082
(WebCore::ChromeClientQt::windowResizerRect):
7084
2011-10-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
7086
[Qt] Remove all references to QTDIR_build and standalone_package
7088
Qt is now modularized, which means we no longer import WebKit into
7089
the Qt source tree. Instead we use git submodules, and building
7090
QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
7092
To decrease the number of buildsystem configurations we also remove
7093
the standalone_package code-path used when we were providing tarballs
7094
with the derived sources pre-generated.
7096
Reviewed by Simon Hausmann.
7098
* Api/DerivedSources.pro:
7100
* declarative/declarative.pro:
7101
* docs/webkitsnippets/webelement/webelement.pro:
7104
2011-10-07 Chang Shu <cshu@webkit.org>
7106
Remove compile time flag ENABLE_PASSWORD_ECHO
7107
https://bugs.webkit.org/show_bug.cgi?id=69647
7109
As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.
7111
Reviewed by Andreas Kling.
7113
* Api/qwebsettings.cpp:
7114
(QWebSettingsPrivate::apply):
7116
2011-10-06 Fady Samuel <fsamuel@chromium.org>
7118
Code clean-up: Make RenderObject::absoluteBoundingBoxRect and associated methods const and make its parameter useTransforms no longer default to false
7119
https://bugs.webkit.org/show_bug.cgi?id=69009
7121
Reviewed by Simon Fraser.
7123
* Api/qwebframe.cpp:
7124
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
7126
2011-10-06 Simon Hausmann <simon.hausmann@nokia.com>
7128
[Qt][Wk2] Fix build with Qt 5 when QtScript is built as standalone module
7129
https://bugs.webkit.org/show_bug.cgi?id=69520
7131
Reviewed by Csaba Osztrogonác.
7133
* QtWebKit.pro: Convenience, use qt5 scope.
7134
* declarative/declarative.pro: Ditto.
7135
* tests/tests.pri: Ditto.
7137
2011-10-03 Pierre Rossi <pierre.rossi@gmail.com>
7139
[Qt] Build fix: Qt::escape is deprecated in Qt5
7140
https://bugs.webkit.org/show_bug.cgi?id=69162
7142
Use QString::toHtmlEscaped in the Qt5 case.
7144
Reviewed by Andreas.
7147
(QWebPage::javaScriptAlert):
7148
(QWebPage::javaScriptConfirm):
7149
(QWebPage::javaScriptPrompt):
7150
* WebCoreSupport/ChromeClientQt.cpp:
7151
(WebCore::ChromeClientQt::setToolTip):
7153
2011-10-01 Sheriff Bot <webkit.review.bot@gmail.com>
7155
Unreviewed, rolling out r96421.
7156
http://trac.webkit.org/changeset/96421
7157
https://bugs.webkit.org/show_bug.cgi?id=69206
7159
It broke Qt-WK2 build (Requested by ossy on #webkit).
7162
(QWebPage::javaScriptAlert):
7163
(QWebPage::javaScriptConfirm):
7164
(QWebPage::javaScriptPrompt):
7165
* WebCoreSupport/ChromeClientQt.cpp:
7166
(WebCore::ChromeClientQt::setToolTip):
7168
2011-09-30 Pierre Rossi <pierre.rossi@gmail.com>
7170
[Qt] Build fix: Qt::escape is deprecated in Qt5
7171
https://bugs.webkit.org/show_bug.cgi?id=69162
7173
Use QString::toHtmlEscaped in the Qt5 case.
7175
Reviewed by Andreas Kling.
7178
(QWebPage::javaScriptAlert):
7179
(QWebPage::javaScriptConfirm):
7180
(QWebPage::javaScriptPrompt):
7181
* WebCoreSupport/ChromeClientQt.cpp:
7182
(WebCore::ChromeClientQt::setToolTip):
7184
2011-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
7186
[Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
7188
QWidget and friends now live in the QtWidgets library. We update
7189
includes in implementation files and private headers to us the
7190
non-module-prefixed path, and leave the lookup for the include
7191
path. For public headers we have to ifdef the includes as the
7192
user might now have the modules we need in his QT config.
7194
Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
7195
have to update our code and use windowHandle() for setting the
7196
parent relationships.
7198
https://bugs.webkit.org/show_bug.cgi?id=68687
7200
Reviewed by Andreas Kling.
7202
* Api/qgraphicswebview.cpp:
7203
* Api/qgraphicswebview.h:
7205
* Api/qwebhistory.h:
7207
* Api/qwebsettings.h:
7210
* WebCoreSupport/PageClientQt.h:
7211
* WebCoreSupport/QtWebComboBox.cpp:
7212
* WebCoreSupport/QtWebComboBox.h:
7213
* declarative/qdeclarativewebview.cpp:
7214
* declarative/qdeclarativewebview_p.h:
7215
* docs/webkitsnippets/webpage/main.cpp:
7216
* examples/platformplugin/WebNotificationPresenter.h:
7218
2011-09-27 Sheriff Bot <webkit.review.bot@gmail.com>
7220
Unreviewed, rolling out r96108, r96111, r96113, and r96116.
7221
http://trac.webkit.org/changeset/96108
7222
http://trac.webkit.org/changeset/96111
7223
http://trac.webkit.org/changeset/96113
7224
http://trac.webkit.org/changeset/96116
7225
https://bugs.webkit.org/show_bug.cgi?id=68913
7227
Wait for working Qt5 (Requested by ossy on #webkit).
7229
* Api/qgraphicswebview.cpp:
7230
* Api/qgraphicswebview.h:
7232
* Api/qwebhistory.h:
7234
* Api/qwebsettings.h:
7237
* WebCoreSupport/PageClientQt.h:
7238
* WebCoreSupport/QtWebComboBox.cpp:
7239
* WebCoreSupport/QtWebComboBox.h:
7240
* declarative/declarative.pro:
7241
* declarative/qdeclarativewebview.cpp:
7242
* declarative/qdeclarativewebview_p.h:
7243
* docs/webkitsnippets/webpage/main.cpp:
7244
* examples/platformplugin/WebNotificationPresenter.h:
7247
2011-09-27 Csaba Osztrogonác <ossy@webkit.org>
7249
[Qt][WK2] Buildfix after r96108.
7251
Rubber-stamped by Andreas Kling.
7255
2011-09-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
7257
[Qt] Fix build of declarative plugin against Qt5
7259
Reviewed by Andreas Kling.
7261
* declarative/declarative.pro:
7263
2011-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
7265
[Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
7267
QWidget and friends now live in the QtWidgets library. We update
7268
includes in implementation files and private headers to us the
7269
non-module-prefixed path, and leave the lookup for the include
7270
path. For public headers we have to ifdef the includes as the
7271
user might now have the modules we need in his QT config.
7273
Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
7274
have to update our code and use windowHandle() for setting the
7275
parent relationships.
7277
https://bugs.webkit.org/show_bug.cgi?id=68687
7279
Reviewed by Andreas Kling.
7281
* Api/qgraphicswebview.cpp:
7282
* Api/qgraphicswebview.h:
7284
* Api/qwebhistory.h:
7286
* Api/qwebsettings.h:
7289
* WebCoreSupport/PageClientQt.h:
7290
* WebCoreSupport/QtWebComboBox.cpp:
7291
* WebCoreSupport/QtWebComboBox.h:
7292
* declarative/qdeclarativewebview.cpp:
7293
* declarative/qdeclarativewebview_p.h:
7294
* docs/webkitsnippets/webpage/main.cpp:
7295
* examples/platformplugin/WebNotificationPresenter.h:
7297
2011-09-24 Adam Barth <abarth@webkit.org>
7299
Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
7300
https://bugs.webkit.org/show_bug.cgi?id=68767
7302
Reviewed by Eric Seidel.
7304
* Api/qwebsecurityorigin.cpp:
7305
(QWebSecurityOrigin::setApplicationCacheQuota):
7306
* Api/qwebsettings.cpp:
7307
(QWebSettings::setOfflineWebApplicationCachePath):
7308
(QWebSettings::offlineWebApplicationCachePath):
7309
(QWebSettings::setOfflineWebApplicationCacheQuota):
7310
(QWebSettings::offlineWebApplicationCacheQuota):
7311
* WebCoreSupport/ChromeClientQt.cpp:
7312
(WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
7313
* WebCoreSupport/ChromeClientQt.h:
7314
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
7315
(DumpRenderTreeSupportQt::clearAllApplicationCaches):
7317
2011-09-21 Andras Becsi <andras.becsi@nokia.com>
7319
[Qt] Remove Qt specific code from css/SelectorChecker.cpp
7320
https://bugs.webkit.org/show_bug.cgi?id=67702
7322
Reviewed by Csaba Osztrogonác.
7324
* WebCoreSupport/WebPlatformStrategies.cpp: Check the Qt global history here, instead of a platform independent file.
7325
(WebPlatformStrategies::isLinkVisited):
7326
* WebCoreSupport/WebPlatformStrategies.h:
7328
2011-09-20 Jarred Nicholls <jarred@sencha.com>
7330
[Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
7331
https://bugs.webkit.org/show_bug.cgi?id=51159
7333
Permit any URL with a local scheme to set a user style sheet. Allow qrc
7334
resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
7336
New test case makes sure a qrc URL will properly load a user stylesheet.
7338
Reviewed by Kenneth Rohde Christiansen.
7340
(tst_QWebPage::userStyleSheetFromQrcUrl):
7341
* tests/qwebpage/tst_qwebpage.qrc:
7343
2011-09-20 Adenilson Cavalcanti <adenilson.silva@openbossa.org>
7345
[Qt] resizeToContent seems to trigger infinite resize on some pages
7346
https://bugs.webkit.org/show_bug.cgi?id=43852
7348
Reviewed by Kenneth Rohde Christiansen.
7350
Test by Luiz Agostini.
7352
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
7353
(ResizeSpy::receiveResize):
7355
(tst_QGraphicsWebView::windowResizeEvent):
7357
2011-09-17 Mihai Parparita <mihaip@chromium.org>
7359
FrameLoaderClient BackForwardList-related methods are unsued
7360
https://bugs.webkit.org/show_bug.cgi?id=68293
7362
Reviewed by Darin Adler.
7364
Remove FrameLoaderClient methods that were added by r51629, since only
7365
the old (since-deleted) Android port needed them.
7367
* WebCoreSupport/FrameLoaderClientQt.cpp:
7368
* WebCoreSupport/FrameLoaderClientQt.h:
7370
2011-09-15 Adam Barth <abarth@webkit.org>
7372
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
7373
https://bugs.webkit.org/show_bug.cgi?id=68205
7375
Reviewed by Eric Seidel.
7377
* Api/qwebdatabase.cpp:
7378
(QWebDatabase::displayName):
7379
(QWebDatabase::expectedSize):
7380
(QWebDatabase::size):
7381
(QWebDatabase::fileName):
7382
(QWebDatabase::removeDatabase):
7383
(QWebDatabase::removeAllDatabases):
7384
* Api/qwebsecurityorigin.cpp:
7385
(QWebSecurityOrigin::databaseUsage):
7386
(QWebSecurityOrigin::databaseQuota):
7387
(QWebSecurityOrigin::setDatabaseQuota):
7388
(QWebSecurityOrigin::allOrigins):
7389
(QWebSecurityOrigin::databases):
7390
* Api/qwebsettings.cpp:
7391
(QWebSettingsPrivate::apply):
7392
(QWebSettings::setOfflineStoragePath):
7393
(QWebSettings::offlineStoragePath):
7394
* WebCoreSupport/ChromeClientQt.cpp:
7395
* WebCoreSupport/ChromeClientQt.h:
7397
2011-09-13 Zeno Albisser <zeno.albisser@nokia.com>
7399
[Qt] Fix state of stop/reload actions in QWebPage
7400
https://bugs.webkit.org/show_bug.cgi?id=65977
7402
FrameLoader does ask its DocumentLoader to stop loading subresources before
7403
setting the state to FrameStateCommittedPage. But it does
7404
not check if the the DocumentLoader actually stopped loading before
7405
it changes the state.
7406
Therefore a subresourceLoader can still be active, when we receive the
7407
call to dispatchDidFinishLoad(). This leads to an inconsistent behavior
7408
of the stop/reload actions in QWebPage.
7409
This changeset fixes the inconsistent state by updating the action states
7410
also when frameLoadCompleted() is called.
7412
Reviewed by Chang Shu.
7414
* WebCoreSupport/FrameLoaderClientQt.cpp:
7415
(WebCore::FrameLoaderClientQt::frameLoadCompleted):
7417
2011-09-12 Csaba Osztrogonác <ossy@webkit.org>
7419
[Qt] Fix "Unmatched parentheses are deprecated." warnings
7420
https://bugs.webkit.org/show_bug.cgi?id=67775
7422
Reviewed by Zoltan Herczeg.
7424
Modify function declarations to single line to make qmake happier.
7427
* Api/qwebpluginfactory.h:
7430
2011-09-10 Jarred Nicholls <jarred@sencha.com>
7432
[Qt] QWebSettings::setUserStyleSheetUrl() does not work with windows paths that contain drive letters
7433
https://bugs.webkit.org/show_bug.cgi?id=34884
7435
KURL::path() alone does not handle removing the leading slash from a windows file path.
7436
Using QUrl::toLocalFile() will turn file:///C:/path into C:/path appropriately.
7438
New test case that ensures a user stylesheet from the file system will load correctly
7441
Reviewed by Andreas Kling.
7443
* tests/qwebpage/resources/user.css: Added.
7445
* tests/qwebpage/tst_qwebpage.cpp:
7446
(tst_QWebPage::userStyleSheetFromFile):
7448
2011-09-09 Fady Samuel <fsamuel@chromium.org>
7450
Move pageScaleFactor code from Frame.{h|cpp} to Page.{h|cpp}
7451
https://bugs.webkit.org/show_bug.cgi?id=67250
7453
Reviewed by Simon Fraser.
7455
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
7456
(DumpRenderTreeSupportQt::scalePageBy):
7458
2011-09-09 Zeno Albisser <zeno.albisser@nokia.com>
7460
[Qt] QWebElement::encloseWith doesn't work at all
7461
https://bugs.webkit.org/show_bug.cgi?id=62464
7463
Enclosing an element means wrapping something around an element,
7464
not inserting something into an element. Therefore we need to check
7465
if the parent of the element allows insertion rather than checking
7468
Reviewed by Andreas Kling.
7470
* Api/qwebelement.cpp:
7471
(QWebElement::prependOutside):
7472
(QWebElement::appendOutside):
7473
(QWebElement::encloseWith):
7474
* tests/qwebelement/tst_qwebelement.cpp:
7475
(tst_QWebElement::appendAndPrepend):
7476
(tst_QWebElement::encloseWith):
7478
2011-09-08 Sam Weinig <sam@webkit.org>
7480
Remove the Completion object from JSC, I have never liked it
7481
https://bugs.webkit.org/show_bug.cgi?id=67755
7483
Reviewed by Gavin Barraclough.
7485
* Api/qwebelement.cpp:
7486
(QWebElement::evaluateJavaScript):
7488
2011-09-05 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
7490
[Qt][WK2] Make TiledDrawingArea request tiles only in the direction the viewport is panned to.
7491
https://bugs.webkit.org/show_bug.cgi?id=67606
7493
TiledBackingStore previously used different values for horizontal and vertial multiplication
7494
to calculate the cover area.
7495
This patch replaces this mechanism, used to give a bigger panning range to vertical panning,
7496
with the possibility to use the motion vector of the viewport to request tiles ahead instead.
7497
This allows economies on rendering resources as tiles won't be rendered beside the trajectory
7501
(QWebPagePrivate::dynamicPropertyChangeEvent):
7503
2011-09-06 Csaba Osztrogonác <ossy@webkit.org>
7505
Unreviewed buildfix after r94620.
7507
* WebCoreSupport/FrameLoaderClientQt.cpp:
7508
(WebCore::FrameLoaderClientQt::createFrame):
7510
2011-09-06 Alexis Menard <alexis.menard@openbossa.org>
7512
[Qt] Move away from QPointer as it is slow and it has a replacement QWeakPointer.
7513
https://bugs.webkit.org/show_bug.cgi?id=67673
7515
Reviewed by Ariya Hidayat.
7517
Move away from QPointer as Qt provides a better and faster solution : QWeakPointer.
7519
* Api/qwebframe.cpp:
7520
(QWebHitTestResult::linkTargetFrame):
7521
(QWebHitTestResult::frame):
7522
* Api/qwebframe_p.h:
7524
(QWebPagePrivate::QWebPagePrivate):
7525
(QWebPagePrivate::~QWebPagePrivate):
7526
(QWebPagePrivate::acceptNavigationRequest):
7527
(QWebPagePrivate::createMainFrame):
7528
(QWebPagePrivate::updateAction):
7529
(QWebPagePrivate::mouseMoveEvent):
7530
(QWebPagePrivate::mousePressEvent):
7531
(QWebPagePrivate::mouseDoubleClickEvent):
7532
(QWebPagePrivate::mouseTripleClickEvent):
7533
(QWebPagePrivate::mouseReleaseEvent):
7534
(QWebPage::createStandardContextMenu):
7535
(QWebPagePrivate::wheelEvent):
7536
(QWebPagePrivate::focusInEvent):
7537
(QWebPage::setPalette):
7538
(QWebPagePrivate::touchEvent):
7539
(QWebPage::~QWebPage):
7540
(QWebPage::mainFrame):
7541
(QWebPage::viewportSize):
7542
(QWebPage::preferredContentsSize):
7543
(QWebPage::setContentEditable):
7544
(QWebPage::updatePositionDependentActions):
7547
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
7548
(DumpRenderTreeSupportQt::contextMenu):
7549
* WebCoreSupport/FrameLoaderClientQt.cpp:
7550
(WebCore::FrameLoaderClientQt::createFrame):
7551
* tests/qwebframe/tst_qwebframe.cpp:
7552
(tst_QWebFrame::ownership):
7553
* tests/qwebpage/tst_qwebpage.cpp:
7554
(PluginCounterPage::PluginCounterPage):
7555
(PluginTracerPage::createPlugin):
7556
(tst_QWebPage::createViewlessPlugin):
7557
* tests/qwebview/tst_qwebview.cpp:
7558
(tst_QWebView::reusePage):
7560
2011-09-06 Alexis Menard <alexis.menard@openbossa.org>
7562
[Qt] Fix API test failure after r92823 and r93001.
7563
https://bugs.webkit.org/show_bug.cgi?id=67676
7565
Reviewed by Kenneth Rohde Christiansen.
7567
r92823 and r93001 make WebKit no longer produce wrapping style
7568
spans on copy and paste and class="Apple-style-span" anymore.
7569
Our expectations need to be updated.
7571
* tests/qwebpage/tst_qwebpage.cpp:
7572
(tst_QWebPage::cursorMovements):
7573
(tst_QWebPage::textSelection):
7574
(tst_QWebPage::findText):
7576
2011-09-06 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
7578
[Qt][Symbian] REGRESSION[94105] DumpRenderTree.exe doesn't build on Symbian
7579
https://bugs.webkit.org/show_bug.cgi?id=67644
7581
Reviewed by Csaba Osztrogonác.
7583
* symbian/eabi/QtWebKitu.def: add missing entry for
7584
FrameLoaderClientQt::dumpProgressFinishedCallback(bool)
7586
2011-09-05 Kaustubh Atrawalkar <kaustubh@motorola.com>
7588
Logic from HTMLElement::deprecatedCreateContextualFragment moved into
7589
Range::createContextualFragment function.
7590
https://bugs.webkit.org/show_bug.cgi?id=67056
7592
Reviewed by Ryosuke Niwa.
7594
Code Refactoring for deprecatedCreateContextualFragment.
7596
* Api/qwebelement.cpp:
7597
(QWebElement::appendInside):
7598
(QWebElement::prependInside):
7599
(QWebElement::prependOutside):
7600
(QWebElement::appendOutside):
7601
(QWebElement::encloseContentsWith):
7602
(QWebElement::encloseWith):
7604
2011-09-03 Laszlo Gombos <laszlo.1.gombos@nokia.com>
7606
REGRESSION (r86268): Fix for qt_networkAccessAllowed()
7607
https://bugs.webkit.org/show_bug.cgi?id=67570
7609
Reviewed by Noam Rosenthal.
7611
Replace the ENABLE(QT_BEARER) guard with
7612
!defined(QT_NO_BEARERMANAGEMENT) which is true by
7613
default in Qt 4.7 or later versions.
7615
* Api/qwebsettings.cpp:
7616
(qt_networkAccessAllowed):
7618
2011-09-02 Jade Han <jade.han@nokia.com>
7620
[Qt][Symbian] REGRESSION(93235) Missing .def update
7621
https://bugs.webkit.org/show_bug.cgi?id=67307
7623
Reviewed by Laszlo Gombos.
7625
* symbian/eabi/QtWebKitu.def:
7627
2011-09-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
7629
[Qt] Transform QtFallbackWebPopupCombo into QtWebComboBox
7630
https://bugs.webkit.org/show_bug.cgi?id=67344
7632
Reviewed by Andreas Kling.
7634
Renamed QtFallbackWebPopup to QtWebComboBox and decoupled it from
7635
QtFallbackWebPopup. The new class is a QComboBox with the features that
7636
we need for QtWebKit: tracking when the popup is hidden (via the didHide()
7637
signal) and a convenience method to show its popup in the cursor position.
7639
An important change was made to the combobox: instead of hooking our actions in
7640
showPopup() and hidePopup(), as well as watching for popup visibility events, we
7641
now just watch for the visibility events. This allowed us to get rid of
7642
m_popupVisible and tracking the Show event.
7644
This commit also removed a workaround for input focus added in r40970 after
7645
reviewers request. See bug report for details.
7648
* WebCoreSupport/QtFallbackWebPopup.cpp:
7649
(WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
7650
(WebCore::QtFallbackWebPopup::~QtFallbackWebPopup):
7651
(WebCore::QtFallbackWebPopup::show):
7652
(WebCore::QtFallbackWebPopup::deleteComboBox):
7653
* WebCoreSupport/QtFallbackWebPopup.h:
7654
* WebCoreSupport/QtWebComboBox.cpp: Added.
7655
(WebCore::QtWebComboBox::QtWebComboBox):
7656
(WebCore::QtWebComboBox::showPopupAtCursorPosition):
7657
(WebCore::QtWebComboBox::eventFilter):
7658
* WebCoreSupport/QtWebComboBox.h: Added.
7660
* tests/qwebframe/tst_qwebframe.cpp:
7661
(tst_QWebFrame::popupFocus):
7662
Change the test to use QObject::findChild(). The old method couldn't find our
7663
new class because we defined a new metaclass for it.
7665
2011-08-31 Ryosuke Niwa <rniwa@webkit.org>
7667
Move text() and textWithHardLineBreaks() from RenderTextControl to HTMLTextFormControlElement
7668
https://bugs.webkit.org/show_bug.cgi?id=67320
7670
Reviewed by Darin Adler.
7672
Call HTMLTextFormControlElement::value() instead of RenderText::text()
7675
(QWebPage::inputMethodQuery):
7677
2011-08-31 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
7679
[Qt] Unskip API test for load signals order
7680
https://bugs.webkit.org/show_bug.cgi?id=67285
7682
Reviewed by Andreas Kling.
7684
* tests/qwebpage/tst_qwebpage.cpp:
7685
(tst_QWebPage::loadSignalsOrder):
7687
2011-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
7689
Unreviewed, rolling out r94142, r94144, r94145, and r94148.
7690
http://trac.webkit.org/changeset/94142
7691
http://trac.webkit.org/changeset/94144
7692
http://trac.webkit.org/changeset/94145
7693
http://trac.webkit.org/changeset/94148
7694
https://bugs.webkit.org/show_bug.cgi?id=67262
7696
Broke isindex element (Requested by rniwa on #webkit).
7698
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
7699
(DumpRenderTreeSupportQt::setAutofilled):
7700
(DumpRenderTreeSupportQt::setValueForUser):
7701
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
7703
2011-08-30 Ryosuke Niwa <rniwa@webkit.org>
7705
Get rid of toInputElement()
7706
https://bugs.webkit.org/show_bug.cgi?id=67175
7708
Reviewed by Darin Adler.
7710
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
7711
(DumpRenderTreeSupportQt::setAutofilled):
7712
(DumpRenderTreeSupportQt::setValueForUser):
7713
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
7715
2011-08-30 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
7717
Emit last progress notification before calling dispatchDidFinishLoad
7718
https://bugs.webkit.org/show_bug.cgi?id=28851
7720
Reviewed by Adam Barth.
7722
Add infrastructure to dump progressFinishedNotification callback in DRT.
7724
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
7725
(DumpRenderTreeSupportQt::dumpProgressFinishedCallback):
7726
* WebCoreSupport/DumpRenderTreeSupportQt.h:
7727
* WebCoreSupport/FrameLoaderClientQt.cpp:
7728
(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
7729
* WebCoreSupport/FrameLoaderClientQt.h:
7731
2011-08-30 Kaustubh Atrawalkar <kaustubh@motorola.com>
7733
The unused ScrollView* argument can and should be removed from
7735
https://bugs.webkit.org/show_bug.cgi?id=67117
7737
Reviewed by Darin Adler.
7739
* WebCoreSupport/ChromeClientQt.h:
7740
(WebCore::ChromeClientQt::scrollRectIntoView):
7742
2011-08-25 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
7744
Unreviewed QtWebKit.pro fix for when building inside Qt
7746
Patch by Simo Fält <simo.falt@nokia.com>
7748
The QtWebKit version was being overwritten by a global Qt version when
7749
QtWebKit was built inside Qt. Fixed by moving the version
7750
definition after the inclusion of qbase.pri.
7754
2011-08-25 Sheriff Bot <webkit.review.bot@gmail.com>
7756
Unreviewed, rolling out r93783.
7757
http://trac.webkit.org/changeset/93783
7758
https://bugs.webkit.org/show_bug.cgi?id=66943
7760
Commited wrong stuff by accident. (Requested by ademar on
7765
(QWebView::setHtml):
7766
(QWebView::setContent):
7770
2011-08-25 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
7772
Unreviewed QtWebKit.pro fix for when building inside Qt
7774
Patch by Simo Fält <simo.falt@nokia.com>
7776
The QtWebKit version was being overwritten by a global Qt version when
7777
QtWebKit was built inside Qt. Fixed by moving the version
7778
definition after the inclusion of qbase.pri.
7782
2011-08-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
7784
[Qt] Fix build on Lion
7786
https://bugs.webkit.org/show_bug.cgi?id=66770
7788
Reviewed by Andreas Kling.
7790
We were mistakenly picking up mac/WebCoreSystemInterface.h instead of
7791
the Qt one, and building on Lion revealed this when a typedef for
7792
IOSurfaceRef was wrapped in PLATFORM(MAC).
7794
For now we fix this by including WebCoreSystemInterface using
7795
brackets, so that we'll pick up the right file based on the
7796
include paths. This also means exposing a few missing enums
7797
in our own version of the file, so those were added.
7799
Lasty, we need to link against the right system interface library
7804
2011-08-21 Lindsay Mathieson <lindsay.mathieson@gmail.com>
7806
[Qt] Fixes premature plugin unload bug
7807
https://bugs.webkit.org/show_bug.cgi?id=66628
7809
Reviewed by Benjamin Poulain.
7811
The QtPlatformPlugin was allocated on the stack, so its destructor is unloading the
7812
plugin at the end of the scope. This patch moves the local creation of QtPlatformPlugin
7813
to class member (TextCheckerClientQt::m_platformPlugin), preventing premature unloading
7816
* WebCoreSupport/TextCheckerClientQt.cpp:
7817
(WebCore::TextCheckerClientQt::loadSpellChecker):
7818
* WebCoreSupport/TextCheckerClientQt.h:
7820
2011-08-17 Adam Roben <aroben@apple.com>
7822
Make WebCore keep track of the current device scale factor
7824
Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
7827
Reviewed by Darin Adler.
7830
(QWebPagePrivate::QWebPagePrivate): Removed pixelRatio.
7831
(QWebPage::viewportAttributesForSize): Now calls Page::setDeviceScaleFactor.
7833
* Api/qwebpage_p.h: Removed pixelRatio.
7835
* WebCoreSupport/ChromeClientQt.cpp:
7836
* WebCoreSupport/ChromeClientQt.h:
7837
Removed deviceScaleFactor.
7839
2011-08-18 Chang Shu <cshu@webkit.org>
7841
Add support of setPasswordEchoEnabled and setPasswordEchoDuration for password echo feature
7842
https://bugs.webkit.org/show_bug.cgi?id=66052
7844
Reviewed by Alexey Proskuryakov.
7846
Enable password echo under the build flag.
7848
* Api/qwebsettings.cpp:
7849
(QWebSettingsPrivate::apply):
7851
2011-08-16 Chang Shu <cshu@webkit.org>
7853
Support reset in WebCore::Internals
7854
https://bugs.webkit.org/show_bug.cgi?id=66307
7856
Reviewed by Dimitri Glazkov.
7858
Added framework code in WebKit.
7860
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
7861
(DumpRenderTreeSupportQt::resetInternalsObject):
7862
* WebCoreSupport/DumpRenderTreeSupportQt.h:
7864
2011-08-16 Lindsay Mathieson <lindsay.mathieson@gmail.com>
7866
[Qt] Missing spell check support
7867
https://bugs.webkit.org/show_bug.cgi?id=44114
7869
Reviewed by Benjamin Poulain.
7871
Added a platform plugin to allow spell and grammar check in QtWebKit.
7873
* Api/qwebkitplatformplugin.h:
7875
* WebCoreSupport/EditorClientQt.cpp:
7876
(WebCore::EditorClientQt::isContinuousSpellCheckingEnabled):
7877
(WebCore::EditorClientQt::isGrammarCheckingEnabled):
7878
(WebCore::EditorClientQt::toggleContinuousSpellChecking):
7879
(WebCore::EditorClientQt::toggleGrammarChecking):
7880
* WebCoreSupport/EditorClientQt.h:
7881
(WebCore::EditorClientQt::textChecker):
7882
* WebCoreSupport/QtPlatformPlugin.cpp:
7883
(WebCore::QtPlatformPlugin::createSpellChecker):
7884
* WebCoreSupport/QtPlatformPlugin.h:
7885
* WebCoreSupport/TextCheckerClientQt.cpp: Added.
7886
(convertToVectorList):
7887
(WebCore::TextCheckerClientQt::ignoreWordInSpellDocument):
7888
(WebCore::TextCheckerClientQt::learnWord):
7889
(WebCore::TextCheckerClientQt::getAutoCorrectSuggestionForMisspelledWord):
7890
(WebCore::TextCheckerClientQt::checkSpellingOfString):
7891
(WebCore::TextCheckerClientQt::checkGrammarOfString):
7892
(WebCore::TextCheckerClientQt::getGuessesForWord):
7893
(WebCore::TextCheckerClientQt::isContinousSpellCheckingEnabled):
7894
(WebCore::TextCheckerClientQt::toggleContinousSpellChecking):
7895
(WebCore::TextCheckerClientQt::isGrammarCheckingEnabled):
7896
(WebCore::TextCheckerClientQt::toggleGrammarChecking):
7897
(WebCore::TextCheckerClientQt::loadSpellChecker):
7898
* WebCoreSupport/TextCheckerClientQt.h: Added.
7899
(WebCore::TextCheckerClientQt::requestCheckingOfString):
7901
2011-08-15 Dmitry Titov <dimich@chromium.org>
7903
FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
7904
https://bugs.webkit.org/show_bug.cgi?id=66165
7906
Reviewed by Darin Fisher.
7908
* WebCoreSupport/FrameLoaderClientQt.cpp:
7909
(WebCore::FrameLoaderClientQt::transferLoadingResourceFromPage):
7910
* WebCoreSupport/FrameLoaderClientQt.h:
7912
2011-08-10 Adam Roben <aroben@apple.com>
7914
Clear up scale factor terminology
7916
WebKit by and large deals with two scale factors: one intrinsic to the device on which the
7917
software is running, and one that is per-Page and can be controlled via API calls. This
7918
patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
7919
code use those names. It should introduce no behavior changes.
7921
Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
7924
Reviewed by Simon Fraser.
7926
* WebCoreSupport/ChromeClientQt.cpp:
7927
* WebCoreSupport/ChromeClientQt.h:
7929
2011-08-12 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
7931
[Qt] Add test for correct order of load signals in QWebPage
7932
https://bugs.webkit.org/show_bug.cgi?id=66016
7934
Reviewed by Benjamin Poulain.
7936
Add API test to ensure the order of load signals: loadStarted() needs to be emitted
7937
first, then loadProgress(100), followed by loadFinished().
7939
The test is skipped since this right now is broken, the bug
7940
https://bugs.webkit.org/show_bug.cgi?id=28851 tracks one possible way to fix.
7942
* tests/qwebpage/tst_qwebpage.cpp:
7943
(SpyForLoadSignalsOrder::SpyForLoadSignalsOrder):
7944
(SpyForLoadSignalsOrder::isFinished):
7945
(SpyForLoadSignalsOrder::onLoadProgress):
7946
(tst_QWebPage::loadSignalsOrder_data):
7947
(tst_QWebPage::loadSignalsOrder):
7949
2011-08-12 Alexis Menard <alexis.menard@openbossa.org>
7951
[Qt] Make sure QtWebKit correctly compiles when building WebKit2 with Qt5.
7953
In order to build correctly the QtQuick1 plugin we need to explicitly
7954
link to the new library added in Qt5 "qtquick1".
7956
Reviewed by Simon Hausmann.
7958
* declarative/declarative.pro:
7960
2011-08-11 Andrew Wason <rectalogic@rectalogic.com>
7962
REGRESSION: Qt JavaScript bridge signal connection fails
7963
https://bugs.webkit.org/show_bug.cgi?id=66097
7965
Reviewed by Gavin Barraclough.
7967
Unmark tests as expected failures, they pass now.
7969
* tests/qwebframe/tst_qwebframe.cpp:
7970
(tst_QWebFrame::connectAndDisconnect):
7972
2011-08-09 Sheriff Bot <webkit.review.bot@gmail.com>
7974
Unreviewed, rolling out r92683.
7975
http://trac.webkit.org/changeset/92683
7976
https://bugs.webkit.org/show_bug.cgi?id=65921
7978
"Breaks Qt --minimal build. Revert pending update of the Qt
7979
minimal configuration" (Requested by simathur on #webkit).
7981
* Api/qwebsettings.cpp:
7982
(QWebSettings::enablePersistentStorage):
7984
2011-08-09 Siddharth Mathur <siddharth.mathur@nokia.com>
7986
[Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
7987
https://bugs.webkit.org/show_bug.cgi?id=65880
7989
Reviewed by Andreas Kling.
7991
QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
7992
check for their feature flags. Assume that any reasonable Qt build provides them.
7994
* Api/qwebsettings.cpp:
7995
(QWebSettings::enablePersistentStorage):
7997
2011-08-05 Dawit Alemayehu <adawit@kde.org>
7999
Reviewed by Andreas Kling.
8001
Reverted commit r87797, http://trac.webkit.org/changeset/87797, because it
8002
causes the regression reported under bug# 63582.
8004
[Qt] REGRESSION(r87797): Broke KDEWebKit's custom QNAM.
8005
https://bugs.webkit.org/show_bug.cgi?id=63582
8007
* WebCoreSupport/FrameLoaderClientQt.cpp:
8008
(WebCore::FrameLoaderClientQt::setFrame):
8010
2011-08-03 Pavel Feldman <pfeldman@google.com>
8012
Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
8013
https://bugs.webkit.org/show_bug.cgi?id=65510
8015
Reviewed by Yury Semikhatsky.
8017
* Api/qwebframe.cpp:
8018
(QWebFramePrivate::renderRelativeCoords):
8020
2011-08-03 Pavel Feldman <pfeldman@chromium.org>
8022
Web Inspector: remove Node parameter from the InspectorClient::highlight
8023
https://bugs.webkit.org/show_bug.cgi?id=65549
8025
Reviewed by Yury Semikhatsky.
8027
* WebCoreSupport/InspectorClientQt.cpp:
8028
(WebCore::InspectorClientQt::highlight):
8029
* WebCoreSupport/InspectorClientQt.h:
8031
2011-08-02 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
8033
[Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
8034
https://bugs.webkit.org/show_bug.cgi?id=61042
8035
Remove mark as expected fail where unexpected pass and mark failing test case as expected fail
8037
Reviewed by Csaba Osztrogonác.
8039
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
8040
(tst_QDeclarativeWebView::basicProperties):
8041
(tst_QDeclarativeWebView::historyNav):
8043
2011-08-02 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
8045
[Qt] Fix tst_QWebPage::viewModes() API test
8046
https://bugs.webkit.org/show_bug.cgi?id=65531
8048
Reviewed by Csaba Osztrogonác.
8050
* tests/qwebpage/tst_qwebpage.cpp: Mark failing test case as expected fail
8051
(tst_QWebPage::viewModes):
8053
2011-08-02 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
8055
[Qt] Fix tst_QWebFrame::connectAndDisconnect() API test
8056
https://bugs.webkit.org/show_bug.cgi?id=65170
8058
Reviewed by Csaba Osztrogonác.
8060
* tests/qwebframe/tst_qwebframe.cpp: Mark failing test case as expected fail
8061
(tst_QWebFrame::connectAndDisconnect):
8063
2011-08-02 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
8065
[Qt] Fix tst_QWebElement::render() API test
8066
https://bugs.webkit.org/show_bug.cgi?id=65243
8068
Reviewed by Csaba Osztrogonác.
8070
* tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail
8071
(tst_QWebElement::render):
8073
2011-08-02 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
8075
[Qt] tst_QWebElement::style() fails because QWebElement::CascadedStyle doesn't work as expected
8076
https://bugs.webkit.org/show_bug.cgi?id=65244
8078
Reviewed by Csaba Osztrogonác.
8080
* tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail
8081
(tst_QWebElement::style):
8083
2011-08-01 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
8085
[Qt] Fix tst_QWebPage::loadHtml5Video() API test
8086
https://bugs.webkit.org/show_bug.cgi?id=65452
8088
Reviewed by Csaba Osztrogonác.
8090
* tests/qwebpage/tst_qwebpage.cpp: Mark failing test case as expected fail
8091
(tst_QWebPage::loadHtml5Video):
8093
2011-07-30 Patrick Gansterer <paroga@webkit.org>
8095
Remove inclusion of MainThread.h from Threading.h
8096
https://bugs.webkit.org/show_bug.cgi?id=65081
8098
Reviewed by Darin Adler.
8100
Add missing include statements for MainThread.
8104
2011-07-27 Benjamin Poulain <benjamin@webkit.org>
8106
[WK2][Qt] Move from QGraphicsView to Qt Scene Graph
8107
https://bugs.webkit.org/show_bug.cgi?id=62969
8109
Reviewed by Andreas Kling.
8111
Co-authored with Simon Hausmann <simon.hausmann@nokia.com>
8113
Add the declarative dependency to link WebKit.
8117
2011-07-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
8119
[Qt] QtWebkit never finishes loading sites when they are loaded after an initial QUrl fails to load.
8120
https://bugs.webkit.org/show_bug.cgi?id=61328
8122
Reviewed by Andreas Kling.
8124
Change the hooks in FrameLoaderClient we use for emitting signals. Instead of
8125
emitting signals in the progress notification functions, we use the
8126
dispatchDid{Start,Finish,Fail}* functions. The main reason behind this change is
8127
that loading code is prepared to handle load() when inside those functions.
8129
The crash was being caused by setUrl() (and load()) being called when
8130
loadFinished(false) was emitted. The problem here is that when
8131
postProgressFinishedNotification the FrameLoader wasn't ready for taking a load()
8132
call again, because it was still the ProvisionalLoadState but with the
8133
provisionalDocumentLoader already removed.
8135
To emulate the same behavior that QtWebKit had when using
8136
postProgressFinishedNotification, we now keep track of the frame originating the
8137
load, and emit the signals when this frame's client is called.
8139
The patch keeps the existing semantics for QWebPage signals, but we now emit the
8140
QWebFrame signals everytime, not only when they are the originating frame for
8143
* Api/qwebframe.cpp:
8144
(clearCoreFrame): Document our assumption that activeDocumentLoader will exist.
8146
* WebCoreSupport/FrameLoaderClientQt.h: Remove m_loadError, add a boolean to keep
8147
track whether the frame is originating the load. Remove the signals from
8148
FrameLoaderClientQt since we will emit QWebFrame and QWebPage signals directly.
8150
* WebCoreSupport/FrameLoaderClientQt.cpp:
8151
(WebCore::FrameLoaderClientQt::FrameLoaderClientQt): Initialize m_isOriginatingLoad.
8153
(WebCore::FrameLoaderClientQt::setFrame): Do not connect QWebFrame and QWebPage
8154
signals to our signals for load/finished, signal emission will be done manually.
8156
(WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad): Emit
8157
loadStarted() signal and make the first notification of estimation change, that
8158
Qt API tests expect to exist and notify 10%.
8160
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): Remove reference to
8161
m_loadError and emit loadFinished() signal.
8163
(WebCore::FrameLoaderClientQt::postProgressStartedNotification): Remove signal
8164
emission and mark the originating load as true, since only the originating frame
8165
gets this call in its client.
8167
(WebCore::FrameLoaderClientQt::postProgressFinishedNotification): Remove signal
8170
(WebCore::FrameLoaderClientQt::callErrorPageExtension): Return whether the call
8171
was successful or not. This wasn't necessary before because a successful call for
8172
error page would lead to a load(), that cleared the m_loadError.
8173
(WebCore::FrameLoaderClientQt::dispatchDidFailProvisionalLoad): Remove reference
8174
to m_loadError and emit finished signal indicating error if ErrorPage extension
8176
(WebCore::FrameLoaderClientQt::dispatchDidFailLoad): Ditto.
8178
(WebCore::FrameLoaderClientQt::emitLoadStarted): Emit the loadStarted() signal
8179
for the QWebFrame, and if the originating load also do for the QWebPage.
8181
(WebCore::FrameLoaderClientQt::emitLoadFinished): Same as before but for
8182
loadFinished(). Take care to reset the originating load flag before the signals
8183
are emitted, since they might want to set it back again.
8185
* tests/qwebframe/tst_qwebframe.cpp:
8186
(URLSetter::URLSetter): Object that sets the url using either load() or setUrl()
8187
when a certain signal is emitted in the frame.
8189
(URLSetter::execute):
8190
(tst_QWebFrame::loadInSignalHandlers_data):
8191
(tst_QWebFrame::loadInSignalHandlers): New test inspired by the bug test case. This test
8192
crashes without this patch applied.
8194
2011-07-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
8196
[Qt] Fix build in Qt 5 of QDeclarativeWebView
8197
https://bugs.webkit.org/show_bug.cgi?id=65258
8199
Reviewed by Andreas Kling.
8201
In Qt 5, the QGraphicsView-based classes for QtQuick are in the
8202
qtquick1 module, including QDeclarativeItem and QDeclarativeView.
8204
* declarative/qdeclarativewebview_p.h:
8205
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
8209
2011-07-26 Sadrul Habib Chowdhury <sadrul@chromium.org>
8211
Add support for download='filename' attribute in anchors.
8212
https://bugs.webkit.org/show_bug.cgi?id=64580
8214
Reviewed by Adam Barth.
8216
* WebCoreSupport/FrameLoaderClientQt.cpp:
8217
(WebCore::FrameLoaderClientQt::startDownload):
8218
* WebCoreSupport/FrameLoaderClientQt.h:
8220
2011-07-26 Alexis Menard <alexis.menard@openbossa.org>
8222
Reviewed by Andreas Kling.
8224
[Qt] Change default backend to use GStreamer on Linux and QuickTime on Mac.
8225
https://bugs.webkit.org/show_bug.cgi?id=63472
8227
Use the flag WTF_USE_QTKIT=1 rather than USE_QTKIT=1 because that flag doesn't
8228
exist anymore, it's the default. Ditto for GStreamer.
8232
2011-07-25 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
8234
[Qt] Add more tests to cover the behavior of loadFinished() signal
8235
https://bugs.webkit.org/show_bug.cgi?id=63490
8237
Reviewed by Benjamin Poulain.
8239
* tests/qwebframe/tst_qwebframe.cpp:
8240
(FakeReply::FakeReply):
8241
(FakeNetworkManager::createRequest): Add a fake reply that gives 404 error code.
8243
(tst_QWebFrame::loadFinishedAfterNotFoundError): Verify that we get loadFinished(false)
8244
after a 404 error without contents.
8246
* tests/qwebpage/tst_qwebpage.cpp:
8247
(tst_QWebPage::errorPageExtensionLoadFinished): Verify if the argument of loadFinished()
8248
is true when we use error page extension to produce our own error pages.
8250
2011-07-19 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
8252
[Qt] Improve documentation of QWebView::setPage()
8253
https://bugs.webkit.org/show_bug.cgi?id=64827
8255
Reviewed by Noam Rosenthal.
8257
* Api/qwebview.cpp: Use the word 'page' to refer to a QWebPage instead of 'document'.
8259
2011-07-19 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
8261
[Qt] Fix leak of QWebPage in errorPageExtension tests
8262
https://bugs.webkit.org/show_bug.cgi?id=64814
8264
Reviewed by Noam Rosenthal.
8266
QWebView::setPage() doesn't take ownership, so the ErrorPages were leaking. So now
8267
allocate them on the stack. This shouldn't change any behavior.
8269
* tests/qwebpage/tst_qwebpage.cpp:
8270
(tst_QWebPage::errorPageExtension):
8271
(tst_QWebPage::errorPageExtensionInIFrames):
8272
(tst_QWebPage::errorPageExtensionInFrameset):
8274
2011-07-18 Hui Huang <hui.2.huang@nokia.com>
8276
[Qt] Compiling error in Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp with Qt 4.7 or older
8277
https://bugs.webkit.org/show_bug.cgi?id=64560
8279
Reviewed by Noam Rosenthal.
8281
* tests/qwebelement/tst_qwebelement.cpp:
8282
(tst_QWebElement::render):
8284
2011-07-15 Dan Bernstein <mitz@apple.com>
8286
REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
8287
https://bugs.webkit.org/show_bug.cgi?id=64615
8289
Reviewed by Anders Carlsson.
8291
* WebCoreSupport/ChromeClientQt.h:
8292
(WebCore::ChromeClientQt::setCursorHiddenUntilMouseMoves): Added this stub.
8294
2011-07-15 Kenneth Rohde Christiansen <kenneth@webkit.org>
8296
REGRESSION(91064): Upstream QtWebKit/N9 changes related tovisibleContentRect
8298
Reviewed by Antonio Gomes.
8300
Only set setFixedVisibleContentRect when in resizesToContents mode.
8302
* WebCoreSupport/FrameLoaderClientQt.cpp:
8303
(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
8305
2011-07-15 Kenneth Rohde Christiansen <kenneth@webkit.org>
8307
Upstream QtWebKit/N9 changes related to visibleContentRect
8308
https://bugs.webkit.org/show_bug.cgi?id=64589
8310
Reviewed by Simon Hausmann.
8313
(QWebPage::setActualVisibleContentRect):
8314
Change to use setFixedVisibleContentRect.
8315
* WebCoreSupport/FrameLoaderClientQt.cpp:
8316
(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
8317
Only set fixedVisibleContentRect for the mainframe.
8318
* symbian/eabi/QtWebKitu.def:
8320
2011-07-13 Joseph Pecoraro <joepeck@webkit.org>
8322
Improve names of some ApplicationCacheStorage accessor methods
8323
https://bugs.webkit.org/show_bug.cgi?id=64433
8325
Reviewed by Alexey Proskuryakov.
8327
* WebCoreSupport/ChromeClientQt.cpp:
8328
(WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
8331
2011-07-12 Joseph Pecoraro <joepeck@webkit.org>
8333
ApplicationCache update should not immediately fail when reaching per-origin quota
8334
https://bugs.webkit.org/show_bug.cgi?id=64177
8336
Reviewed by Alexey Proskuryakov.
8340
* WebCoreSupport/ChromeClientQt.cpp:
8341
(WebCore::ChromeClientQt::reachedApplicationCacheOriginQuota):
8342
* WebCoreSupport/ChromeClientQt.h:
8343
Pass the spaceNeeded value through to the applicationCacheQuotaExceeded signal.
8345
2011-07-11 Ryosuke Niwa <rniwa@webkit.org>
8347
Move selection related code from RenderTextControl to HTMLTextFormControlElement
8348
https://bugs.webkit.org/show_bug.cgi?id=64133
8350
Reviewed by Dimitri Glazkov.
8352
Replaced calls to WebCore::setSelectionRange by calls to HTMLTextFormControlElement::setSelectionRange.
8355
(QWebPagePrivate::inputMethodEvent):
8357
2011-07-08 Adam Barth <abarth@webkit.org>
8359
Unreviewed, rolling out r90662.
8360
http://trac.webkit.org/changeset/90662
8361
https://bugs.webkit.org/show_bug.cgi?id=64210
8363
Introduced regressions in Chromium browser tests (Requested by
8367
(QWebPagePrivate::inputMethodEvent):
8369
2011-07-08 Ryosuke Niwa <rniwa@webkit.org>
8371
Move selection related code from RenderTextControl to HTMLTextFormControlElement
8372
https://bugs.webkit.org/show_bug.cgi?id=64133
8374
Reviewed by Dimitri Glazkov.
8376
Replaced calls to WebCore::setSelectionRange by calls to HTMLTextFormControlElement::setSelectionRange.
8379
(QWebPagePrivate::inputMethodEvent):
8381
2011-07-05 Rafael Brandao <rafael.lobo@openbossa.org>
8383
[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
8384
https://bugs.webkit.org/show_bug.cgi?id=63235
8386
Modified baseUrl to be a local file in order to get a security origin
8387
that is allowed to request local resources. Removed QSignalSpy from it
8388
as loadFinished always happens, and the original test was split into two.
8390
Reviewed by Benjamin Poulain.
8392
* tests/qwebframe/tst_qwebframe.cpp:
8393
(tst_QWebFrame::setHtmlWithImageResource):
8394
(tst_QWebFrame::setHtmlWithStylesheetResource):
8395
(tst_QWebFrame::setHtmlWithBaseURL):
8397
2011-04-02 Robert Hogan <robert@webkit.org>
8399
Reviewed by Benjamin Poulain.
8401
[Qt] Support third-party cookie policy for Qt clients
8403
This adds new API to QWebSettings that allows clients to
8404
select one of three third-party cookie blocking policies:
8406
AlwaysAllowThirdPartyCookies
8407
AlwaysBlockThirdPartyCookies
8408
AllowThirdPartyWithExistingCookies
8410
The first two are self-explanatory, the third mimics Safari's
8411
default behaviour of permitting third-party cookies when the user
8412
already has cookies from the third-party site. This was
8413
introduced to allow third-party cookie blocking to play well with
8414
facebook sharing etc. AlwaysAllowThirdPartyCookies is the default.
8416
There is scope for adding an 'exceptions' list API and clients would
8417
struggle to implement it themselves given the paucity of information
8418
available from setCookiesForUrl().
8420
See also: http://gitorious.org/qt/qt/merge_requests/1205
8421
(commit 154402f56dcf8303a6ce601a52215226af8d31ba)
8422
http://bugreports.qt.nokia.com/browse/QTBUG-13601
8424
https://bugs.webkit.org/show_bug.cgi?id=45455
8426
* Api/qwebsettings.cpp:
8427
(QWebSettings::QWebSettings):
8428
(QWebSettings::setThirdPartyCookiePolicy):
8429
(QWebSettings::thirdPartyCookiePolicy):
8430
* Api/qwebsettings.h:
8432
2011-07-01 Jade Han <jade.han@nokia.com>
8434
[Qt][Symbian] Update .def file for Symbian to build Tools
8435
https://bugs.webkit.org/show_bug.cgi?id=61200
8437
Reviewed by Laszlo Gombos.
8439
Add newly introduced symbols to fix building the Tools directory for Symbian.
8441
* symbian/eabi/QtWebKitu.def:
8443
2011-07-01 Jade Han <jade.han@nokia.com>
8445
Reviewed by Laszlo Gombos.
8447
[Qt][Symbian] Update .def file for Symbian
8448
https://bugs.webkit.org/show_bug.cgi?id=61200
8450
Add newly introduced symbols to fix the Symbian build.
8452
* symbian/eabi/QtWebKitu.def:
8454
2011-06-30 Rafael Brandao <rafael.lobo@openbossa.org>
8456
Reviewed by Benjamin Poulain.
8458
[Qt] Fix tst_QWebFrame::renderGeometry() API test
8459
https://bugs.webkit.org/show_bug.cgi?id=63236
8461
This test required a security origin with granted permission to request local resources.
8462
By default, only local files can load local resources. So modified baseUrl to be a local file.
8464
* tests/qwebframe/tst_qwebframe.cpp:
8465
(tst_QWebFrame::renderGeometry):
8467
2011-06-27 Diego Gonzalez <diegohcg@webkit.org>
8469
Reviewed by Antonio Gomes.
8471
[Qt] DRT: Provide LayoutTestController::setDefersLoading and ::goBack support
8472
https://bugs.webkit.org/show_bug.cgi?id=63489
8475
loader/navigation-while-deferring-loads.html
8477
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
8478
(DumpRenderTreeSupportQt::setDefersLoading):
8479
(DumpRenderTreeSupportQt::goBack):
8480
* WebCoreSupport/DumpRenderTreeSupportQt.h:
8482
2011-06-30 Fabrizio Machado <fabrizio.machado@nokia.com>
8484
Reviewed by Benjamin Poulain.
8486
[Qt] QML Webview causes performance drops
8487
https://bugs.webkit.org/show_bug.cgi?id=57554
8489
Remove tiledBackingStoreEnabled from QML WebView.
8491
* declarative/qdeclarativewebview.cpp:
8492
(QDeclarativeWebView::setPage):
8494
2011-06-30 Kentaro Hara <haraken@google.com>
8496
Reviewed by Kent Tamura.
8498
Change the label of an HTML5 file chooser button to "Choose Files"
8499
https://bugs.webkit.org/show_bug.cgi?id=49245
8501
We should notify capability of multiple files to users.
8503
Test: fast/forms/input-file-label.html
8505
* WebCoreSupport/WebPlatformStrategies.cpp:
8506
(WebPlatformStrategies::fileButtonChooseFileLabel): Updated the description for "Choose File".
8507
(WebPlatformStrategies::fileButtonChooseMultipleFilesLabel): Returns a "Choose Files" label.
8508
* WebCoreSupport/WebPlatformStrategies.h:
8510
2011-06-29 Alexis Menard <alexis.menard@openbossa.org>
8512
Reviewed by Benjamin Poulain.
8514
[Qt] Add Qt dependencies in QtWebKit's main pro file.
8515
https://bugs.webkit.org/show_bug.cgi?id=63639
8517
syncqt, the script which generates the headers inside Qt parses
8518
the main pro file of QtWebKit to check the Qt dependencies. It used
8519
to be WebCore.pro but after the build reorganization QtWebKit.pro is
8520
the new main pro file so we need to add the network dependency just like
8521
we did in WebCore.pro.
8525
2011-06-28 Ilya Sherman <isherman@chromium.org>
8527
Reviewed by Adam Barth.
8529
form.autocomplete="off" does not work
8530
https://bugs.webkit.org/show_bug.cgi?id=35823
8532
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
8533
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId): Update callsite.
8535
2011-06-27 Diego Gonzalez <diegohcg@webkit.org>
8537
Reviewed by Kenneth Rohde Christiansen.
8539
[Qt] DRT support for setInteractiveFormValidationEnabled
8540
https://bugs.webkit.org/show_bug.cgi?id=63496
8543
fast/forms/interactive-validation-prevented.html
8544
fast/forms/interactive-validation-attach-assertion.html
8545
fast/forms/interactive-validation-assertion-by-validate-twice.html
8546
fast/forms/interactive-validation-select-crash.html
8547
fast/forms/interactive-validation-crash-by-style-override.html
8549
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
8550
(DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled):
8551
* WebCoreSupport/DumpRenderTreeSupportQt.h:
8553
2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
8555
Reviewed by Andreas Kling.
8557
[Qt] Use <QtX/x.h> style of headers for Qt tests which rely on it.
8558
https://bugs.webkit.org/show_bug.cgi?id=63562
8560
Some Qt auto-tests rely on <QtX/x.h> types of includes.
8562
* Api/qwebkitplatformplugin.h:
8563
* symbian/platformplugin/qwebkitplatformplugin.h:
8565
2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
8567
Reviewed by Andreas Kling.
8569
[Qt] Use QtQuick imports in Api tests rather than old deprecated Qt 4.x imports.
8570
https://bugs.webkit.org/show_bug.cgi?id=63533
8572
We need to use the new QtQuick 1.x imports rather than the old deprecated
8575
* tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml:
8576
* tests/qdeclarativewebview/resources/webviewtest.qml:
8577
* tests/qdeclarativewebview/resources/webviewtestdefault.qml:
8579
2011-06-27 Alexis Menard <alexis.menard@openbossa.org>
8581
Reviewed by Darin Adler.
8583
Use specific headers includes rather than full system headers.
8584
https://bugs.webkit.org/show_bug.cgi?id=63475
8586
Use only needed headers rather than system headers.
8588
* WebCoreSupport/QTKitFullScreenVideoHandler.mm:
8590
2011-06-27 Alexis Menard <alexis.menard@openbossa.org>
8592
Reviewed by Kenneth Rohde Christiansen.
8594
[Qt] Remove Phonon MediaPlayer from the tree.
8595
https://bugs.webkit.org/show_bug.cgi?id=63448
8597
Remove Phonon related stuff.
8599
* docs/qtwebkit.qdocconf:
8600
* qt_webkit_version.pri:
8602
2011-06-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
8604
Reviewed by Andreas Kling.
8606
[Qt] tst_QWebFrame::overloadedSlots() fails
8607
https://bugs.webkit.org/show_bug.cgi?id=37319
8609
* tests/qwebframe/tst_qwebframe.cpp:
8610
(tst_QWebFrame::overloadedSlots): Remove expected failure and
8613
2011-06-20 Robert Hogan <robert@webkit.org>
8615
Reviewed by Antonio Gomes.
8617
[Qt] Duplicate entry in context menu
8618
https://bugs.webkit.org/show_bug.cgi?id=62139
8620
contextMenuController()->populate() is called from
8621
ContextMenuController::handleContextMenuEvent() so
8622
QWebPage::updatePositionDependentActions() does not need
8623
to call it independently.
8626
http://trac.webkit.org/changeset/73535
8627
http://trac.webkit.org/changeset/32389
8630
(QWebPage::updatePositionDependentActions):
8631
* tests/qwebpage/tst_qwebpage.cpp:
8632
(tst_QWebPage::contextMenuCopy):
8633
(tst_QWebPage::contextMenuPopulatedOnce):
8635
2011-06-24 Dominic Cooney <dominicc@chromium.org>
8637
Reviewed by Dimitri Glazkov.
8639
Convert shadow-DOM related tests to use window.internals
8640
https://bugs.webkit.org/show_bug.cgi?id=61671
8642
Remove shadow-DOM related methods from Qt DRT API. These are not
8645
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
8646
* WebCoreSupport/DumpRenderTreeSupportQt.h:
8648
2011-06-23 Joe Wild <joseph.wild@nokia.com>
8650
Reviewed by Laszlo Gombos.
8652
[Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
8653
https://bugs.webkit.org/show_bug.cgi?id=61200
8655
Revert r87060 as it broke compatibility with QtWebKit 2.1 release
8656
and add some newly introduce symbols.
8658
* symbian/eabi/QtWebKitu.def:
8660
2011-06-23 Alexis Menard <alexis.menard@openbossa.org>
8662
Reviewed by Eric Carlson.
8664
[Qt] Implement fullscreen support on Mac with the QuickTime backend.
8665
https://bugs.webkit.org/show_bug.cgi?id=61728
8667
Implement fullscreen support for Qt when using the QuickTime backend.
8668
We mostly use what is already done for the Mac port.
8671
* WebCoreSupport/ChromeClientQt.cpp:
8672
(WebCore::ChromeClientQt::ChromeClientQt):
8673
(WebCore::ChromeClientQt::~ChromeClientQt):
8674
* WebCoreSupport/ChromeClientQt.h:
8675
* WebCoreSupport/FullScreenVideoQt.cpp:
8676
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
8677
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
8678
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
8679
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
8680
(WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
8681
(WebCore::FullScreenVideoQt::isValid):
8682
* WebCoreSupport/FullScreenVideoQt.h:
8683
* WebCoreSupport/QTKitFullScreenVideoHandler.h: Added.
8684
* WebCoreSupport/QTKitFullScreenVideoHandler.mm: Added.
8685
(QTKitFullScreenVideoHandler::QTKitFullScreenVideoHandler):
8686
(QTKitFullScreenVideoHandler::~QTKitFullScreenVideoHandler):
8687
(QTKitFullScreenVideoHandler::enterFullScreen):
8688
(QTKitFullScreenVideoHandler::exitFullScreen):
8689
* WebCoreSupport/WebSystemInterface.mm:
8690
(InitWebCoreSystemInterface):
8692
2011-06-23 Yael Aharon <yael.aharon@nokia.com>
8694
Reviewed by Andreas Kling.
8696
[Qt] [WK2] Add drag and drop support
8697
https://bugs.webkit.org/show_bug.cgi?id=62838
8699
Call dragEnded from the DragClient to make WebKit1 and WebKit2 consistent.
8701
* WebCoreSupport/DragClientQt.cpp:
8702
(WebCore::DragClientQt::startDrag):
8704
2011-06-23 Joe Wild <joseph.wild@nokia.com>
8706
Reviewed by Laszlo Gombos.
8708
[Qt] Export files under Symbian Qt WebKit build
8709
https://bugs.webkit.org/show_bug.cgi?id=61207
8711
Export files for the Symbian platform as this is needed by the
8712
production build system.
8714
Janne Koskinen provided the suggestion to use target_predeps,
8715
which is an improvement over the originally suggested patch.
8719
2011-06-23 Csaba Osztrogonác <ossy@webkit.org>
8721
Rubber-stamped by Andreas Kling.
8723
[Qt] Fix tst_QWebFrame::setHtmlWithResource() API test
8724
https://bugs.webkit.org/show_bug.cgi?id=63235
8726
[Qt] Fix tst_QWebFrame::renderGeometry() API test
8727
https://bugs.webkit.org/show_bug.cgi?id=63236
8729
[Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
8730
https://bugs.webkit.org/show_bug.cgi?id=63237
8732
* tests/qwebframe/tst_qwebframe.cpp: Mark failing test cases as expected fails until real fix.
8733
(tst_QWebFrame::setHtmlWithResource):
8734
(tst_QWebFrame::renderGeometry):
8736
2011-06-23 Csaba Osztrogonác <ossy@webkit.org>
8738
Rubber-stamped by Andreas Kling.
8740
[Qt] Fix tst_QWebPage::showModalDialog() API test
8741
https://bugs.webkit.org/show_bug.cgi?id=63244
8743
[Qt] Fix tst_QWebPage::testStopScheduledPageRefresh() API test
8744
https://bugs.webkit.org/show_bug.cgi?id=63245
8746
* tests/qwebpage/tst_qwebpage.cpp: Mark failing test cases as expected fails.
8747
(tst_QWebPage::showModalDialog):
8748
(tst_QWebPage::testStopScheduledPageRefresh):
8750
2011-06-22 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
8752
Reviewed by Holger Freyther.
8754
[Qt] Fix Qt namespace on QDeclarativeWebView autotest
8755
https://bugs.webkit.org/show_bug.cgi?id=63147
8757
Applications (such as the test runner) are not supposed to be wrapped
8758
by {QT_BEGIN,QT_END}_NAMESPACE macros, otherwise building Qt (or
8759
QtWebKit) with a specific namespace won't work (will result in main
8762
This was the only test wrapped by these macros, all others are fine.
8764
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: remove
8767
2011-06-20 Dimitri Glazkov <dglazkov@chromium.org>
8769
Reviewed by Kent Tamura.
8771
FileChooser should be only created when we need to choose files.
8772
https://bugs.webkit.org/show_bug.cgi?id=63039
8774
* WebCoreSupport/ChromeClientQt.cpp:
8775
(WebCore::ChromeClientQt::runOpenPanel): Changed to use settings.
8777
2011-06-21 Yael Aharon <yael.aharon@nokia.com>
8779
Reviewed by Andreas Kling.
8781
[Qt] Regression(60942) wrong default action for drag-and-drop.
8782
https://bugs.webkit.org/show_bug.cgi?id=63004
8784
Added special handling for the case that dragOperation is not initialized.
8785
Save the last dropOperation and pass it to the dropEvent, so that it can
8786
be accepted by QDrag.
8787
Call event->accepted() and not event->acceptProposedAction(), because the
8788
later ignores the dropAction specified in JavaScript.
8790
Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401
8791
and did not see any issue.
8792
Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html
8796
(dropActionToDragOp):
8797
(QWebPagePrivate::dragMoveEvent):
8798
(QWebPagePrivate::dropEvent):
8800
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
8802
Reviewed by Yury Semikhatsky.
8804
Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
8805
https://bugs.webkit.org/show_bug.cgi?id=62994
8807
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
8808
* WebCoreSupport/DumpRenderTreeSupportQt.h:
8810
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
8812
Reviewed by Darin Adler.
8814
Separate concerns of loading file icons and choosing files.
8815
https://bugs.webkit.org/show_bug.cgi?id=62931
8817
* WebCoreSupport/ChromeClientQt.cpp:
8818
(WebCore::ChromeClientQt::loadIconForFiles): Renamed.
8819
* WebCoreSupport/ChromeClientQt.h:
8821
2011-06-17 Alexis Menard <alexis.menard@openbossa.org>
8823
Reviewed by Andreas Kling.
8825
[Qt] Fix wrong framework generation on MacOS when inside Qt 4.8.
8826
https://bugs.webkit.org/show_bug.cgi?id=62815
8828
Partially revert r85870 which assumed that QtWebKit will never be build inside Qt
8829
anymore. Everything inside !QTDIR_build condition is not needed in the Qt tree because
8830
qbase.pri is doing the job for us, i.e. using includes generated by syncqt to
8831
setup the mac framework. It also use a correct QMAKE_LFLAGS_SONAME making possible
8832
to actually run an application linked against QtWebKit.
8836
2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
8838
Unreviewed, rolling out r88796.
8839
http://trac.webkit.org/changeset/88796
8840
https://bugs.webkit.org/show_bug.cgi?id=62790
8842
It made fast/dom/nodesFromRect-basic.html time out on Qt,
8843
64-bit, debug mode (Requested by Ossy on #webkit).
8845
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
8846
(DumpRenderTreeSupportQt::plainText):
8847
(DumpRenderTreeSupportQt::nodesFromRect):
8848
* WebCoreSupport/DumpRenderTreeSupportQt.h:
8849
* tests/qwebframe/tst_qwebframe.cpp:
8850
(tst_QWebFrame::overloadedSlots):
8851
(tst_QWebFrame::domCycles):
8853
2011-06-15 Diego Gonzalez <diegohcg@webkit.org>
8855
Reviewed by Kenneth Rohde Christiansen.
8857
[Qt] Inconsistent behavior on a form submit request...
8858
https://bugs.webkit.org/show_bug.cgi?id=45523
8860
The inconsistency occurs when a form submission requests a new window.
8861
Two windows are opened (instead of only one) and the first window is opened
8864
By default each page is put into their own unique page group, which affects popup windows
8865
and visited links. Page groups (per process only) is a feature making it possible to use
8866
separate settings for each group, so that for instance an integrated browser/email reader
8867
can use different settings for displaying HTML pages and HTML email. To make QtWebKit work
8868
as expected out of the box, we use a default group similar to what other ports are doing.
8872
2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
8874
Reviewed by Andreas Kling.
8876
[Qt] tst_QWebFrame::overloadedSlots() fails
8877
https://bugs.webkit.org/show_bug.cgi?id=37319
8879
Since the implicit conversion was removed, change support functions of DRT to
8880
expect a QVariantMap instead of a QWebElement. This matches the exposed function
8881
in the controller, which takes 'document' and not 'document.documentElement'.
8883
And now that Element -> QWebElement is a perfect match, we must use QWebElement
8884
instead of QVariantMap, like in plainText().
8886
* WebCoreSupport/DumpRenderTreeSupportQt.h:
8887
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
8888
(DumpRenderTreeSupportQt::plainText): Fix to use QWebElement instead of
8889
QVariantMap when getting the startContainer. Also use QVariantMap directly,
8890
bridge will do conversion for us now.
8892
(getCoreDocumentFromVariantMap): Extracts the WebCore::Document* from the
8893
QVariantMap that Qt bridge gives us when 'document' is passed from JS.
8895
(DumpRenderTreeSupportQt::nodesFromRect): Use helper function.
8897
* tests/qwebframe/tst_qwebframe.cpp: Splitted the test domCycles() into two
8898
different tests. In practice, the original test just checked whether we could
8899
create a QVariantMap representing 'document' without infinite looping due to
8900
cycles in the DOM. This was more evident before since we haven't a conversion
8901
from JSElement to QWebElement, but from JSElement to QVariantMap.
8903
(tst_QWebFrame::documentHasDocumentElement): Evaluates 'document' and extracts
8904
'documentElement' from it. Compares to QWebFrame::documentElement().
8906
(tst_QWebFrame::documentAllHasDocumentElement): Look inside 'document.all' for
8907
the documentElement.
8909
(tst_QWebFrame::overloadedSlots): Remove expected failure and fix wrong comment.
8911
2011-06-14 Andreas Kling <kling@webkit.org>
8913
Reviewed by Benjamin Poulain.
8915
[Qt] Don't include convenience "QWebFoo" headers in WebKit code.
8916
https://bugs.webkit.org/show_bug.cgi?id=62632
8918
* WebCoreSupport/FrameNetworkingContextQt.cpp:
8920
2011-06-12 Adam Barth <abarth@webkit.org>
8922
Reviewed by Alexey Proskuryakov.
8924
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
8925
https://bugs.webkit.org/show_bug.cgi?id=62516
8927
* WebCoreSupport/FrameLoaderClientQt.cpp:
8928
(WebCore::FrameLoaderClientQt::interruptedForPolicyChangeError):
8929
* WebCoreSupport/FrameLoaderClientQt.h:
8931
2011-06-12 Adam Barth <abarth@webkit.org>
8933
Attempt to fix Qt build.
8935
* WebCoreSupport/FrameLoaderClientQt.cpp:
8936
(drtPrintFrameUserGestureStatus):
8938
2011-06-12 Adam Barth <abarth@webkit.org>
8940
Reviewed by Eric Seidel.
8942
Remove FrameLoader::isProcessingUserGesture
8943
https://bugs.webkit.org/show_bug.cgi?id=62519
8945
* WebCoreSupport/FrameLoaderClientQt.cpp:
8946
(drtPrintFrameUserGestureStatus):
8948
2011-06-10 Andreas Kling <kling@webkit.org>
8950
Reviewed by Benjamin Poulain.
8952
[Qt] Fix 'headers' autotest when building inside Qt.
8953
https://bugs.webkit.org/show_bug.cgi?id=62449
8955
* Api/qwebkitplatformplugin.h:
8957
2011-06-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
8959
Reviewed by Kenneth Rohde Christiansen.
8961
[Qt] Keep ORIENTATION_EVENTS independent from DEVICE_ORIENTATION
8962
https://bugs.webkit.org/show_bug.cgi?id=62420
8964
ORIENTATION_EVENTS and DEVICE_ORIENTATION features are very similar
8965
but they meant to be independent.
8967
* Api/qwebframe.cpp:
8968
(QWebFramePrivate::_q_orientationChanged):
8969
(QWebFrame::QWebFrame):
8970
* Api/qwebframe_p.h:
8972
2011-06-09 Andras Becsi <abecsi@webkit.org>
8974
Reviewed by Andreas Kling.
8976
[Qt] Fix the in-tree build on Linux
8977
https://bugs.webkit.org/show_bug.cgi?id=62378
8979
In case of an in-tree build qmake generates defect prl dependencies for
8980
the QtWebKit library, because the inclusion of qtbase.pri adds explicitlib to CONFIG.
8982
* QtWebKit.pro: Remove explicitlib and staticlib from CONFIG.
8984
2011-06-09 Robert Hogan <robert@webkit.org>
8986
Reviewed by Andreas Kling.
8988
Teach Qt about window.internals
8989
https://bugs.webkit.org/show_bug.cgi?id=61074
8991
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
8992
(DumpRenderTreeSupportQt::injectInternalsObject):
8993
* WebCoreSupport/DumpRenderTreeSupportQt.h:
8995
2011-06-08 Andreas Kling <kling@webkit.org>
8997
Reviewed by Benjamin Poulain.
8999
[Qt] FrameLoaderClient: Check Vector::find() return value for WTF::notFound.
9000
https://bugs.webkit.org/show_bug.cgi?id=62274
9002
Vector::find() returns size_t (which is unsigned), so we should check
9003
for WTF::notFound instead of -1.
9005
* WebCoreSupport/FrameLoaderClientQt.cpp:
9006
(WebCore::FrameLoaderClientQt::createPlugin):
9008
2011-06-07 Noam Rosenthal <noam.rosenthal@nokia.com>
9010
Reviewed by Andreas Kling.
9012
[Texmap][Qt] Enable TextureMapper by default
9013
https://bugs.webkit.org/show_bug.cgi?id=61740
9015
Enable TextureMapper on Windows+Symbian, disabling the direct OpenGL path. This would mean that
9016
for now QtWebKit on Windows/Symbian would use the Qt backend for TextureMapper.
9018
* WebCoreSupport/PageClientQt.cpp:
9019
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
9021
2011-06-07 Aravind Akella <aravind.akella@nokia.com>
9023
Reviewed by Laszlo Gombos.
9025
[Qt][Symbian] API test failure qdeclarativewebview
9026
https://bugs.webkit.org/show_bug.cgi?id=59481
9028
QML files cannot be loaded on Symbian due to difference
9029
in capabilities between qmlwebkitplugin.dll and Qtwebkit.dll.
9030
A PlatSec error that Qtwebkit.dll has "DRM AllFiles" capabilities
9031
missing is observed when dynamically loading the QML plugin.
9033
* declarative/declarative.pro: Match capabilities in QtWebKit.pro.
9034
* symbian/platformplugin/platformplugin.pro: Match capabilities with the other 2 DLLs.
9035
Also remove TARGET.VID from platformplugin, as it's not used in any other Qt WebKit DLL,
9036
and causes build warnings about undefined VENDOR_VID.
9037
* tests/tests.pri: Add WriteDeviceData capability for API tests.
9039
2011-06-04 Robert Hogan <robert@webkit.org>
9041
Reviewed by Andreas Kling.
9043
[Qt] Fix and unskip acid2
9044
https://bugs.webkit.org/show_bug.cgi?id=62089
9046
shouldFallBack() tells the DOM if it should attempt to render
9047
the next nested <object> if its parent fails to load.
9049
This fix is only required for the fast/css version of the ACID2
9050
test, which loads a non-existent file:// url. The HTTP version of the
9051
test already passes because the loader will render fallback content
9052
on a failed HTTP load without delegating the decision to the client
9053
( see MainResourceLoader::continueAfterContentPolicy).
9055
Some ports also check for WebKitErrorPluginWillHandleLoad when deciding
9056
what to return. This error isn't currently set by Qt so we don't check
9057
it. (Other ports set it when the erring document is a MediaDocument, maybe
9058
we should do that too at some point).
9060
* WebCoreSupport/FrameLoaderClientQt.cpp:
9061
(WebCore::FrameLoaderClientQt::shouldFallBack):
9063
2011-06-03 Rafael Brandao <rafael.lobo@openbossa.org>
9065
Reviewed by Andreas Kling.
9067
[Qt] It made two Qt API tests fail
9068
https://bugs.webkit.org/show_bug.cgi?id=58847
9070
Modified failing test's base url so it could get a valid origin
9071
and make use of local storage. Also added another test that checks
9072
local storage visibility in both scenarios.
9074
* tests/qwebpage/tst_qwebpage.cpp:
9075
(tst_QWebPage::testOptionalJSObjects):
9076
(checkLocalStorageVisibility):
9077
(tst_QWebPage::testLocalStorageVisibility):
9079
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
9081
Reviewed by Andreas Kling.
9083
[Qt] Warning fixes on comparisons between a signed and an unsigned.
9085
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
9086
(DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
9087
(DumpRenderTreeSupportQt::nodesFromRect):
9089
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
9091
Reviewed by Andreas Kling.
9093
To support building namespaced Qt, we require that forward-declarations
9094
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
9096
* WebCoreSupport/FrameLoaderClientQt.h:
9098
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
9100
Unreviewed build fix after r87902.
9102
To support building namespaced Qt, we require that forward-declarations
9103
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE but
9104
only on classes inside Qt.
9106
* WebCoreSupport/DumpRenderTreeSupportQt.h:
9108
2011-06-03 Alexis Menard <alexis.menard@openbossa.org>
9110
Reviewed by Benjamin Poulain.
9112
Some warning fixes. Values in switch not handled, and
9113
a comparison between a signed and an unsigned.
9116
(QWebPagePrivate::inputMethodEvent):
9117
(QWebPagePrivate::dynamicPropertyChangeEvent):
9120
2011-06-02 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
9122
Reviewed by Andreas Kling.
9124
[Qt] Fix enum order in qwebpage.h public API header
9125
https://bugs.webkit.org/show_bug.cgi?id=61959
9127
Since qwebpage.h is a public header, we can't change the values of
9128
the enumerations. This patch moves the new enumeration to the end
9129
of the list. As a bonus, adds a missing entry in
9130
editorCommandWebActions table.
9135
2011-06-02 Andreas Kling <kling@webkit.org>
9137
Rubber-stamped by Simon Hausmann.
9139
Remove Qt's precompiled header hack as it was broken, and was not even
9140
used unless building WebKit inside a Qt tree.
9142
* WebKit_pch.h: Removed.
9144
2011-06-02 Andreas Kling <kling@webkit.org>
9146
Unreviewed build fix.
9148
To support building namespaced Qt, we require that forward-declarations
9149
of Qt classes be wrapped in QT_BEGIN_NAMESPACE and QT_END_NAMESPACE.
9151
* WebCoreSupport/DumpRenderTreeSupportQt.h:
9153
2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
9155
Reviewed by Kenneth Rohde Christiansen.
9157
[Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
9158
https://bugs.webkit.org/show_bug.cgi?id=59345
9160
KURL and QUrl disagree whether certain URLs are valid or not. The regression here
9161
was caused by the fact that now KURL accepts "http:/example.com" (note only one
9162
slash) and our test case used a strange edge case that's transformed into a
9163
"one-slash" URL that now KURL can handle.
9165
QtWebKit approach in this case is to do a best effort and accept the QUrl if KURL
9166
can understand it. So I've updated the test to use a more meaningful example and
9167
show that an invalid URL gets converted to a valid URL if possible.
9169
* tests/qwebframe/tst_qwebframe.cpp:
9170
(tst_QWebFrame::setUrlToInvalid):
9172
2011-06-01 Andreas Kling <kling@webkit.org>
9174
Reviewed by Benjamin Poulain.
9176
REGRESSION: [Qt] QNetworkReply delivered by the unsupportedContent() signal does not contain downloaded data
9177
https://bugs.webkit.org/show_bug.cgi?id=49650
9179
Defer emission of QWebPage::unsupportedContent() until we're back in the event loop.
9180
This lets the QNAM backend finish with the reply without handing over ownership to the user code.
9182
No new tests since this doesn't fail for qrc:// or file:// URLs and our tests can't depend on http:// URLs.
9184
To correctly solve this issue, we need changes to Qt, tracked here:
9185
http://bugreports.qt.nokia.com/browse/QTBUG-18718
9187
* WebCoreSupport/FrameLoaderClientQt.cpp:
9188
(WebCore::FrameLoaderClientQt::setFrame):
9189
(WebCore::FrameLoaderClientQt::download):
9190
* WebCoreSupport/FrameLoaderClientQt.h:
9192
2011-06-01 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
9194
Reviewed by Tor Arne Vestbø.
9196
[Qt] Rewrite tst_QDeclarativeWebView::multipleWindows() to not depend on Grid internals
9197
https://bugs.webkit.org/show_bug.cgi?id=61739
9199
The skipped test was imported from Qt source repository, and used private headers
9200
to peek in the QML Grid element. This patch changes the QML used to expose the
9201
information we want to test: number of pages opened and the first page opened.
9203
* tests/qdeclarativewebview/resources/newwindows.html:
9204
Added <body> tags. We have no reason to not use them in the test.
9206
* tests/qdeclarativewebview/resources/newwindows.qml:
9207
Moved the timer out of the page component, used anchors for setting webview size,
9208
changed the way we count pages opened. Also changed coding style a bit.
9210
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
9211
(tst_QDeclarativeWebView::multipleWindows):
9212
We now look for properties with the information we want in the rootItem: pagesOpened and
9215
2011-05-31 Rafael Brandao <rafael.lobo@openbossa.org>
9217
Reviewed by Andreas Kling.
9219
[Qt] tst_QWebFrame::render() failing
9220
https://bugs.webkit.org/show_bug.cgi?id=60893
9222
The test was expecting the frame contents to be already loaded
9223
before rendering it into a QPicture. Renamed the test to fit
9224
its real purpose more accordingly.
9226
* tests/qwebframe/tst_qwebframe.cpp:
9227
(tst_QWebFrame::renderGeometry):
9229
2011-05-30 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
9231
Reviewed by Andreas Kling.
9233
[Qt] Fix unnecessary wait in API autotest tst_QWebFrame::scrollbarsOff
9234
https://bugs.webkit.org/show_bug.cgi?id=61711
9236
The loadFinished() signal was emitted directly inside the call for setHtml, so
9237
the test was waiting the loadFinished() signal with a big timeout. Change this by
9238
a very small timeout and a verification with signal spy.
9240
In practice, setHtml() will either directly call loadFinished() or queue it to
9241
the next event loop run, and test will work for both situations.
9243
* tests/qwebframe/tst_qwebframe.cpp:
9244
(tst_QWebFrame::scrollbarsOff):
9246
2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>
9248
Reviewed by Kenneth Rohde Christiansen.
9250
[Texmap][Qt] Disable accelerated plugins/media in until they're working.
9251
https://bugs.webkit.org/show_bug.cgi?id=61687
9253
Turn off accelerated compositing for media and plugins when in texture-mapper.
9255
* Api/qwebsettings.cpp:
9256
(QWebSettingsPrivate::apply):
9258
2011-05-28 Adam Barth <abarth@webkit.org>
9260
Reviewed by Alexey Proskuryakov.
9262
Audit all uses of KURL::prettyURL
9263
https://bugs.webkit.org/show_bug.cgi?id=61201
9265
Update callers of prettyURL to just call string.
9267
* WebCoreSupport/ChromeClientQt.cpp:
9268
(WebCore::ChromeClientQt::mouseDidMoveOverElement):
9269
* WebCoreSupport/FrameLoaderClientQt.cpp:
9270
(WebCore::FrameLoaderClientQt::updateGlobalHistory):
9271
(WebCore::FrameLoaderClientQt::cancelledError):
9272
(WebCore::FrameLoaderClientQt::blockedError):
9273
(WebCore::FrameLoaderClientQt::objectContentType):
9274
(WebCore::FrameLoaderClientQt::createPlugin):
9276
2011-05-27 Alexis Menard <alexis.menard@openbossa.org>
9278
Reviewed by Csaba Osztrogonác.
9280
[Qt] Fix tst_QGraphicsWebView::setPalette(inactiveBG) autotest
9281
https://bugs.webkit.org/show_bug.cgi?id=61044
9283
Make sure to set the active window on the application too.
9285
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
9286
(tst_QGraphicsWebView::setPalette):
9288
2011-05-26 Alexis Menard <alexis.menard@openbossa.org>
9290
Unreviewed build fix for Qt and QuickTime backend.
9292
r87328 added a new system interface, we need to add it too.
9294
* WebCoreSupport/WebSystemInterface.mm:
9295
(InitWebCoreSystemInterface):
9297
2011-05-25 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
9299
Reviewed by Andreas Kling.
9301
[Qt] JSC bridge: implement __qt_sender__ without using Scope Chain
9302
https://bugs.webkit.org/show_bug.cgi?id=61343
9304
Create a '__qt_sender__' property in the global object, that returns the top of
9305
the qtSenderStack. This is an alternative implementation for the feature of
9306
providing a way for a function (acting as a Qt 'slot') discover which object
9307
emitted the signal that caused it to be executed.
9309
This reduces the coupling of the Qt bridge and JSC internal implementation. The
9310
patch tries to use as much JSC public API as possible.
9312
This behavior is covered by the tst_QWebFrame::connectAndDisconnect() auto test.
9314
* WebCoreSupport/FrameLoaderClientQt.cpp:
9315
(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
9316
Instead of emitting the QWebPage::javaScriptWindowObjectCleared() directly, calls
9317
a QWebPagePrivate function to do it.
9319
* Api/qwebframe_p.h:
9320
* Api/qwebframe.cpp:
9321
(QWebFramePrivate::didClearedWindowObject):
9322
Before emitting the signal mentioned, adds the '__qt_sender__' to the fresh
9326
Returns the JSObjectRef corresponding to the top of qtSenderStack.
9328
(QWebFramePrivate::addQtSenderToGlobalObject):
9329
Create a property with a qtSenderCallback as getter function in the global object.
9331
2011-05-25 Alexis Menard <alexis.menard@openbossa.org>
9333
Reviewed by Eric Carlson.
9335
[Qt] Enable usage of QuickTime mediaplayer for the Qt port on Mac.
9336
https://bugs.webkit.org/show_bug.cgi?id=61279
9338
Enable the usage of QuickTime backend for the Qt port. It can be enabled by
9339
passing DEFINES+=USE_QTKIT=1 when calling build-webkit.
9342
(QWebPagePrivate::QWebPagePrivate):
9344
* WebCoreSupport/FullScreenVideoQt.cpp:
9345
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
9346
(WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
9347
(WebCore::FullScreenVideoQt::isValid):
9348
* WebCoreSupport/WebSystemInterface.h: Added.
9349
* WebCoreSupport/WebSystemInterface.mm: Added.
9350
(InitWebCoreSystemInterface):
9352
2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
9354
Reviewed by Andreas Kling.
9356
[Qt] fast/css/disabled-author-styles.html failed
9357
https://bugs.webkit.org/show_bug.cgi?id=61438
9359
Provided API setAuthorAndUserStylesEnabled for DumpRenderTree.
9361
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
9362
(DumpRenderTreeSupportQt::setAuthorAndUserStylesEnabled):
9363
* WebCoreSupport/DumpRenderTreeSupportQt.h:
9365
2011-05-24 Adam Barth <abarth@webkit.org>
9367
Reviewed by Eric Seidel.
9369
Add FIXME comments about removing FrameLoader::isProcessingUserGesture
9370
https://bugs.webkit.org/show_bug.cgi?id=61395
9372
* WebCoreSupport/FrameLoaderClientQt.cpp:
9373
(drtPrintFrameUserGestureStatus):
9375
2011-05-23 Luiz Agostini <luiz.agostini@openbossa.org>
9377
Reviewed by Andreas Kling.
9379
[Qt] When opening a combo-box the popup renders badly.
9380
https://bugs.webkit.org/show_bug.cgi?id=61288
9382
Removing combobox palette changes from QtFallbackWebPopup::show() because they
9383
are causing rendering problems for some styles.
9385
The changes in palette are not needed because the background and foreground
9386
colors are already set by QStandardItem::setBackground() and QStandardItem::setForeground()
9387
in method QtFallbackWebPopup::populate().
9389
* WebCoreSupport/QtFallbackWebPopup.cpp:
9390
(WebCore::QtFallbackWebPopup::show):
9392
2011-05-23 Joe Wild <joseph.wild@nokia.com>
9394
Reviewed by Andreas Kling.
9396
[Qt] The Qt WebKit Symbian .def file needs to be updated so Symbian will build
9397
https://bugs.webkit.org/show_bug.cgi?id=61200
9399
* symbian/eabi/QtWebKitu.def:
9401
2011-05-22 Hui Huang <hui.2.huang@nokia.com>, Yi Shen <yi.4.shen@nokia.com>
9403
Reviewed by Laszlo Gombos.
9405
[Qt] Upstream Symbian platform plugin
9406
https://bugs.webkit.org/show_bug.cgi?id=58435
9408
Upstream Symbian platform plugin with html5 video player.
9410
* symbian/platformplugin/HTML5VideoPlugin.cpp: Added.
9411
(HTML5FullScreenVideoHandler::HTML5FullScreenVideoHandler):
9412
(HTML5FullScreenVideoHandler::enterFullScreen):
9413
(HTML5FullScreenVideoHandler::exitFullScreen):
9414
(HTML5FullScreenVideoHandler::onPlayerError):
9415
(HTML5FullScreenVideoHandler::onPlayerStateChanged):
9416
(HTML5FullScreenVideoHandler::onMediaStatusChanged):
9417
(HTML5VideoPlugin::supportsExtension):
9418
(HTML5VideoPlugin::createExtension):
9419
* symbian/platformplugin/HTML5VideoPlugin.h: Added.
9420
(HTML5FullScreenVideoHandler::requiresFullScreenForVideoPlayback):
9421
(HTML5FullScreenVideoHandler::isFullScreen):
9422
(HTML5FullScreenVideoHandler::updateScreenRect):
9423
* symbian/platformplugin/HTML5VideoWidget.cpp: Added.
9424
(HTML5VideoWidget::HTML5VideoWidget):
9425
(HTML5VideoWidget::setDuration):
9426
(HTML5VideoWidget::mousePressEvent):
9427
(HTML5VideoWidget::onPlayerStopped):
9428
(HTML5VideoWidget::onPlayerError):
9429
(HTML5VideoWidget::onEndOfMedia):
9430
(HTML5VideoWidget::onBufferingMedia):
9431
(HTML5VideoWidget::onBufferedMedia):
9432
(HTML5VideoWidget::onControlClicked):
9433
(HTML5VideoWidget::onPositionChanged):
9434
(HTML5VideoWidget::onSliderMoved):
9435
(HTML5VideoWidget::onCloseClicked):
9436
(HTML5VideoWidget::showFullScreen):
9437
(HTML5VideoWidget::setVolume):
9438
* symbian/platformplugin/HTML5VideoWidget.h: Added.
9439
* symbian/platformplugin/OverlayWidget.cpp: Added.
9440
(OverlayWidget::OverlayWidget):
9441
(OverlayWidget::~OverlayWidget):
9442
(OverlayWidget::setDuration):
9443
(OverlayWidget::setPosition):
9444
(OverlayWidget::setVolume):
9445
(OverlayWidget::mousePressEvent):
9446
(OverlayWidget::onPlayerStopped):
9447
(OverlayWidget::onPlayerError):
9448
(OverlayWidget::onEndOfMedia):
9449
(OverlayWidget::onBufferingMedia):
9450
(OverlayWidget::onBufferedMedia):
9451
(OverlayWidget::timeToString):
9452
(OverlayWidget::applyStyleSheet):
9453
(OverlayWidget::onControlClicked):
9454
(OverlayWidget::onSliderMoved):
9455
(OverlayWidget::onSoundClicked):
9456
(OverlayWidget::onCloseClicked):
9457
(OverlayWidget::onVolumeSliderReleased):
9458
(OverlayWidget::onVolumeSliderMoved):
9459
(OverlayWidget::onTimerTimeout):
9460
(OverlayWidget::showFullScreen):
9461
* symbian/platformplugin/OverlayWidget.h: Added.
9462
* symbian/platformplugin/PlayerButton.cpp: Added.
9463
(PlayerButton::PlayerButton):
9464
(PlayerButton::event):
9465
* symbian/platformplugin/PlayerButton.h: Added.
9466
* symbian/platformplugin/PlayerLabel.cpp: Added.
9467
(PlayerLabel::PlayerLabel):
9468
(PlayerLabel::onPlayerError):
9469
(PlayerLabel::startBufferingAnimation):
9470
(PlayerLabel::stopBufferingAnimation):
9471
(PlayerLabel::onAnimationTimeout):
9472
* symbian/platformplugin/PlayerLabel.h: Added.
9473
* symbian/platformplugin/WebPlugin.cpp:
9474
(WebPlugin::createExtension):
9475
* symbian/platformplugin/images: Added.
9476
* symbian/platformplugin/images/button_cannotplay.png: Added.
9477
* symbian/platformplugin/images/button_close.png: Added.
9478
* symbian/platformplugin/images/button_pause.png: Added.
9479
* symbian/platformplugin/images/button_play.png: Added.
9480
* symbian/platformplugin/images/button_sound_off.png: Added.
9481
* symbian/platformplugin/images/button_sound_on.png: Added.
9482
* symbian/platformplugin/images/loading_buffering_1.png: Added.
9483
* symbian/platformplugin/images/loading_buffering_2.png: Added.
9484
* symbian/platformplugin/images/loading_buffering_3.png: Added.
9485
* symbian/platformplugin/images/loading_buffering_4.png: Added.
9486
* symbian/platformplugin/platformplugin.pro:
9487
* symbian/platformplugin/platformplugin.qrc: Added.
9488
* symbian/platformplugin/qss: Added.
9489
* symbian/platformplugin/qss/OverlayWidget.qss: Added.
9491
2011-05-22 Robert Hogan <robert@webkit.org>
9493
Reviewed by Kenneth Rohde Christiansen.
9495
Fix policyDelegate in Qt DRT
9497
https://bugs.webkit.org/show_bug.cgi?id=61247
9499
Use the 'policy delegate' implemented in FrameLoaderClient
9500
for layout tests. The partial implementation in DumpRenderTreeQt
9503
* WebCoreSupport/FrameLoaderClientQt.cpp:
9504
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
9506
2011-05-22 Andrew Wason <rectalogic@rectalogic.com>
9508
Reviewed by Benjamin Poulain.
9510
[Qt] Implement toImageData() in QtWebKit Bridge
9511
https://bugs.webkit.org/show_bug.cgi?id=60897
9513
* docs/qtwebkit-bridge.qdoc:
9514
* docs/webkitsnippets/qtwebkit_bridge_snippets.cpp:
9516
Document Qt bridge toImageData() feature.
9517
* tests/hybridPixmap/test.html:
9518
* tests/hybridPixmap/widget.cpp:
9521
* tests/hybridPixmap/widget.h:
9522
Add tests for Qt bridge toImageData() feature.
9524
2011-05-20 Simon Fraser <simon.fraser@apple.com>
9526
Reviewed by Sam Weinig.
9528
numberOfActiveAnimations() can include animations from documents in the page cache
9529
https://bugs.webkit.org/show_bug.cgi?id=53641
9531
Pass the Frame's document as the one to count animations on.
9533
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
9534
(DumpRenderTreeSupportQt::numberOfActiveAnimations):
9536
2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
9538
Reviewed by Benjamin Poulain.
9540
[Qt] tst_QWebElement::style() fails because QWebElement::InlineStyle doesn't work as expected
9541
https://bugs.webkit.org/show_bug.cgi?id=60372
9543
* tests/qwebelement/tst_qwebelement.cpp: Mark failing test case as expected fail.
9544
(tst_QWebElement::style):
9546
2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
9548
Reviewed by Benjamin Poulain.
9550
[Qt] Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
9551
https://bugs.webkit.org/show_bug.cgi?id=61042
9553
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Mark failing test cases as expected fails.
9554
(tst_QDeclarativeWebView::basicProperties):
9555
(tst_QDeclarativeWebView::historyNav):
9557
2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
9559
Reviewed by Benjamin Poulain.
9561
[Qt] Fix tst_QWebPage::testOptionalJSObjects() autotest
9562
https://bugs.webkit.org/show_bug.cgi?id=61045
9564
* tests/qwebpage/tst_qwebpage.cpp:
9565
(tst_QWebPage::testOptionalJSObjects): Mark failing test cases as expected fails.
9567
2011-05-20 Peter Varga <pvarga@webkit.org>
9569
Reviewed by Simon Hausmann.
9571
[Qt][V8] Use qtscript-staging's shipped version of V8 when building with --v8
9572
https://bugs.webkit.org/show_bug.cgi?id=56649
9574
Use the provided V8 and functionality of
9575
http://qt.gitorious.org/+qt-developers/qt/qtscript-staging to build QtWebKit+V8.
9576
Based on the original patch of Andras Becsi <abecsi@webkit.org>.
9578
* Api/qwebframe.cpp:
9579
(QWebFrame::addToJavaScriptWindowObject): Fix QString deprecated
9581
* QtWebKit.pro: Adding the V8 library should happen in the final build
9583
* WebCoreSupport/ChromeClientQt.cpp: Add missing head.
9584
* WebCoreSupport/DumpRenderTreeSupportQt.cpp: Ditto.
9586
2011-05-20 Csaba Osztrogonác <ossy@webkit.org>
9588
Reviewed by Benjamin Poulain.
9590
[Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762
9591
https://bugs.webkit.org/show_bug.cgi?id=59345
9593
* tests/qwebframe/tst_qwebframe.cpp:
9594
(tst_QWebFrame::setUrlToInvalid): Mark failing test cases as expected fails.
9596
2011-05-19 Zsolt Fehér <h490267@stud.u-szeged.hu>
9598
Reviewed by Csaba Osztrogonác.
9600
[Qt] Implement eventSender.scalePageBy
9601
https://bugs.webkit.org/show_bug.cgi?id=60015
9603
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
9604
(DumpRenderTreeSupportQt::scalePageBy):
9605
* WebCoreSupport/DumpRenderTreeSupportQt.h:
9607
2011-05-18 Yi Shen <yi.4.shen@nokia.com>
9609
Reviewed by Andreas Kling.
9611
[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
9612
https://bugs.webkit.org/show_bug.cgi?id=33179
9614
Remove the implementation of the handleInputMethodKeydown, which introduces
9615
a regression(r82243) on Linux. Also, add more Api tests for the EnterKey event.
9617
* WebCoreSupport/EditorClientQt.cpp:
9618
(WebCore::EditorClientQt::handleInputMethodKeydown): Remove implementation.
9619
* tests/qwebpage/tst_qwebpage.cpp:
9620
(tst_QWebPage::inputMethods): Add more tests.
9622
2011-05-18 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
9624
Reviewed by Csaba Osztrogonác.
9626
[Qt] Implement layoutTestController.setValueForUser()
9627
https://bugs.webkit.org/show_bug.cgi?id=60956
9629
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
9630
(DumpRenderTreeSupportQt::setValueForUser):
9631
* WebCoreSupport/DumpRenderTreeSupportQt.h:
9633
2011-05-16 Robert Hogan <robert@webkit.org>
9635
Reviewed by Kenneth Rohde Christiansen.
9637
plugins/invalidate_rect.html fails on linux ports
9639
Add ChromeClientQt::allowsAcceleratedCompositing().
9641
https://bugs.webkit.org/show_bug.cgi?id=54051
9643
* WebCoreSupport/ChromeClientQt.cpp:
9644
(WebCore::ChromeClientQt::allowsAcceleratedCompositing):
9645
* WebCoreSupport/ChromeClientQt.h:
9647
2011-05-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
9649
Reviewed by Andreas Kling.
9651
[Qt] Simplify syntax in test code to make prepare-ChangeLog less confused
9652
https://bugs.webkit.org/show_bug.cgi?id=60978
9654
Backslash to escape newlines was confusing both prepare-ChangeLog and the
9655
QtCreator highlight system.
9657
* tests/qwebframe/tst_qwebframe.cpp:
9658
(tst_QWebFrame::evalJSV):
9659
Remove usage of backslash to escape newlines in string literal.
9661
2011-05-17 Young Han Lee <joybro@company100.net>
9663
Reviewed by Csaba Osztrogonác.
9665
[Texmap][Qt] Enable strict PassOwnPtr for Qt with texmap enabled.
9666
https://bugs.webkit.org/show_bug.cgi?id=60947
9668
* WebCoreSupport/PageClientQt.cpp:
9669
(WebCore::PageClientQWidget::setRootGraphicsLayer):
9671
2011-05-16 Jon Lee <jonlee@apple.com>
9673
Reviewed by Simon Fraser.
9675
Can't horizontally scroll iframes and overflow because wheel events are always accepted
9676
https://bugs.webkit.org/show_bug.cgi?id=60779
9678
* WebCoreSupport/ChromeClientQt.h:
9679
(WebCore::ChromeClientQt::shouldRubberBandInDirection): Default impl of new ChromeClient method
9680
(WebCore::ChromeClientQt::numWheelEventHandlersChanged): Default impl of new ChromeClient method
9682
2011-05-16 Andreas Kling <kling@webkit.org>
9684
Reviewed by Kenneth Rohde Christiansen.
9686
REGRESSION(r83820): [Qt] Accelerated compositing no longer works in QGraphicsWebView.
9687
https://bugs.webkit.org/show_bug.cgi?id=60892
9689
Don't set the ItemClipsChildrenToShape flag for the root platform layer,
9690
since that is now the overflow controls layer. The clip layer, which was
9691
previously the root platform layer, already gets the flag by way of
9692
the GraphicsLayer mask-to-bounds flag.
9694
* WebCoreSupport/PageClientQt.cpp:
9695
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
9697
2011-05-16 Adam Barth <abarth@webkit.org>
9699
Partial revert of r86537. FullScreenVideoQt.h can't depend on OwnPtr.h
9700
because moc_FullScreenVideoQt.cpp fails to include config.h.
9701
Apparently, having moc_FullScreenVideoQt.cpp properly include config.h
9702
is hard, so we're going back to manual new and delete for this class.
9705
* WebCoreSupport/FullScreenVideoQt.cpp:
9706
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
9707
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
9708
* WebCoreSupport/FullScreenVideoQt.h:
9710
2011-05-16 Adam Barth <abarth@webkit.org>
9712
Sigh. This code is somewhat crazy.
9714
* WebCoreSupport/InspectorClientQt.cpp:
9715
(WebCore::InspectorClientQt::openInspectorFrontend):
9717
2011-05-16 Adam Barth <abarth@webkit.org>
9719
Attempt to fix Qt build. (Strict PassOwnPtr fix.)
9721
This patch requires some slightly fancy footwork.
9723
* WebCoreSupport/InspectorClientQt.cpp:
9724
(WebCore::InspectorClientQt::openInspectorFrontend):
9725
(WebCore::InspectorFrontendClientQt::InspectorFrontendClientQt):
9727
2011-05-16 Adam Barth <abarth@webkit.org>
9731
* WebCoreSupport/PopupMenuQt.h:
9733
2011-05-16 Adam Barth <abarth@webkit.org>
9735
[Qt] QtPlatformPlugin create methods should use PassOwnPtr
9736
https://bugs.webkit.org/show_bug.cgi?id=60873
9738
This change is slightly more than a build fix because the patch kind of
9739
spidered a bit while I was trying to fix the build the "right way."
9740
Hopefully nothing here is controversial.
9743
(QWebPagePrivate::adjustPointForClicking):
9744
* WebCoreSupport/ChromeClientQt.cpp:
9745
(WebCore::ChromeClientQt::createSelectPopup):
9746
* WebCoreSupport/FullScreenVideoQt.cpp:
9747
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
9748
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
9749
* WebCoreSupport/FullScreenVideoQt.h:
9750
* WebCoreSupport/NotificationPresenterClientQt.cpp:
9751
(WebCore::NotificationWrapper::NotificationWrapper):
9752
(WebCore::NotificationPresenterClientQt::displayNotification):
9753
* WebCoreSupport/PopupMenuQt.cpp:
9754
(WebCore::PopupMenuQt::PopupMenuQt):
9755
(WebCore::PopupMenuQt::~PopupMenuQt):
9756
(WebCore::PopupMenuQt::show):
9757
* WebCoreSupport/PopupMenuQt.h:
9758
* WebCoreSupport/QtPlatformPlugin.cpp:
9759
(WebCore::QtPlatformPlugin::createSelectInputMethod):
9760
(WebCore::QtPlatformPlugin::createNotificationPresenter):
9761
(WebCore::QtPlatformPlugin::createHapticFeedbackPlayer):
9762
(WebCore::QtPlatformPlugin::createTouchModifier):
9763
(WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
9764
* WebCoreSupport/QtPlatformPlugin.h:
9765
(WebCore::QtPlatformPlugin::QtPlatformPlugin):
9767
2011-05-15 Adam Barth <abarth@webkit.org>
9769
Attempt to fix the Qt build. (Strict PassOwnPtr fix.)
9771
* Api/qgraphicswebview.cpp:
9772
(QGraphicsWebViewPrivate::detachCurrentPage):
9773
(QGraphicsWebView::setPage):
9775
(QWebPage::setView):
9777
2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>
9779
Unreviewed, rolling out r86504.
9780
http://trac.webkit.org/changeset/86504
9781
https://bugs.webkit.org/show_bug.cgi?id=60853
9783
"Broke Qt EventSender in editing/selection tests" (Requested
9784
by mwenge on #webkit).
9786
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
9787
* WebCoreSupport/DumpRenderTreeSupportQt.h:
9789
2011-05-12 Robert Hogan <robert@webkit.org>
9791
Reviewed by Benjamin Poulain.
9793
[Qt] fix http/tests/plugins/plugin-document-has-focus.html
9794
https://bugs.webkit.org/show_bug.cgi?id=60722
9796
QWebPage::setView() will display the browser window, so
9797
implement a private version that does just enough to
9798
satisfy EventSender's requirement to install an event
9799
filter on a page's web view.
9801
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
9802
(DumpRenderTreeSupportQt::setView):
9803
* WebCoreSupport/DumpRenderTreeSupportQt.h:
9805
2011-05-13 Sheriff Bot <webkit.review.bot@gmail.com>
9807
Unreviewed, rolling out r86447.
9808
http://trac.webkit.org/changeset/86447
9809
https://bugs.webkit.org/show_bug.cgi?id=60809
9811
"Broke some uses of EventSender object on Qt" (Requested by
9814
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
9815
* WebCoreSupport/DumpRenderTreeSupportQt.h:
9817
2011-05-13 Sam Weinig <sam@webkit.org>
9819
Reviewed by Anders Carlsson.
9821
Prune #includes from FrameView.h (Part 2)
9822
https://bugs.webkit.org/show_bug.cgi?id=60748
9824
- Update files that were depending on FrameView.h #including Frame.h or
9827
* Api/qgraphicswebview.cpp:
9828
* WebCoreSupport/ChromeClientQt.cpp:
9830
2011-05-13 Robert Hogan <robert@webkit.org>
9832
Reviewed by Benjamin Poulain.
9834
[Qt] fix http/tests/plugins/plugin-document-has-focus.html
9835
https://bugs.webkit.org/show_bug.cgi?id=60722
9837
QWebPage::setView() will display the browser window, so
9838
implement a private version that does just enough to
9839
satisfy EventSender's requirement to install an event
9840
filter on a page's web view.
9842
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
9843
(DumpRenderTreeSupportQt::setView):
9844
* WebCoreSupport/DumpRenderTreeSupportQt.h:
9846
2011-05-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
9848
Reviewed by nobody, build fix.
9850
[Qt] Fix build on MSVC.
9852
qobject_cast<> requires the class to be exported on MSVC,
9853
removing it since the code that needs it is commented out for
9856
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
9857
(tst_QDeclarativeWebView::elementAreaAt):
9859
2011-05-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
9861
Reviewed by nobody, build fix.
9863
[Qt] Fix build on MSVC by only enabling tst_MIMESniffing on linux.
9867
2011-05-12 Young Han Lee <joybro@company100.net>
9869
Reviewed by Kenneth Rohde Christiansen.
9871
[Qt] Implement layoutTestController.layerTreeAsText()
9872
https://bugs.webkit.org/show_bug.cgi?id=60367
9874
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
9875
(DumpRenderTreeSupportQt::layerTreeAsText):
9876
* WebCoreSupport/DumpRenderTreeSupportQt.h:
9878
2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
9880
Reviewed by Kenneth Rohde Christiansen.
9882
[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
9883
https://bugs.webkit.org/show_bug.cgi?id=60439
9885
Patch 10/12: Glue the TextureMapper refactoring into Webkit(1).
9886
1. Pass a GraphicsLayer* instead of a PlatformLayer* to the QWebPageClient.
9887
2. Set parameters in TextureMapper/TextureMapperNode instead of passing them in an options argument.
9888
3. Rename PlatformLayerProxyQt to TextureMapperNodeClient
9890
* Api/qwebframe.cpp:
9891
(QWebFramePrivate::renderCompositedLayers):
9893
* Api/qwebframe_p.h:
9894
(QWebFramePrivate::QWebFramePrivate):
9895
* WebCoreSupport/ChromeClientQt.cpp:
9896
(WebCore::ChromeClientQt::attachRootGraphicsLayer):
9897
* WebCoreSupport/PageClientQt.cpp:
9898
(WebCore::TextureMapperNodeClientQt::TextureMapperNodeClientQt):
9899
(WebCore::TextureMapperNodeClientQt::scroll):
9900
(WebCore::TextureMapperNodeClientQt::setTextureMapper):
9901
(WebCore::TextureMapperNodeClientQt::~TextureMapperNodeClientQt):
9902
(WebCore::TextureMapperNodeClientQt::computeLastModifiedRect):
9903
(WebCore::TextureMapperNodeClientQt::syncRootLayer):
9904
(WebCore::TextureMapperNodeClientQt::rootNode):
9905
(WebCore::PageClientQWidget::setRootGraphicsLayer):
9906
(WebCore::PageClientQWidget::syncLayers):
9907
(WebCore::PageClientQWidget::~PageClientQWidget):
9908
(WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget):
9909
(WebCore::PageClientQGraphicsWidget::update):
9910
(WebCore::PageClientQGraphicsWidget::syncLayers):
9911
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
9912
(WebCore::PageClientQGraphicsWidget::markForSync):
9913
* WebCoreSupport/PageClientQt.h:
9914
(WebCore::PageClientQWidget::PageClientQWidget):
9915
(WebCore::PageClientQGraphicsWidget::PageClientQGraphicsWidget):
9916
(WebCore::PageClientQGraphicsWidget::syncLayersTimeout):
9919
2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
9921
Reviewed by Kenneth Rohde Christiansen.
9923
[Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
9924
https://bugs.webkit.org/show_bug.cgi?id=60439
9926
Patch 4/12: Update the settings to enable accelerated compositing for all the relevant settings
9929
* Api/qwebsettings.cpp:
9930
(qt_networkAccessAllowed):
9931
(QWebSettingsPrivate::apply):
9933
2011-05-11 Sam Weinig <sam@webkit.org>
9935
Reviewed by Eric Seidel.
9937
Stop including Console.h just to get Console enum types
9938
https://bugs.webkit.org/show_bug.cgi?id=60607
9940
Move MessageSource, MessageType and MessageLevel into its own
9941
header and cleanup surrounding classes.
9943
* Api/qwebelement.cpp:
9945
2011-05-10 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
9947
Reviewed by Csaba Osztrogonác.
9949
[Qt] Increment QtWebKit trunk version to 4.10.0
9950
https://bugs.webkit.org/show_bug.cgi?id=60549
9952
QtWebKit-2.2 (branched) will be 4.9.0, so we need to
9953
increase the trunk version by 1.
9955
* qt_webkit_version.pri:
9957
2011-05-10 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
9959
Reviewed by Csaba Osztrogonác.
9961
[Qt] tst_QWebPage creates temporary files in the current working dir
9962
https://bugs.webkit.org/show_bug.cgi?id=60497
9964
tst_QWebPage was using QDir::currentPath when creating temporary dirs
9965
and leaving them after the test was run. I basically borrowed the fix
9966
from tst_QDeclarativeWebView.
9968
* tests/qwebpage/tst_qwebpage.cpp:
9970
(tst_QWebPage::tmpDirPath):
9971
(tst_QWebPage::cleanupFiles):
9972
(tst_QWebPage::database):
9973
(tst_QWebPage::multiplePageGroupsAndLocalStorage):
9975
2011-05-09 Chang Shu <cshu@webkit.org>
9977
Reviewed by Kenneth Rohde Christiansen.
9979
[Qt] DumpRenderTreeQt needs an implementation of unmarkText
9980
https://bugs.webkit.org/show_bug.cgi?id=60499
9982
The implementation is similar to gtk.
9984
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
9985
(DumpRenderTreeSupportQt::confirmComposition):
9986
* WebCoreSupport/DumpRenderTreeSupportQt.h:
9988
2011-05-07 Joe Mason <jmason@rim.com>
9990
Reviewed by Daniel Bates.
9992
FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
9993
https://bugs.webkit.org/show_bug.cgi?id=52211
9995
Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
9997
* WebCoreSupport/FrameLoaderClientQt.cpp:
9998
(WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
10000
2011-05-06 Kent Tamura <tkent@chromium.org>
10002
Reviewed by Ryosuke Niwa.
10004
Eliminate WebCore/dom/InputElement.{cpp,h}
10005
https://bugs.webkit.org/show_bug.cgi?id=60262
10007
* Api/qwebpage.cpp:
10008
(QWebPage::inputMethodQuery):
10009
Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength.
10010
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
10011
(DumpRenderTreeSupportQt::setAutofilled):
10012
Follow the return type change of Node::toInputElement().
10014
2011-05-04 Philippe Normand <pnormand@igalia.com>
10016
Reviewed by Dimitri Glazkov.
10018
Implement LayoutTestController::pseudoShadowId()
10019
https://bugs.webkit.org/show_bug.cgi?id=60034
10021
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
10022
(DumpRenderTreeSupportQt::shadowPseudoId):
10023
* WebCoreSupport/DumpRenderTreeSupportQt.h:
10025
2011-05-05 Prasanth Ullattil <prasanth.ullattil@nokia.com>
10027
Reviewed by Simon Hausmann.
10029
Install correct header files for webkit.
10031
Since WebKit is no longer inside Qt, we can remove the detection for
10034
[Qt] Install targets are not working correctly for modularized Qt and QtWebkit
10035
https://bugs.webkit.org/show_bug.cgi?id=57621
10039
2011-05-05 Ryosuke Niwa <rniwa@webkit.org>
10041
Reviewed by Eric Seidel.
10043
Rename SelectionController to FrameSelection
10044
https://bugs.webkit.org/show_bug.cgi?id=60234
10046
* Api/qwebframe.cpp:
10048
2011-05-05 Alexis Menard <alexis.menard@openbossa.org>
10050
Reviewed by Andreas Kling.
10052
[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
10053
https://bugs.webkit.org/show_bug.cgi?id=60224
10055
We should use nullptr rather than 0. nullptr will be added in the new C++ standard
10056
but WebKit already has a nullptr class if there is no c++0x support.
10058
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
10059
(DumpRenderTreeSupportQt::addUserStyleSheet):
10061
2011-05-04 Cris Neckar <cdn@chromium.org>
10063
Reviewed by Adam Barth.
10065
Expose WebView directly through ChromeClient.
10066
https://bugs.webkit.org/show_bug.cgi?id=49902
10068
* WebCoreSupport/ChromeClientQt.h:
10069
(WebCore::ChromeClientQt::webView):
10071
2011-05-04 Alexis Menard <alexis.menard@openbossa.org>
10073
Unreviewed warning fix.
10075
The variable is just unused.
10077
* tests/qwebpage/tst_qwebpage.cpp:
10078
(tst_QWebPage::inputMethods):
10080
2011-05-04 Tao Bai <michaelbai@chromium.org>
10082
Reviewed by David Kilzer.
10084
Populate touch-icon url to FrameLoaderClient
10085
https://bugs.webkit.org/show_bug.cgi?id=59143
10087
Respect the interface change in FrameLoaderClient.
10089
* WebCoreSupport/FrameLoaderClientQt.cpp:
10090
(WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
10091
* WebCoreSupport/FrameLoaderClientQt.h:
10093
2011-03-31 Luiz Agostini <luiz.agostini@openbossa.org>
10095
Reviewed by Kenneth Rohde Christiansen.
10097
[Qt] Qt WebKit updates view on HTTP 204 response
10098
https://bugs.webkit.org/show_bug.cgi?id=42529
10100
Ignoring http responses which have status code equal to 204 (No Content)
10101
or 205 (Reset Content).
10103
* WebCoreSupport/FrameLoaderClientQt.cpp:
10104
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
10106
2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
10108
Reviewed by Benjamin Poulain.
10110
[Qt] Fix signals emitted in FakeReply used in autotests
10111
https://bugs.webkit.org/show_bug.cgi?id=60049
10113
The signals emitted for each case of FakeReply were swapped (error case
10114
emitting metaDataChanged() and redirect case emitting error()). Emitting
10115
readyRead() is not necessary.
10117
* tests/qwebframe/tst_qwebframe.cpp:
10118
(FakeReply::FakeReply):
10119
Choose the different continue function for each case of FakeReply. This removes
10120
the need of the if-statement in timeout() and let us replace timeout() with two
10123
(FakeReply::continueRedirect):
10124
(FakeReply::continueError):
10125
Continuation cases, emitting the minimal set of signals needed for each case.
10127
2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>
10129
Reviewed by Dimitri Glazkov.
10131
Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
10132
https://bugs.webkit.org/show_bug.cgi?id=58703
10134
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
10135
(DumpRenderTreeSupportQt::shadowRoot): Added #include for ShadowRoot.h.
10137
2011-05-03 Keith Kyzivat <keith.kyzivat@nokia.com>
10139
Reviewed by Andreas Kling.
10141
[Qt] QtDeclarative Webview element has a fixed white background
10142
https://bugs.webkit.org/show_bug.cgi?id=40918
10144
QProperty REVISION feature is not present in certain Qt Trunk clones.
10145
These builds report their version as 4.8.0, and therefore break on the
10146
prior #if QT_VERSION >= 0x040704. The proper fix is to check based on
10147
the existance of Q_REVISION.
10149
* declarative/plugin.cpp:
10150
(WebKitQmlPlugin::registerTypes):
10151
* declarative/qdeclarativewebview.cpp:
10152
* declarative/qdeclarativewebview_p.h:
10154
2011-05-01 Sam Weinig <sam@webkit.org>
10156
Reviewed by Anders Carlsson.
10158
Prune some unnecessary #includes
10159
https://bugs.webkit.org/show_bug.cgi?id=59895
10161
Start getting rid of unnecessary #includes and forward declares.
10163
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
10165
2011-04-29 Csaba Osztrogonác <ossy@webkit.org>
10167
Reviewed by Adam Barth.
10169
Enable strict OwnPtr for Qt
10170
https://bugs.webkit.org/show_bug.cgi?id=59667
10172
* Api/qwebpage.cpp:
10173
(QWebPagePrivate::QWebPagePrivate):
10175
2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
10177
Reviewed by Simon Hausmann.
10179
ENABLE(QT_BEARER) -> USE(QT_BEARER)
10181
* Api/qwebsettings.cpp:
10183
2011-04-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
10185
Reviewed by Simon Hausmann.
10187
ENABLE(QT_USERAGENT_DEVICEMODEL) -> USE(QT_MOBILITY_SYSTEMINFO)
10189
* Api/qwebpage.cpp:
10191
2011-04-28 Yael Aharon <yael.aharon@nokia.com>
10193
Reviewed by Andreas Kling.
10195
Remove flag ENABLE_SYMBIAN_DIALOG_PROVIDER
10196
https://bugs.webkit.org/show_bug.cgi?id=59704
10198
* WebCoreSupport/QtFallbackWebPopup.cpp:
10199
(WebCore::QtFallbackWebPopup::show):
10200
* WebCoreSupport/QtFallbackWebPopup.h:
10202
2011-04-27 Yi Shen <yi.4.shen@nokia.com>
10204
Reviewed by Kenneth Rohde Christiansen.
10206
[Qt] Upstream Symbian platform plugin
10207
https://bugs.webkit.org/show_bug.cgi?id=58435
10209
Upstream Symbian platform plugin.
10211
* QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
10212
* symbian/platformplugin: Added.
10213
* symbian/platformplugin/WebPlugin.cpp: Added.
10214
(ItemListDelegate::ItemListDelegate):
10215
(ItemListDelegate::paint):
10217
(Popup::resizeEvent):
10218
(Popup::populateList):
10219
(Popup::onItemSelected):
10220
(Popup::updateSelectionsBeforeDialogClosing):
10221
(Popup::updateAndClose):
10222
(WebPopup::WebPopup):
10223
(WebPopup::~WebPopup):
10224
(WebPopup::createSingleSelectionPopup):
10225
(WebPopup::createMultipleSelectionPopup):
10226
(WebPopup::createPopup):
10229
(WebPopup::popupClosed):
10230
(WebPopup::itemClicked):
10231
(SingleSelectionPopup::SingleSelectionPopup):
10232
(MultipleSelectionPopup::MultipleSelectionPopup):
10233
(WebNotificationPresenter::showNotification):
10234
(WebPlugin::supportsExtension):
10235
(WebPlugin::createExtension):
10236
* symbian/platformplugin/WebPlugin.h: Added.
10237
(Popup::preSelectedIndices):
10238
(Popup::listWidget):
10239
(WebNotificationPresenter::WebNotificationPresenter):
10240
(WebNotificationPresenter::~WebNotificationPresenter):
10241
* symbian/platformplugin/platformplugin.pro: Added.
10242
* symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
10243
(QWebSelectData::~QWebSelectData):
10244
(QWebSelectMethod::~QWebSelectMethod):
10245
(QWebNotificationData::~QWebNotificationData):
10246
(QWebNotificationPresenter::QWebNotificationPresenter):
10247
(QWebNotificationPresenter::~QWebNotificationPresenter):
10248
(QWebTouchModifier::~QWebTouchModifier):
10249
(QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
10250
(QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
10251
(QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
10253
2011-04-26 Yi Shen <yi.4.shen@nokia.com>
10255
Reviewed by Tor Arne Vestbø.
10257
[Qt][Symbian] Fix Api test failure -- tst_QWebFrame::setHtmlWithBaseURL
10258
https://bugs.webkit.org/show_bug.cgi?id=56946
10260
Deployed the missing resource for Symbian platform.
10262
* tests/qwebframe/qwebframe.pro:
10264
2011-04-26 Siddharth Mathur <siddharth.mathur@nokia.com>
10266
Reviewed by Andreas Kling.
10268
[Qt] Build fix: QtDeclarative Webview element has a fixed white background
10269
https://bugs.webkit.org/show_bug.cgi?id=40918
10271
Macro Q_REVISION and associated qdeclarativeitem.h signals are not available in 4.7.3 headers in Nokia Qt SDK.
10273
* declarative/plugin.cpp: Bump up required version to 4.7.4+
10274
(WebKitQmlPlugin::registerTypes):
10275
* declarative/qdeclarativewebview.cpp: ditto
10276
* declarative/qdeclarativewebview_p.h: ditto
10277
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: ditto
10279
2011-04-26 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
10281
Reviewed by Csaba Osztrogonác.
10283
[Qt] Implement LayoutTestController::setAutofilled
10284
https://bugs.webkit.org/show_bug.cgi?id=59439
10286
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
10287
(DumpRenderTreeSupportQt::setAutofilled):
10288
* WebCoreSupport/DumpRenderTreeSupportQt.h:
10290
2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
10292
Unreviewed, rolling out r84627.
10293
http://trac.webkit.org/changeset/84627
10294
https://bugs.webkit.org/show_bug.cgi?id=59271
10296
It broke Symbian build (Requested by Ossy on #webkit).
10299
* symbian/platformplugin/WebPlugin.cpp: Removed.
10300
* symbian/platformplugin/WebPlugin.h: Removed.
10301
* symbian/platformplugin/platformplugin.pro: Removed.
10302
* symbian/platformplugin/qwebkitplatformplugin.h: Removed.
10304
2011-04-22 Sam Weinig <sam@webkit.org>
10308
* Api/qwebelement.cpp:
10309
(setupScriptContext):
10311
2011-04-22 Yi Shen <yi.4.shen@nokia.com>
10313
Reviewed by Kenneth Rohde Christiansen.
10315
[Qt] Upstream Symbian platform plugin
10316
https://bugs.webkit.org/show_bug.cgi?id=58435
10318
Upstream Symbian platform plugin.
10320
* QtWebKit.pro: Add platformplugin.dll to the QtWebKit.sis.
10321
* symbian/platformplugin: Added.
10322
* symbian/platformplugin/WebPlugin.cpp: Added.
10323
(ItemListDelegate::ItemListDelegate):
10324
(ItemListDelegate::paint):
10326
(Popup::resizeEvent):
10327
(Popup::populateList):
10328
(Popup::onItemSelected):
10329
(Popup::updateSelectionsBeforeDialogClosing):
10330
(Popup::updateAndClose):
10331
(WebPopup::WebPopup):
10332
(WebPopup::~WebPopup):
10333
(WebPopup::createSingleSelectionPopup):
10334
(WebPopup::createMultipleSelectionPopup):
10335
(WebPopup::createPopup):
10338
(WebPopup::popupClosed):
10339
(WebPopup::itemClicked):
10340
(SingleSelectionPopup::SingleSelectionPopup):
10341
(MultipleSelectionPopup::MultipleSelectionPopup):
10342
(WebNotificationPresenter::showNotification):
10343
(WebPlugin::supportsExtension):
10344
(WebPlugin::createExtension):
10345
* symbian/platformplugin/WebPlugin.h: Added.
10346
(Popup::preSelectedIndices):
10347
(Popup::listWidget):
10348
(WebNotificationPresenter::WebNotificationPresenter):
10349
(WebNotificationPresenter::~WebNotificationPresenter):
10350
* symbian/platformplugin/platformplugin.pro: Added.
10351
* symbian/platformplugin/qwebkitplatformplugin.h: Copied from WebKit/qt/Api/qwebkitplatformplugin.h.
10352
(QWebSelectData::~QWebSelectData):
10353
(QWebSelectMethod::~QWebSelectMethod):
10354
(QWebNotificationData::~QWebNotificationData):
10355
(QWebNotificationPresenter::QWebNotificationPresenter):
10356
(QWebNotificationPresenter::~QWebNotificationPresenter):
10357
(QWebTouchModifier::~QWebTouchModifier):
10358
(QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
10359
(QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
10360
(QWebKitPlatformPlugin::~QWebKitPlatformPlugin):
10362
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
10364
Reviewed by Sam Weinig.
10366
Add Frame* to the argument lists of canCopyCut and canPaste
10367
https://bugs.webkit.org/show_bug.cgi?id=59153
10369
* WebCoreSupport/EditorClientQt.cpp:
10370
(WebCore::EditorClientQt::canCopyCut):
10371
(WebCore::EditorClientQt::canPaste):
10372
* WebCoreSupport/EditorClientQt.h:
10374
2011-04-21 Yi Shen <yi.4.shen@nokia.com>
10376
Reviewed by Antonio Gomes.
10378
[Qt] Fix the style issue for Api/qwebkitplatformplugin.h
10379
https://bugs.webkit.org/show_bug.cgi?id=59097
10381
Fix the style issues for Api/qwebkitplatformplugin.h found by the webkit-check-style.
10383
* Api/qwebkitplatformplugin.h:
10385
2011-04-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
10387
Reviewed by Csaba Osztrogonác.
10389
[Qt] REGRESSION(84057): It made 4 API tests fail
10390
https://bugs.webkit.org/show_bug.cgi?id=58848
10392
After MIME sniffing support was added, some autotests are failing because
10393
the sniffer doesn't recognize our HTML pages.
10395
This fixes tst_QWebPage::backActionUpdate(), tst_QWebPage::errorPageExtensionInFrameset()
10396
and tst_QWebFrame::horizontalScrollAfterBack().
10398
* tests/qwebframe/resources/testiframe.html:
10399
* tests/qwebframe/resources/testiframe2.html:
10400
Remove spurious </html> in beginning of the document.
10402
* tests/qwebpage/resources/framedindex.html:
10403
* tests/qwebpage/resources/index.html:
10404
Add <html> (and </html>) tags, <frameset> is not recognized by the sniffer as a
10405
possible starting tag for HTML document.
10407
* tests/qwebpage/tst_qwebpage.cpp:
10408
(tst_QWebPage::errorPageExtensionInFrameset):
10409
Verify if we do have a main frame and the main frame has the children frames we
10410
expect. This will avoid crashing if for some reason children frames are not
10413
2011-04-20 Dominic Cooney <dominicc@chromium.org>
10415
Reviewed by Dimitri Glazkov.
10417
layoutTestController can create and destroy shadow DOM
10418
https://bugs.webkit.org/show_bug.cgi?id=59058
10420
Support for new methods in Qt DRT.
10422
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
10423
(DumpRenderTreeSupportQt::ensureShadowRoot):
10424
(DumpRenderTreeSupportQt::removeShadowRoot):
10425
* WebCoreSupport/DumpRenderTreeSupportQt.h:
10427
2011-04-20 Balazs Kelemen <kbalazs@webkit.org>
10429
Reviewed by Csaba Osztrogonác.
10431
[Qt] Cleanup includepath adjustment for generated files
10432
https://bugs.webkit.org/show_bug.cgi?id=58869
10434
* QtWebKit.pro: Revert the hacky fix in r84174. Remove
10437
2011-04-19 Yi Shen <yi.4.shen@nokia.com>
10439
Reviewed by Andreas Kling.
10441
[Qt][Symbian] Fix Api test failure -- tst_QWebView::setPalette()
10442
https://bugs.webkit.org/show_bug.cgi?id=57254
10444
Skip test for setPalette() which doesn't work
10445
when WTF_USE_QT_MOBILE_THEME is defined.
10447
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
10448
* tests/qwebview/tst_qwebview.cpp:
10451
2011-04-19 Yi Shen <yi.4.shen@nokia.com>
10453
Reviewed by Laszlo Gombos.
10455
[Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache
10456
https://bugs.webkit.org/show_bug.cgi?id=58044
10458
Fixing this test by disabling the scrollbars on the graphics view
10459
since QtWebKit handles scrolling and scrollbar automatically and correctly.
10461
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
10462
(tst_QGraphicsWebView::widgetsRenderingThroughCache):
10464
2011-04-19 Igor Oliveira <igor.oliveira@openbossa.org>
10466
Reviewed by Andreas Kling.
10468
[Qt] X11: Text selection is causing oncopy event to be called
10469
https://bugs.webkit.org/show_bug.cgi?id=58656
10471
Always when text is selected the oncopy event is fired, this behavior does
10472
not exist in Firefox or Chrome. Now, when selecting a text, QtWebKit
10473
is making multi part-copies (with rich text metadata), the multi-part
10474
data can be obtained by data transfer items interface when supported by QtWebKit.
10475
Also, copies to the clipboard of a selected image, is not supported by Chrome and
10476
Firefox and was removed from QtWebKit.
10479
* Api/qwebpage.cpp:
10480
(QWebPagePrivate::handleClipboard):
10482
2011-04-18 Csaba Osztrogonác <ossy@webkit.org>
10484
[Qt][WK2] Unreviewed buildfix after r84174.
10486
* QtWebKit.pro: Missing includepath added.
10488
2011-04-18 Yi Shen <yi.4.shen@nokia.com>
10490
Reviewed by Laszlo Gombos.
10492
[Qt][Symbian] Fix Api test failure -- tst_QWebFrame::inputFieldFocus
10493
https://bugs.webkit.org/show_bug.cgi?id=57546
10495
Disable the fullscreen VKB when testing inputFieldFocus().
10497
* tests/qwebframe/tst_qwebframe.cpp:
10499
2011-04-18 Andreas Kling <kling@webkit.org>
10501
[Qt] DRT: Unreviewed test fix after r84168.
10503
Dump the original request KURL for blocked access attempts.
10504
Turns out converting it to a QUrl lower-cases the hostname.
10506
* WebCoreSupport/FrameLoaderClientQt.cpp:
10507
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
10509
2011-04-18 Yi Shen <yi.4.shen@nokia.com>
10511
Reviewed by Laszlo Gombos.
10513
[Qt] Fix Api tests for QWebPage on Symbian
10514
https://bugs.webkit.org/show_bug.cgi?id=56924
10516
Ignores the style attribute that selectedHtml() returns.
10518
* tests/qwebpage/tst_qwebpage.cpp:
10519
(tst_QWebPage::cursorMovements):
10520
(tst_QWebPage::textSelection):
10521
(tst_QWebPage::findText):
10523
2011-04-18 Andreas Kling <kling@webkit.org>
10525
Reviewed by Adam Barth.
10527
REGRESSION (r84010): [Qt] DRT: Unbreak redirection of http:/ URLs.
10528
https://bugs.webkit.org/show_bug.cgi?id=58779
10530
KURL::host() doesn't return the host part of [broken] http:/ URLs, so use
10531
QUrl instead to match the behavior of other ports.
10533
* WebCoreSupport/FrameLoaderClientQt.cpp:
10534
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
10536
2011-04-18 Dominic Cooney <dominicc@chromium.org>
10538
Reviewed by Andreas Kling.
10540
Add layoutTestController.shadowRoot to Qt DRT.
10541
https://bugs.webkit.org/show_bug.cgi?id=58759
10543
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
10544
(DumpRenderTreeSupportQt::shadowRoot): Added.
10545
* WebCoreSupport/DumpRenderTreeSupportQt.h:
10547
2011-04-16 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
10549
Reviewed by Andreas Kling.
10551
[Qt] Autotest got missed in the handover of the QML WebView element
10552
https://bugs.webkit.org/show_bug.cgi?id=41449
10554
Importing WebView QML element test cases from Qt repository. I did some
10555
style modifications and simplifications in the original code but hopefully
10556
without changing the behavior.
10558
Tests that do not pass are marked with QEXPECT_FAIL or QSKIP. The two major
10559
issues currently are:
10561
- pixelCache() test checked the usage of pixel cache by using a subclass of
10562
QDeclarativeWebView. We can't do that right now because this class is not
10563
exported. We may need a Q_AUTOTEST_EXPORT thing for QtWebKit if we want
10565
- elementAtArea() test uses a function that is not exported. But in this case
10566
I think we should test it's user, the public method "heuristicZoom".
10568
* tests/qdeclarativewebview/resources/basic.html: Added.
10569
* tests/qdeclarativewebview/resources/basic.png: Added.
10570
* tests/qdeclarativewebview/resources/basic.qml: Added.
10571
* tests/qdeclarativewebview/resources/elements.html: Added.
10572
* tests/qdeclarativewebview/resources/elements.qml: Added.
10573
* tests/qdeclarativewebview/resources/forward.html: Added.
10574
* tests/qdeclarativewebview/resources/forward.png: Added.
10575
* tests/qdeclarativewebview/resources/javaScript.html: Added.
10576
* tests/qdeclarativewebview/resources/javaScript.qml: Added.
10577
* tests/qdeclarativewebview/resources/loadError.qml: Added.
10578
* tests/qdeclarativewebview/resources/newwindows.html: Added.
10579
* tests/qdeclarativewebview/resources/newwindows.qml: Added.
10580
* tests/qdeclarativewebview/resources/propertychanges.qml: Added.
10581
* tests/qdeclarativewebview/resources/sethtml.qml: Added.
10582
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
10583
(tst_QDeclarativeWebView::tmpDir):
10587
(tst_QDeclarativeWebView::cleanupTestCase):
10588
(tst_QDeclarativeWebView::basicProperties):
10589
(tst_QDeclarativeWebView::elementAreaAt):
10590
(tst_QDeclarativeWebView::historyNav):
10591
(callEvaluateJavaScript):
10592
(tst_QDeclarativeWebView::javaScript):
10593
(tst_QDeclarativeWebView::loadError):
10594
(tst_QDeclarativeWebView::multipleWindows):
10595
(tst_QDeclarativeWebView::newWindowComponent):
10596
(tst_QDeclarativeWebView::newWindowParent):
10597
(tst_QDeclarativeWebView::pressGrabTime):
10598
(tst_QDeclarativeWebView::renderingEnabled):
10599
(tst_QDeclarativeWebView::setHtml):
10600
(tst_QDeclarativeWebView::settings):
10601
(tst_QDeclarativeWebView::checkNoErrors):
10602
* tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
10604
2011-04-08 Luiz Agostini <luiz.agostini@openbossa.org>
10606
Reviewed by Kenneth Rohde Christiansen.
10608
[Qt] QWebPage MIME type handling inconsistency with other web browsers
10609
https://bugs.webkit.org/show_bug.cgi?id=46968
10611
Implementing mime type sniffing based on
10612
http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
10614
* WebCoreSupport/FrameLoaderClientQt.cpp:
10615
(WebCore::FrameLoaderClientQt::createNetworkingContext):
10616
* WebCoreSupport/FrameNetworkingContextQt.cpp:
10617
(WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
10618
(WebCore::FrameNetworkingContextQt::create):
10619
(WebCore::FrameNetworkingContextQt::MIMESniffingEnabled):
10620
* WebCoreSupport/FrameNetworkingContextQt.h:
10621
* tests/MIMESniffing/MIMESniffing.pro: Added.
10622
* tests/MIMESniffing/TestData.h: Added.
10623
* tests/MIMESniffing/resources.qrc: Added.
10624
* tests/MIMESniffing/resources/application_atom+xml: Added.
10625
* tests/MIMESniffing/resources/application_ogg: Added.
10626
* tests/MIMESniffing/resources/application_pdf: Added.
10627
* tests/MIMESniffing/resources/application_postscript: Added.
10628
* tests/MIMESniffing/resources/application_rdf+xml: Added.
10629
* tests/MIMESniffing/resources/application_rss+xml: Added.
10630
* tests/MIMESniffing/resources/application_x-gzip: Added.
10631
* tests/MIMESniffing/resources/application_x-rar-compressed: Added.
10632
* tests/MIMESniffing/resources/application_zip: Added.
10633
* tests/MIMESniffing/resources/audio_x-wave: Added.
10634
* tests/MIMESniffing/resources/image_bmp: Added.
10635
* tests/MIMESniffing/resources/image_gif: Added.
10636
* tests/MIMESniffing/resources/image_jpeg: Added.
10637
* tests/MIMESniffing/resources/image_png: Added.
10638
* tests/MIMESniffing/resources/image_vnd.microsoft.icon: Added.
10639
* tests/MIMESniffing/resources/image_webp: Added.
10640
* tests/MIMESniffing/resources/text_html: Added.
10641
* tests/MIMESniffing/resources/text_xml: Added.
10642
* tests/MIMESniffing/resources/video_webm: Added.
10643
* tests/MIMESniffing/tst_MIMESniffing.cpp: Added.
10644
(tst_MIMESniffing::tst_MIMESniffing):
10646
(tst_MIMESniffing::testCase1):
10649
2011-04-15 Andreas Kling <kling@webkit.org>
10651
Reviewed by Antonio Gomes.
10653
[Qt] DRT: Block access to external URLs.
10655
Implement the "Blocked access to external URL" behavior for Qt's DRT,
10656
based on what other ports are doing.
10658
Fixes <http://webkit.org/b/57306> and <http://webkit.org/b/58523>.
10660
* WebCoreSupport/FrameLoaderClientQt.cpp:
10661
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
10663
2011-01-26 Ragner Magalhaes <ragner.magalhaes@openbossa.org>
10665
Reviewed by Antonio Gomes.
10667
[Qt] Web Inspector does not highlight elements
10668
https://bugs.webkit.org/show_bug.cgi?id=35125
10670
Adjust Web inspector to highlight elements on the page when the mouse
10671
hovers the element on DOM inspector.
10673
* Api/qwebframe.cpp:
10674
(QWebFramePrivate::renderRelativeCoords):
10675
* WebCoreSupport/InspectorClientQt.cpp:
10676
(WebCore::InspectorClientQt::highlight):
10677
(WebCore::InspectorClientQt::hideHighlight):
10679
2011-04-12 George Guo <George.Guo@nokia.com>
10681
Reviewed by Laszlo Gombos.
10683
[Qt] On Symbian got "Update Error" when installing QtWebkit.sis
10684
http://bugs.webkit.org/show_bug.cgi?id=58141
10686
If QtWebKit is already in Symbian ROM, we need package to be
10687
both SA and RU type
10691
2011-04-12 Alexis Menard <alexis.menard@openbossa.org>
10693
Reviewed by Andreas Kling.
10695
[Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
10696
https://bugs.webkit.org/show_bug.cgi?id=58251
10698
Fix an issue with slot names after http://trac.webkit.org/changeset/83512.
10700
* Api/qwebframe.cpp:
10701
(QWebFrame::QWebFrame):
10703
2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
10705
Reviewed by Benjamin Poulain.
10707
[Qt] Private Q_SLOTS void orientationChanged() can't be in qwebframe.h public header file.
10708
https://bugs.webkit.org/show_bug.cgi?id=58251
10710
Qt coding conventions states that private slots should be located in private implementation of
10711
the class. This allows us to rename/delete the slots in the future without breaking anything.
10713
No new tests added, just a simple refactoring.
10715
* Api/qwebframe.cpp:
10716
(QWebFramePrivate::_q_orientationChanged):
10718
* Api/qwebframe_p.h:
10720
2011-04-11 Alexis Menard <alexis.menard@openbossa.org>
10722
Reviewed by Kenneth Rohde Christiansen.
10724
[Qt] Sub-Frame content is not updated when scrolling in certain circumstances
10725
https://bugs.webkit.org/show_bug.cgi?id=50373
10727
Make sure that we invalidate the backing store when using TILED_BACKING_STORE
10728
and the page contains sub frames. This bug appears only when frame flattening is
10729
disabled and scrollable subframes.
10731
Original patch from Thomas Thrainer.
10733
* WebCoreSupport/ChromeClientQt.cpp:
10734
(WebCore::ChromeClientQt::invalidateWindow):
10736
2011-04-11 Benjamin Poulain <benjamin.poulain@nokia.com>
10738
Reviewed by Andreas Kling.
10740
[Qt] HTML5 Drag and Drop demos not working
10741
https://bugs.webkit.org/show_bug.cgi?id=56486
10743
Handling the drop with JavaScript was not working with Qt because if the action is ignored
10744
in response to DragEnter, no further events are sent to the view.
10746
Drag and drop is defined and used differently by webpages. The drag move events are determining
10747
what action should take place. To adopt this behavior for Qt, we always accept drag enter events
10750
* Api/qwebpage.cpp:
10751
(QWebPagePrivate::dragEnterEvent):
10753
2011-04-11 Andras Becsi <abecsi@webkit.org>
10755
Reviewed by Andreas Kling.
10757
[Qt] REGRESSION(83122): tst_QWebElement::style() fails
10758
https://bugs.webkit.org/show_bug.cgi?id=58032
10760
According to the documentation of QWebElement the styleProperty method should
10761
not respect style inheritance and other CSS rules for the InlineStyle enum.
10763
r83122 fixed this behaviour.
10765
* tests/qwebelement/tst_qwebelement.cpp:
10766
(tst_QWebElement::style): Fix the expected color for QWebElement::InlineStyle.
10768
2011-04-11 Andreas Kling <andreas.kling@nokia.com>
10770
Build fix after r83436.
10772
* WebCoreSupport/FrameLoaderClientQt.cpp:
10773
(WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse):
10775
2011-04-11 Andreas Kling <andreas.kling@nokia.com>
10777
Reviewed by Benjamin Poulain.
10779
[Qt] dumpResourceResponseMIMETypes shouldn't strip URL query string.
10781
* WebCoreSupport/FrameLoaderClientQt.cpp:
10782
(WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): Use KURL::lastPathComponent()
10783
for the dumpResourceResponseMIMETypes display string instead of QFileInfo::fileName().
10784
This is in line with the Mac port.
10786
2011-04-08 Sheriff Bot <webkit.review.bot@gmail.com>
10788
Unreviewed, rolling out r83295.
10789
http://trac.webkit.org/changeset/83295
10790
https://bugs.webkit.org/show_bug.cgi?id=58144
10792
Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
10794
* WebCoreSupport/EditorClientQt.cpp:
10795
(WebCore::EditorClientQt::handleInputMethodKeydown):
10797
2011-04-08 Yi Shen <yi.4.shen@nokia.com>
10799
Reviewed by Antonio Gomes.
10801
[Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
10802
https://bugs.webkit.org/show_bug.cgi?id=57472
10804
Avoid to insert new line for both keydown event & keypress event.
10806
* WebCoreSupport/EditorClientQt.cpp:
10807
(WebCore::EditorClientQt::handleInputMethodKeydown):
10809
2011-04-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
10811
Reviewed by Benjamin Poulain.
10813
[Qt] QWebFrame::setUrl works only from second time if url fragment is present
10814
https://bugs.webkit.org/show_bug.cgi?id=32723
10816
When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(),
10817
use an invalid URL (the begin() without arguments). Clearing the document
10818
with the same URL was causing problems when we had a fragment because it assume that
10819
only scrolling was enough and did not loaded the document again.
10821
When setUrl() is called but fails, url() is expected to return the requested value. The
10822
begin(url) guaranteed that before. This patch adds a member to track the URL, which is
10823
updated when the URL changes and also when setUrl() is called.
10825
KURL was used for the member so that when setUrl() is called, and then url() is checked
10826
before the page gets loaded, we perform the same conversion that will be performed by a
10827
successful load, e.g. add trailing '/' to an address. This behavior is checked by
10828
tst_QWebFrame::requestedUrl() test.
10830
For the record: the second QWebPage::setUrl() worked because the load was considered a
10831
FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was
10832
needed. See FrameLoader::shouldScrollToAnchor() for details on this classification.
10834
* Api/qwebframe.cpp:
10835
(QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal.
10837
(isCoreFrameClear):
10838
(QWebFrame::setUrl):
10840
(QWebFrame::baseUrl): look in the document for the baseURL since its contents can change
10841
the baseURL, e.g. by using the <base> tag.
10842
* Api/qwebframe_p.h:
10844
* WebCoreSupport/FrameLoaderClientQt.cpp:
10845
(WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage):
10846
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
10848
* tests/qwebframe/tst_qwebframe.cpp:
10849
(tst_QWebFrame::setUrlWithFragment): unskip test.
10851
2011-04-07 Alexis Menard <alexis.menard@openbossa.org>
10853
Reviewed by Kenneth Rohde Christiansen.
10855
Build fix when using Phonon as a backend for the multimedia support.
10857
* WebCoreSupport/ChromeClientQt.cpp:
10858
(WebCore::ChromeClientQt::ChromeClientQt):
10859
(WebCore::ChromeClientQt::~ChromeClientQt):
10860
* WebCoreSupport/ChromeClientQt.h:
10862
2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
10864
Reviewed by Kenneth Rohde Christiansen.
10866
[Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
10867
https://bugs.webkit.org/show_bug.cgi?id=56086
10869
Add the accessor numberOfPendingGeolocationPermissionRequests to call GeolocationClientMock::numberOfPendingPermissionRequests()
10870
from the LayoutTestController.
10872
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
10873
(DumpRenderTreeSupportQt::numberOfPendingGeolocationPermissionRequests):
10874
* WebCoreSupport/DumpRenderTreeSupportQt.h:
10876
2011-04-06 Anders Bakken <agbakken@gmail.com>
10878
Reviewed by Kenneth Rohde Christiansen.
10880
[Qt] FrameLoaderClientQt.cpp has coding-style errors
10881
https://bugs.webkit.org/show_bug.cgi?id=40254
10883
* WebCoreSupport/FrameLoaderClientQt.cpp:
10884
(drtDescriptionSuitableForTestResult):
10885
(WebCore::FrameLoaderClientQt::hasWebView):
10886
(WebCore::FrameLoaderClientQt::setCopiesOnScroll):
10887
(WebCore::FrameLoaderClientQt::dispatchDidHandleOnloadEvents):
10888
(WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
10889
(WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
10890
(WebCore::FrameLoaderClientQt::cancelPolicyCheck):
10891
(WebCore::FrameLoaderClientQt::dispatchWillSubmitForm):
10892
(WebCore::FrameLoaderClientQt::postProgressStartedNotification):
10893
(WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
10894
(WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
10895
(WebCore::FrameLoaderClientQt::willChangeTitle):
10896
(WebCore::FrameLoaderClientQt::didChangeTitle):
10897
(WebCore::FrameLoaderClientQt::finishedLoading):
10898
(WebCore::FrameLoaderClientQt::frameLoadCompleted):
10899
(WebCore::FrameLoaderClientQt::provisionalLoadStarted):
10900
(WebCore::FrameLoaderClientQt::didFinishLoad):
10901
(WebCore::FrameLoaderClientQt::setTitle):
10902
(WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
10903
(WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
10904
(WebCore::FrameLoaderClientQt::updateGlobalHistory):
10905
(WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
10906
(WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem):
10907
(WebCore::FrameLoaderClientQt::committedLoad):
10908
(WebCore::FrameLoaderClientQt::download):
10909
(WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
10910
(WebCore::FrameLoaderClientQt::shouldUseCredentialStorage):
10911
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
10912
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
10913
(WebCore::FrameLoaderClientQt::createFrame):
10914
(WebCore::FrameLoaderClientQt::objectContentType):
10915
(WebCore::FrameLoaderClientQt::createPlugin):
10917
2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
10919
Reviewed by Andreas Kling.
10921
[Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
10922
https://bugs.webkit.org/show_bug.cgi?id=57974
10924
We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
10926
No new tests needed, just a config flag rename.
10928
* Api/qwebkitplatformplugin.h:
10929
* WebCoreSupport/ChromeClientQt.cpp:
10930
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
10931
(DumpRenderTreeSupportQt::mediaContentUrlByElementId):
10932
* WebCoreSupport/FullScreenVideoQt.cpp:
10933
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
10934
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
10935
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
10936
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
10937
(WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
10938
(WebCore::FullScreenVideoQt::isValid):
10939
* WebCoreSupport/FullScreenVideoQt.h:
10940
* WebCoreSupport/QtPlatformPlugin.cpp:
10941
* WebCoreSupport/QtPlatformPlugin.h:
10942
* examples/platformplugin/WebPlugin.cpp:
10943
(WebPlugin::supportsExtension):
10944
(WebPlugin::createExtension):
10945
* examples/platformplugin/WebPlugin.h:
10946
* examples/platformplugin/platformplugin.pro:
10947
* examples/platformplugin/qwebkitplatformplugin.h:
10948
* tests/qwebpage/tst_qwebpage.cpp:
10949
(tst_QWebPage::loadHtml5Video):
10952
2011-04-06 Alexis Menard <alexis.menard@openbossa.org>
10954
Reviewed by Andreas Kling.
10956
[Qt] Implement fullscreen playback for the GStreamer backend.
10957
https://bugs.webkit.org/show_bug.cgi?id=56826
10959
Implement support for fullscreen playback when building the
10960
Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
10961
The implementation is done in FullScreenVideoQt alongside with
10962
the Qt Multimedia support.
10964
No new tests because layout tests cover it. They are not yet activated
10965
but will be any time soon.
10968
* WebCoreSupport/ChromeClientQt.cpp:
10969
(WebCore::ChromeClientQt::ChromeClientQt):
10970
(WebCore::ChromeClientQt::~ChromeClientQt):
10971
(WebCore::ChromeClientQt::enterFullscreenForNode):
10972
(WebCore::ChromeClientQt::exitFullscreenForNode):
10973
* WebCoreSupport/ChromeClientQt.h:
10974
* WebCoreSupport/FullScreenVideoQt.cpp:
10975
(WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
10976
(WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
10977
(WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
10978
(WebCore::GStreamerFullScreenVideoHandler::windowClosed):
10979
(WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
10980
(WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
10981
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
10982
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
10983
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
10984
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
10985
(WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
10986
(WebCore::FullScreenVideoQt::isValid):
10987
* WebCoreSupport/FullScreenVideoQt.h:
10988
(WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):
10990
2011-04-06 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
10992
Reviewed by Kenneth Rohde Christiansen.
10994
[Qt] Improve tests for QWebFrame::url() and related methods
10995
https://bugs.webkit.org/show_bug.cgi?id=57865
10997
* tests/qwebframe/tst_qwebframe.cpp:
10998
(FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
10999
(tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
11000
that fails and a load() that fails (for a different URL).
11002
(tst_QWebFrame::setUrlWithFragment_data):
11003
(tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
11004
the URL in the frame before the test starts.
11006
(tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
11007
the same URL as argument.
11010
(tst_QWebFrame::setUrlThenLoads_data):
11011
(tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
11012
sequence of set and loads. Those tests are interesting because the properties
11013
react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
11014
is used or after the load() is committed and baseUrl() is similar to url() but also depends
11015
on the contents of the page when it loads.
11017
2011-04-04 MORITA Hajime <morrita@google.com>
11019
Reviewed by Ryosuke Niwa.
11021
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
11022
https://bugs.webkit.org/show_bug.cgi?id=56085
11024
* WebCoreSupport/EditorClientQt.h:
11025
(WebCore::EditorClientQt::requestCheckingOfString):
11027
2011-04-04 Chang Shu <cshu@webkit.org>
11029
Reviewed by Ryosuke Niwa.
11031
setContentEditable with true/false/inherit string is not working properly
11032
https://bugs.webkit.org/show_bug.cgi?id=52058
11034
Move isContentEditable from HTMLElement to Node. WebKit should only access isContentEditable
11035
as rendererIsEditable is for WebCore internal use.
11037
* WebCoreSupport/EditorClientQt.cpp:
11038
(WebCore::EditorClientQt::handleKeyboardEvent):
11040
2011-04-01 Carol Szabo <carol.szabo@nokia.com>
11042
Reviewed by Benjamin Poulain.
11044
Changed QWebFramePrivate::renderFromTiledBackingStore to call directly into
11045
Scrollbar/PanIcon rendering, bypassing the potential relayout in renderRelativeCoords.
11047
Tiled painting still causes synchronous layout when
11048
accelerated compositing and texture mapper are enabled
11049
https://bugs.webkit.org/show_bug.cgi?id=56929
11051
* Api/qwebframe.cpp:
11052
(QWebFramePrivate::renderFromTiledBackingStore):
11053
(QWebFramePrivate::renderRelativeCoords):
11054
(QWebFramePrivate::renderFrameWidgets):
11055
* Api/qwebframe_p.h:
11057
2011-04-01 Nancy Piedra <nancy.piedra@nokia.com>
11059
Reviewed by Benjamin Poulain.
11061
[Qt] DragClientQt.h has coding-style errors
11062
https://bugs.webkit.org/show_bug.cgi?id=40425
11064
* WebCoreSupport/DragClientQt.h:
11066
2011-03-31 Marius Storm-Olsen <marius.storm-olsen@nokia.com>
11068
Reviewed by Kenneth Rohde Christiansen.
11070
[Qt] Properly detect phonon include, and avoid double qtLibraryTarget() call
11071
https://bugs.webkit.org/show_bug.cgi?id=57017
11073
Build fix. No new tests.
11077
2011-03-31 Evan Martin <evan@chromium.org>
11081
* WebCoreSupport/FrameLoaderClientQt.cpp:
11082
(WebCore::FrameLoaderClientQt::updateGlobalHistory):
11084
2011-03-31 Nancy Piedra <nancy.piedra@nokia.com>
11086
Reviewed by Benjamin Poulain.
11088
[Qt] ChromeClientQt.h has coding-style errors
11089
https://bugs.webkit.org/show_bug.cgi?id=40239
11091
* WebCoreSupport/ChromeClientQt.h:
11092
(WebCore::ChromeClientQt::scrollbarsModeDidChange):
11093
(WebCore::ChromeClientQt::needTouchEvents):
11094
(WebCore::ChromeClientQt::formStateDidChange):
11095
(WebCore::ChromeClientQt::scrollRectIntoView):
11096
(WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
11097
(WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
11099
2011-03-31 Evan Martin <evan@chromium.org>
11101
Build fix from previous change.
11103
* Api/qwebframe.cpp:
11104
(QWebFrame::title):
11106
2011-03-31 Evan Martin <evan@chromium.org>
11108
Reviewed by Eric Seidel.
11110
<title> should support dir attribute
11111
https://bugs.webkit.org/show_bug.cgi?id=50961
11113
Update to new FrameLoaderClient interface.
11115
* WebCoreSupport/FrameLoaderClientQt.cpp:
11116
(WebCore::FrameLoaderClientQt::dispatchDidReceiveTitle):
11117
(WebCore::FrameLoaderClientQt::setTitle):
11118
* WebCoreSupport/FrameLoaderClientQt.h:
11120
2011-03-30 Yi Shen <yi.4.shen@nokia.com>
11122
Reviewed by Kenneth Rohde Christiansen.
11124
[Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes
11125
https://bugs.webkit.org/show_bug.cgi?id=57020
11127
Added a macro 'VERIFY_INPUTMETHOD_HINTS' to test inputmethodhints().
11129
* tests/qwebview/tst_qwebview.cpp:
11130
(tst_QWebView::focusInputTypes):
11132
2011-03-30 Robert Hogan <robert@webkit.org>
11134
Reviewed by Antonio Gomes.
11136
[Qt] Fix LoadHTMLStringItem::invoke() after r75966
11138
Add DRT support for loading an alternate HTML string
11139
for error pages. This allows Qt to unskip
11140
http/tests/navigation/go-back-to-error-page.html.
11142
https://bugs.webkit.org/show_bug.cgi?id=52614
11144
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
11145
(DumpRenderTreeSupportQt::setAlternateHtml):
11146
* WebCoreSupport/DumpRenderTreeSupportQt.h:
11148
2011-03-29 Alexis Menard <alexis.menard@openbossa.org>
11150
Unreviewed build fix for build-webkit -minimal.
11152
Breakage introduced by http://trac.webkit.org/changeset/82238.
11153
The minimal option has no support for shortcuts.
11155
* WebCoreSupport/EditorClientQt.cpp:
11156
(WebCore::EditorClientQt::handleInputMethodKeydown):
11158
2011-03-29 Janne Koskinen <janne.p.koskinen@digia.com>
11160
Reviewed by Kenneth Rohde Christiansen.
11162
[Qt] Enterkey to go to Newline does not work in the text area(in HTML form)
11163
https://bugs.webkit.org/show_bug.cgi?id=33179
11165
Fixed newline generation from Qt::Key_Enter when editting text area using InputMethods.
11167
* WebCoreSupport/EditorClientQt.cpp:
11168
(WebCore::EditorClientQt::handleInputMethodKeydown):
11169
* tests/qwebpage/tst_qwebpage.cpp:
11170
(tst_QWebPage::inputMethods):
11172
2011-03-29 Andreas Kling <kling@webkit.org>
11174
Reviewed by Simon Hausmann.
11176
[Qt] Fix documentation for QWebPage::repaintRequested()
11178
This signal is always emitted when the page is dirtied, so remove
11179
reference to old behavior where we would only emit the signal for
11180
headless QWebPages.
11182
* Api/qwebpage.cpp:
11184
2011-03-28 Andreas Kling <kling@webkit.org>
11186
Reviewed by Benjamin Poulain.
11188
[Qt] Pass QString() instead of String() when emitting titleChanged() for new loads.
11190
* WebCoreSupport/FrameLoaderClientQt.cpp:
11191
(WebCore::FrameLoaderClientQt::dispatchDidCommitLoad):
11193
2011-03-28 Andreas Kling <kling@webkit.org>
11195
Reviewed by Benjamin Poulain.
11197
[Qt] Crash when calling QWebFrame::render() in response to QWebPage::repaintRequested()
11198
https://bugs.webkit.org/show_bug.cgi?id=52629
11200
* WebCoreSupport/ChromeClientQt.cpp:
11201
(WebCore::ChromeClientQt::invalidateContentsAndWindow): Make the emission of
11202
QWebPage::repaintRequested() use a Qt::QueuedConnection.
11204
* tests/qwebpage/tst_qwebpage.cpp:
11205
(RepaintRequestedRenderer::RepaintRequestedRenderer):
11206
(RepaintRequestedRenderer::onRepaintRequested):
11207
(tst_QWebPage::renderOnRepaintRequestedShouldNotRecurse): Test that calling
11208
QWebFrame::render() in a slot connected to to QWebPage::repaintRequested()
11209
doesn't cause recursive signal emissions.
11211
2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>
11213
Reviewed by Andreas Kling.
11215
[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
11216
https://bugs.webkit.org/show_bug.cgi?id=57087
11218
* QtWebKit.pro: we can now enable QT_ASCII_CAST_WARNINGS
11219
* tests/tests.pri: we do not require QT_ASCII_CAST_WARNINGS for tests
11220
since they are applications, not libraries.
11222
2011-03-28 Andras Becsi <abecsi@webkit.org>
11224
Reviewed by Csaba Osztrogonác.
11226
[Qt] QtWebKit does not link with --3d-canvas using MinGW
11227
https://bugs.webkit.org/show_bug.cgi?id=57225
11229
* QtWebKit.pro: Append the OpenGL libraries on MinGW so it can resolve symbols.
11231
2011-03-28 Csaba Osztrogonác <ossy@webkit.org>
11233
Reviewed by Andreas Kling.
11235
REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
11236
https://bugs.webkit.org/show_bug.cgi?id=57183
11238
Windows buildfix after r82065.
11240
* Api/DerivedSources.pro: Readding escaping on Windows platforms.
11242
2011-03-27 Andreas Kling <kling@webkit.org>
11244
Fix build warning about IconDatabaseClient.h (wrong path.)
11248
2011-03-27 Andreas Kling <kling@webkit.org>
11250
Reviewed by Kenneth Rohde Christiansen.
11252
[Qt] Support for CSS color and background-color properties on select element's dropdown list
11253
https://bugs.webkit.org/show_bug.cgi?id=51627
11255
Extend the QWebSelectData interface with background and foreground colors
11256
for the whole menu, as well as per-item. Hook it up to the PopupMenuStyle
11257
getters in RenderMenuList.
11259
* Api/qwebkitplatformplugin.h:
11260
* WebCoreSupport/PopupMenuQt.cpp:
11261
(SelectData::backgroundColor):
11262
(SelectData::foregroundColor):
11263
(SelectData::itemBackgroundColor):
11264
(SelectData::itemForegroundColor):
11265
* WebCoreSupport/QtFallbackWebPopup.cpp:
11266
(WebCore::QtFallbackWebPopup::show):
11267
(WebCore::QtFallbackWebPopup::populate):
11269
2011-03-27 Yi Shen <yi.4.shen@nokia.com>
11271
Reviewed by Andreas Kling.
11273
[Qt][Symbian] Fix Api test failure -- microFocusCoordinates
11274
https://bugs.webkit.org/show_bug.cgi?id=57108
11276
Since the canvas is not self-closing tag, we need to add '</canvas>'.
11278
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
11279
(tst_QGraphicsWebView::microFocusCoordinates):
11280
* tests/qwebview/tst_qwebview.cpp:
11281
(tst_QWebView::microFocusCoordinates):
11283
2011-03-27 Kwang Yul Seo <skyul@company100.net>
11285
Reviewed by Eric Seidel.
11287
[Qt] Build fix: Define WTF_USE_TEXTURE_MAPPER=1 when CONFIG contains texmap.
11288
https://bugs.webkit.org/show_bug.cgi?id=57143
11290
Qt WebKit uses USE(TEXTURE_MAPPER) guard. Check texmap in CONFIG and
11291
define WTF_USE_TEXTURE_MAPPER=1.
11295
2011-03-27 Andreas Kling <kling@webkit.org>
11297
Reviewed by Benjamin Poulain.
11299
REGRESSION(r54712): [Qt] Installed QtWebKit header does not compile.
11300
https://bugs.webkit.org/show_bug.cgi?id=57183
11302
The convenience <QtWebKit> header would include \<QtNetwork/QtNetwork\>
11303
which was due to the outputting code previously being wrapped in eval().
11305
* Api/DerivedSources.pro:
11307
2011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com>
11309
Reviewed by Andreas Kling.
11311
[Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
11312
https://bugs.webkit.org/show_bug.cgi?id=57087
11314
Use explicit conversion for string to avoid depending on the default codec
11315
installed by the user code.
11317
* Api/qwebkitversion.cpp:
11319
* Api/qwebpage.cpp:
11320
(QWebPagePrivate::dynamicPropertyChangeEvent):
11321
(QWebPage::javaScriptConsoleMessage):
11322
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
11323
(convertToPropertyName):
11324
(DumpRenderTreeSupportQt::setEditingBehavior):
11325
(DumpRenderTreeSupportQt::plainText):
11326
* WebCoreSupport/EditorClientQt.cpp:
11328
* WebCoreSupport/FrameLoaderClientQt.cpp:
11329
(drtDescriptionSuitableForTestResult):
11330
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
11331
* WebCoreSupport/InspectorClientQt.cpp:
11332
(WebCore::InspectorClientQt::openInspectorFrontend):
11333
* WebCoreSupport/InspectorServerQt.cpp:
11334
(WebCore::parseWebSocketChallengeNumber):
11335
(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
11337
2011-03-26 Andreas Kling <kling@webkit.org>
11339
Reviewed by Kenneth Rohde Christiansen.
11341
[Qt] QWebFrame::iconChanged() not emitted when icon is cached but not yet loaded
11342
https://bugs.webkit.org/show_bug.cgi?id=57157
11344
Add an IconDatabaseClient for the Qt port to ensure that QWebFrame::iconChanged()
11345
is always emitted when appropriate.
11347
* QtWebKit.pro: Add new files.
11349
* WebCoreSupport/IconDatabaseClientQt.h: Added.
11350
* WebCoreSupport/IconDatabaseClientQt.cpp: Added.
11351
(WebCore::IconDatabaseClientQt::instance):
11352
(WebCore::IconDatabaseClientQt::IconDatabaseClientQt):
11353
(WebCore::IconDatabaseClientQt::~IconDatabaseClientQt):
11354
(WebCore::IconDatabaseClientQt::performImport):
11355
(WebCore::IconDatabaseClientQt::didRemoveAllIcons):
11356
(WebCore::IconDatabaseClientQt::didImportIconURLForPageURL):
11357
(WebCore::IconDatabaseClientQt::didImportIconDataForPageURL):
11358
(WebCore::IconDatabaseClientQt::didChangeIconForPageURL):
11359
(WebCore::IconDatabaseClientQt::didFinishURLImport):
11361
* WebCoreSupport/FrameLoaderClientQt.h:
11362
* WebCoreSupport/FrameLoaderClientQt.cpp:
11363
(WebCore::FrameLoaderClientQt::registerForIconNotification):
11364
(WebCore::FrameLoaderClientQt::onIconLoadedForPageURL): New slot connected
11365
to the IconDatabaseClientQt::iconLoadedForPageURL() signal. This emits the
11366
QWebFrame::iconChanged() signal when the IconDatabases finishes loading
11367
a cached favicon for the frame's URL.
11369
* Api/qwebsettings.cpp:
11370
(QWebSettings::setIconDatabasePath): Make sure that IconDatabaseClientQt is
11371
instantiated. An IconDatabaseClient has to be registered before the IconDatabase
11372
spawns its reader thread.
11374
2011-03-25 Andy Estes <aestes@apple.com>
11376
Reviewed by Adele Peterson.
11378
REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
11379
https://bugs.webkit.org/show_bug.cgi?id=49016
11381
Update objectContentType() implementation to handle the
11382
shouldPreferPlugInsForImages flag.
11384
* WebCoreSupport/FrameLoaderClientQt.cpp:
11385
(WebCore::FrameLoaderClientQt::objectContentType):
11386
* WebCoreSupport/FrameLoaderClientQt.h:
11388
2011-03-25 Chang Shu <cshu@webkit.org>
11390
Reviewed by Ryosuke Niwa.
11392
rename Node::isContentEditable and all call sites to rendererIsEditable
11393
https://bugs.webkit.org/show_bug.cgi?id=54290
11395
This is part of the effort to separate JS API HTMLElement isContentEditable from
11396
internal Node::rendererIsEditable.
11398
* WebCoreSupport/EditorClientQt.cpp:
11399
(WebCore::EditorClientQt::handleKeyboardEvent):
11401
2011-03-25 Alexis Menard <alexis.menard@openbossa.org>
11403
Reviewed by Andreas Kling.
11405
[Qt] The keyboard shortcuts during fullscreen playback do not work.
11406
https://bugs.webkit.org/show_bug.cgi?id=57095
11408
We need to explicitely set the focus on the widget in order to receive the keyboard events.
11410
* WebCoreSupport/FullScreenVideoWidget.cpp:
11411
(WebCore::FullScreenVideoWidget::show):
11413
2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
11415
Unreviewed, rolling out r81916 and r81917.
11416
http://trac.webkit.org/changeset/81916
11417
http://trac.webkit.org/changeset/81917
11418
https://bugs.webkit.org/show_bug.cgi?id=57071
11420
broke a test on platforms that do not have QuickTime installed
11421
(Requested by estes on #webkit).
11423
* WebCoreSupport/FrameLoaderClientQt.cpp:
11424
(WebCore::FrameLoaderClientQt::objectContentType):
11425
* WebCoreSupport/FrameLoaderClientQt.h:
11427
2011-03-24 Andy Estes <aestes@apple.com>
11429
Reviewed by Darin Adler.
11431
REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
11432
https://bugs.webkit.org/show_bug.cgi?id=49016
11434
Update objectContentType() implementation to handle the
11435
shouldPreferPlugInsForImages flag.
11437
* WebCoreSupport/FrameLoaderClientQt.cpp:
11438
(WebCore::FrameLoaderClientQt::objectContentType):
11439
* WebCoreSupport/FrameLoaderClientQt.h:
11441
2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com>
11443
Reviewed by Kenneth Rohde Christiansen.
11445
[Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
11446
https://bugs.webkit.org/show_bug.cgi?id=40884
11448
Add tests and benchmarks for the software fallback of WebGL.
11450
* tests/benchmarks/webgl/10000_triangles.html: Added.
11451
* tests/benchmarks/webgl/tst_webgl.cpp: Added.
11452
(GraphicsView::GraphicsView):
11453
(GraphicsView::resizeEvent):
11454
(tst_WebGlPerformance::init):
11455
(tst_WebGlPerformance::cleanup):
11456
(tst_WebGlPerformance::benchSoftwareFallbackRgb16):
11457
(tst_WebGlPerformance::benchSoftwareFallbackRgb32):
11458
(tst_WebGlPerformance::benchSoftwareFallbackArgb32):
11459
(tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
11460
(tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
11461
* tests/benchmarks/webgl/tst_webgl.qrc: Added.
11462
* tests/benchmarks/webgl/webgl.pro: Added.
11463
* tests/qgraphicswebview/qgraphicswebview.pro:
11464
* tests/qgraphicswebview/resources/pointing_right.html: Added.
11465
* tests/qgraphicswebview/resources/pointing_up.html: Added.
11466
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
11467
(compareImagesFuzzyPixelCount):
11468
(GraphicsView::GraphicsView):
11469
(tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
11470
(tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
11471
(tst_QGraphicsWebView::compareCanvasToImage):
11472
* tests/qgraphicswebview/tst_qgraphicswebview.qrc:
11475
2011-03-24 Kristian Amlie <kristian.amlie@nokia.com>
11477
Reviewed by Benjamin Poulain.
11479
Avoided ASCII-cast warnings for WebKit.
11481
Normally they won't be enabled anyway, but if you build webkit from
11482
within the Qt mother repository it will pick up Qt's default build
11483
settings, which do enable it. We need to disable them because
11484
warnings are treated as errors and there are way too many of them in
11487
[Qt] Avoid ASCII-cast warnings for WebKit.
11488
https://bugs.webkit.org/show_bug.cgi?id=57016
11492
2011-03-24 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
11494
Reviewed by Benjamin Poulain.
11496
[Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
11497
https://bugs.webkit.org/show_bug.cgi?id=29595
11499
Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
11500
ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
11501
prepending the current directory.
11503
By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
11504
will end up loading "about:blank", but keeping it as a requested URL.
11506
This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
11507
is filled for the loaded URLs as well, we can use it in every case.
11509
Three new autotests were added, to better cover the expected behavior of setting
11510
the QUrl() in a QWebFrame.
11512
* Api/qwebframe.cpp:
11513
(ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
11514
(QWebFrame::requestedUrl): always use m_lastRequestedUrl.
11516
* WebCoreSupport/FrameLoaderClientQt.cpp:
11517
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
11518
anymore, since we always rely on it even for loaded frames.
11520
* tests/qwebframe/tst_qwebframe.cpp:
11521
(tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
11522
the reduction of the bug report.
11523
(tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
11524
(tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
11526
2011-03-23 Brady Eidson <beidson@apple.com>
11528
Reviewed by Sam Weinig.
11530
Change IconDatabase opening to allow for arbitrary filenames
11531
https://bugs.webkit.org/show_bug.cgi?id=56977
11533
* Api/qwebsettings.cpp:
11534
(QWebSettings::setIconDatabasePath):
11536
2011-03-23 Aparna Nandyal <aparna.nand@wipro.com>
11538
Reviewed by Andreas Kling.
11540
[Qt] QtWebKit rendering problem when maximizing and doing a back
11541
https://bugs.webkit.org/show_bug.cgi?id=56669
11543
Added an auto test.
11544
Patch by Alexis Menard < alexis.menard@nokia.com> on 2011-03-21
11546
* tests/qwebview/tst_qwebview.cpp:
11547
(tst_QWebView::rendering):
11549
2011-03-23 Yury Semikhatsky <yurys@chromium.org>
11551
Reviewed by Pavel Feldman.
11553
[V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
11554
https://bugs.webkit.org/show_bug.cgi?id=56843
11556
* WebCoreSupport/InspectorClientQt.cpp:
11557
(WebCore::InspectorClientQt::openInspectorFrontend):
11559
2011-03-22 Andrew Wason <rectalogic@rectalogic.com>
11561
Reviewed by Benjamin Poulain.
11563
[Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
11564
https://bugs.webkit.org/show_bug.cgi?id=54138
11566
* tests/qwebpage/tst_qwebpage.cpp:
11567
(webGLScreenshotWithoutView):
11568
(tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
11569
(tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
11570
Render a QWebPage (with and without accelerated compositing)
11571
with a WebGL context that has no owning view. Shouldn't crash.
11573
2011-03-21 Chang Shu <cshu@webkit.org>
11575
Reviewed by Alexey Proskuryakov.
11577
REGRESSION (r79953): Can't type in MS Outlook 2011
11578
https://bugs.webkit.org/show_bug.cgi?id=56665
11580
r79953 removed the WebView level editablity which is persistent no matter whether
11581
underlying document itself is changed and editability gets lost. The resolution is to
11582
set this WebView editable value to WebCore. This avoids the callback from WebCore to
11583
WebKit which was the main goal in r79953 to improve performance.
11585
* Api/qwebpage.cpp:
11586
(QWebPage::setContentEditable):
11587
(QWebPage::isContentEditable):
11589
2011-03-19 Andreas Kling <kling@webkit.org>
11591
Reviewed by Benjamin Poulain.
11593
[Qt] Remove support for Qt 4.6
11594
https://bugs.webkit.org/show_bug.cgi?id=56712
11596
* Api/qwebframe.cpp:
11598
* Api/qwebpage.cpp:
11599
(QWebPagePrivate::QWebPagePrivate):
11600
* Api/qwebsettings.cpp:
11601
(QWebSettings::QWebSettings):
11602
* WebCoreSupport/GeolocationClientQt.cpp:
11603
(WebCore::GeolocationClientQt::positionUpdated):
11605
2011-03-19 Andreas Kling <kling@webkit.org>
11607
Reviewed by Antonio Gomes.
11609
[Qt][Doc] QWebPage::unsupportedContent() passes ownership of the QNetworkReply
11610
https://bugs.webkit.org/show_bug.cgi?id=56711
11612
Document the fact that when unsupportedContent(QNetworkReply*) is emitted,
11613
ownership of the reply is transferred to the receiving slot.
11615
* Api/qwebpage.cpp:
11617
2011-03-17 Brady Eidson <beidson@apple.com>
11619
Reviewed by Sam Weinig.
11621
https://bugs.webkit.org/show_bug.cgi?id=56425
11622
More groundwork for WebKit2 IconDatabase
11624
Update already-used function names:
11625
* Api/qwebhistory.cpp:
11626
(QWebHistoryItem::icon):
11627
* Api/qwebsettings.cpp:
11628
(QWebSettings::iconForUrl):
11630
2011-03-18 Alexis Menard <alexis.menard@openbossa.org>
11632
Reviewed by Benjamin Poulain.
11634
[Qt] console.log not being exposed to QmlViewer
11635
https://bugs.webkit.org/show_bug.cgi?id=56536
11637
The documentation is bogus the feature does not exist.
11639
* declarative/qdeclarativewebview.cpp:
11641
2011-03-17 Andreas Kling <kling@webkit.org>
11643
Reviewed by Kenneth Rohde Christiansen.
11645
[Qt] QML WebView emits iconChanged() when the page title changes
11646
https://bugs.webkit.org/show_bug.cgi?id=56570
11648
* declarative/qdeclarativewebview.cpp:
11649
(QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
11650
signal to the view's iconChanged signal.
11652
2011-03-17 Alexis Menard <alexis.menard@openbossa.org>
11654
Reviewed by Benjamin Poulain.
11656
[Qt] Videos look ugly when using QGraphicsWebView.
11657
https://bugs.webkit.org/show_bug.cgi?id=56580
11659
We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
11660
QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
11661
by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
11662
QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
11663
ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
11664
in addition of what could be set on the painter. In order to not break the rendering of all the items in the
11665
scene we set back the painter to its original state when QGraphicsWebView is rendered.
11667
* Api/qgraphicswebview.cpp:
11668
(QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
11669
(QGraphicsWebView::paint):
11670
(QGraphicsWebView::renderHints):
11671
(QGraphicsWebView::setRenderHints):
11672
(QGraphicsWebView::setRenderHint):
11673
* Api/qgraphicswebview.h:
11674
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
11675
(tst_QGraphicsWebView::renderHints):
11677
2011-03-16 Joseph Pecoraro <joepeck@webkit.org>
11679
Reviewed by Kenneth Rohde Christiansen.
11681
Viewport no longer allows an auto value for "user-scalable"
11682
https://bugs.webkit.org/show_bug.cgi?id=55416
11684
Make the default value for userScalable be true.
11686
* Api/qwebpage.cpp:
11687
(QWebPage::viewportAttributesForSize):
11688
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
11689
(DumpRenderTreeSupportQt::viewportAsText): update test output to include userScalable.
11691
2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
11693
Reviewed by Darin Adler.
11695
Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
11696
info into the headers rather than in export symbol definition files, but disable it on
11697
all platforms initially so we can deal with port build issues one port at a time.
11699
https://bugs.webkit.org/show_bug.cgi?id=27551
11701
* WebCoreSupport/GeolocationClientQt.cpp:
11702
* WebCoreSupport/PopupMenuQt.cpp:
11704
2011-03-14 Brady Eidson <beidson@apple.com>
11706
Reviewed by Anders Carlsson.
11708
https://bugs.webkit.org/show_bug.cgi?id=56320
11709
Remove HistoryItem::icon() and the WebCore dependency on "IconDatabaseBase::defaultIcon()"
11711
* Api/qwebhistory.cpp:
11712
(QWebHistoryItem::icon): Use IconDatabase directly.
11714
2011-03-11 Brady Eidson <beidson@apple.com>
11716
Reviewed by attempt at build fix!
11718
https://bugs.webkit.org/show_bug.cgi?id=56216
11719
Fix the Qt build following the same pattern of the patch.
11721
* Api/qwebsettings.cpp:
11722
(QWebSettings::setIconDatabasePath): Call the static method via IconDatabase:: and not via iconDatabase()
11724
2011-03-11 Alexis Menard <alexis.menard@openbossa.org>
11726
Reviewed by Ariya Hidayat.
11728
[Qt] Entering fullscreen and leaving it may hide the cursor of the application.
11729
https://bugs.webkit.org/show_bug.cgi?id=56181
11731
We need to stop the auto hide cursor timer when closing the widget otherwise the timer
11732
might get fired and therefore hide the cursor even when the fullscreen widget is closed.
11734
* WebCoreSupport/FullScreenVideoWidget.cpp:
11735
(WebCore::FullScreenVideoWidget::closeEvent):
11737
2011-03-10 David Boddie <david.boddie@nokia.com>
11739
Reviewed by Andreas Kling.
11741
Fixed a qdoc warning and terminology (WebKit instead of Webkit).
11742
https://bugs.webkit.org/show_bug.cgi?id=55756
11744
* Api/qwebhistoryinterface.cpp:
11746
2011-03-10 Andreas Kling <kling@webkit.org>
11748
Unreviewed build fix after r80774.
11750
QML property versioning is introduced in Qt 4.7.3, not 4.7.2.
11751
See also: http://bugreports.qt.nokia.com/browse/QTBUG-13451
11753
* declarative/plugin.cpp:
11754
(WebKitQmlPlugin::registerTypes):
11755
* declarative/qdeclarativewebview.cpp:
11756
* declarative/qdeclarativewebview_p.h:
11757
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
11759
2011-03-10 Alexis Menard <alexis.menard@openbossa.org>
11761
Reviewed by Andreas Kling.
11763
[Qt] QtDeclarative Webview element has a fixed white background
11764
https://bugs.webkit.org/show_bug.cgi?id=40918
11766
Implement a way to change the background color of the WebView QML element.
11767
This feature is activated for QtWebKit 1.1 version of the plugin.
11769
* declarative/plugin.cpp:
11770
(WebKitQmlPlugin::registerTypes):
11771
* declarative/qdeclarativewebview.cpp:
11772
(QDeclarativeWebView::backgroundColor):
11773
(QDeclarativeWebView::setBackgroundColor):
11774
* declarative/qdeclarativewebview_p.h:
11775
* tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml: Added.
11776
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
11777
(tst_QDeclarativeWebView::backgroundColor):
11778
* tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
11780
2011-03-10 Stanislav Paltis <Stanislav.Paltis@nokia.com>
11782
Reviewed by Laszlo Gombos.
11784
[Qt] MemoryCache deadDecodedDataDeletionInterval is not exposed for client's usage
11785
https://bugs.webkit.org/show_bug.cgi?id=55945
11787
Added handling of dynamic/runtime property _q_deadDecodedDataDeletionInterval to
11788
set interval used to trigger when decoded data in dead list of object cache will
11789
be purged from object cache.
11791
* Api/qwebpage.cpp:
11792
(QWebPagePrivate::dynamicPropertyChangeEvent):
11794
2011-03-10 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
11796
Reviewed by Antonio Gomes.
11798
Simplify how QWebFrame::requestedUrl() is obtained
11799
https://bugs.webkit.org/show_bug.cgi?id=55842
11801
When a load starts, store the requested URL until we know that it'll be
11802
available for us in the document loader -- after load finished.
11804
The existing auto tests cover the three different code paths in
11805
requestedUrl() and the new code passes the autotests. In each of those
11806
cases, we looked for the information in a different place, but in all
11807
of them, dispatchDidStartProvisionalLoad was called.
11809
This simplification will be useful to fix bug 32723. The way requestedUrl()
11810
is implementent, we can't use it as a fallback for url() when the setUrl()
11811
was called with an invalid URL.
11813
* Api/qwebframe.cpp:
11814
(QWebFrame::requestedUrl):
11815
* WebCoreSupport/FrameLoaderClientQt.cpp:
11816
(WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
11817
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoad):
11818
* WebCoreSupport/FrameLoaderClientQt.h:
11819
(WebCore::FrameLoaderClientQt::lastRequestedUrl):
11821
2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
11823
Reviewed by Kenneth Rohde Christiansen.
11825
Tiled backing store's delegated scroll request uses incorrect convention
11826
https://bugs.webkit.org/show_bug.cgi?id=56011
11828
Adapt internal API to match the change from delta to point on the
11829
WebCore side, and convert the point to a delta for the public API.
11831
* WebCoreSupport/ChromeClientQt.cpp:
11832
(WebCore::ChromeClientQt::delegatedScrollRequested):
11833
* WebCoreSupport/ChromeClientQt.h:
11835
2011-03-09 Peter Kasting <pkasting@google.com>
11837
Reviewed by Mihai Parparita.
11839
Unify Windows version checks.
11840
https://bugs.webkit.org/show_bug.cgi?id=55979
11842
* Api/qwebpage.cpp:
11843
(QWebPage::userAgentForUrl):
11845
2011-03-07 Sam Weinig <sam@webkit.org>
11847
Reviewed by Anders Carlsson.
11849
Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
11850
https://bugs.webkit.org/show_bug.cgi?id=55827
11852
Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
11853
and pass the entire response, instead of just the MIMEType.
11855
* WebCoreSupport/FrameLoaderClientQt.cpp:
11856
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):
11857
* WebCoreSupport/FrameLoaderClientQt.h:
11859
2011-03-05 Qi Zhang <qi.2.zhang@nokia.com>
11861
Reviewed by Laszlo Gombos.
11863
[Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
11864
https://bugs.webkit.org/show_bug.cgi?id=48636
11866
Add model infomation into user agent string when qtmobility is available, but only for symbian, Maemo and MeeGo.
11868
* Api/qwebpage.cpp:
11869
(QWebPage::userAgentForUrl):
11871
2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
11873
Reviewed by Kenneth Rohde Christiansen.
11875
[QT] Implement mock client-based geolocation for layout testing
11876
https://bugs.webkit.org/show_bug.cgi?id=54334
11878
Implement layout testing for Client-Based geolocation. If drt_run is set
11879
then create mock geolocationClient and update the same with controller.
11881
* Api/qwebpage.cpp:
11882
(QWebPagePrivate::QWebPagePrivate):
11883
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
11884
(DumpRenderTreeSupportQt::mockGeolocationReset):
11885
(DumpRenderTreeSupportQt::setMockGeolocationPermission):
11886
(DumpRenderTreeSupportQt::setMockGeolocationPosition):
11887
(DumpRenderTreeSupportQt::setMockGeolocationError):
11888
* WebCoreSupport/DumpRenderTreeSupportQt.h:
11889
* WebCoreSupport/GeolocationClientQt.cpp:
11890
(WebCore::GeolocationClientQt::GeolocationClientQt):
11891
* WebCoreSupport/GeolocationClientQt.h:
11893
2011-03-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
11895
Reviewed by Kenneth Rohde Christiansen.
11897
[Qt] QWebFrame::setUrl works only from second time if url fragment is present
11898
https://bugs.webkit.org/show_bug.cgi?id=32723
11900
Create an auto-test for Qt based on the bug description.
11902
* tests/qwebframe/tst_qwebframe.cpp: add setUrlWithFragment() test.
11904
2011-03-03 Brady Eidson <beidson@apple.com>
11906
Reviewed by Darin Adler.
11908
https://bugs.webkit.org/show_bug.cgi?id=55721
11909
Global IconDatabase should be returned by reference, not as a pointer
11911
* Api/qwebsettings.cpp:
11912
(QWebSettings::setIconDatabasePath):
11913
(QWebSettings::iconDatabasePath):
11914
(QWebSettings::clearIconDatabase):
11915
(QWebSettings::iconForUrl):
11917
2011-03-03 Alexey Proskuryakov <ap@apple.com>
11919
Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
11922
* WebCoreSupport/ChromeClientQt.h:
11924
2011-03-02 Alexey Proskuryakov <ap@apple.com>
11926
Reviewed by Darin Adler.
11928
REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
11929
https://bugs.webkit.org/show_bug.cgi?id=55633
11930
<rdar://problem/8963023>
11932
* WebCoreSupport/ChromeClientQt.cpp (WebCore::ChromeClientQt::keyboardUIMode):
11933
* WebCoreSupport/ChromeClientQt.h:
11934
Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
11935
this platform doesn't observe or have full keyboard access state.
11937
2011-03-03 Alexis Menard <alexis.menard@openbossa.org>
11939
Reviewed by Andreas Kling.
11941
[Qt] QGraphicsWebView should use updateMicroFocus() of QGraphicsItem
11942
https://bugs.webkit.org/show_bug.cgi?id=55568
11944
We should use updateMicroFocus() from QGraphicsItem rather than the implementation
11945
in QGraphicsWebView. _q_updateMicroFocus was added when QGraphicsItem didn't have the feature.
11946
In Qt 4.7, updateMicroFocus was added, let's use it, then we can benefit of all bug fixing done
11949
* Api/qgraphicswebview.cpp:
11950
(QGraphicsWebView::setPage):
11951
* Api/qgraphicswebview.h:
11953
2011-03-03 Peter Kasting <pkasting@google.com>
11955
Reviewed by James Robinson.
11957
Drop redundant "Windows; " from the Windows-specific User Agent string.
11958
https://bugs.webkit.org/show_bug.cgi?id=54567
11960
* Api/qwebpage.cpp:
11961
(QWebPage::userAgentForUrl):
11963
2011-03-01 Brian Weinstein <bweinstein@apple.com>
11965
Reviewed by Adam Roben.
11967
Part of WebKit2: Need a way to send notifications to client when cookies change
11968
https://bugs.webkit.org/show_bug.cgi?id=55427
11969
<rdar://problem/9056027>
11971
Add stubs for CookiesStrategy on Qt WebKit1.
11973
* WebCoreSupport/WebPlatformStrategies.cpp:
11974
(WebPlatformStrategies::createCookiesStrategy):
11975
(WebPlatformStrategies::notifyCookiesChanged):
11976
* WebCoreSupport/WebPlatformStrategies.h:
11978
2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
11980
Unreviewed. Roll out r80068 and r80073 due to breaking WebKit2 Qt port.
11982
* Api/qwebpage.cpp:
11983
(QWebPage::viewportAttributesForSize):
11984
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
11985
(DumpRenderTreeSupportQt::viewportAsText):
11987
2011-03-01 Joseph Pecoraro <joepeck@webkit.org>
11989
Reviewed by Kenneth Rohde Christiansen.
11991
Viewport Warning/Error Messages Are Now Inaccurate
11992
https://bugs.webkit.org/show_bug.cgi?id=53707
11994
* Api/qwebpage.cpp:
11995
(QWebPage::viewportAttributesForSize): pass a Document into computeViewportAttributes for warnings to be reported to.
11996
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
11997
(DumpRenderTreeSupportQt::viewportAsText): pass a Document into computeViewportAttributes for warnings to be reported to.
11999
2011-03-01 Andras Becsi <abecsi@webkit.org>
12001
Reviewed by Csaba Osztrogonác.
12003
[Qt] Clean up the project files and move common options to WebKit.pri.
12005
* QtWebKit.pro: Move common options to WebKit.pri.
12007
2011-03-01 Aparna Nandyal <aparna.nand@wipro.com>
12009
Reviewed by Simon Hausmann.
12011
[Qt]tst_QWebPage::backActionUpdate fails when there is not network connection
12012
https://bugs.webkit.org/show_bug.cgi?id=55319
12014
The test case required internet connection to be able to connect to
12015
google.com. Added new html file which refers to local html file.
12017
* tests/qwebpage/resources/content.html: Added.
12018
* tests/qwebpage/resources/frame_c.html: Added.
12019
* tests/qwebpage/resources/framedindex.html: Added.
12020
* tests/qwebpage/tst_qwebpage.cpp:
12021
(tst_QWebPage::backActionUpdate):
12022
* tests/qwebpage/tst_qwebpage.qrc:
12024
2011-02-25 Steve Block <steveblock@google.com>
12026
Reviewed by Jeremy Orlow.
12028
Bridge.h should not include BridgeJSC.h
12029
https://bugs.webkit.org/show_bug.cgi?id=55212
12031
Include BridgeJSC.h directly instead.
12033
* Api/qwebframe.cpp:
12035
2011-02-28 Chang Shu <cshu@webkit.org>
12037
Reviewed by Ryosuke Niwa.
12039
Remove the support of Frame::isContentEditable and its dependencies.
12040
https://bugs.webkit.org/show_bug.cgi?id=54292
12042
Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode.
12044
* Api/qwebpage.cpp:
12045
(QWebPagePrivate::QWebPagePrivate):
12046
(QWebPage::setContentEditable):
12047
(QWebPage::isContentEditable):
12048
* Api/qwebpage_p.h:
12049
* WebCoreSupport/EditorClientQt.cpp:
12050
* WebCoreSupport/EditorClientQt.h:
12052
2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
12054
Reviewed by Oliver Hunt.
12056
Build fix for Qt port after API changes of http://trac.webkit.org/changeset/79904.
12058
* Api/qwebelement.cpp:
12059
(QWebElement::evaluateJavaScript):
12061
2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
12063
Reviewed by Andreas Kling.
12065
[Qt]tst_QDeclarativeWebView - 8 test cases fail
12066
https://bugs.webkit.org/show_bug.cgi?id=55214
12068
Fix the API tests for the QML WebView element. The default size of the element should be the size of the QGraphicsWebView
12069
if no preferred width or height are provided (see http://trac.webkit.org/changeset/79672).
12070
I also refactored the tests so we don't use the network but instead a local html file.
12071
QML doesn't support qrc loading so I had to workaround by using a property that I update afterwards.
12073
* tests/qdeclarativewebview/resources/sample.html: Added.
12074
* tests/qdeclarativewebview/resources/webviewtest.qml:
12075
* tests/qdeclarativewebview/resources/webviewtestdefault.qml:
12076
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
12077
(tst_QDeclarativeWebView::preferredWidthTest):
12078
(tst_QDeclarativeWebView::preferredHeightTest):
12079
(tst_QDeclarativeWebView::preferredWidthDefaultTest):
12080
(tst_QDeclarativeWebView::preferredHeightDefaultTest):
12081
* tests/qdeclarativewebview/tst_qdeclarativewebview.qrc:
12083
2011-02-28 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
12085
Reviewed by Andreas Kling.
12087
[Qt] Add clipped version of QWebElement::render method.
12088
Allows faster rendering of web element part.
12089
https://bugs.webkit.org/show_bug.cgi?id=50311
12091
* Api/qwebelement.cpp:
12092
(QWebElement::render):
12093
* Api/qwebelement.h:
12094
* tests/qwebelement/tst_qwebelement.cpp:
12095
(tst_QWebElement::render):
12097
2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
12099
Reviewed by Andreas Kling.
12101
Added full webkit module profile and a syncqt profile.
12103
This is for modularized Qt.
12105
[Qt] WebKit patches required to work with a modularized version of Qt
12106
https://bugs.webkit.org/show_bug.cgi?id=53916
12108
* qt_webkit_version.pri:
12110
2011-02-27 Aparna Nandyal <aparna.nand@wipro.com>
12112
Reviewed by Antonio Gomes.
12114
[Qt] QtTestBrowser - Horizontal scrollbar disappears on navigating pages using Back/Forward
12115
https://bugs.webkit.org/show_bug.cgi?id=53917
12117
Adding test case to check the scenario to avoid regressions in the
12120
* tests/qwebframe/tst_qwebframe.cpp:
12122
2011-02-27 Benjamin Poulain <benjamin.poulain@nokia.com>
12124
Reviewed by Andreas Kling.
12126
[Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
12127
https://bugs.webkit.org/show_bug.cgi?id=55322
12129
Documentation update, add a reference to the QtWebKit bridge page.
12131
* Api/qwebframe.cpp:
12133
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
12135
Reviewed by Pavel Feldman.
12137
DumpRenderTree should reset frame opener between tests.
12138
https://bugs.webkit.org/show_bug.cgi?id=54874
12140
Added clearOpener method to DumpRenderTreeSupportQT.
12142
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
12143
(DumpRenderTreeSupportQt::clearOpener):
12144
* WebCoreSupport/DumpRenderTreeSupportQt.h:
12146
2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
12148
Reviewed by Andreas Kling.
12150
Make it possible to test the targetdensity-dpi support
12151
https://bugs.webkit.org/show_bug.cgi?id=55142
12153
Test the viewport meta tag feature targetdensity-dpi by
12154
adding extra arguments to dumpConfigurationForViewport
12156
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
12157
(DumpRenderTreeSupportQt::viewportAsText):
12158
* WebCoreSupport/DumpRenderTreeSupportQt.h:
12160
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
12162
Unreviewed, rolling out r79764.
12163
http://trac.webkit.org/changeset/79764
12164
https://bugs.webkit.org/show_bug.cgi?id=55295
12166
"broke Chromium builds" (Requested by rniwa on #webkit).
12168
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
12169
* WebCoreSupport/DumpRenderTreeSupportQt.h:
12171
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
12173
Reviewed by Pavel Feldman.
12175
DumpRenderTree should reset frame opener between tests.
12176
https://bugs.webkit.org/show_bug.cgi?id=54874
12178
Added clearOpener method to DumpRenderTreeSupportQT.
12180
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
12181
(DumpRenderTreeSupportQt::clearOpener):
12182
* WebCoreSupport/DumpRenderTreeSupportQt.h:
12184
2011-02-25 Andras Becsi <abecsi@webkit.org>
12186
Reviewed by Csaba Osztrogonác.
12188
[Qt] Make the WebKit2 build system less confusing for non-Qt developers
12189
https://bugs.webkit.org/show_bug.cgi?id=55213
12191
* QtWebKit.pro: Move the WebKit2 API into a project include file
12192
in the WebKit2 directory and include the pri file here.
12194
2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
12196
Unreviewed build fix for Intel ICC and MSVC.
12198
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
12199
(tst_QGraphicsWebView::setPalette):
12200
* tests/qwebview/tst_qwebview.cpp:
12201
(tst_QWebView::setPalette):
12203
2011-02-25 Alexis Menard <alexis.menard@openbossa.org>
12205
Reviewed by Kenneth Rohde Christiansen.
12207
[Qt] Properly propagate the palette to QWebPage from QGraphicsWebView
12208
https://bugs.webkit.org/show_bug.cgi?id=31742
12210
Discovered while looking at 31742. When we set a palette on the
12211
QGraphicsWebView we need to propagate it to the page like QWebView.
12212
I have added the same tests as QWebView to be sure to catch potential
12213
regressions as well as two extras QVERIFY to check the palette propagation.
12215
* Api/qgraphicswebview.cpp:
12216
(QGraphicsWebView::event):
12217
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
12218
(tst_QGraphicsWebView::setPalette_data):
12219
(tst_QGraphicsWebView::setPalette):
12221
2011-02-25 Csaba Osztrogonác <ossy@webkit.org>
12223
Unreviewed buildfix after r79672.
12225
[Qt] Build tst_qdeclarativewebview if QT_CONFIG contains declarative.
12230
2011-02-25 Gopal Raghavan <gopal.1.raghavan@nokia.com>
12232
Reviewed by Kenneth Rohde Christiansen.
12234
[Qt] QML WebView inside a Flickable shows checkers pattern at startup
12235
https://bugs.webkit.org/show_bug.cgi?id=50222.
12237
This patch fixes the checkerboard visible at startup even if preferredWidth and preferredHeight are not set.
12239
* declarative/qdeclarativewebview.cpp:
12240
(QDeclarativeWebView::init):
12241
* tests/qdeclarativewebview: Added.
12242
* tests/qdeclarativewebview/qdeclarativewebview.pro: Added.
12243
* tests/qdeclarativewebview/resources: Added.
12244
* tests/qdeclarativewebview/resources/webviewtest.qml: Added.
12245
* tests/qdeclarativewebview/resources/webviewtestdefault.qml: Added.
12246
* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp: Added.
12247
(tst_QDeclarativeWebView::initTestCase):
12248
(tst_QDeclarativeWebView::cleanupTestCase):
12249
(tst_QDeclarativeWebView::init):
12250
(tst_QDeclarativeWebView::cleanup):
12251
(tst_QDeclarativeWebView::preferredWidthTest):
12252
(tst_QDeclarativeWebView::preferredHeightTest):
12253
(tst_QDeclarativeWebView::preferredWidthDefaultTest):
12254
(tst_QDeclarativeWebView::preferredHeightDefaultTest):
12255
(tst_QDeclarativeWebView::checkNoErrors):
12259
2011-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
12261
Reviewed by Andreas Kling.
12263
[Qt] Revert the support for QNAM affined to a different thread.
12264
https://bugs.webkit.org/show_bug.cgi?id=55149
12266
Qt 4.8 will have QNAM use its own thread internally by default,
12267
no need to keep this complexity in WebKit.
12269
This mainly reverts:
12270
http://trac.webkit.org/changeset/73710
12271
http://trac.webkit.org/changeset/73712
12273
* WebCoreSupport/FrameLoaderClientQt.cpp:
12274
(WebCore::FrameLoaderClientQt::download):
12275
* tests/qwebpage/tst_qwebpage.cpp:
12277
2011-02-24 Sam Weinig <sam@webkit.org>
12279
Try to fix the Qt build.
12283
2011-02-24 Peter Kasting <pkasting@google.com>
12285
Reviewed by Eric Seidel.
12287
Drop the "U; " encryption level from the User Agent string.
12288
https://bugs.webkit.org/show_bug.cgi?id=54566
12290
* Api/qwebpage.cpp:
12291
(QWebPage::userAgentForUrl):
12293
2011-02-24 Andrew Wilson <atwilson@chromium.org>
12295
Unreviewed, rolling out r79570.
12296
http://trac.webkit.org/changeset/79570
12297
https://bugs.webkit.org/show_bug.cgi?id=54874
12299
Breaks chromium build because glue/mocks/mock_web_frame.h/cc
12302
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
12303
* WebCoreSupport/DumpRenderTreeSupportQt.h:
12305
2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
12307
Reviewed by Alexey Proskuryakov.
12309
DumpRenderTree should reset frame opener between tests.
12310
https://bugs.webkit.org/show_bug.cgi?id=54874
12312
Added clearOpener method to DumpRenderTreeSupportQT.
12314
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
12315
(DumpRenderTreeSupportQt::clearOpener):
12316
* WebCoreSupport/DumpRenderTreeSupportQt.h:
12318
2011-02-24 Alexis Menard <alexis.menard@openbossa.org>
12320
Reviewed by Andreas Kling.
12322
[Qt] tst_QWebView::setPalette(activeFG) fails
12323
https://bugs.webkit.org/show_bug.cgi?id=55029
12325
This time it should be the proper fix. The window needs to be shown before we
12326
call activateWindow() otherwise there is no active windows for the application.
12328
* tests/qwebview/tst_qwebview.cpp:
12329
(tst_QWebView::setPalette):
12331
2011-02-24 Andras Becsi <abecsi@webkit.org>
12333
Reviewed by Laszlo Gombos.
12335
[Qt] MinGW build fails to link
12336
https://bugs.webkit.org/show_bug.cgi?id=55050
12338
Prepend the libraries of subcomponents instead of appending them
12339
to fix the library order according to the dependency of the libraries
12341
* QtWebKit.pro: prepend libraries in the correct order
12343
2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
12345
Reviewed by Ariya Hidayat.
12347
[Qt] tst_QWebView::setPalette(activeFG) fails
12348
https://bugs.webkit.org/show_bug.cgi?id=55029
12350
Attempt to make the test more robust. By investigating with the bot virtual machine
12351
I discovered that the activation can take some time. In this patch we make sure that
12352
the active window we want to have is the same as the QApplication.
12354
* tests/qwebview/tst_qwebview.cpp:
12355
(tst_QWebView::setPalette):
12357
2011-02-23 Alexis Menard <alexis.menard@openbossa.org>
12359
Reviewed by Dan Bernstein.
12361
[Qt]REGRESSION(r79167): It broke 3 Qt-API test cases
12362
http://trac.webkit.org/changeset/79167 refactored the way the bound size of
12363
the frame is handled. A new API setBoundsSize was added, we need to call it
12364
in addition to setFrameRect. I could call setBoundSize after setFrameRect but
12365
I thought It would be more elegant to use the resize method.
12367
* Api/qwebpage.cpp:
12368
(QWebPage::setViewportSize):
12370
2011-02-22 Fabrizio Machado <fabrizio.machado@nokia.com>
12372
Reviewed by Laszlo Gombos.
12374
[Qt] Don't fall through case in variantToSetting() if qvariant.type() is Bool
12375
https://bugs.webkit.org/show_bug.cgi?id=54976
12379
* WebCoreSupport/InspectorClientQt.cpp:
12381
2011-02-22 Alexis Menard <alexis.menard@openbossa.org>
12383
Reviewed by Andreas Kling.
12385
[Qt] QWebView ignores a palette set with QWebView::setPalette()
12386
https://bugs.webkit.org/show_bug.cgi?id=31742
12388
Test case to check that the palette sets on the QWebView is taken
12391
* tests/qwebview/tst_qwebview.cpp:
12392
(tst_QWebView::setPalette_data):
12393
(tst_QWebView::setPalette):
12395
2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
12397
Reviewed by Alexey Proskuryakov.
12399
Drop the language tag part from the User Agent string
12400
https://bugs.webkit.org/show_bug.cgi?id=54560
12402
* Api/qwebpage.cpp:
12403
(QWebPage::userAgentForUrl):
12405
* tests/qwebpage/tst_qwebpage.cpp: Remove the userAgentLocaleChange
12408
2011-02-22 Chang Shu <cshu@webkit.org>
12410
Reviewed by Csaba Osztrogonác.
12412
[Qt] editing/deleting/5408255.html fails
12413
https://bugs.webkit.org/show_bug.cgi?id=54964
12415
Move WebCore resource file to QtWebKit since they are referred in WebKit.
12419
2011-02-22 Andras Becsi <abecsi@webkit.org>
12421
Reviewed by Csaba Osztrogonác.
12423
[Qt] Redesign the build system
12424
https://bugs.webkit.org/show_bug.cgi?id=51339
12426
Move inspector's resource files into the final build step to fix the layout test regression.
12428
* QtWebKit.pro: Add inspector's reaource files.
12430
2011-02-22 Andras Becsi <abecsi@webkit.org>
12432
Reviewed by Laszlo Gombos.
12433
Rubber-stamped by Csaba Osztrogonác.
12435
[Qt] Redesign the build system
12436
https://bugs.webkit.org/show_bug.cgi?id=51339
12438
The patch landed in r79320 didn't contain the cleanup
12439
which was already addressed in the last attachment.
12441
* QtWebKit.pro: Move common LIB and CONFIG options to WebCore.pri.
12443
2011-02-22 Andras Becsi <abecsi@webkit.org>
12445
Reviewed by Laszlo Gombos.
12447
[Qt] Redesign the build system
12448
https://bugs.webkit.org/show_bug.cgi?id=51339
12452
Build WebCore as a static library, compile the WebKit API and WebKit2 API
12453
in a final step and link to WebKit2, WebCore and JSC libraries to fix
12454
linking issues resulting from stripped away symbols.
12456
* QtWebKit.pro: Added.
12457
Project file for the final build step.
12459
2011-02-17 Ryosuke Niwa <rniwa@webkit.org>
12461
Reviewed by Kent Tamura.
12463
Rename Position::node() to Position::deprecatedNode()
12464
https://bugs.webkit.org/show_bug.cgi?id=54622
12466
Replaced the call to node() by a call to containerNode() because the returned node is
12467
used to determine whether or not the selected contents are editable and such a check
12468
must be done against the container node.
12470
* WebCoreSupport/EditorClientQt.cpp:
12471
(WebCore::EditorClientQt::handleKeyboardEvent):
12473
2011-02-19 Charlie Reis <creis@chromium.org>
12475
Reviewed by Mihai Parparita.
12477
Ensure loading has stopped in HistoryController::goToItem
12478
https://bugs.webkit.org/show_bug.cgi?id=54517
12480
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
12482
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
12484
* WebCoreSupport/FrameLoaderClientQt.cpp:
12485
(WebCore::FrameLoaderClientQt::shouldStopLoadingForHistoryItem): Added.
12486
* WebCoreSupport/FrameLoaderClientQt.h:
12488
2011-02-18 Fabrizio Machado <fabrizio.machado@nokia.com>
12490
Reviewed by Eric Seidel.
12492
Remove reduntant checks.
12493
https://bugs.webkit.org/show_bug.cgi?id=54764
12496
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
12497
(DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
12498
* WebCoreSupport/NotificationPresenterClientQt.cpp:
12499
(WebCore::NotificationPresenterClientQt::toPage):
12501
2011-02-18 Csaba Osztrogonác <ossy@webkit.org>
12505
[Qt] Buildfix for platforms with geolocation disabled.
12507
* Api/qwebpage.cpp: Add the missing guard.
12509
2011-02-18 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
12511
Reviewed by Kenneth Rohde Christiansen.
12513
[Qt] Implement client based geolocation for qtport
12514
https://bugs.webkit.org/show_bug.cgi?id=42629
12516
Implements client based geolocation for qtwebkit.
12517
New client based geolocation contains permission API's as well,
12518
so removed the implementation from ChromeClientQt.cpp.
12520
* Api/qwebpage.cpp:
12521
(QWebPagePrivate::QWebPagePrivate):
12522
* WebCoreSupport/ChromeClientQt.cpp:
12523
* WebCoreSupport/ChromeClientQt.h:
12524
(WebCore::ChromeClientQt::requestGeolocationPermissionForFrame):
12525
(WebCore::ChromeClientQt::cancelGeolocationPermissionRequestForFrame):
12526
* WebCoreSupport/GeolocationClientQt.cpp: Added.
12527
(WebCore::GeolocationClientQt::GeolocationClientQt):
12528
(WebCore::GeolocationClientQt::~GeolocationClientQt):
12529
(WebCore::GeolocationClientQt::geolocationDestroyed):
12530
(WebCore::GeolocationClientQt::positionUpdated):
12531
(WebCore::GeolocationClientQt::startUpdating):
12532
(WebCore::GeolocationClientQt::stopUpdating):
12533
(WebCore::GeolocationClientQt::setEnableHighAccuracy):
12534
(WebCore::GeolocationClientQt::requestPermission):
12535
(WebCore::GeolocationClientQt::cancelPermissionRequest):
12536
* WebCoreSupport/GeolocationClientQt.h: Added.
12537
(WebCore::GeolocationClientQt::lastPosition):
12539
2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
12541
Reviewed by Adam Roben.
12543
HTML5 <details> and <summary>: localized text
12544
https://bugs.webkit.org/show_bug.cgi?id=54260
12546
The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
12547
provide the default label to be used by a <details> tag that has no <summary> child.
12549
* WebCoreSupport/WebPlatformStrategies.cpp:
12550
(WebPlatformStrategies::defaultDetailsSummaryText):
12551
* WebCoreSupport/WebPlatformStrategies.h:
12553
2011-02-17 Hui Huang <hui.2.huang@nokia.com>
12555
Reviewed by Laszlo Gombos.
12557
The URL of HTML5 Video Element is percent encoded at websites such as youtube.
12558
It is percent encoded again by QUrl constructor QUrl::QUrl(QString). This causes
12559
the HTTP GET request for the video to be rejected by the service provider.
12560
https://bugs.webkit.org/show_bug.cgi?id=53973.
12562
The bug is fixed by constructing QUrl from the encoded URL in
12563
MediaPlayerPrivateQt::commitLoad.
12565
New test function tst_QWebPage::loadHtml5Video() is added to load HTML content with
12566
HTML5 Video element. A new public method DumpRenderTreeSupportQt::mediaContentUrlByElementId
12567
is added to retrieve the URL of the media content from WebCore MediaPlayerPrivateQt.
12568
A new macro ENABLE_QT_MULTIMEDIA is introduced in tests.pri to make sure that the test
12569
is skipped if Qt Multimedia is not available.
12571
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
12572
(DumpRenderTreeSupportQt::mediaContentUrlByElementId):
12573
* WebCoreSupport/DumpRenderTreeSupportQt.h:
12574
* tests/qwebpage/tst_qwebpage.cpp:
12575
(tst_QWebPage::loadHtml5Video):
12578
2011-02-17 Andreas Kling <kling@webkit.org>
12580
Reviewed by Antti Koivisto.
12582
[Qt] Crash when calling QWebFrame::setUrl() while a previous load has pending requests
12583
https://bugs.webkit.org/show_bug.cgi?id=49216
12585
* tests/qwebframe/tst_qwebframe.cpp:
12587
== Rolled over to ChangeLog-2011-02-16 ==
added
removed
Source/WebKit/qt/ChangeLog
